Skip to contentSkip to conversation

i2c: acpi: Force Dell XPS 17 9720 touchpad to 100 kHz

PATCH Superseded Mika Westerberg 4 participants 7 messages Nov 13

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: acpi: Force Dell XPS 17 9720 touchpad to 100 kHz

The Dell XPS 17 9720 touchpad has the same lagging issue as with others when run at 400 kHz as the ACPI tables describe. This particular system does not use standard ACPI ID but it seems to use "Windows Device ID" VEN_04F3 for whatever reason. Add this one to the 100 kHz quirk list as well but since this is not a standard ACPI ID match it also via DMI strings just to be on the safe side.

---
 drivers/i2c/i2c-core-acpi.c | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)
drivers/i2c/i2c-core-acpi.c +23 -1
index 84841ed13487..98a8d63e3fb8 100644
@@ -7,6 +7,7 @@
 
 #include <linux/acpi.h>
 #include <linux/device.h>
+#include <linux/dmi.h>
 #include <linux/err.h>
 #include <linux/i2c.h>
 #include <linux/list.h>
@@ -356,6 +357,16 @@ static const struct acpi_device_id i2c_acpi_force_400khz_device_ids[] = {
 	{ }
 };
 
+static const struct dmi_system_id i2c_acpi_dell_xps_17_9720_dmi_ids[] = {
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 17 9720"),
+		},
+	},
+	{ }
+};
+
 static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = {
 	/*
 	 * When a 400KHz freq is used on this model of ELAN touchpad in Linux,
@@ -377,6 +388,14 @@ static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = {
 	{ .id = "ELAN0678" },
 	{ .id = "ELAN06FA" },
 	{ .id = "ELAN1300" },
+	{
+		/*
+		 * Some Dell XPS 17 9720 systems do not use standard
+		 * ACPI IDs so we need to match also via DMI strings.
+		 */
+		.id = "VEN_04F3",
+		.driver_data = (kernel_ulong_t)i2c_acpi_dell_xps_17_9720_dmi_ids,
+	},
 	{ }
 };
 
@@ -385,6 +404,7 @@ static acpi_status i2c_acpi_lookup_speed(acpi_handle handle, u32 level,
 {
 	struct i2c_acpi_lookup *lookup = data;
 	struct acpi_device *adev = acpi_fetch_acpi_dev(handle);
+	const struct acpi_device_id *id;
 
 	if (!adev || i2c_acpi_do_lookup(adev, lookup))
 		return AE_OK;
@@ -398,7 +418,9 @@ static acpi_status i2c_acpi_lookup_speed(acpi_handle handle, u32 level,
 	if (acpi_match_device_ids(adev, i2c_acpi_force_400khz_device_ids) == 0)
 		lookup->force_speed = I2C_MAX_FAST_MODE_FREQ;
 
-	if (acpi_match_device_ids(adev, i2c_acpi_force_100khz_device_ids) == 0)
+	id = acpi_match_acpi_device(i2c_acpi_force_100khz_device_ids, adev);
+	if (id && (!id->driver_data ||
+		   dmi_check_system((const struct dmi_system_id *)id->driver_data)))
 		lookup->force_speed = I2C_MAX_STANDARD_MODE_FREQ;
 
 	return AE_OK;
Signature · 1 line
2.53.0
#1 lore raw

Hi,

Quoted 10 lines · Mika Westerberg

The Dell XPS 17 9720 touchpad has the same lagging issue as with others when run at 400 kHz as the ACPI tables describe. This particular system does not use standard ACPI ID but it seems to use "Windows Device ID" VEN_04F3 for whatever reason. Add this one to the 100 kHz quirk list as well but since this is not a standard ACPI ID match it also via DMI strings just to be on the safe side.

Thank you for your patch.

Quoted 34 lines
---
 drivers/i2c/i2c-core-acpi.c | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)
drivers/i2c/i2c-core-acpi.c +11 -0
index 84841ed13487..98a8d63e3fb8 100644
@@ -7,6 +7,7 @@
 
 #include <linux/acpi.h>
 #include <linux/device.h>
+#include <linux/dmi.h>
 #include <linux/err.h>
 #include <linux/i2c.h>
 #include <linux/list.h>
@@ -356,6 +357,16 @@ static const struct acpi_device_id i2c_acpi_force_400khz_device_ids[] = {
 	{ }
 };
 
+static const struct dmi_system_id i2c_acpi_dell_xps_17_9720_dmi_ids[] = {
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 17 9720"),
+		},
+	},
+	{ }
+};
+
 static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = {
 	/*
 	 * When a 400KHz freq is used on this model of ELAN touchpad in Linux,

drivers/i2c/i2c-core-acpi.c static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = { · line 396

Quoted 9 lines
drivers/i2c/i2c-core-acpi.c +6 -0
@@ -377,6 +388,14 @@ static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = {
 	{ .id = "ELAN0678" },
 	{ .id = "ELAN06FA" },
 	{ .id = "ELAN1300" },
+	{
+		/*
+		 * Some Dell XPS 17 9720 systems do not use standard
+		 * ACPI IDs so we need to match also via DMI strings.
+		 */
+		.id = "VEN_04F3",

04F3 is ELAN's USB/I2C-HID vendor ID and the commonality between all touchpads with needs this seems to be them being from ELAN.

Also a quick grep through my DSDT collection shows 0 uses of VEN_04F3, which makes me think this is pretty unique.

So all in all I think we can just add a match on "VEN_04F3" without requiring / adding DMI matching ?

Regards,

Hans

Quoted 24 lines
drivers/i2c/i2c-core-acpi.c +6 -1
+		.driver_data = (kernel_ulong_t)i2c_acpi_dell_xps_17_9720_dmi_ids,
+	},
 	{ }
 };
 
@@ -385,6 +404,7 @@ static acpi_status i2c_acpi_lookup_speed(acpi_handle handle, u32 level,
 {
 	struct i2c_acpi_lookup *lookup = data;
 	struct acpi_device *adev = acpi_fetch_acpi_dev(handle);
+	const struct acpi_device_id *id;
 
 	if (!adev || i2c_acpi_do_lookup(adev, lookup))
 		return AE_OK;
@@ -398,7 +418,9 @@ static acpi_status i2c_acpi_lookup_speed(acpi_handle handle, u32 level,
 	if (acpi_match_device_ids(adev, i2c_acpi_force_400khz_device_ids) == 0)
 		lookup->force_speed = I2C_MAX_FAST_MODE_FREQ;
 
-	if (acpi_match_device_ids(adev, i2c_acpi_force_100khz_device_ids) == 0)
+	id = acpi_match_acpi_device(i2c_acpi_force_100khz_device_ids, adev);
+	if (id && (!id->driver_data ||
+		   dmi_check_system((const struct dmi_system_id *)id->driver_data)))
 		lookup->force_speed = I2C_MAX_STANDARD_MODE_FREQ;
 
 	return AE_OK;
#2 lore raw

Hi,

Quoted 63 lines · Hans de Goede

Hi,

Quoted 10 lines · Mika Westerberg

The Dell XPS 17 9720 touchpad has the same lagging issue as with others when run at 400 kHz as the ACPI tables describe. This particular system does not use standard ACPI ID but it seems to use "Windows Device ID" VEN_04F3 for whatever reason. Add this one to the 100 kHz quirk list as well but since this is not a standard ACPI ID match it also via DMI strings just to be on the safe side.

Thank you for your patch.

Quoted 34 lines
---
 drivers/i2c/i2c-core-acpi.c | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)
drivers/i2c/i2c-core-acpi.c +11 -0
index 84841ed13487..98a8d63e3fb8 100644
@@ -7,6 +7,7 @@
 
 #include <linux/acpi.h>
 #include <linux/device.h>
+#include <linux/dmi.h>
 #include <linux/err.h>
 #include <linux/i2c.h>
 #include <linux/list.h>
@@ -356,6 +357,16 @@ static const struct acpi_device_id i2c_acpi_force_400khz_device_ids[] = {
 	{ }
 };
 
+static const struct dmi_system_id i2c_acpi_dell_xps_17_9720_dmi_ids[] = {
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 17 9720"),
+		},
+	},
+	{ }
+};
+
 static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = {
 	/*
 	 * When a 400KHz freq is used on this model of ELAN touchpad in Linux,

drivers/i2c/i2c-core-acpi.c static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = { · line 396

Quoted 9 lines
drivers/i2c/i2c-core-acpi.c +6 -0
@@ -377,6 +388,14 @@ static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = {
 	{ .id = "ELAN0678" },
 	{ .id = "ELAN06FA" },
 	{ .id = "ELAN1300" },
+	{
+		/*
+		 * Some Dell XPS 17 9720 systems do not use standard
+		 * ACPI IDs so we need to match also via DMI strings.
+		 */
+		.id = "VEN_04F3",

04F3 is ELAN's USB/I2C-HID vendor ID and the commonality between all touchpads with needs this seems to be them being from ELAN.

Quoted 5 lines

Also a quick grep through my DSDT collection shows 0 uses of VEN_04F3, which makes me think this is pretty unique.

So all in all I think we can just add a match on "VEN_04F3" without requiring / adding DMI matching ?

Works for me. I'll do that in v2.

#3 lore raw
In reply to Mika Westerberg
Quoted 6 lines · Mika Westerberg

The Dell XPS 17 9720 touchpad has the same lagging issue as with others when run at 400 kHz as the ACPI tables describe. This particular system does not use standard ACPI ID but it seems to use "Windows Device ID" VEN_04F3 for whatever reason. Add this one to the 100 kHz quirk list as well but since this is not a standard ACPI ID match it also via DMI strings just to be on the safe side.

...

Quoted 3 lines

Isn't this https://bugzilla.kernel.org/show_bug.cgi?id=214597 as well?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw

Hi Andy,

Yes this post explains this exact problem (I even posted on it).

Since applying the 100khz patch I have had 0 issue with the touchpad. Not sure why the Dell XPS 17 9720 is so unique in this issue, but amongst all the firmware updates I have received since purchasing this computer, there has been 0 improvement to this.

I appreciate you all working to resolve this issue. Is there any further information I can provide you all to get a fix pushed to the main Linux kernel?

Quoted 22 lines · Andy Shevchenko
Quoted 6 lines · Mika Westerberg

The Dell XPS 17 9720 touchpad has the same lagging issue as with others when run at 400 kHz as the ACPI tables describe. This particular system does not use standard ACPI ID but it seems to use "Windows Device ID" VEN_04F3 for whatever reason. Add this one to the 100 kHz quirk list as well but since this is not a standard ACPI ID match it also via DMI strings just to be on the safe side.

...

Quoted 3 lines

Isn't this https://bugzilla.kernel.org/show_bug.cgi?id=214597 as well?

--
With Best Regards,
Andy Shevchenko

#5 lore raw
Quoted 4 lines · On Fri, Nov 13, 2026 at 02:17:23PM +0000, [email protected] wrote:

Hi Andy,

Yes this post explains this exact problem (I even posted on it).

Quoted 8 lines

Since applying the 100khz patch I have had 0 issue with the touchpad. Not sure why the Dell XPS 17 9720 is so unique in this issue, but amongst all the firmware updates I have received since purchasing this computer, there has been 0 improvement to this.

I appreciate you all working to resolve this issue. Is there any further information I can provide you all to get a fix pushed to the main Linux kernel?

Can you comment on that bug with a link to this thread that your case is fixed by this patch, so others also may test it?

Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Mika Westerberg
Quoted 6 lines

The Dell XPS 17 9720 touchpad has the same lagging issue as with others when run at 400 kHz as the ACPI tables describe. This particular system does not use standard ACPI ID but it seems to use "Windows Device ID" VEN_04F3 for whatever reason. Add this one to the 100 kHz quirk list as well but since this is not a standard ACPI ID match it also via DMI strings just to be on the safe side.

...

Quoted 5 lines
Quoted 5 lines
Quoted 3 lines

Isn't this https://bugzilla.kernel.org/show_bug.cgi?id=214597 as well?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#6 lore raw

Hi Andy,

Done.

Quoted 40 lines · Andy Shevchenko
Quoted 4 lines · On Fri, Nov 13, 2026 at 02:17:23PM +0000, [email protected] wrote:

Hi Andy,

Yes this post explains this exact problem (I even posted on it).

Quoted 8 lines

Since applying the 100khz patch I have had 0 issue with the touchpad. Not sure why the Dell XPS 17 9720 is so unique in this issue, but amongst all the firmware updates I have received since purchasing this computer, there has been 0 improvement to this.

I appreciate you all working to resolve this issue. Is there any further information I can provide you all to get a fix pushed to the main Linux kernel?

Can you comment on that bug with a link to this thread that your case is fixed by this patch, so others also may test it?

Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Mika Westerberg
Quoted 6 lines

The Dell XPS 17 9720 touchpad has the same lagging issue as with others when run at 400 kHz as the ACPI tables describe. This particular system does not use standard ACPI ID but it seems to use "Windows Device ID" VEN_04F3 for whatever reason. Add this one to the 100 kHz quirk list as well but since this is not a standard ACPI ID match it also via DMI strings just to be on the safe side.

...

Quoted 5 lines
Quoted 5 lines
Quoted 3 lines

Isn't this https://bugzilla.kernel.org/show_bug.cgi?id=214597 as well?

--
With Best Regards,
Andy Shevchenko