Skip to contentSkip to conversation

SUPPORT.md: split XSM from Flask

PATCH Superseded Jan Beulich 3 participants 9 messages Jul 30, 2024

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SUPPORT.md: split XSM from Flask

XSM is a generic framework, which in particular is also used by SILO. With this it can't really be experimental: Arm enables SILO by default.

SUPPORT.md +13 -2
@@ -768,13 +768,20 @@ Compile time disabled for ARM by default
 
     Status, x86: Supported, not security supported
 
-### XSM & FLASK
+### XSM
+
+    Status: Supported
+
+See below for use with FLASK and SILO.  The dummy implementation is covered here
+as well.
+
+### XSM + FLASK
 
     Status: Experimental
 
 Compile time disabled by default.
 
-Also note that using XSM
+Also note that using FLASK
 to delegate various domain control hypercalls
 to particular other domains, rather than only permitting use by dom0,
 is also specifically excluded from security support for many hypercalls.
@@ -787,6 +794,10 @@ Please see XSA-77 for more details.
 The default policy includes FLASK labels and roles for a "typical" Xen-based system
 with dom0, driver domains, stub domains, domUs, and so on.
 
+### XSM + SILO
+
+    Status: Supported
+
 ## Virtual Hardware, Hypervisor
 
 ### x86/Nested PV
#1 lore raw

---- On Tue, 30 Jul 2024 06:57:08 -0400 Jan Beulich wrote ---

Quoted 10 lines

XSM is a generic framework, which in particular is also used by SILO. With this it can't really be experimental: Arm enables SILO by default.

SUPPORT.md +0 -0
@@ -768,13 +768,20 @@ Compile time disabled for ARM by default 
 
 Status, x86: Supported, not security supported 

SUPPORT.md Compile time disabled for ARM by default · line 778

Quoted 10 lines
SUPPORT.md +8 -1
 
-### XSM & FLASK 
+### XSM 
+ 
+    Status: Supported 
+ 
+See below for use with FLASK and SILO.  The dummy implementation is covered here 
+as well. 
+ 
+### XSM + FLASK 

To me it would make more sense to say XSM FLASK Policy than XSM + FLASK.

Quoted 10 lines
SUPPORT.md +1 -1
 Status: Experimental 
 
 Compile time disabled by default. 
 
-Also note that using XSM 
+Also note that using FLASK 
 to delegate various domain control hypercalls 
 to particular other domains, rather than only permitting use by dom0, 
 is also specifically excluded from security support for many hypercalls. 

SUPPORT.md Please see XSA-77 for more details. · line 797

Quoted 4 lines
SUPPORT.md +1 -0
@@ -787,6 +794,10 @@ Please see XSA-77 for more details. 
 The default policy includes FLASK labels and roles for a "typical" Xen-based system 
 with dom0, driver domains, stub domains, domUs, and so on. 
 
+### XSM + SILO 

Same here, XSM SILO Policy.

SUPPORT.md Please see XSA-77 for more details. · line 803

Quoted 6 lines
SUPPORT.md +2 -0
+    Status: Supported 
+ 
 ## Virtual Hardware, Hypervisor 
 
 ### x86/Nested PV 

v/r,
dps

#2 lore raw
Quoted 13 lines · Daniel Smith

---- On Tue, 30 Jul 2024 06:57:08 -0400 Jan Beulich wrote ---

Quoted 11 lines

XSM is a generic framework, which in particular is also used by SILO. With this it can't really be experimental: Arm enables SILO by default.

SUPPORT.md +0 -0
@@ -768,13 +768,20 @@ Compile time disabled for ARM by default 
 
 Status, x86: Supported, not security supported 
 
Quoted 11 lines

SUPPORT.md Compile time disabled for ARM by default · line 778

Quoted 9 lines
SUPPORT.md +8 -1
-### XSM & FLASK 
+### XSM 
+ 
+    Status: Supported 
+ 
+See below for use with FLASK and SILO.  The dummy implementation is covered here 
+as well. 
+ 
+### XSM + FLASK 

To me it would make more sense to say XSM FLASK Policy than XSM + FLASK.

I thought about using "policy", but then deemed that wrong. The "Flask policy" is what you load into Flask. Whereas here we're talking about the code actually carrying out what such a policy says.

Jan

#3 lore raw

---- On Tue, 30 Jul 2024 08:04:09 -0400 Jan Beulich wrote ---

Quoted 24 lines · Daniel Smith
Quoted 23 lines

---- On Tue, 30 Jul 2024 06:57:08 -0400 Jan Beulich wrote ---

Quoted 20 lines

XSM is a generic framework, which in particular is also used by SILO. With this it can't really be experimental: Arm enables SILO by default.

SUPPORT.md +8 -1
@@ -768,13 +768,20 @@ Compile time disabled for ARM by default 
 
 Status, x86: Supported, not security supported 
 
-### XSM & FLASK 
+### XSM 
+ 
+    Status: Supported 
+ 
+See below for use with FLASK and SILO.  The dummy implementation is covered here 
+as well. 
+ 
+### XSM + FLASK 
Quoted 5 lines
Quoted 1 line

To me it would make more sense to say XSM FLASK Policy than XSM + FLASK.

I thought about using "policy", but then deemed that wrong. The "Flask policy" is what you load into Flask. Whereas here we're talking about the code actually carrying out what such a policy says.

The main issue I have is the "+", so I checked how the different security models/policies are referenced under LSM. The documentation I reviwed lists them as modules or security modules, e.g. AppArmor module. How about one of these combinations, FLASK Module, XSM FLASK Module, or FLASK XSM Module? And similar for SILO.

dps

#4 lore raw
Quoted 26 lines · Daniel Smith

---- On Tue, 30 Jul 2024 08:04:09 -0400 Jan Beulich wrote ---

Quoted 24 lines · Daniel Smith
Quoted 23 lines

---- On Tue, 30 Jul 2024 06:57:08 -0400 Jan Beulich wrote ---

Quoted 20 lines

XSM is a generic framework, which in particular is also used by SILO. With this it can't really be experimental: Arm enables SILO by default.

SUPPORT.md +8 -1
@@ -768,13 +768,20 @@ Compile time disabled for ARM by default 
 
 Status, x86: Supported, not security supported 
 
-### XSM & FLASK 
+### XSM 
+ 
+    Status: Supported 
+ 
+See below for use with FLASK and SILO.  The dummy implementation is covered here 
+as well. 
+ 
+### XSM + FLASK 
Quoted 7 lines
Quoted 5 lines
Quoted 1 line

To me it would make more sense to say XSM FLASK Policy than XSM + FLASK.

I thought about using "policy", but then deemed that wrong. The "Flask policy" is what you load into Flask. Whereas here we're talking about the code actually carrying out what such a policy says.

The main issue I have is the "+", so I checked how the different security models/policies are referenced under LSM. The documentation I reviwed lists them as modules or security modules, e.g. AppArmor module. How about one of these combinations, FLASK Module, XSM FLASK Module, or FLASK XSM Module?

Either of the latter two are fine(ish) by me. My (smaller) concern there is that the M in XSM also stands for Module.

Jan

#5 lore raw
In reply to Jan Beulich
Quoted 2 lines · Jan Beulich

XSM is a generic framework, which in particular is also used by SILO. With this it can't really be experimental: Arm enables SILO by default.

It's stronger than this.

XSA-295 makes SILO the only security supported configuration for ARM.

And since then, no-one has added LSE atomic support to ARM, so this is still the case even on hardware which can be driven in a way which isn't susceptible to LL/SC infinite loops...

Quoted 6 lines

SUPPORT.md Compile time disabled for ARM by default · line 776

Quoted 10 lines
SUPPORT.md +6 -1
@@ -768,13 +768,20 @@ Compile time disabled for ARM by default
 
     Status, x86: Supported, not security supported
 
-### XSM & FLASK
+### XSM
+
+    Status: Supported
+
+See below for use with FLASK and SILO.  The dummy implementation is covered here
+as well.

This feels weird, although I can't suggest a better option.

XSM isn't optional; it can't be compiled out, nor can the dummy policy, so it's weird to call out what literally cannot have a statement different to the rest of Xen.

Combined with ...

SUPPORT.md Compile time disabled for ARM by default · line 778

Quoted 2 lines
SUPPORT.md +2 -0
+
+### XSM + FLASK

... this wanting to say "Flask (XSM module/policy)" IMO, maybe what we really want is:

---%<---
### XSM (Xen Security Modules)

Base XSM is a security policy framework used in Xen.  The dummy policy implements a basic "dom0 all powerful, domUs all unprivileged" policy". ---%<---

intentionally without giving a Status.

Then, the two blocks below are clearly alternative modules which have optionality and different support statuses.

~Andrew

#6 lore raw
Quoted 7 lines · Andrew Cooper
Quoted 2 lines · Jan Beulich

XSM is a generic framework, which in particular is also used by SILO. With this it can't really be experimental: Arm enables SILO by default.

It's stronger than this.

XSA-295 makes SILO the only security supported configuration for ARM.

Okay, switched to "Arm mandates SILO for having a security supported configuration."

Quoted 16 lines

SUPPORT.md Compile time disabled for ARM by default · line 776

Quoted 13 lines
SUPPORT.md +6 -1
@@ -768,13 +768,20 @@ Compile time disabled for ARM by default
 
     Status, x86: Supported, not security supported
 
-### XSM & FLASK
+### XSM
+
+    Status: Supported
+
+See below for use with FLASK and SILO.  The dummy implementation is covered here
+as well.

This feels weird, although I can't suggest a better option.

Quoted 1 line

XSM isn't optional; it can't be compiled out,

How can it not be? There's an "XSM" Kconfig control.

Quoted 1 line

nor can the dummy policy,

In a way. Yet how the dummy policy is instantiated is quite different between XSM=y and XSM=n.

Quoted 11 lines

so it's weird to call out what literally cannot have a statement different to the rest of Xen.

Combined with ...

SUPPORT.md Compile time disabled for ARM by default · line 778

Quoted 2 lines
SUPPORT.md +2 -0
+
+### XSM + FLASK

... this wanting to say "Flask (XSM module/policy)" IMO, maybe what we really want is:

Quoted 8 lines

---%<---
### XSM (Xen Security Modules)

Base XSM is a security policy framework used in Xen.  The dummy policy implements a basic "dom0 all powerful, domUs all unprivileged" policy". ---%<---

intentionally without giving a Status.

As per above, imo XSM=y wants security status named. That's, after all, part of what was missing / ambiguous so far.

Quoted 2 lines

Then, the two blocks below are clearly alternative modules which have optionality and different support statuses.

I'll change the wording there some, to be closer to what you and also Daniel ask for.

Jan

#7 lore raw

---- On Tue, 30 Jul 2024 08:58:03 -0400 Jan Beulich wrote ---

Quoted 28 lines · Andrew Cooper
Quoted 7 lines · Jan Beulich
Quoted 2 lines

XSM is a generic framework, which in particular is also used by SILO. With this it can't really be experimental: Arm enables SILO by default.

It's stronger than this.

XSA-295 makes SILO the only security supported configuration for ARM.

Okay, switched to "Arm mandates SILO for having a security supported configuration."

Quoted 16 lines

SUPPORT.md Compile time disabled for ARM by default · line 776

Quoted 13 lines
SUPPORT.md +6 -1
@@ -768,13 +768,20 @@ Compile time disabled for ARM by default 
 
     Status, x86: Supported, not security supported 
 
-### XSM & FLASK 
+### XSM 
+ 
+    Status: Supported 
+ 
+See below for use with FLASK and SILO.  The dummy implementation is covered here 
+as well. 

This feels weird, although I can't suggest a better option.

Quoted 8 lines
Quoted 1 line

XSM isn't optional; it can't be compiled out,

How can it not be? There's an "XSM" Kconfig control.

Quoted 1 line

nor can the dummy policy,

In a way. Yet how the dummy policy is instantiated is quite different between XSM=y and XSM=n.

I have pointed this out a few times, the difference between XSM=y vs XSM=n determines how the dummy policy is embedded into the hypervisor. XSM=n, causes the dummy policy hooks to be included directly for the xsm_* hooks. When XSM=y, then the callback wrapper functions are used for the xsm_* hooks with dummy policy set for the callbacks.

Quoted 20 lines
Quoted 11 lines

so it's weird to call out what literally cannot have a statement different to the rest of Xen.

Combined with ...

SUPPORT.md Compile time disabled for ARM by default · line 778

Quoted 2 lines
SUPPORT.md +2 -0
+ 
+### XSM + FLASK 

... this wanting to say "Flask (XSM module/policy)" IMO, maybe what we really want is:

Quoted 8 lines

---%<---
### XSM (Xen Security Modules)

Base XSM is a security policy framework used in Xen.  The dummy policy implements a basic "dom0 all powerful, domUs all unprivileged" policy". ---%<---

intentionally without giving a Status.

Quoted 8 lines

As per above, imo XSM=y wants security status named. That's, after all, part of what was missing / ambiguous so far.

Quoted 2 lines

Then, the two blocks below are clearly alternative modules which have optionality and different support statuses.

I'll change the wording there some, to be closer to what you and also Daniel ask for.

Thank you.

dps

#8 lore raw
Quoted 32 lines · Daniel Smith

---- On Tue, 30 Jul 2024 08:58:03 -0400 Jan Beulich wrote ---

Quoted 30 lines · Andrew Cooper
Quoted 7 lines · Jan Beulich
Quoted 2 lines

XSM is a generic framework, which in particular is also used by SILO. With this it can't really be experimental: Arm enables SILO by default.

It's stronger than this.

XSA-295 makes SILO the only security supported configuration for ARM.

Okay, switched to "Arm mandates SILO for having a security supported configuration."

Quoted 17 lines

SUPPORT.md Compile time disabled for ARM by default · line 776

Quoted 13 lines
SUPPORT.md +6 -1
@@ -768,13 +768,20 @@ Compile time disabled for ARM by default 
 
     Status, x86: Supported, not security supported 
 
-### XSM & FLASK 
+### XSM 
+ 
+    Status: Supported 
+ 
+See below for use with FLASK and SILO.  The dummy implementation is covered here 
+as well. 

This feels weird, although I can't suggest a better option.

XSM isn't optional; it can't be compiled out,

Quoted 8 lines
Quoted 6 lines

How can it not be? There's an "XSM" Kconfig control.

Quoted 1 line

nor can the dummy policy,

In a way. Yet how the dummy policy is instantiated is quite different between XSM=y and XSM=n.

I have pointed this out a few times, the difference between XSM=y vs XSM=n determines how the dummy policy is embedded into the hypervisor. XSM=n, causes the dummy policy hooks to be included directly for the xsm_* hooks. When XSM=y, then the callback wrapper functions are used for the xsm_* hooks with dummy policy set for the callbacks.

I wonder what you're trying to tell me. According to my reading that's what I said, just in far fewer words.

Jan