package/qt5enginio: needs ssl
PATCH v2 1/1 package/qt5enginio: needs ssl
qt5enginio needs Qt5 with ssl support, a dependency could be added on BR2_PACKAGE_QT5BASE_OPENSSL but this proposal was rejected in the first iteration of this patch
Qt5 has ssl support through libressl on Qt 5.6 or openssl in latest Qt however we can't select libressl without adding a circular dependency as some packages (such as sqlcipher) force openssl through BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
So, as suggested by Arnout:
- add a hidden BR2_PACKAGE_QT5ENGINIO_SELECT_OPENSSL option that selects BR2_PACKAGE_OPENSSL if qt5enginio is selected
- remove select on BR2_PACKAGE_QT5BASE to avoid a circular dependency and because it's not needed as BR2_PACKAGE_QT5 already selects BR2_PACKAGE_QT5BASE
- add dependencies of BR2_PACKAGE_LIBRESSL if Qt 5.6 is selected (but don't select libressl to avoid a circular dependency)
Fixes:
- http://autobuild.buildroot.org/results/60678cab68ec9aa17184b8417b64b3b79adf428a
---
Changes v1 -> v2 (after review of Thomas Petazzoni and Arnout Vandecappelle):
- Remove dependency on BR2_PACKAGE_QT5BASE_OPENSSL
package/qt5/qt5enginio/Config.in | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
package/qt5/qt5enginio/Config.in +10 -2
@@ -1,7 +1,15 @@ +# This is a hack to avoid circular dependencies when selecting OPENSSL +config BR2_PACKAGE_QT5ENGINIO_SELECT_OPENSSL + bool + default y if BR2_PACKAGE_QT5ENGINIO + select BR2_PACKAGE_OPENSSL + config BR2_PACKAGE_QT5ENGINIO bool "qt5enginio" - select BR2_PACKAGE_OPENSSL - select BR2_PACKAGE_QT5BASE + depends on !BR2_PACKAGE_QT5_VERSION_5_6 || \ + (BR2_PACKAGE_QT5_VERSION_5_6 && \ + (!BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL && \ + !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU))) select BR2_PACKAGE_QT5BASE_GUI select BR2_PACKAGE_QT5BASE_NETWORK help
Signature · 1 line
2.20.1
PATCH v2 1/1 package/qt5enginio: needs ssl
Hi Fabrice,
Quoted 35 lines · Fabrice Fontaine
qt5enginio needs Qt5 with ssl support, a dependency could be added on
BR2_PACKAGE_QT5BASE_OPENSSLbut this proposal was rejected in the first iteration of this patchQt5 has ssl support through libressl on Qt 5.6 or openssl in latest Qt however we can't select libressl without adding a circular dependency as some packages (such as sqlcipher) force openssl through
BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSLSo, as suggested by Arnout:
- add a hiddenBR2_PACKAGE_QT5ENGINIO_SELECT_OPENSSLoption that selectsBR2_PACKAGE_OPENSSLif qt5enginio is selected
- remove select onBR2_PACKAGE_QT5BASEto avoid a circular dependency and because it's not needed asBR2_PACKAGE_QT5already selectsBR2_PACKAGE_QT5BASE
- add dependencies ofBR2_PACKAGE_LIBRESSLif Qt 5.6 is selected (but don't select libressl to avoid a circular dependency)Fixes:
- http://autobuild.buildroot.org/results/60678cab68ec9aa17184b8417b64b3b79adf428aSigned-off-by Fabrice Fontaine <[email protected]>---
Changes v1 -> v2 (after review of Thomas Petazzoni and Arnout Vandecappelle):
- Remove dependency onBR2_PACKAGE_QT5BASE_OPENSSLpackage/qt5/qt5enginio/Config.in | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)package/qt5/qt5enginio/Config.in +0
-0
package/qt5/qt5enginio/Config.in line 5
Quoted 5 lines
package/qt5/qt5enginio/Config.in +5
-0@@ -1,7 +1,15 @@ +# This is a hack to avoid circular dependencies when selecting OPENSSL +config BR2_PACKAGE_QT5ENGINIO_SELECT_OPENSSL + bool + default y if BR2_PACKAGE_QT5ENGINIO + select BR2_PACKAGE_OPENSSL
Unfortunately, this still doesn't work for Qt5.6.
However, there is not much we can do there. Selecting libressl is not possible,
so we have to depend on it, so we can't select libopenssl or we'd get a circular dependency.
So, I've gone back to your original patch but changed the depends into a
select, and I added a comment that for Qt5.6 you need to select libressl:
comment "qt5enginio needs libressl for Qt5.6"
depends on BR2_PACKAGE_QT5_VERSION_5_6
depends on !BR2_PACKAGE_LIBRESSL
This would still lead to autobuild failures for Qt5.6, of course, because it is
still possible to select libopenssl instead of libressl. But we don't test Qt5.6 in the autobuilders, so that's fine.
With that, I've applied to master. Many thanks for keeping on trying to fix
this properly.
Regards,
Arnout
Quoted 13 lines
package/qt5/qt5enginio/Config.in +5
-2+ config BR2_PACKAGE_QT5ENGINIO bool "qt5enginio" - select BR2_PACKAGE_OPENSSL - select BR2_PACKAGE_QT5BASE + depends on !BR2_PACKAGE_QT5_VERSION_5_6 || \ + (BR2_PACKAGE_QT5_VERSION_5_6 && \ + (!BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL && \ + !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU))) select BR2_PACKAGE_QT5BASE_GUI select BR2_PACKAGE_QT5BASE_NETWORK help
PATCH v2 1/1 package/qt5enginio: needs ssl
Dear Arnout,
Le ven. 10 mai 2019 ? 17:07, Arnout Vandecappelle <[email protected]> a ?crit :
Quoted 54 lines
Hi Fabrice,
Quoted 35 lines · Fabrice Fontaine
qt5enginio needs Qt5 with ssl support, a dependency could be added on
BR2_PACKAGE_QT5BASE_OPENSSLbut this proposal was rejected in the first iteration of this patchQt5 has ssl support through libressl on Qt 5.6 or openssl in latest Qt however we can't select libressl without adding a circular dependency as some packages (such as sqlcipher) force openssl through
BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSLSo, as suggested by Arnout:
- add a hiddenBR2_PACKAGE_QT5ENGINIO_SELECT_OPENSSLoption that selectsBR2_PACKAGE_OPENSSLif qt5enginio is selected
- remove select onBR2_PACKAGE_QT5BASEto avoid a circular dependency and because it's not needed asBR2_PACKAGE_QT5already selectsBR2_PACKAGE_QT5BASE
- add dependencies ofBR2_PACKAGE_LIBRESSLif Qt 5.6 is selected (but don't select libressl to avoid a circular dependency)Fixes:
- http://autobuild.buildroot.org/results/60678cab68ec9aa17184b8417b64b3b79adf428aSigned-off-by Fabrice Fontaine <[email protected]>---
Changes v1 -> v2 (after review of Thomas Petazzoni and Arnout Vandecappelle):
- Remove dependency onBR2_PACKAGE_QT5BASE_OPENSSLpackage/qt5/qt5enginio/Config.in | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)package/qt5/qt5enginio/Config.in +0
-0package/qt5/qt5enginio/Config.in line 5
Quoted 5 lines
package/qt5/qt5enginio/Config.in +5
-0@@ -1,7 +1,15 @@ +# This is a hack to avoid circular dependencies when selecting OPENSSL +config BR2_PACKAGE_QT5ENGINIO_SELECT_OPENSSL + bool + default y if BR2_PACKAGE_QT5ENGINIO + select BR2_PACKAGE_OPENSSLUnfortunately, this still doesn't work for Qt5.6.
However, there is not much we can do there. Selecting libressl is not possible,
so we have to depend on it, so we can't select libopenssl or we'd get a circular dependency.So, I've gone back to your original patch but changed the depends into a
select, and I added a comment that for Qt5.6 you need to select libressl:
Quoted 8 lines
comment "qt5enginio needs libressl for Qt5.6"
depends onBR2_PACKAGE_QT5_VERSION_5_6
depends on !BR2_PACKAGE_LIBRESSLThis would still lead to autobuild failures for Qt5.6, of course, because it is
still possible to select libopenssl instead of libressl. But we don't test Qt5.6 in the autobuilders, so that's fine.
Are you sure that we're not testing Qt5.6 in autobuilders? Here is the latest build failure on qt5enginio:
http://autobuild.buildroot.org/results/969/969d38b9ff1db51959e68343cf6e932dc8645688/config.
But I agree that perhaps we should remove Qt5.6 from autobuilders.
Quoted 21 lines
With that, I've applied to master. Many thanks for keeping on trying to fix
this properly.Regards,
ArnoutQuoted 13 lines
package/qt5/qt5enginio/Config.in +5
-2+ config BR2_PACKAGE_QT5ENGINIO bool "qt5enginio" - select BR2_PACKAGE_OPENSSL - select BR2_PACKAGE_QT5BASE + depends on !BR2_PACKAGE_QT5_VERSION_5_6 || \ + (BR2_PACKAGE_QT5_VERSION_5_6 && \ + (!BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL && \ + !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU))) select BR2_PACKAGE_QT5BASE_GUI select BR2_PACKAGE_QT5BASE_NETWORK help
Best Regards,
Fabrice
PATCH v2 1/1 package/qt5enginio: needs ssl
Quoted 4 lines · Fabrice Fontaine
Quoted 3 lines
This would still lead to autobuild failures for Qt5.6, of course, because it is
still possible to select libopenssl instead of libressl. But we don't test Qt5.6 in the autobuilders, so that's fine.Are you sure that we're not testing Qt5.6 in autobuilders?
Thomas said so and I believed him :-)
Quoted 2 lines
Here is the latest build failure on qt5enginio:
http://autobuild.buildroot.org/results/969/969d38b9ff1db51959e68343cf6e932dc8645688/config.
We don't actively select QT5.6 in the autobuilders, but there are some
toolchains that don't support Qt5.9+ so in these cases Qt5.6 is still selected.
Quoted 1 line
But I agree that perhaps we should remove Qt5.6 from autobuilders.
Or remove Qt5.6 completely :-)
Regards,
Arnout
PATCH v2 1/1 package/qt5enginio: needs ssl
In reply to Arnout VandecappelleQuoted 59 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle <[email protected]> writes:
Hi Fabrice,
Quoted 35 lines · Fabrice Fontaine
qt5enginio needs Qt5 with ssl support, a dependency could be added on
BR2_PACKAGE_QT5BASE_OPENSSLbut this proposal was rejected in the first iteration of this patchQt5 has ssl support through libressl on Qt 5.6 or openssl in latest Qt however we can't select libressl without adding a circular dependency as some packages (such as sqlcipher) force openssl through
BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSLSo, as suggested by Arnout:
- add a hiddenBR2_PACKAGE_QT5ENGINIO_SELECT_OPENSSLoption that selectsBR2_PACKAGE_OPENSSLif qt5enginio is selected
- remove select onBR2_PACKAGE_QT5BASEto avoid a circular dependency and because it's not needed asBR2_PACKAGE_QT5already selectsBR2_PACKAGE_QT5BASE
- add dependencies ofBR2_PACKAGE_LIBRESSLif Qt 5.6 is selected (but don't select libressl to avoid a circular dependency)Fixes:
- http://autobuild.buildroot.org/results/60678cab68ec9aa17184b8417b64b3b79adf428aSigned-off-by Fabrice Fontaine <[email protected]>---
Changes v1 -> v2 (after review of Thomas Petazzoni and Arnout Vandecappelle):
- Remove dependency onBR2_PACKAGE_QT5BASE_OPENSSLpackage/qt5/qt5enginio/Config.in | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)package/qt5/qt5enginio/Config.in +0
-0package/qt5/qt5enginio/Config.in line 5
Quoted 5 lines
package/qt5/qt5enginio/Config.in +5
-0@@ -1,7 +1,15 @@ +# This is a hack to avoid circular dependencies when selecting OPENSSL +config BR2_PACKAGE_QT5ENGINIO_SELECT_OPENSSL + bool + default y if BR2_PACKAGE_QT5ENGINIO + select BR2_PACKAGE_OPENSSLUnfortunately, this still doesn't work for Qt5.6.
However, there is not much we can do there. Selecting libressl is not possible,
so we have to depend on it, so we can't select libopenssl or we'd get a circular dependency.So, I've gone back to your original patch but changed the depends into a
select, and I added a comment that for Qt5.6 you need to select libressl:comment "qt5enginio needs libressl for Qt5.6"
depends onBR2_PACKAGE_QT5_VERSION_5_6
depends on !BR2_PACKAGE_LIBRESSL
Quoted 6 lines
This would still lead to autobuild failures for Qt5.6, of course, because it is
still possible to select libopenssl instead of libressl. But we don't test Qt5.6 in the autobuilders, so that's fine.With that, I've applied to master. Many thanks for keeping on trying to fix
this properly.
Committed to 2019.02.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard