Skip to contentSkip to conversation

: forgotten __init and __exit in memory.c

ALSA - driver 0001239 [email protected] 1 participant 1 message Jul 25, 2005

lore
Share & tools
lore
#0 lore raw

A NOTE has been added to this issue.
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1239>
======================================================================
Reported By: Henne
Assigned To:
======================================================================

Project:                    ALSA - driver
Issue ID:                   1239
Category:                   1_OTHERS
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Distribution:               
Kernel Version:             
======================================================================
Date Submitted:             07-07-2005 10:37 CEST
Last Modified:              07-25-2005 14:54 CEST

======================================================================
Summary: forgotten __init and __exit in memory.c
Description:
I think that snd_memory_init() should get an __init,
and snd_memory_exit() an __exit, cause that __init
function isn't called again and can be removed from the memory. That doesn't save too much space, but it's cleaner and mekes more sense .
The patch I added will fix it and is made for the current cvs version(memory.c 1.38).

======================================================================

----------------------------------------------------------------------
tiwai - 07-08-05 11:52
----------------------------------------------------------------------
__exit can't be applied since it's called from init function, too. Could you regenerate the patch?

----------------------------------------------------------------------
Henne - 07-25-05 14:54
----------------------------------------------------------------------
Here is the new one!

Issue History
Date Modified Username Field Change
======================================================================

07-07-05 10:37 Henne          New Issue                                    
07-07-05 10:37 Henne          File Added: memory_c.diff                    
07-08-05 11:52 tiwai          Note Added: 0005410                          
07-12-05 11:41 Henne          File Added: memory_c_1.diff                    
07-25-05 14:54 Henne          Note Added: 0005563                          

======================================================================

-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click