Skip to contentSkip to conversation

ahci: drop board_ahci constants

PATCH In review Sebastian Herbszt 2 participants 3 messages May 31, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ahci: drop board_ahci constants

Drop not used board_ahci constants.

hw/ahci.c +0 -6
index 3476cea..4090def 100644
@@ -65,12 +65,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0)
 #define RX_FIS_SDB                0x58 /* offset of SDB FIS data */
 #define RX_FIS_UNK                0x60 /* offset of Unknown FIS data */
 
-#define board_ahci                0
-#define board_ahci_pi             1
-#define board_ahci_vt8251         2
-#define board_ahci_ign_iferr      3
-#define board_ahci_sb600          4
-
 /* global controller registers */
 #define HOST_CAP                  0x00 /* host capabilities */
 #define HOST_CTL                  0x04 /* global host control */
#1 lore raw
Quoted 9 lines · Sebastian Herbszt

Drop not used board_ahci constants.

hw/ahci.c +0 -0
index 3476cea..4090def 100644

hw/ahci.c do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0) · line 73

Quoted 9 lines
hw/ahci.c +0 -6
@@ -65,12 +65,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0)
 #define RX_FIS_SDB                0x58 /* offset of SDB FIS data */
 #define RX_FIS_UNK                0x60 /* offset of Unknown FIS data */
 
-#define board_ahci                0
-#define board_ahci_pi             1
-#define board_ahci_vt8251         2
-#define board_ahci_ign_iferr      3
-#define board_ahci_sb600          4
-

They weren't used before? Why are they there at all then?

Alex

#2 lore raw
Quoted 22 lines · Alexander Graf
Quoted 9 lines · Sebastian Herbszt

Drop not used board_ahci constants.

hw/ahci.c +0 -0
index 3476cea..4090def 100644

hw/ahci.c do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0) · line 73

Quoted 9 lines
hw/ahci.c +0 -6
@@ -65,12 +65,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0)
 #define RX_FIS_SDB                0x58 /* offset of SDB FIS data */
 #define RX_FIS_UNK                0x60 /* offset of Unknown FIS data */
 
-#define board_ahci                0
-#define board_ahci_pi             1
-#define board_ahci_vt8251         2
-#define board_ahci_ign_iferr      3
-#define board_ahci_sb600          4
-

They weren't used before? Why are they there at all then?

Quoted 1 line

Alex

Copy and paste from the linux kernel (ahci.c/h)?

Sebastian