Skip to contentSkip to conversation

ARM: dts: at91: sama5d2: Fix typo in i2s1 node

PATCH Applied [email protected] 3 participants 3 messages Jul 7, 2022 – Jul 8, 2022 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 ARM: dts: at91: sama5d2: Fix typo in i2s1 node

From: Ryan Wanner <[email protected]>

Typo in i2s1 causing errors in dt binding validation. Changed assigned-parens to assigned-clock-parents and to match i2s0 node formatting.

Fixes 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")

---
changes in v2:
-corrected subject and tags
changes in v1:
-corrected formatting issues

 arch/arm/boot/dts/sama5d2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/sama5d2.dtsi +1 -1
index 89c71d419f82..659a17fc755c 100644
@@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>,
 				clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>;
 				clock-names = "pclk", "gclk";
 				assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>;
-				assigned-parrents = <&pmc PMC_TYPE_GCK 55>;
+				assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>;
 				status = "disabled";
 			};
 
Signature · 1 line
2.34.1
#1 lore raw

Hey Ryan,
Just a couple of nit-pick comments:

Quoted 5 lines · On 07/07/2022 22:58, [email protected] wrote:

From: Ryan Wanner <[email protected]>

Typo in i2s1 causing errors in dt binding validation. Changed assigned-parens to assigned-clock-parents and to match i2s0 node formatting.

Commit messages are usually written in the imperative, so rather than "changed", we usually say "change" etc.

Quoted 3 lines
Fixes 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")

The blank line here isn't needed.
I wouldn't respin a v4 for this unless Nicolas/Claudiu request one.

Thanks,
Conor.

Quoted 23 lines

---
changes in v2:
-corrected subject and tags
changes in v1:

(quoted diff) +0 -1
-corrected formatting issues
 
 arch/arm/boot/dts/sama5d2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/sama5d2.dtsi +1 -1
index 89c71d419f82..659a17fc755c 100644
@@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>,
 				clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>;
 				clock-names = "pclk", "gclk";
 				assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>;
-				assigned-parrents = <&pmc PMC_TYPE_GCK 55>;
+				assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>;
 				status = "disabled";
 			};
 
#2 lore raw
In reply to [email protected]
Quoted 9 lines · On 08.07.2022 00:58, [email protected] wrote:

From: Ryan Wanner <[email protected]>

Typo in i2s1 causing errors in dt binding validation. Changed assigned-parens to assigned-clock-parents and to match i2s0 node formatting.

Fixes 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")

Applied to at91-fixes, thanks!

Quoted 22 lines

---
changes in v2:
-corrected subject and tags
changes in v1:

(quoted diff) +0 -1
-corrected formatting issues
 
 arch/arm/boot/dts/sama5d2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/sama5d2.dtsi +1 -1
index 89c71d419f82..659a17fc755c 100644
@@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>,
 				clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>;
 				clock-names = "pclk", "gclk";
 				assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>;
-				assigned-parrents = <&pmc PMC_TYPE_GCK 55>;
+				assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>;
 				status = "disabled";
 			};