ARM: dts: at91: sama5d2: Fix typo in i2s1 node
PATCH v3 1/1 ARM: dts: at91: sama5d2: Fix typo in i2s1 node
From: Ryan Wanner <[email protected]>
Typo in i2s1 causing errors in dt binding validation. Changed assigned-parens to assigned-clock-parents and to match i2s0 node formatting.
---
changes in v2:
-corrected subject and tags
changes in v1:
-corrected formatting issues
arch/arm/boot/dts/sama5d2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/sama5d2.dtsi +1 -1
@@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>, clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>; clock-names = "pclk", "gclk"; assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>; - assigned-parrents = <&pmc PMC_TYPE_GCK 55>; + assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>; status = "disabled"; };
Signature · 1 line
2.34.1
Hey Ryan,
Just a couple of nit-pick comments:
Quoted 5 lines · On 07/07/2022 22:58, [email protected] wrote:
From: Ryan Wanner <[email protected]>
Typo in i2s1 causing errors in dt binding validation. Changed assigned-parens to assigned-clock-parents and to match i2s0 node formatting.
Commit messages are usually written in the imperative, so rather than "changed", we usually say "change" etc.
Quoted 3 lines
Fixes 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")
The blank line here isn't needed.
I wouldn't respin a v4 for this unless Nicolas/Claudiu request one.
Thanks,
Conor.
Quoted 23 lines
Signed-off-by Ryan Wanner <[email protected]>---
changes in v2:
-corrected subject and tags
changes in v1:(quoted diff) +0
-1-corrected formatting issues arch/arm/boot/dts/sama5d2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/sama5d2.dtsi +1
-1@@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>, clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>; clock-names = "pclk", "gclk"; assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>; - assigned-parrents = <&pmc PMC_TYPE_GCK 55>; + assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>; status = "disabled"; };
[email protected]
AppliedQuoted 9 lines · On 08.07.2022 00:58, [email protected] wrote:
From: Ryan Wanner <[email protected]>
Typo in i2s1 causing errors in dt binding validation. Changed assigned-parens to assigned-clock-parents and to match i2s0 node formatting.
Fixes 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")Signed-off-by Ryan Wanner <[email protected]>
Applied to at91-fixes, thanks!
Quoted 22 lines
---
changes in v2:
-corrected subject and tags
changes in v1:(quoted diff) +0
-1-corrected formatting issues arch/arm/boot/dts/sama5d2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/sama5d2.dtsi +1
-1@@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>, clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>; clock-names = "pclk", "gclk"; assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>; - assigned-parrents = <&pmc PMC_TYPE_GCK 55>; + assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>; status = "disabled"; };