tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()
Subsystems (3)
PATCH v2 1/1 tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()
From: Stefan Berger <[email protected]>
Return error code -ETIMEDOUT rather than '0' when waiting for the rtce_buf to be set has timed out.
--- drivers/char/tpm/tpm_ibmvtpm.c | 1 + 1 file changed, 1 insertion(+)
drivers/char/tpm/tpm_ibmvtpm.c +1 -0
@@ -687,6 +687,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, ibmvtpm->rtce_buf != NULL, HZ)) {dev_err (dev,"CRQ response timed out\n" ); + rc = -ETIMEDOUT ; goto init_irq_cleanup; }
Signature · 1 line
2.25.4
Quoted 10 lines · Stefan Berger
From: Stefan Berger <[email protected]>
Return error code
-ETIMEDOUTrather than '0' when waiting for thertce_bufto be set has timed out.Fixes d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")Reported-by Hulk Robot <[email protected]>Signed-off-by Wang Hai <[email protected]>Signed-off-by Stefan Berger <[email protected]>---
Thanks! Should I add
/Jarkko
Quoted 19 lines
drivers/char/tpm/tpm_ibmvtpm.c | 1 + 1 file changed, 1 insertion(+)drivers/char/tpm/tpm_ibmvtpm.c +1
-0@@ -687,6 +687,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, ibmvtpm->rtce_buf != NULL, HZ)) {dev_err (dev,"CRQ response timed out\n" ); + rc = -ETIMEDOUT ; goto init_irq_cleanup; }Signature · 1 line
2.25.4
Quoted 11 lines · Jarkko Sakkinen
Quoted 10 lines · Stefan Berger
From: Stefan Berger <[email protected]>
Return error code
-ETIMEDOUTrather than '0' when waiting for thertce_bufto be set has timed out.Fixes d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")Reported-by Hulk Robot <[email protected]>Signed-off-by Wang Hai <[email protected]>Signed-off-by Stefan Berger <[email protected]>---
Quoted 5 lines
Reviewed-by Jarkko Sakkinen <[email protected]>Thanks! Should I add
Cc [email protected] to this?
Yes, that would be good! Thank you!
Stefan
Quoted 23 lines
/Jarkko
Quoted 19 lines
drivers/char/tpm/tpm_ibmvtpm.c | 1 + 1 file changed, 1 insertion(+)drivers/char/tpm/tpm_ibmvtpm.c +1
-0@@ -687,6 +687,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, ibmvtpm->rtce_buf != NULL, HZ)) {dev_err (dev,"CRQ response timed out\n" ); + rc = -ETIMEDOUT ; goto init_irq_cleanup; }Signature · 1 line
2.25.4
Jarkko Sakkinen
maintainerQuoted 12 lines · Stefan Berger
Quoted 11 lines · Jarkko Sakkinen
Quoted 10 lines · Stefan Berger
From: Stefan Berger <[email protected]>
Return error code
-ETIMEDOUTrather than '0' when waiting for thertce_bufto be set has timed out.Fixes d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")Reported-by Hulk Robot <[email protected]>Signed-off-by Wang Hai <[email protected]>Signed-off-by Stefan Berger <[email protected]>---
Quoted 7 lines
Quoted 5 lines
Reviewed-by Jarkko Sakkinen <[email protected]>Thanks! Should I add
Cc [email protected] to this?Yes, that would be good! Thank you!
OK, it's applied.
Quoted 1 line
Stefan
/Jarkko