Skip to contentSkip to conversation

tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()

PATCH In review Stefan Berger 3 participants 4 messages Jan 26, 2021 – Jan 30, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()

From: Stefan Berger <[email protected]>

Return error code -ETIMEDOUT rather than '0' when waiting for the rtce_buf to be set has timed out.

Fixes d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
---
 drivers/char/tpm/tpm_ibmvtpm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/char/tpm/tpm_ibmvtpm.c +1 -0
index 994385bf37c0..813eb2cac0ce 100644
@@ -687,6 +687,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
 				ibmvtpm->rtce_buf != NULL,
 				HZ)) {
 		dev_err(dev, "CRQ response timed out\n");
+		rc = -ETIMEDOUT;
 		goto init_irq_cleanup;
 	}
 
Signature · 1 line
2.25.4
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 10 lines · Stefan Berger

From: Stefan Berger <[email protected]>

Return error code -ETIMEDOUT rather than '0' when waiting for the rtce_buf to be set has timed out.

Fixes d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")

---

Thanks! Should I add

Cc [email protected] to this?

/Jarkko

Quoted 19 lines
 drivers/char/tpm/tpm_ibmvtpm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/char/tpm/tpm_ibmvtpm.c +1 -0
index 994385bf37c0..813eb2cac0ce 100644
@@ -687,6 +687,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
 				ibmvtpm->rtce_buf != NULL,
 				HZ)) {
 		dev_err(dev, "CRQ response timed out\n");
+		rc = -ETIMEDOUT;
 		goto init_irq_cleanup;
 	}
 
Signature · 1 line
2.25.4
#2 lore raw
Quoted 11 lines · Jarkko Sakkinen
Quoted 10 lines · Stefan Berger

From: Stefan Berger <[email protected]>

Return error code -ETIMEDOUT rather than '0' when waiting for the rtce_buf to be set has timed out.

Fixes d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")

---

Quoted 5 lines

Thanks! Should I add

Cc [email protected] to this?

Yes, that would be good! Thank you!

   Stefan

Quoted 23 lines

/Jarkko

Quoted 19 lines
  drivers/char/tpm/tpm_ibmvtpm.c | 1 +
  1 file changed, 1 insertion(+)
drivers/char/tpm/tpm_ibmvtpm.c +1 -0
index 994385bf37c0..813eb2cac0ce 100644
@@ -687,6 +687,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
  				ibmvtpm->rtce_buf != NULL,
  				HZ)) {
  		dev_err(dev, "CRQ response timed out\n");
+		rc = -ETIMEDOUT;
  		goto init_irq_cleanup;
  	}
 
Signature · 1 line
2.25.4
maintainer
#3 lore raw
Quoted 12 lines · Stefan Berger
Quoted 11 lines · Jarkko Sakkinen
Quoted 10 lines · Stefan Berger

From: Stefan Berger <[email protected]>

Return error code -ETIMEDOUT rather than '0' when waiting for the rtce_buf to be set has timed out.

Fixes d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")

---

Quoted 7 lines
Quoted 5 lines

Thanks! Should I add

Cc [email protected] to this?

Yes, that would be good! Thank you!

OK, it's applied.

Quoted 1 line

    Stefan

/Jarkko