Skip to contentSkip to conversation

ARM: dts: rockchip: phycore: Remove 1.8 GHz operation point

PATCH In review Daniel Schultz 2 participants 6 messages Feb 13, 2018 – Feb 15, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 ARM: dts: rockchip: phycore: Remove 1.8 GHz operation point

Rockchip recommends to run the CPU cores only with operations points of 1.6 GHz or lower.

Removed the cpu0 node with too high operation points and use the default values instead.

---
 arch/arm/boot/dts/rk3288-phycore-som.dtsi | 20 --------------------
 1 file changed, 20 deletions(-)
arch/arm/boot/dts/rk3288-phycore-som.dtsi +0 -20
index 99cfae8..5eae477 100644
@@ -110,26 +110,6 @@
 	};
 };
 
-&cpu0 {
-	cpu0-supply = <&vdd_cpu>;
-	operating-points = <
-		/* KHz    uV */
-		1800000	1400000
-		1608000	1350000
-		1512000 1300000
-		1416000 1200000
-		1200000 1100000
-		1008000 1050000
-		 816000 1000000
-		 696000  950000
-		 600000  900000
-		 408000  900000
-		 312000  900000
-		 216000  900000
-		 126000  900000
-	>;
-};
-
 &emmc {
 	status = "okay";
 	bus-width = <8>;
Signature · 1 line
2.7.4
#1 lore raw

PATCH 2/3 ARM: dts: rockchip: phycore: Fix supply node for card's power

From: Wadim Egorov <[email protected]>

The card is powered by the RK818 switch vdd_sd which is supplied by VCC9 (VDD_3V3_IO).

---
 arch/arm/boot/dts/rk3288-phycore-rdk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/rk3288-phycore-rdk.dts +1 -1
index 1241cbc..ecb26f0 100644
@@ -265,7 +265,7 @@
 	disable-wp;
 	pinctrl-names = "default";
 	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
-	vmmc-supply = <&vdd_io_sd>;
+	vmmc-supply = <&vdd_sd>;
 	vqmmc-supply = <&vdd_io_sd>;
 	status = "okay";
 };
Signature · 1 line
2.7.4
#2 lore raw

PATCH 3/3 ARM: dts: rockchip: phycore: Support UHS mode for SD card on phyCORE-RK3288 RDK

In reply to Daniel Schultz

From: Wadim Egorov <[email protected]>

The phyCORE-RK3288 RDK could enable SD3.0 card but need vdd_io_sd to support the voltage range from 1.8V to 3.3V.
And we have also to add relevant UHS modes to the sdmmc node. Let's also turn off the vdd_io_sd regulator in suspend state.

---
 arch/arm/boot/dts/rk3288-phycore-rdk.dts  | 4 ++++
 arch/arm/boot/dts/rk3288-phycore-som.dtsi | 5 ++---
 2 files changed, 6 insertions(+), 3 deletions(-)
arch/arm/boot/dts/rk3288-phycore-rdk.dts +4 -0
index ecb26f0..985743f 100644
@@ -265,6 +265,10 @@
 	disable-wp;
 	pinctrl-names = "default";
 	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
+	sd-uhs-sdr12;
+	sd-uhs-sdr25;
+	sd-uhs-sdr50;
+	sd-uhs-sdr104;
 	vmmc-supply = <&vdd_sd>;
 	vqmmc-supply = <&vdd_io_sd>;
 	status = "okay";
arch/arm/boot/dts/rk3288-phycore-som.dtsi +2 -3
index 5eae477..f13bcb1 100644
@@ -336,11 +336,10 @@
 				regulator-name = "vdd_io_sd";
 				regulator-always-on;
 				regulator-boot-on;
-				regulator-min-microvolt = <3300000>;
+				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <3300000>;
 				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <3300000>;
+					regulator-off-in-suspend;
 				};
 			};
 		};
Signature · 1 line
2.7.4
maintainer
#3 lore raw
In reply to Daniel Schultz

Am Dienstag, 13. Februar 2018, 10:44:32 CET schrieb Daniel Schultz:

Quoted 7 lines

Rockchip recommends to run the CPU cores only with operations points of 1.6 GHz or lower.

Removed the cpu0 node with too high operation points and use the default values instead.

applied all 3 for 4.17

Thanks
Heiko

#4 lore raw
Quoted 10 lines · Heiko Stübner

Am Dienstag, 13. Februar 2018, 10:44:32 CET schrieb Daniel Schultz:

Quoted 7 lines

Rockchip recommends to run the CPU cores only with operations points of 1.6 GHz or lower.

Removed the cpu0 node with too high operation points and use the default values instead.

applied all 3 for 4.17

Thanks! I think I should have mentioned this earlier, but can you please add
    ARM: dts: rockchip: phycore: Remove 1.8 GHz operation point to the stable tree v4.14?

Signature · 3 lines
Mit freundlichen Grüßen,
With best regards,
  Daniel Schultz
maintainer
#5 lore raw

Hi Daniel,

Am Mittwoch, 14. Februar 2018, 16:32:44 CET schrieb Daniel Schultz:

Quoted 8 lines · Heiko St?bner
Quoted 7 lines

Am Dienstag, 13. Februar 2018, 10:44:32 CET schrieb Daniel Schultz:

Quoted 6 lines

Rockchip recommends to run the CPU cores only with operations points of 1.6 GHz or lower.

Removed the cpu0 node with too high operation points and use the default values instead.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

applied all 3 for 4.17

Thanks! I think I should have mentioned this earlier, but can you please add
ARM: dts: rockchip: phycore: Remove 1.8 GHz operation point
to the stable tree v4.14?

I've moved that patch to the fixes branch and added the necessary Fixes and cc-stable tags, so it should eventually reach stable kernels as well.

Heiko