drm/mipi-dsi: add mipi_dsi_shutdown_peripheral_multi
Subsystems (2)
PATCH 1/1 drm/mipi-dsi: add mipi_dsi_shutdown_peripheral_multi
Add mipi_dsi_shutdown_peripheral_multi function and mark mipi_dsi_shutdown_peripheral function as deprecated.
---
Please refer: https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/#26719778
Build and boot tested with QEMU.
drivers/gpu/drm/drm_mipi_dsi.c | 28 ++++++++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 1 + 2 files changed, 29 insertions(+)
drivers/gpu/drm/drm_mipi_dsi.c +28 -0
@@ -587,6 +587,9 @@ EXPORT_SYMBOL(mipi_dsi_create_packet);* mipi_dsi_shutdown_peripheral() - sends a Shutdown Peripheral command * @dsi: DSI peripheral device * +* This function is deprecated. Use mipi_dsi_shutdown_peripheral_multi() +* instead. +* * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_shutdown_peripheral (struct mipi_dsi_device *dsi)
@@ -1980,6 +1983,31 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, }EXPORT_SYMBOL (mipi_dsi_dcs_set_tear_scanline_multi); +/** +* mipi_dsi_shutdown_peripheral_multi() - sends a Shutdown Peripheral command +* @ctx: Context for multiple DSI transactions +* +* Like mipi_dsi_shutdown_peripheral() but deals with errors in a way that +* makes it convienient to make seeral calls in a row. +*/ +void mipi_dsi_shutdown_peripheral_multi (struct mipi_dsi_multi_context *ctx) +{ +struct mipi_dsi_device *dsi = ctx->dsi; +struct device *dev = &dsi->dev; +int ret; + +if (ctx->accum_err) +return ; + + ret =mipi_dsi_shutdown_peripheral (dsi); +if (ret <0 ) { + ctx->accum_err = ret; +dev_err (dev,"Failed to shutdown peripheral: %d\n" , + ctx->accum_err); + } +} +EXPORT_SYMBOL (mipi_dsi_shutdown_peripheral_multi); +static int mipi_dsi_drv_probe (struct device *dev) {struct mipi_dsi_driver *drv =to_mipi_dsi_driver (dev->driver);
include/drm/drm_mipi_dsi.h +1 -0
@@ -389,6 +389,7 @@ void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx,void mipi_dsi_dcs_set_tear_scanline_multi (struct mipi_dsi_multi_context *ctx,u16 scanline);void mipi_dsi_dcs_set_tear_off_multi (struct mipi_dsi_multi_context *ctx); +void mipi_dsi_shutdown_peripheral_multi (struct mipi_dsi_multi_context *ctx);/** * mipi_dsi_generic_write_seq_multi - transmit data using a generic write packet
--
2.52.0
Quoted 71 lines · Avinal Kumar
Add
mipi_dsi_shutdown_peripheral_multifunction and markmipi_dsi_shutdown_peripheralfunction as deprecated.Signed-off-by Avinal Kumar <[email protected]>---
Please refer: https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/#26719778
Build and boot tested with QEMU.drivers/gpu/drm/drm_mipi_dsi.c | 28 ++++++++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 1 + 2 files changed, 29 insertions(+)drivers/gpu/drm/drm_mipi_dsi.c +28
-0@@ -587,6 +587,9 @@ EXPORT_SYMBOL(mipi_dsi_create_packet);* mipi_dsi_shutdown_peripheral() - sends a Shutdown Peripheral command * @dsi: DSI peripheral device * +* This function is deprecated. Use mipi_dsi_shutdown_peripheral_multi() +* instead. +* * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_shutdown_peripheral (struct mipi_dsi_device *dsi)@@ -1980,6 +1983,31 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, }EXPORT_SYMBOL (mipi_dsi_dcs_set_tear_scanline_multi); +/** +* mipi_dsi_shutdown_peripheral_multi() - sends a Shutdown Peripheral command +* @ctx: Context for multiple DSI transactions +* +* Like mipi_dsi_shutdown_peripheral() but deals with errors in a way that +* makes it convienient to make seeral calls in a row. +*/ +void mipi_dsi_shutdown_peripheral_multi (struct mipi_dsi_multi_context *ctx) +{ +struct mipi_dsi_device *dsi = ctx->dsi; +struct device *dev = &dsi->dev; +int ret; + +if (ctx->accum_err) +return ; + + ret =mipi_dsi_shutdown_peripheral (dsi); +if (ret <0 ) { + ctx->accum_err = ret; +dev_err (dev,"Failed to shutdown peripheral: %d\n" , + ctx->accum_err); + } +} +EXPORT_SYMBOL (mipi_dsi_shutdown_peripheral_multi); +static int mipi_dsi_drv_probe (struct device *dev) {struct mipi_dsi_driver *drv =to_mipi_dsi_driver (dev->driver);include/drm/drm_mipi_dsi.h +1
-1@@ -389,6 +389,7 @@ void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx,void mipi_dsi_dcs_set_tear_scanline_multi (struct mipi_dsi_multi_context *ctx,u16 scanline);void mipi_dsi_dcs_set_tear_off_multi (struct mipi_dsi_multi_context *ctx); +void mipi_dsi_shutdown_peripheral_multi (struct mipi_dsi_multi_context *ctx);/** * mipi_dsi_generic_write_seq_multi - transmit data using a generic write packet --
Quoted 2 lines
2.52.0
Looks good, please send a multi-patch patchset with "drm/panel: panasonic-vvx10f034n00: transition to mipi_dsi wrapped functions" updated to use this function aswell.
If you want to use a simpler way to generate patchsets, please have a look the b4 tool.
Neil