mmc: omap_hsmmc: Add guards around omap_hsmmc_get_cfg()
PATCH 1/1 mmc: omap_hsmmc: Add guards around omap_hsmmc_get_cfg()
We only call the function omap_hsmmc_get_cfg in the case of OMAP34XX or when we have to iodelay recalibration. Add guards for these checks as clang will otherwise warn.
---
Aside, Lokesh, can you please add drivers/mmc/omap_hsmmc.c to the general TI entry MAINTAINERS entry? Thanks!
--- drivers/mmc/omap_hsmmc.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/mmc/omap_hsmmc.c +3 -0
@@ -175,6 +175,8 @@ static inline struct omap_hsmmc_data *omap_hsmmc_get_data(struct mmc *mmc)return (struct omap_hsmmc_data *)mmc->priv;#endif } + +#if defined(CONFIG_OMAP34XX ) || defined(CONFIG_IODELAY_RECALIBRATION )static inline struct mmc_config *omap_hsmmc_get_cfg (struct mmc *mmc) {#if CONFIG_IS_ENABLED (DM_MMC )
@@ -184,6 +186,7 @@ static inline struct mmc_config *omap_hsmmc_get_cfg(struct mmc *mmc)return &((struct omap_hsmmc_data *)mmc->priv)->cfg; #endif } +#endif #if defined(OMAP_HSMMC_USE_GPIO ) && !CONFIG_IS_ENABLED (DM_MMC )static int omap_mmc_setup_gpio_in (int gpio,const char *label)
Signature · 1 line
2.17.1
PATCH 1/1 mmc: omap_hsmmc: Add guards around omap_hsmmc_get_cfg()
Quoted 34 lines
Subject: [PATCH] mmc:
omap_hsmmc: Add guards aroundomap_hsmmc_get_cfg()We only call the function
omap_hsmmc_get_cfgin the case of OMAP34XX or when we have to iodelay recalibration. Add guards for these checks as clang will otherwise warn.Cc Peng Fan <[email protected]>Cc Lokesh Vutla <[email protected]>Signed-off-by Tom Rini <[email protected]>---
Aside, Lokesh, can you please adddrivers/mmc/omap_hsmmc.cto the general TI entryMAINTAINERSentry? Thanks!--- drivers/mmc/omap_hsmmc.c | 3 +++ 1 file changed, 3 insertions(+)drivers/mmc/omap_hsmmc.c +2
-0@@ -175,6 +175,8 @@ static inline struct omap_hsmmc_data *omap_hsmmc_get_data(struct mmc *mmc)return (struct omap_hsmmc_data *)mmc->priv;#endif } + +#if defined(CONFIG_OMAP34XX ) || defined(CONFIG_IODELAY_RECALIBRATION )static inline struct mmc_config *omap_hsmmc_get_cfg (struct mmc *mmc){ #if
CONFIG_IS_ENABLED(DM_MMC)@@ -184,6 +186,7 @@ static inline structmmc_config*omap_hsmmc_get_cfg(struct mmc *mmc)drivers/mmc/omap_hsmmc.c +1
-0return &((struct omap_hsmmc_data *)mmc->priv)->cfg;#endif } +#endif #if defined(OMAP_HSMMC_USE_GPIO )
Quoted 4 lines
&& !CONFIG_IS_ENABLED(DM_MMC) static int
omap_mmc_setup_gpio_in(int gpio, const char *label)--
2.17.1
PATCH 1/1 mmc: omap_hsmmc: Add guards around omap_hsmmc_get_cfg()
In reply to Tom RiniQuoted 7 lines · Tom Rini
We only call the function
omap_hsmmc_get_cfgin the case of OMAP34XX or when we have to iodelay recalibration. Add guards for these checks as clang will otherwise warn.Cc Peng Fan <[email protected]>Cc Lokesh Vutla <[email protected]>Signed-off-by Tom Rini <[email protected]>
Quoted 3 lines
---
Aside, Lokesh, can you please adddrivers/mmc/omap_hsmmc.cto the general TI entryMAINTAINERSentry? Thanks!
We have a subsystem maintainer for MMC. IIUC, all the patches should go through subsystem if one is available, so I intentionally did not add omap_hsmmc under TI. Is my understanding wrong?
Thanks and regards,
Lokesh
PATCH 1/1 mmc: omap_hsmmc: Add guards around omap_hsmmc_get_cfg()
Quoted 13 lines · Lokesh Vutla
Quoted 7 lines · Tom Rini
We only call the function
omap_hsmmc_get_cfgin the case of OMAP34XX or when we have to iodelay recalibration. Add guards for these checks as clang will otherwise warn.Cc Peng Fan <[email protected]>Cc Lokesh Vutla <[email protected]>Signed-off-by Tom Rini <[email protected]>Reviewed-by Lokesh Vutla <[email protected]>
Quoted 7 lines
Quoted 3 lines
---
Aside, Lokesh, can you please adddrivers/mmc/omap_hsmmc.cto the general TI entryMAINTAINERSentry? Thanks!We have a subsystem maintainer for MMC. IIUC, all the patches should go through subsystem if one is available, so I intentionally did not add
omap_hsmmcunder TI. Is my understanding wrong?
Yes. While there is a subsystem maintainer, they aren't going to know the IP-block quirks as well as the custodian for a given SoC, so individual drivers should be listed under the SoC/arch entry as well. get_maintainers.pl will list both when queried. Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200605/32b5bb43/attachment.sig>
PATCH 1/1 mmc: omap_hsmmc: Add guards around omap_hsmmc_get_cfg()
In reply to Tom RiniQuoted 7 lines · Tom Rini
We only call the function
omap_hsmmc_get_cfgin the case of OMAP34XX or when we have to iodelay recalibration. Add guards for these checks as clang will otherwise warn.Cc Peng Fan <[email protected]>Cc Lokesh Vutla <[email protected]>Signed-off-by Tom Rini <[email protected]>
Applied to u-boot-ti next.
Thanks and regards,
Lokesh