Skip to contentSkip to conversation

board: xilinx/zynqmp: Remove 1-second delay at boot

PATCH New Mike Looijmans 2 participants 2 messages May 26, 2020 – May 29, 2020 Arm/Zynq architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board: xilinx/zynqmp: Remove 1-second delay at boot

SPL boot is slow on the ZynqMP because of this delay. The initialization done in psu_init no longer requires an external delay, so this can be removed to speed up the SPL boot flow considerably.

---
 board/xilinx/zynqmp/zynqmp.c | 4 ----
 1 file changed, 4 deletions(-)
board/xilinx/zynqmp/zynqmp.c +0 -4
index cb72914adb..d00235f236 100644
@@ -32,7 +32,6 @@
 #include <zynqmp_firmware.h>
 #include <g_dnl.h>
 #include <linux/bitops.h>
-#include <linux/delay.h>
 #include <linux/sizes.h>
 #include "../common/board.h"
 
@@ -334,9 +333,6 @@ int board_early_init_f(void)
 	ret = psu_init();
 	if (ret)
 		return ret;
-
-	/* Delay is required for clocks to be propagated */
-	udelay(1000000);
 #endif
 
 #ifdef CONFIG_DEBUG_UART
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 board: xilinx/zynqmp: Remove 1-second delay at boot

Quoted 23 lines · Mike Looijmans

SPL boot is slow on the ZynqMP because of this delay. The initialization done in psu_init no longer requires an external delay, so this can be removed to speed up the SPL boot flow considerably.

---
 board/xilinx/zynqmp/zynqmp.c | 4 ----
 1 file changed, 4 deletions(-)
board/xilinx/zynqmp/zynqmp.c +0 -1
index cb72914adb..d00235f236 100644
@@ -32,7 +32,6 @@
 #include <zynqmp_firmware.h>
 #include <g_dnl.h>
 #include <linux/bitops.h>
-#include <linux/delay.h>
 #include <linux/sizes.h>
 #include "../common/board.h"
 

board/xilinx/zynqmp/zynqmp.c int board_early_init_f(void) · line 338

Quoted 9 lines
board/xilinx/zynqmp/zynqmp.c +0 -3
@@ -334,9 +333,6 @@ int board_early_init_f(void)
 	ret = psu_init();
 	if (ret)
 		return ret;
-
-	/* Delay is required for clocks to be propagated */
-	udelay(1000000);
 #endif
 
 #ifdef CONFIG_DEBUG_UART

Mike reported me that removing this 1s is causing issue in SD boot mode that's why I am not applying this patch till we root caused it.

Thanks,
Michal