Skip to contentSkip to conversation

arm64: dts: rockchip: add more cpu operating points for RK3328

PATCH Superseded Leonidas P. Papadakos 4 participants 4 messages Mar 1, 2019 – Mar 5, 2019 2 messages not in the archive

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: add more cpu operating points for RK3328

This allows for greater max frequency on rk3328 boards, increasing performance.

It has been included in Armbian (a linux distibution for ARM boards) for a while now without any reported issues

https://github.com/armbian/build/blob/master/patch/kernel/rockchip64-default/enable-1392mhz-opp.patch
https://github.com/armbian/build/blob/master/patch/kernel/rockchip64-default/enable-1512mhz-opp.patch

---
 arch/arm64/boot/dts/rockchip/rk3328.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/rockchip/rk3328.dtsi +14 -0
index 84f14b132..18caef3c3 100644
@@ -123,6 +123,20 @@
 			opp-microvolt = <1300000>;
 			clock-latency-ns = <40000>;
 		};
+		opp-1392000000 {
+			opp-hz = /bits/ 64 <1392000000>;
+			opp-microvolt = <1350000 1350000 1350000>;
+			opp-microvolt-L0 = <1350000 1350000 1350000>;
+			opp-microvolt-L1 = <1325000 1325000 1325000>;
+			clock-latency-ns = <40000>;
+		};
+		opp-1512000000 {
+			opp-hz = /bits/ 64 <1512000000>;
+			opp-microvolt = <1450000 1450000 1450000>;
+			opp-microvolt-L0 = <1450000 1450000 1450000>;
+			opp-microvolt-L1 = <1425000 1425000 1425000>;
+			clock-latency-ns = <40000>;
+		};
 	};
 
 	amba {
Signature · 1 line
2.21.0

A message that is not in the archive (sent off-list or not yet received): 20190301175452.6701-1-papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

Hi,

Am Freitag, 1. März 2019, 18:54:53 CET schrieb Leonidas P. Papadakos:

Quoted 21 lines

This allows for greater max frequency on rk3328 boards, increasing performance.

It has been included in Armbian (a linux distibution for ARM boards) for a while now without any reported issues

https://github.com/armbian/build/blob/master/patch/kernel/rockchip64-default/enable-1392mhz-opp.patch
https://github.com/armbian/build/blob/master/patch/kernel/rockchip64-default/enable-1512mhz-opp.patch

---
 arch/arm64/boot/dts/rockchip/rk3328.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/rockchip/rk3328.dtsi +0 -0
index 84f14b132..18caef3c3 100644

arch/arm64/boot/dts/rockchip/rk3328.dtsi line 130

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3328.dtsi +5 -0
@@ -123,6 +123,20 @@
 			opp-microvolt = <1300000>;
 			clock-latency-ns = <40000>;
 		};
+		opp-1392000000 {
+			opp-hz = /bits/ 64 <1392000000>;
+			opp-microvolt = <1350000 1350000 1350000>;
+			opp-microvolt-L0 = <1350000 1350000 1350000>;
+			opp-microvolt-L1 = <1325000 1325000 1325000>;

I checked Rockchip's productpage and the chip really seems to be rated up to 1.5GHz, but you should get rid of opp-microvolt-Lx options as these are still vendor-specific regarding the leakage handling.

While on it, when all microvolt elements are the same, using the absolute value instead of "preferred min max" saves a bit of space similar to the other OPPs in the file.

Thanks
Heiko

Quoted 13 lines
arch/arm64/boot/dts/rockchip/rk3328.dtsi +9 -0
+			clock-latency-ns = <40000>;
+		};
+		opp-1512000000 {
+			opp-hz = /bits/ 64 <1512000000>;
+			opp-microvolt = <1450000 1450000 1450000>;
+			opp-microvolt-L0 = <1450000 1450000 1450000>;
+			opp-microvolt-L1 = <1425000 1425000 1425000>;
+			clock-latency-ns = <40000>;
+		};
 	};
 
 	amba {
#3 lore raw
Quoted 28 lines · Heiko Stuebner

Hi,

Am Freitag, 1. März 2019, 18:54:53 CET schrieb Leonidas P. Papadakos:

Quoted 25 lines

This allows for greater max frequency on rk3328 boards, increasing performance.

It has been included in Armbian (a linux distibution for ARM boards) for a while now without any reported issues

https://github.com/armbian/build/blob/master/patch/kernel/rockchip64-default/enable-1392mhz-opp.patch
https://github.com/armbian/build/blob/master/patch/kernel/rockchip64-default/enable-1512mhz-opp.patch

---
 arch/arm64/boot/dts/rockchip/rk3328.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/rockchip/rk3328.dtsi +1 -0
index 84f14b132..18caef3c3 100644
@@ -123,6 +123,20 @@
 			opp-microvolt = <1300000>;
 			clock-latency-ns = <40000>;
 		};
+		opp-1392000000 {
Quoted 8 lines

arch/arm64/boot/dts/rockchip/rk3328.dtsi line 130

Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3328.dtsi +4 -0
+			opp-hz = /bits/ 64 <1392000000>;
+			opp-microvolt = <1350000 1350000 1350000>;
+			opp-microvolt-L0 = <1350000 1350000 1350000>;
+			opp-microvolt-L1 = <1325000 1325000 1325000>;

I checked Rockchip's productpage and the chip really seems to be rated up to 1.5GHz, but you should get rid of opp-microvolt-Lx options as these are still vendor-specific regarding the leakage handling.

The datasheet at [1] lists Max CPU frequency of A53 as 1.4 Ghz in Table 3-2 Recommended operating condition, is there a newer datasheet that lists 1.5 Ghz as recommended max?

[1] http://opensource.rock-chips.com/images/d/d7/Rockchip_RK3328_Datasheet_V1.1-20170309.pdf

Regards,
Jonas

Quoted 22 lines

While on it, when all microvolt elements are the same, using the absolute value instead of "preferred min max" saves a bit of space similar to the other OPPs in the file.

Thanks
Heiko

Quoted 13 lines
arch/arm64/boot/dts/rockchip/rk3328.dtsi +9 -0
+			clock-latency-ns = <40000>;
+		};
+		opp-1512000000 {
+			opp-hz = /bits/ 64 <1512000000>;
+			opp-microvolt = <1450000 1450000 1450000>;
+			opp-microvolt-L0 = <1450000 1450000 1450000>;
+			opp-microvolt-L1 = <1425000 1425000 1425000>;
+			clock-latency-ns = <40000>;
+		};
 	};
 
 	amba {

A message that is not in the archive (sent off-list or not yet received): AM3PR03MB0966D92B504944D7C6D06123AC760-XQTXrJX/[email protected]

#5 lore raw

Re: [PATCH] arm64: dts: rockchip: add more cpu operating points for RK3328【请注意,邮件由[email protected]代发】

Hi, All:

       The 1.4 Ghz and 1.5 Ghz frequency is not stable for some chips of rk3328, so  we recommend use 1.3 Ghz as the max frequency for rk3328 SoCs.

        And the max voltage of vdd_cpu is 1.35V, do not exceed that.

Quoted 63 lines · Jonas Karlman
Quoted 28 lines · Heiko Stuebner

Hi,

Am Freitag, 1. März 2019, 18:54:53 CET schrieb Leonidas P. Papadakos:

Quoted 25 lines

This allows for greater max frequency on rk3328 boards, increasing performance.

It has been included in Armbian (a linux distibution for ARM boards) for a while now without any reported issues

https://github.com/armbian/build/blob/master/patch/kernel/rockchip64-default/enable-1392mhz-opp.patch
https://github.com/armbian/build/blob/master/patch/kernel/rockchip64-default/enable-1512mhz-opp.patch

---
  arch/arm64/boot/dts/rockchip/rk3328.dtsi | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
arch/arm64/boot/dts/rockchip/rk3328.dtsi +1 -0
index 84f14b132..18caef3c3 100644
@@ -123,6 +123,20 @@
  			opp-microvolt = <1300000>;
  			clock-latency-ns = <40000>;
  		};
+		opp-1392000000 {
Quoted 8 lines

arch/arm64/boot/dts/rockchip/rk3328.dtsi line 130

Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3328.dtsi +4 -0
+			opp-hz = /bits/ 64 <1392000000>;
+			opp-microvolt = <1350000 1350000 1350000>;
+			opp-microvolt-L0 = <1350000 1350000 1350000>;
+			opp-microvolt-L1 = <1325000 1325000 1325000>;

I checked Rockchip's productpage and the chip really seems to be rated up to 1.5GHz, but you should get rid of opp-microvolt-Lx options as these are still vendor-specific regarding the leakage handling.

The datasheet at [1] lists Max CPU frequency of A53 as 1.4 Ghz in Table 3-2 Recommended operating condition, is there a newer datasheet that lists 1.5 Ghz as recommended max?

[1] http://opensource.rock-chips.com/images/d/d7/Rockchip_RK3328_Datasheet_V1.1-20170309.pdf

Regards,
Jonas

Quoted 18 lines

While on it, when all microvolt elements are the same, using the absolute value instead of "preferred min max" saves a bit of space similar to the other OPPs in the file.

Thanks
Heiko

Quoted 11 lines
arch/arm64/boot/dts/rockchip/rk3328.dtsi +9 -0
+			clock-latency-ns = <40000>;
+		};
+		opp-1512000000 {
+			opp-hz = /bits/ 64 <1512000000>;
+			opp-microvolt = <1450000 1450000 1450000>;
+			opp-microvolt-L0 = <1450000 1450000 1450000>;
+			opp-microvolt-L1 = <1425000 1425000 1425000>;
+			clock-latency-ns = <40000>;
+		};
  	};
 
Quoted 10 lines
Quoted 2 lines

arch/arm64/boot/dts/rockchip/rk3328.dtsi line 142

Quoted 2 lines
arch/arm64/boot/dts/rockchip/rk3328.dtsi +0 -0
  	amba {

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip