Skip to contentSkip to conversation

board: ti: am62ax: env: Use default MMC related args

PATCH In review Andrew Davis 5 participants 5 messages May 22, 2025 – Jun 5, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board: ti: am62ax: env: Use default MMC related args

There are common MMC args for TI plats in include/environment/ti/mmc.env. Since we already include this, there is no need to redefine these MMC vars. Use the defaults.

This seems like something that could have been done while refactoring these vars in the first place as it happened after this AM62A file was available hence the fixes tag.

Fixes 3709b529156e ("env: ti: mmc.env: Move mmc related args to common place")
---
 board/ti/am62ax/am62ax.env | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)
board/ti/am62ax/am62ax.env +1 -14
index 96d9e1e2797..dc7af56a6f7 100644
@@ -17,18 +17,5 @@ mmcdev=1
 bootpart=1:2
 bootdir=/boot
 rd_spec=-
-init_mmc=run args_all args_mmc
-get_overlay_mmc=
-	fdt address ${fdtaddr};
-	fdt resize 0x100000;
-	for overlay in $name_overlays;
-	do;
-	load mmc ${bootpart} ${dtboaddr} ${bootdir}/${overlay} &&
-	fdt apply ${dtboaddr};
-	done;
-get_kern_mmc=load mmc ${bootpart} ${loadaddr}
-	${bootdir}/${name_kern}
-get_fit_mmc=load mmc ${bootpart} ${addr_fit}
-	${bootdir}/${name_fit}
-partitions=name=rootfs,start=0,size=-,uuid=${uuid_gpt_rootfs}
+
 rproc_fw_binaries= 0 /lib/firmware/am62a-mcu-r5f0_0-fw 1 /lib/firmware/am62a-c71_0-fw
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw

Hi Andrew

Quoted 29 lines · Andrew Davis

There are common MMC args for TI plats in include/environment/ti/mmc.env. Since we already include this, there is no need to redefine these MMC vars. Use the defaults.

This seems like something that could have been done while refactoring these vars in the first place as it happened after this AM62A file was available hence the fixes tag.

Fixes 3709b529156e ("env: ti: mmc.env: Move mmc related args to common place")
---
 board/ti/am62ax/am62ax.env | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)
board/ti/am62ax/am62ax.env +0 -6
index 96d9e1e2797..dc7af56a6f7 100644
@@ -17,18 +17,5 @@ mmcdev=1
 bootpart=1:2
 bootdir=/boot
 rd_spec=-
-init_mmc=run args_all args_mmc
-get_overlay_mmc=
-	fdt address ${fdtaddr};
-	fdt resize 0x100000;
-	for overlay in $name_overlays;
-	do;

board/ti/am62ax/am62ax.env mmcdev=1 · line 21

Quoted 10 lines
board/ti/am62ax/am62ax.env +1 -8
-	load mmc ${bootpart} ${dtboaddr} ${bootdir}/${overlay} &&
-	fdt apply ${dtboaddr};
-	done;
-get_kern_mmc=load mmc ${bootpart} ${loadaddr}
-	${bootdir}/${name_kern}
-get_fit_mmc=load mmc ${bootpart} ${addr_fit}
-	${bootdir}/${name_fit}
-partitions=name=rootfs,start=0,size=-,uuid=${uuid_gpt_rootfs}
+
 rproc_fw_binaries= 0 /lib/firmware/am62a-mcu-r5f0_0-fw 1 /lib/firmware/am62a-c71_0-fw
Signature · 2 lines
Thanking You
Neha Malcom Francis
Acked-by on v1 1/1
#2 lore raw
In reply to Andrew Davis

Hi Andrew,

Quoted 11 lines · Andrew Davis

There are common MMC args for TI plats in include/environment/ti/mmc.env. Since we already include this, there is no need to redefine these MMC vars. Use the defaults.

This seems like something that could have been done while refactoring these vars in the first place as it happened after this AM62A file was available hence the fixes tag.

Fixes 3709b529156e ("env: ti: mmc.env: Move mmc related args to common place")
Quoted 28 lines
---
  board/ti/am62ax/am62ax.env | 15 +--------------
  1 file changed, 1 insertion(+), 14 deletions(-)
board/ti/am62ax/am62ax.env +1 -14
index 96d9e1e2797..dc7af56a6f7 100644
@@ -17,18 +17,5 @@ mmcdev=1
  bootpart=1:2
  bootdir=/boot
  rd_spec=-
-init_mmc=run args_all args_mmc
-get_overlay_mmc=
-	fdt address ${fdtaddr};
-	fdt resize 0x100000;
-	for overlay in $name_overlays;
-	do;
-	load mmc ${bootpart} ${dtboaddr} ${bootdir}/${overlay} &&
-	fdt apply ${dtboaddr};
-	done;
-get_kern_mmc=load mmc ${bootpart} ${loadaddr}
-	${bootdir}/${name_kern}
-get_fit_mmc=load mmc ${bootpart} ${addr_fit}
-	${bootdir}/${name_fit}
-partitions=name=rootfs,start=0,size=-,uuid=${uuid_gpt_rootfs}
+
  rproc_fw_binaries= 0 /lib/firmware/am62a-mcu-r5f0_0-fw 1 /lib/firmware/am62a-c71_0-fw
Reviewed-by on v1 1/1
#3 lore raw
In reply to Andrew Davis

Hi Andrew,

Quoted 11 lines · Andrew Davis

There are common MMC args for TI plats in include/environment/ti/mmc.env. Since we already include this, there is no need to redefine these MMC vars. Use the defaults.

This seems like something that could have been done while refactoring these vars in the first place as it happened after this AM62A file was available hence the fixes tag.

Fixes 3709b529156e ("env: ti: mmc.env: Move mmc related args to common place")

Thanks for the patch.

#4 lore raw
In reply to Andrew Davis
Quoted 9 lines · Andrew Davis

There are common MMC args for TI plats in include/environment/ti/mmc.env. Since we already include this, there is no need to redefine these MMC vars. Use the defaults.

This seems like something that could have been done while refactoring these vars in the first place as it happened after this AM62A file was available hence the fixes tag.

[...]

Applied to u-boot/master, thanks!

[1/1] board: ti: am62ax: env: Use default MMC related args

      commit: 5262b3ab9329b702f98ef61e76b0c78eb8c76f24
Signature · 1 line
Tom