board: ti: am62ax: env: Use default MMC related args
PATCH 1/1 board: ti: am62ax: env: Use default MMC related args
There are common MMC args for TI plats in include/environment/ti/mmc.env. Since we already include this, there is no need to redefine these MMC vars. Use the defaults.
This seems like something that could have been done while refactoring these vars in the first place as it happened after this AM62A file was available hence the fixes tag.
--- board/ti/am62ax/am62ax.env | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-)
board/ti/am62ax/am62ax.env +1 -14
@@ -17,18 +17,5 @@ mmcdev=1 bootpart=1:2 bootdir=/boot rd_spec=- -init_mmc=run args_all args_mmc -get_overlay_mmc= - fdt address ${fdtaddr}; - fdt resize 0x100000; - for overlay in $name_overlays; - do; - load mmc ${bootpart} ${dtboaddr} ${bootdir}/${overlay} && - fdt apply ${dtboaddr}; - done; -get_kern_mmc=load mmc ${bootpart} ${loadaddr} - ${bootdir}/${name_kern} -get_fit_mmc=load mmc ${bootpart} ${addr_fit} - ${bootdir}/${name_fit} -partitions=name=rootfs,start=0,size=-,uuid=${uuid_gpt_rootfs} + rproc_fw_binaries= 0 /lib/firmware/am62a-mcu-r5f0_0-fw 1 /lib/firmware/am62a-c71_0-fw
Signature · 1 line
2.39.2
Hi Andrew
Quoted 29 lines · Andrew Davis
There are common MMC args for TI plats in
include/environment/ti/mmc.env. Since we already include this, there is no need to redefine these MMC vars. Use the defaults.This seems like something that could have been done while refactoring these vars in the first place as it happened after this AM62A file was available hence the fixes tag.
Reported-by Chirag Shilwant <[email protected]>Fixes 3709b529156e ("env: ti: mmc.env: Move mmc related args to common place")Signed-off-by Andrew Davis <[email protected]>--- board/ti/am62ax/am62ax.env | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-)board/ti/am62ax/am62ax.env +0
-6@@ -17,18 +17,5 @@ mmcdev=1 bootpart=1:2 bootdir=/boot rd_spec=- -init_mmc=run args_all args_mmc -get_overlay_mmc= - fdt address ${fdtaddr}; - fdt resize 0x100000; - for overlay in $name_overlays; - do;
board/ti/am62ax/am62ax.env mmcdev=1 · line 21
Quoted 10 lines
board/ti/am62ax/am62ax.env +1
-8- load mmc ${bootpart} ${dtboaddr} ${bootdir}/${overlay} && - fdt apply ${dtboaddr}; - done; -get_kern_mmc=load mmc ${bootpart} ${loadaddr} - ${bootdir}/${name_kern} -get_fit_mmc=load mmc ${bootpart} ${addr_fit} - ${bootdir}/${name_fit} -partitions=name=rootfs,start=0,size=-,uuid=${uuid_gpt_rootfs} + rproc_fw_binaries= 0 /lib/firmware/am62a-mcu-r5f0_0-fw 1 /lib/firmware/am62a-c71_0-fw
Signature · 2 lines
Thanking You Neha Malcom Francis
Hi Andrew,
Quoted 11 lines · Andrew Davis
There are common MMC args for TI plats in
include/environment/ti/mmc.env. Since we already include this, there is no need to redefine these MMC vars. Use the defaults.This seems like something that could have been done while refactoring these vars in the first place as it happened after this AM62A file was available hence the fixes tag.
Reported-by Chirag Shilwant <[email protected]>Fixes 3709b529156e ("env: ti: mmc.env: Move mmc related args to common place")Signed-off-by Andrew Davis <[email protected]>
Quoted 28 lines
--- board/ti/am62ax/am62ax.env | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-)board/ti/am62ax/am62ax.env +1
-14@@ -17,18 +17,5 @@ mmcdev=1 bootpart=1:2 bootdir=/boot rd_spec=- -init_mmc=run args_all args_mmc -get_overlay_mmc= - fdt address ${fdtaddr}; - fdt resize 0x100000; - for overlay in $name_overlays; - do; - load mmc ${bootpart} ${dtboaddr} ${bootdir}/${overlay} && - fdt apply ${dtboaddr}; - done; -get_kern_mmc=load mmc ${bootpart} ${loadaddr} - ${bootdir}/${name_kern} -get_fit_mmc=load mmc ${bootpart} ${addr_fit} - ${bootdir}/${name_fit} -partitions=name=rootfs,start=0,size=-,uuid=${uuid_gpt_rootfs} + rproc_fw_binaries= 0 /lib/firmware/am62a-mcu-r5f0_0-fw 1 /lib/firmware/am62a-c71_0-fw
Hi Andrew,
Quoted 11 lines · Andrew Davis
There are common MMC args for TI plats in
include/environment/ti/mmc.env. Since we already include this, there is no need to redefine these MMC vars. Use the defaults.This seems like something that could have been done while refactoring these vars in the first place as it happened after this AM62A file was available hence the fixes tag.
Reported-by Chirag Shilwant <[email protected]>Fixes 3709b529156e ("env: ti: mmc.env: Move mmc related args to common place")Signed-off-by Andrew Davis <[email protected]>
Thanks for the patch.
Quoted 9 lines · Andrew Davis
There are common MMC args for TI plats in
include/environment/ti/mmc.env. Since we already include this, there is no need to redefine these MMC vars. Use the defaults.This seems like something that could have been done while refactoring these vars in the first place as it happened after this AM62A file was available hence the fixes tag.
[...]
Applied to u-boot/master, thanks!
[1/1] board: ti: am62ax: env: Use default MMC related args
commit: 5262b3ab9329b702f98ef61e76b0c78eb8c76f24
Signature · 1 line
Tom