Skip to contentSkip to conversation

xen/include: compat/xlat.h may change with .config changes

PATCH In review Jan Beulich 2 participants 2 messages Jan 25, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/include: compat/xlat.h may change with .config changes

$(xlat-y) getting derived from $(headers-y) means its contents may change with changes to .config. The individual files $(xlat-y) refers to, otoh, may not change, and hence not trigger rebuilding of xlat.h. (Note that the issue was already present before the commit referred to below, but it was far more limited in affecting only changes to CONFIG_XSM_FLASK.)

Fixes 2c8fabb2232d ("x86: only generate compat headers actually needed")
xen/include/Makefile +1 -1
@@ -81,7 +81,7 @@ compat/.xlat/%.lst: xlat.lst Makefile
 xlat-y := $(shell sed -ne 's,@arch@,$(compat-arch-y),g' -re 's,^[?!][[:blank:]]+[^[:blank:]]+[[:blank:]]+,,p' xlat.lst | uniq)
 xlat-y := $(filter $(patsubst compat/%,%,$(headers-y)),$(xlat-y))
 
-compat/xlat.h: $(addprefix compat/.xlat/,$(xlat-y)) Makefile
+compat/xlat.h: $(addprefix compat/.xlat/,$(xlat-y)) config/auto.conf Makefile
 	cat $(filter %.h,$^) >[email protected]
 	mv -f [email protected] $@
 
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Jan Beulich

$(xlat-y) getting derived from $(headers-y) means its contents may change with changes to .config. The individual files $(xlat-y) refers to, otoh, may not change, and hence not trigger rebuilding of xlat.h. (Note that the issue was already present before the commit referred to below, but it was far more limited in affecting only changes to CONFIG_XSM_FLASK.)

Fixes 2c8fabb2232d ("x86: only generate compat headers actually needed")