Fix a spelling error in a doc of bcachefs
PATCH 1/1 Fix a spelling error in a doc of bcachefs
--- Documentation/filesystems/bcachefs/CodingStyle.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/filesystems/bcachefs/CodingStyle.rst +1 -1
@@ -175,7 +175,7 @@ errors in our thinking by running our code and seeing what happens. If your time is being wasted because your tools are bad or too slow - don't accept it, fix it. -Put effort into your documentation, commmit messages, and code comments - but +Put effort into your documentation, commit messages, and code comments - but don't go overboard. A good commit message is wonderful - but if the information was important enough to go in a commit message, ask yourself if it would be even better as a code comment.
Signature · 1 line
2.34.1
Shuah Khan
reviewerOn 8/7/24 01:10, Xiaxi Shen wrote:
Missing commit message --
Quoted 10 lines
Signed-off-by Xiaxi Shen <[email protected]>--- Documentation/filesystems/bcachefs/CodingStyle.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/filesystems/bcachefs/CodingStyle.rst +0
-0
Documentation/filesystems/bcachefs/CodingStyle.rst errors in our thinking by running our code and seeing what happens. If your · line 181
Quoted 8 lines
Documentation/filesystems/bcachefs/CodingStyle.rst +1
-1@@ -175,7 +175,7 @@ errors in our thinking by running our code and seeing what happens. If your time is being wasted because your tools are bad or too slow - don't accept it, fix it. -Put effort into your documentation, commmit messages, and code comments - but +Put effort into your documentation, commit messages, and code comments - but don't go overboard. A good commit message is wonderful - but if the information was important enough to go in a commit message, ask yourself if it would be even better as a code comment.
thanks,
-- Shuah
Quoted 3 lines · Shuah Khan
On 8/7/24 01:10, Xiaxi Shen wrote:
Missing commit message --
I wasn't going to commit this, because I don't like taking patches that do nothing more than fix spelling, but since it in fact does not need a commit message for something so trivial I am applying it.
Shuah Khan
reviewerQuoted 8 lines · Kent Overstreet
Quoted 3 lines · Shuah Khan
On 8/7/24 01:10, Xiaxi Shen wrote:
Missing commit message --
I wasn't going to commit this, because I don't like taking patches that do nothing more than fix spelling, but since it in fact does not need a commit message for something so trivial I am applying it.
Sure. Your preference.
I don't accept patches without commit message even if it is trivial.
thanks,
-- Shuah