Skip to contentSkip to conversation

Fix a spelling error in a doc of bcachefs

PATCH In review Xiaxi Shen 3 participants 4 messages Aug 7, 2024 Documentation

lore
Share & tools
lore

Xiaxi Shen

author
#0 lore raw

PATCH 1/1 Fix a spelling error in a doc of bcachefs

---
 Documentation/filesystems/bcachefs/CodingStyle.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/filesystems/bcachefs/CodingStyle.rst +1 -1
index 0c45829a4899..01de555e21d8 100644
@@ -175,7 +175,7 @@ errors in our thinking by running our code and seeing what happens. If your
 time is being wasted because your tools are bad or too slow - don't accept it,
 fix it.
 
-Put effort into your documentation, commmit messages, and code comments - but
+Put effort into your documentation, commit messages, and code comments - but
 don't go overboard. A good commit message is wonderful - but if the information
 was important enough to go in a commit message, ask yourself if it would be
 even better as a code comment.
Signature · 1 line
2.34.1
reviewer
#1 lore raw

On 8/7/24 01:10, Xiaxi Shen wrote:

Missing commit message --

Quoted 10 lines
---
  Documentation/filesystems/bcachefs/CodingStyle.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/filesystems/bcachefs/CodingStyle.rst +0 -0
index 0c45829a4899..01de555e21d8 100644

Documentation/filesystems/bcachefs/CodingStyle.rst errors in our thinking by running our code and seeing what happens. If your · line 181

Quoted 8 lines
Documentation/filesystems/bcachefs/CodingStyle.rst +1 -1
@@ -175,7 +175,7 @@ errors in our thinking by running our code and seeing what happens. If your
  time is being wasted because your tools are bad or too slow - don't accept it,
  fix it.
 
-Put effort into your documentation, commmit messages, and code comments - but
+Put effort into your documentation, commit messages, and code comments - but
  don't go overboard. A good commit message is wonderful - but if the information
  was important enough to go in a commit message, ask yourself if it would be
  even better as a code comment.

thanks,
-- Shuah

#2 lore raw
Quoted 3 lines · Shuah Khan

On 8/7/24 01:10, Xiaxi Shen wrote:

Missing commit message --

I wasn't going to commit this, because I don't like taking patches that do nothing more than fix spelling, but since it in fact does not need a commit message for something so trivial I am applying it.

reviewer
#3 lore raw
Quoted 8 lines · Kent Overstreet
Quoted 3 lines · Shuah Khan

On 8/7/24 01:10, Xiaxi Shen wrote:

Missing commit message --

I wasn't going to commit this, because I don't like taking patches that do nothing more than fix spelling, but since it in fact does not need a commit message for something so trivial I am applying it.

Sure. Your preference.

I don't accept patches without commit message even if it is trivial.

thanks,
-- Shuah