Skip to contentSkip to conversation

kconfig: Add PCIe devices to s390x machines

PATCH Superseded Cédric Le Goater 4 participants 5 messages Jul 5, 2023 – Jul 6, 2023

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 kconfig: Add PCIe devices to s390x machines

It is useful to extend the number of available PCI devices to KVM guests for passthrough scenarios and also to expose these models to a different (big endian) architecture. Include models for Intel Ethernet adapters and one USB controller, which all support MSI-X. Devices only supporting INTx won't work on s390x.

---

v3: PCI -> PCI_EXPRESS
v2: select -> imply

 hw/s390x/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
hw/s390x/Kconfig +4 -1
index 5e7d8a2bae8b..ab62c9120545 100644
@@ -5,8 +5,11 @@ config S390_CCW_VIRTIO
     imply VFIO_AP
     imply VFIO_CCW
     imply WDT_DIAG288
-    select PCI
+    select PCI_EXPRESS
     select S390_FLIC
     select SCLPCONSOLE
     select VIRTIO_CCW
     select MSI_NONBROKEN
+    imply E1000E_PCI_EXPRESS
+    imply IGB_PCI_EXPRESS
+    imply USB_XHCI_PCI
Signature · 1 line
2.41.0
Acked-by on v3 1/1
#1 lore raw
Quoted 7 lines · Cédric Le Goater

It is useful to extend the number of available PCI devices to KVM guests for passthrough scenarios and also to expose these models to a different (big endian) architecture. Include models for Intel Ethernet adapters and one USB controller, which all support MSI-X. Devices only supporting INTx won't work on s390x.

Quoted 25 lines

---

v3: PCI -> PCI_EXPRESS
v2: select -> imply

 hw/s390x/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
hw/s390x/Kconfig +4 -1
index 5e7d8a2bae8b..ab62c9120545 100644
@@ -5,8 +5,11 @@ config S390_CCW_VIRTIO
     imply VFIO_AP
     imply VFIO_CCW
     imply WDT_DIAG288
-    select PCI
+    select PCI_EXPRESS
     select S390_FLIC
     select SCLPCONSOLE
     select VIRTIO_CCW
     select MSI_NONBROKEN
+    imply E1000E_PCI_EXPRESS
+    imply IGB_PCI_EXPRESS
+    imply USB_XHCI_PCI
Reviewed-by on v3 1/1
#2 lore raw
In reply to Cédric Le Goater
Quoted 6 lines · Cédric Le Goater

It is useful to extend the number of available PCI devices to KVM guests for passthrough scenarios and also to expose these models to a different (big endian) architecture. Include models for Intel Ethernet adapters and one USB controller, which all support MSI-X. Devices only supporting INTx won't work on s390x.

Quoted 8 lines

---

v3: PCI -> PCI_EXPRESS
v2: select -> imply

  hw/s390x/Kconfig | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
#3 lore raw
In reply to Cédric Le Goater

hw/s390x/Kconfig config S390_CCW_VIRTIO · line 15

Quoted 3 lines · Cédric Le Goater
hw/s390x/Kconfig +3 -0
+    imply E1000E_PCI_EXPRESS
+    imply IGB_PCI_EXPRESS
+    imply USB_XHCI_PCI

"imply" should only be used whenever the device can be created with the front-end/back-end combo command line options, and as far as I can see this is not the case here.

You could set CONFIG_PCIE_DEVICES=y in s390-softmmu.mak and make these three devices "default y if PCI_DEVICES || PCIE_DEVICES".

Paolo

#4 lore raw
Quoted 8 lines · Paolo Bonzini
Quoted 3 lines · Cédric Le Goater

+    imply E1000E_PCI_EXPRESS
+    imply IGB_PCI_EXPRESS
+    imply USB_XHCI_PCI

"imply" should only be used whenever the device can be created with the front-end/back-end combo command line options, and as far as I can see this is not the case here.

You could set CONFIG_PCIE_DEVICES=y in s390-softmmu.mak and make these three devices "default y if PCI_DEVICES || PCIE_DEVICES".

"default y if PCIE_DEVICES" for *_PCI_EXPRESS.