Miscellaneous build and docs, fixes from Debian
cover Miscellaneous build and docs, fixes from Debian
Bastian Blank (1):
tools/xenstat: Fix shared library version
Ian Jackson (17):
docs/man: Fix two typos detected by the Debian lintian tool tools/xentrace/xenalyze: Fix typos detected by lintian
Various: Fix typos unkown', retreive' (detected by lintian)
Various: Fix typo `occured'
Various: Fix typo reseting' tools/python/xen/lowlevel: Fix typo sucess'
Various: Fix typo `infomation'
Various: Fix typo `mappping'
tools/Rules.mk: Honour PREPEND_LDFLAGS_XEN_TOOLS
INSTALL: Mention kconfig
docs/man: Provide properly-formatted NAME sections docs/man/xen-pv-channel.pod.7: Remove a spurious blank line
gdbsx: Honour LDFLAGS when linking
libfsimage: Honour general LDFLAGS
pygrub fsimage.so: Honour LDFLAGS when building
xenmon: Install as xenmon, not xenmon.py tools/debugger/kdd: Install as xen-kdd', not just kdd'
INSTALL | 20 ++++++++++++++++++++ docs/man/xen-pci-device-reservations.pod.7 | 4 ++++ docs/man/xen-pv-channel.pod.7 | 3 +-- docs/man/xen-tscmode.pod.7 | 4 ++++ docs/man/xen-vtpm.pod.7 | 6 ++++++ docs/man/xen-vtpmmgr.pod.7 | 4 ++++ docs/man/xenstore.pod.1 | 2 +- docs/man/xl-numa-placement.pod.7 | 2 +- docs/man/xl.pod.1.in | 2 +- tools/Rules.mk | 2 ++ tools/debugger/gdbsx/Makefile | 2 +- tools/debugger/kdd/Makefile | 4 ++-- tools/hotplug/Linux/block-drbd-probe | 2 +- tools/libfsimage/common/Makefile | 2 +- tools/libxc/xc_dom_elfloader.c | 2 +- tools/libxl/libxl_dm.c | 2 +- tools/libxl/libxl_event.h | 2 +- tools/libxl/libxl_internal.h | 2 +- tools/libxl/libxl_qmp.c | 2 +- tools/misc/xenlockprof.c | 2 +- tools/misc/xenperf.c | 2 +- tools/pygrub/Makefile | 2 +- tools/python/xen/lowlevel/xc/xc.c | 6 +++--- tools/xenmon/Makefile | 4 ++-- tools/xenstat/libxenstat/Makefile | 2 +- tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +- tools/xentrace/xenalyze.c | 8 ++++---- tools/xl/xl_flask.c | 2 +- xen/arch/arm/arm64/lib/memcmp.S | 2 +- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/hvm/svm/intr.c | 2 +- xen/common/sched_rt.c | 2 +- xen/drivers/acpi/apei/erst.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 2 +- xen/drivers/passthrough/vtd/iommu.h | 2 +- xen/include/efi/efiprot.h | 2 +- xen/include/public/domctl.h | 2 +- xen/include/public/xen.h | 2 +- xen/include/xen/libfdt/libfdt.h | 2 +- xen/include/xen/sched.h | 2 +- 40 files changed, 81 insertions(+), 42 deletions(-)
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 1/18 docs/man: Fix two typos detected by the Debian lintian tool
--- docs/man/xenstore.pod.1 | 2 +- docs/man/xl.pod.1.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
docs/man/xenstore.pod.1 +1 -1
@@ -18,7 +18,7 @@ Sets the permissions of keys. =item B<xenstore-exists>(1) -Test for the existance of a key. +Test for the existence of a key. =item B<xenstore-list>(1)
docs/man/xl.pod.1.in +1 -1
@@ -1398,7 +1398,7 @@ Creates a new network device in the domain specified by I<domain-id>. I<network-device> describes the device to attach, using the same format as the B<vif> string in the domain config file. See L<xl.cfg(5)> and L<xl-network-configuration(5)> -for more informations. +for more information. Note that only attaching PV network interfaces is supported.
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 01/18] docs/man: Fix two typos detected by the Debian lintian tool
Quoted 2 lines · Ian Jackson
Signed-off-by Ian Jackson <[email protected]>---
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 2/18 tools/xentrace/xenalyze: Fix typos detected by lintian
In reply to Ian Jackson--- tools/xentrace/xenalyze.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
tools/xentrace/xenalyze.c +4 -4
@@ -9224,7 +9224,7 @@ void process_cpu_change(struct pcpu_info *p) {/* File sanity check */ if (p->file_offset != p->next_cpu_change_offset) { -fprintf (warn,"Strange, pcpu %d expected offet %llx, actual %llx!\n" , +fprintf (warn,"Strange, pcpu %d expected offset %llx, actual %llx!\n" , p->pid, (unsigned long long )p->next_cpu_change_offset, (unsigned long long )p->file_offset); }
@@ -9673,7 +9673,7 @@ ssize_t read_record(struct pcpu_info * p) { }/* -* This funciton gets called for every record when doing dump. Try to +* This function gets called for every record when doing dump. Try to * make it efficient by changing the minimum amount from the last * call. Do this by: * - Keeping track of the last pcpu called, so we can just set that to -
@@ -10629,7 +10629,7 @@ const struct argp_option cmd_opts[] = { .key = OPT_SCATTERPLOT_EXTINT_CYCLES, .arg = "vector", .group = OPT_GROUP_EXTRA, - .doc = "Output a scatterplot of vmexit cycles for external interrupts of the given vector as a funciton of time.", }, + .doc = "Output a scatterplot of vmexit cycles for external interrupts of the given vector as a function of time.", }, { .name = "scatterplot-unpin-promote", .key = OPT_SCATTERPLOT_UNPIN_PROMOTE,
@@ -10756,7 +10756,7 @@ const struct argp_option cmd_opts[] = { .key = OPT_MMIO_ENUMERATION_SKIP_VGA, .arg = "[0|1]", .group = OPT_GROUP_SUMMARY, - .doc = "Control whether we enumerate MMIO accesses to the VGA area, which can be extremly high during boot. Default: 0", }, + .doc = "Control whether we enumerate MMIO accesses to the VGA area, which can be extremely high during boot. Default: 0", }, { .name = "sample-size", .key = OPT_SAMPLE_SIZE,
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 02/18] tools/xentrace/xenalyze: Fix typos detected by lintian
Quoted 1 line · Ian Jackson
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 3/18 Various: Fix typos `unkown', `retreive' (detected by lintian)
In reply to Ian Jackson--- tools/hotplug/Linux/block-drbd-probe | 2 +- tools/libxc/xc_dom_elfloader.c | 2 +- tools/libxl/libxl_dm.c | 2 +- tools/libxl/libxl_event.h | 2 +- tools/libxl/libxl_qmp.c | 2 +- xen/include/xen/libfdt/libfdt.h | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
tools/hotplug/Linux/block-drbd-probe +1 -1
@@ -20,7 +20,7 @@ # Return value: # 0: the device is drbd device # 1: the device is not drbd device -# 2: unkown error +# 2: unknown error # 3: the drbd device does not use protocol D # 4: the drbd device is not ready
tools/libxc/xc_dom_elfloader.c +1 -1
@@ -87,7 +87,7 @@ static char *xc_dom_guest_type(struct xc_dom_image *dom,return "xen-3.0-x86_64" ;default :xc_dom_panic (dom->xch,XC_INVALID_KERNEL , -"%s: unkown image type %" PRIu64, +"%s: unknown image type %" PRIu64, __FUNCTION__, machine);return NULL ; }
tools/libxl/libxl_dm.c +1 -1
@@ -992,7 +992,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,/* * Do not use any of the user-provided config files in sysconfdir, -* avoiding unkown and uncontrolled configuration. +* avoiding unknown and uncontrolled configuration. */ flexarray_append (dm_args,"-no-user-config" );
tools/libxl/libxl_event.h +1 -1
@@ -169,7 +169,7 @@ void libxl_event_register_callbacks(libxl_ctx *ctx,* * Applications should ensure that they eventually retrieve every * event using libxl_event_check or libxl_event_wait, since events -* which occur but are not retreived by the application will be queued +* which occur but are not retrieved by the application will be queued * inside libxl indefinitely. libxl_event_check/_wait may be O(n) * where n is the number of queued events which do not match the * criteria specified in the arguments to check/wait.
tools/libxl/libxl_qmp.c +1 -1
@@ -238,7 +238,7 @@ static int qmp_register_vnc_callback(libxl__qmp_handler *qmp, port =libxl__json_object_get_string (obj);if (!addr || !port) { -LOGD (ERROR , qmp->domid,"Failed to retreive VNC connect information." ); +LOGD (ERROR , qmp->domid,"Failed to retrieve VNC connect information." ); goto out; }
xen/include/xen/libfdt/libfdt.h +1 -1
@@ -594,7 +594,7 @@ const char *fdt_get_alias_namelen(const void *fdt, const char *name, int namelen);/** -* fdt_get_alias - retreive the path referenced by a given alias +* fdt_get_alias - retrieve the path referenced by a given alias * @fdt: pointer to the device tree blob * @name: name of the alias th look up *
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 03/18] Various: Fix typos `unkown', `retreive' (detected by lintian)
Quoted 1 line · Ian Jackson
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 4/18 Various: Fix typo `occured'
In reply to Ian Jackson--- tools/xl/xl_flask.c | 2 +- xen/arch/arm/arm64/lib/memcmp.S | 2 +- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/hvm/svm/intr.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 2 +- xen/include/efi/efiprot.h | 2 +- xen/include/public/xen.h | 2 +- xen/include/xen/sched.h | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-)
tools/xl/xl_flask.c +1 -1
@@ -75,7 +75,7 @@ int main_setenforce(int argc, char **argv)fprintf (stderr,"Flask XSM disabled\n" ); }else -fprintf (stderr,"error occured while setting enforcing mode (%i)\n" , ret); +fprintf (stderr,"error occurred while setting enforcing mode (%i)\n" , ret); }return ret;
xen/arch/arm/arm64/lib/memcmp.S +1 -1
@@ -210,7 +210,7 @@ CPU_LE( lsr tmp2, tmp2, tmp1 ) .Lunequal_proc: cbz diff, .Lremain8 -/*There is differnence occured in the latest comparison.*/ +/*There is differnence occurred in the latest comparison.*/ .Lnot_limit: /* * For little endian,reverse the low significant equal bits into MSB,then
xen/arch/x86/hvm/hvm.c +1 -1
@@ -1696,7 +1696,7 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla,case NESTEDHVM_PAGEFAULT_RETRY :return 1 ;case NESTEDHVM_PAGEFAULT_L1_ERROR : -/* An error occured while translating gpa from +/* An error occurred while translating gpa from * l2 guest address to l1 guest address. */ return 0 ;case NESTEDHVM_PAGEFAULT_INJECT :
xen/arch/x86/hvm/svm/intr.c +1 -1
@@ -159,7 +159,7 @@ void svm_intr_assist(void)int rc;/* l2 guest was running when an interrupt for -* the l1 guest occured. +* the l1 guest occurred. */ rc =nestedsvm_vcpu_interrupt (v, intack);switch (rc) {
xen/drivers/passthrough/arm/smmu.c +1 -1
@@ -2278,7 +2278,7 @@ MODULE_DEVICE_TABLE(of, arm_smmu_of_match);/* * Xen: We don't have refcount for allocated memory so manually free memory -* when an error occured. +* when an error occurred. */ static int arm_smmu_device_dt_probe (struct platform_device *pdev) {
xen/include/efi/efiprot.h +1 -1
@@ -691,7 +691,7 @@ typedef enum {@retval EFI_SUCCESS The Blt operation completed. @retval EFI_INVALID_PARAMETER BltOperation is not valid. -@retval EFI_DEVICE_ERROR A hardware error occured writting to the video buffer. +@retval EFI_DEVICE_ERROR A hardware error occurred writting to the video buffer. **/ typedef
xen/include/public/xen.h +1 -1
@@ -177,7 +177,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t);#define VIRQ_XENOPROF 7/* V. XenOprofile interrupt: new sample available */ #define VIRQ_CON_RING 8/* G. (DOM0) Bytes received on console */ #define VIRQ_PCPU_STATE 9/* G. (DOM0) PCPU state changed */ -#define VIRQ_MEM_EVENT 10/* G. (DOM0) A memory event has occured */ +#define VIRQ_MEM_EVENT 10/* G. (DOM0) A memory event has occurred */ #define VIRQ_XC_RESERVED 11/* G. Reserved for XenClient */ #define VIRQ_ENOMEM 12/* G. (DOM0) Low on heap memory */ #define VIRQ_XENPMU 13/* V. PMC interrupt */
xen/include/xen/sched.h +1 -1
@@ -615,7 +615,7 @@ void __domain_crash(struct domain *d);/* * Called from assembly code, with an optional address to help indicate why -* the crash occured. If addr is 0, look up address from last extable +* the crash occurred. If addr is 0, look up address from last extable * redirection. */ void noreturnasm_domain_crash_synchronous (unsigned long addr);
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 04/18] Various: Fix typo `occured'
Quoted 2 lines
Quoted 1 line
Quoted 1 line · On 05.10.18 at 19:29, <[email protected]> wrote:
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 04/18] Various: Fix typo `occured'
In reply to Ian JacksonQuoted 1 line · Ian Jackson
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 5/18 Various: Fix typo `reseting'
In reply to Ian Jackson--- tools/misc/xenlockprof.c | 2 +- tools/misc/xenperf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
tools/misc/xenlockprof.c +1 -1
@@ -46,7 +46,7 @@ int main(int argc, char *argv[]) {if (xc_lockprof_reset (xc_handle) !=0 ) { -fprintf (stderr,"Error reseting profile data: %d (%s)\n" , +fprintf (stderr,"Error resetting profile data: %d (%s)\n" , errno,strerror (errno));return 1 ; }
tools/misc/xenperf.c +1 -1
@@ -123,7 +123,7 @@ int main(int argc, char *argv[]) {if (xc_perfc_reset (xc_handle) !=0 ) { -fprintf (stderr,"Error reseting performance counters: %d (%s)\n" , +fprintf (stderr,"Error resetting performance counters: %d (%s)\n" , errno,strerror (errno));return 1 ; }
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 05/18] Various: Fix typo `reseting'
Quoted 1 line · Ian Jackson
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 6/18 tools/python/xen/lowlevel: Fix typo `sucess'
In reply to Ian Jackson--- tools/python/xen/lowlevel/xc/xc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/python/xen/lowlevel/xc/xc.c +1 -1
@@ -2178,7 +2178,7 @@ static PyMethodDef pyxc_methods[] = {" xenstore_gmfn [int]: \n" " console_domid [int]: \n" " xenstore_domid [int]: \n" - "Returns: None on sucess. Raises exception on error.\n" }, + "Returns: None on success. Raises exception on error.\n" }, { "hvm_get_param", (PyCFunction)pyxc_hvm_param_get,
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 06/18] tools/python/xen/lowlevel: Fix typo `sucess'
Quoted 1 line · Ian Jackson
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 7/18 Various: Fix typo `infomation'
In reply to Ian Jackson--- tools/libxl/libxl_internal.h | 2 +- tools/python/xen/lowlevel/xc/xc.c | 2 +- tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +- xen/common/sched_rt.c | 2 +- xen/drivers/acpi/apei/erst.c | 2 +- xen/include/public/domctl.h | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
tools/libxl/libxl_internal.h +1 -1
@@ -2604,7 +2604,7 @@ struct libxl__multidev {* Once finished, aodev->callback will be executed. */ /* -* As of Xen 4.5 we maintain various infomation, including hotplug +* As of Xen 4.5 we maintain various information, including hotplug * device information, in JSON files, so that we can use this JSON * file as a template to reconstruct domain configuration. *
tools/python/xen/lowlevel/xc/xc.c +1 -1
@@ -2200,7 +2200,7 @@ static PyMethodDef pyxc_methods[] = { {"get_device_group" , (PyCFunction )pyxc_get_device_group,METH_VARARGS ,"\n" -"get sibling devices infomation.\n" +"get sibling devices information.\n" " dom [int]: Domain to assign device to.\n" " seg [int]: PCI segment.\n" " bus [int]: PCI bus.\n"
tools/xenstat/libxenstat/src/xenstat_qmp.c +1 -1
@@ -59,7 +59,7 @@ enum query_block {/* Given the qmp device name, get the image filename associated with it -QMP Syntax for querying block infomation: +QMP Syntax for querying block information: In: { "execute": "query-block" } Out: {"return": [{ "device": 'str, "locked": 'bool', "removable": bool,
xen/common/sched_rt.c +1 -1
@@ -203,7 +203,7 @@ struct rt_vcpu {s_time_t period;s_time_t budget; -/* VCPU current infomation in nanosecond */ +/* VCPU current information in nanosecond */ s_time_t cur_budget;/* current budget */ s_time_t last_start;/* last start time */ s_time_t cur_deadline;/* current deadline for EDF */
xen/drivers/acpi/apei/erst.c +1 -1
@@ -2,7 +2,7 @@* APEI Error Record Serialization Table support * * ERST is a way provided by APEI to save and retrieve hardware error -* infomation to and from a persistent store. +* information to and from a persistent store. * * For more information about ERST, please refer to ACPI Specification * version 4.0, section 17.4.
xen/include/public/domctl.h +1 -1
@@ -508,7 +508,7 @@ struct xen_domctl_assign_device { } u; }; -/* Retrieve sibling devices infomation of machine_sbdf */ +/* Retrieve sibling devices information of machine_sbdf */ /* XEN_DOMCTL_get_device_group */ struct xen_domctl_get_device_group {uint32_t machine_sbdf;/* IN */
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 07/18] Various: Fix typo `infomation'
Quoted 2 lines
Quoted 1 line
Quoted 1 line · On 05.10.18 at 19:29, <[email protected]> wrote:
Signed-off-by Ian Jackson <[email protected]>
Funny how often the same spelling mistakes repeat...
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 07/18] Various: Fix typo `infomation'
Jan Beulich writes ("Re: [PATCH 07/18] Various: Fix typo `infomation'"):
Quoted 6 lines · On 05.10.18 at 19:29, <[email protected]> wrote:
Quoted 1 line
Signed-off-by Ian Jackson <[email protected]>Acked-by Jan Beulich <[email protected]>Funny how often the same spelling mistakes repeat...
Mmm.
In one of my own projects I had a persistent problem with pseudo' (which appeared in some textual protocol elements, so the spelling was important). I eventually wrote a test case which fails iff the source code contains ps[u]edo' (written that way to avoid tripping itself).
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 07/18] Various: Fix typo `infomation'
In reply to Ian JacksonQuoted 1 line · Ian Jackson
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 8/18 Various: Fix typo `mappping'
In reply to Ian Jackson--- tools/python/xen/lowlevel/xc/xc.c | 2 +- xen/drivers/passthrough/vtd/iommu.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
tools/python/xen/lowlevel/xc/xc.c +1 -1
@@ -2385,7 +2385,7 @@ static PyMethodDef pyxc_methods[] = { {"domain_set_memmap_limit" , (PyCFunction )pyxc_domain_set_memmap_limit,METH_VARARGS ,"\n" -"Set a domain's physical memory mappping limit\n" +"Set a domain's physical memory mapping limit\n" " dom [int]: Identifier of domain.\n" " map_limitkb [int]: .\n" "Returns: [int] 0 on success; -1 on error.\n" },
xen/drivers/passthrough/vtd/iommu.h +1 -1
@@ -513,7 +513,7 @@ struct qi_ctrl {struct ir_ctrl {u64 iremap_maddr;/* interrupt remap table machine address */ int iremap_num;/* total num of used interrupt remap entry */ -spinlock_t iremap_lock;/* lock for irq remappping table */ +spinlock_t iremap_lock;/* lock for irq remapping table */ };struct iommu_flush {
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 08/18] Various: Fix typo `mappping'
Quoted 1 line · Ian Jackson
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 9/18 tools/Rules.mk: Honour PREPEND_LDFLAGS_XEN_TOOLS
In reply to Ian JacksonThis allows the caller to provide some LDFLAGS to the Xen build system.
--- tools/Rules.mk | 2 ++ 1 file changed, 2 insertions(+)
tools/Rules.mk +2 -0
@@ -9,6 +9,8 @@ include $(XEN_ROOT)/Config.mk export _INSTALL := $(INSTALL) INSTALL = $(XEN_ROOT)/tools/cross-install +LDFLAGS += $(PREPEND_LDFLAGS_XEN_TOOLS) + XEN_INCLUDE = $(XEN_ROOT)/tools/include XEN_LIBXENTOOLCORE = $(XEN_ROOT)/tools/libs/toolcore XEN_LIBXENTOOLLOG = $(XEN_ROOT)/tools/libs/toollog
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 10/18 INSTALL: Mention kconfig
In reply to Ian JacksonFirstly, add a reference to the documentation for the kconfig system.
Secondly, warn the user about the XEN_CONFIG_EXPERT problem.
--- INSTALL | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
INSTALL +20 -0
@@ -19,6 +19,26 @@ following compile process. Once configure is done, make(1) has to be called. Also make(1) recognizes certain arguments. The following sections will give an overview. +Xen Hypervisor +============== + +Xen itself is configured via a `kconfig' system borrowed from Linux. +See docs/misc/kconfig.txt. + +Note that unlike with Linux, and contrary to that document, you cannot +look at Kconfig files, or the default or generated config files etc., +to find available configuration options. This is because it is only +supported (and security supported) by the Xen Project, to change a +small subset of the options. Attempts to change other options will be +silently overriden. The only way to find which configuration options +are available is to run `make menuconfig' or the like. + +You can counter-override this behaviour by setting XEN_CONFIG_EXPERT=y +in your environment. However, doing this is not supported and the +resulting configurations do not receive security support. If you set +this varible there is nothing stopping you setting dangerously +experimental combinations of features - not even any warnings. + Options recognized by configure ===============================
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 10/18] INSTALL: Mention kconfig
Quoted 9 lines · Ian Jackson
Firstly, add a reference to the documentation for the kconfig system.
Secondly, warn the user about the
XEN_CONFIG_EXPERTproblem.CC Doug Goldstein <[email protected]>CC Wei Liu <[email protected]>CC Jan Beulich <[email protected]>CC Andrew Cooper <[email protected]>Signed-off-by Ian Jackson <[email protected]>
Quoted 21 lines
--- INSTALL | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)INSTALL +9
-0@@ -19,6 +19,26 @@ following compile process. Once configure is done, make(1) has to be called. Also make(1) recognizes certain arguments. The following sections will give an overview. +Xen Hypervisor +============== + +Xen itself is configured via a `kconfig' system borrowed from Linux. +See docs/misc/kconfig.txt. + +Note that unlike with Linux, and contrary to that document, you cannot +look at Kconfig files, or the default or generated config files etc., +to find available configuration options. This is because it is only
INSTALL following compile process. Once configure is done, make(1) has to be · line 40
Quoted 10 lines
INSTALL +10
-0+supported (and security supported) by the Xen Project, to change a +small subset of the options. Attempts to change other options will be +silently overriden. The only way to find which configuration options +are available is to run `make menuconfig' or the like. + +You can counter-override this behaviour by setting XEN_CONFIG_EXPERT=y +in your environment. However, doing this is not supported and the +resulting configurations do not receive security support. If you set +this varible there is nothing stopping you setting dangerously +experimental combinations of features - not even any warnings.
Not really true because the shim is supported and relies on XEN_CONFIG_EXPERT but certainly better to make users aware than blindly hiding everything from them. I'd still argue that eventually we'll get rid of this because most distros build with XEN_CONFIG_EXPERT on and most Xen devs I know just have it set in their environment.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 10/18] INSTALL: Mention kconfig
Doug Goldstein writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"):
Quoted 6 lines · Ian Jackson
Quoted 3 lines
Firstly, add a reference to the documentation for the kconfig system.
Secondly, warn the user about the
XEN_CONFIG_EXPERTproblem.Reviewed-by Doug Goldstein <[email protected]>
Thanks.
Quoted 14 lines
Quoted 14 lines
INSTALL +14
-0+Xen Hypervisor +============== + +Xen itself is configured via a `kconfig' system borrowed from Linux. +See docs/misc/kconfig.txt. + +Note that unlike with Linux, and contrary to that document, you cannot +look at Kconfig files, or the default or generated config files etc., +to find available configuration options. This is because it is only +supported (and security supported) by the Xen Project, to change a +small subset of the options. Attempts to change other options will be +silently overriden. The only way to find which configuration options +are available is to run `make menuconfig' or the like. +
Quoted 8 lines
INSTALL following compile process. Once configure is done, make(1) has to be · line 40
Quoted 5 lines
INSTALL +5
-0+You can counter-override this behaviour by setting XEN_CONFIG_EXPERT=y +in your environment. However, doing this is not supported and the +resulting configurations do not receive security support. If you set +this varible there is nothing stopping you setting dangerously +experimental combinations of features - not even any warnings.Not really true because the shim is supported and relies on
XEN_CONFIG_EXPERT
It sounds like you are saying that what I write above is not accurate. I didn't intend it to cover any setting of XEN_CONFIG_EXPERT by the Xen build system itself.
I'm not sure how that interacts wit your R-B either. Normally a R-B would imply approval of the contents.
Quoted 4 lines
but certainly better to make users aware than blindly
hiding everything from them. I'd still argue that eventually we'll get rid of this because most distros build withXEN_CONFIG_EXPERTon and most Xen devs I know just have it set in their environment.
Well, yes. I decided that documenting the situation was the best way to throw light on it and possibly even get it changed.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 10/18] INSTALL: Mention kconfig
In reply to Ian JacksonINSTALL following compile process. Once configure is done, make(1) has to be · line 33
Quoted 13 lines
Quoted 1 line
Quoted 1 line · On 05.10.18 at 19:29, <[email protected]> wrote:
INSTALL +12
-0+Xen Hypervisor +============== + +Xen itself is configured via a `kconfig' system borrowed from Linux. +See docs/misc/kconfig.txt. + +Note that unlike with Linux, and contrary to that document, you cannot +look at Kconfig files, or the default or generated config files etc., +to find available configuration options. This is because it is only +supported (and security supported) by the Xen Project, to change a +small subset of the options. Attempts to change other options will be +silently overriden. The only way to find which configuration options
Isn't it "overridden", or are both spellings okay?
INSTALL following compile process. Once configure is done, make(1) has to be · line 39
Quoted 6 lines
INSTALL +6
-0+are available is to run `make menuconfig' or the like. + +You can counter-override this behaviour by setting XEN_CONFIG_EXPERT=y +in your environment. However, doing this is not supported and the +resulting configurations do not receive security support. If you set +this varible there is nothing stopping you setting dangerously
variable
Beyond these nits I'm okay with the text now, accepting the anomaly pointed out by Doug.
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 10/18] INSTALL: Mention kconfig
Jan Beulich writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"):
Quoted 4 lines · On 05.10.18 at 19:29, <[email protected]> wrote:
Quoted 1 line
+silently overriden. The only way to find which configuration options
Isn't it "overridden", or are both spellings okay?
It is; I was wrong.
Quoted 3 lines
Quoted 1 line
+this varible there is nothing stopping you setting dangerously
variable
Fixed.
Quoted 2 lines
Beyond these nits I'm okay with the text now, accepting the anomaly pointed out by Doug.
Thanks, I'll take that as an ack. (Assuming you did indeed mean accepting' rather than excepting'.)
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 10/18] INSTALL: Mention kconfig
Quoted 13 lines
Quoted 1 line
Quoted 1 line · On 08.10.18 at 16:08, <[email protected]> wrote:
Jan Beulich writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"):
Quoted 4 lines · On 05.10.18 at 19:29, <[email protected]> wrote:
Quoted 1 line
+silently overriden. The only way to find which configuration options
Isn't it "overridden", or are both spellings okay?
It is; I was wrong.
Quoted 3 lines
Quoted 1 line
+this varible there is nothing stopping you setting dangerously
variable
Quoted 7 lines
Fixed.
Quoted 2 lines
Beyond these nits I'm okay with the text now, accepting the anomaly pointed out by Doug.
Thanks, I'll take that as an ack. (Assuming you did indeed mean
accepting' rather thanexcepting'.)
Well, no, it was not meant as an ack, merely as the absence of further objections. (And yes, I did mean "accepting".)
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 10/18] INSTALL: Mention kconfig
Jan Beulich writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"):
Quoted 6 lines · On 08.10.18 at 16:08, <[email protected]> wrote:
Quoted 2 lines
Thanks, I'll take that as an ack. (Assuming you did indeed mean
accepting' rather thanexcepting'.)Well, no, it was not meant as an ack, merely as the absence of further objections. (And yes, I did mean "accepting".)
Err, OK.
Doug, do you want me to propose a different or expanded wording ?
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 10/18] INSTALL: Mention kconfig
Quoted 5 lines · Ian Jackson
Jan Beulich writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"):
Quoted 4 lines · On 08.10.18 at 16:08, <[email protected]> wrote:
Quoted 2 lines
Thanks, I'll take that as an ack. (Assuming you did indeed mean
accepting' rather thanexcepting'.)
Quoted 8 lines
Quoted 2 lines
Well, no, it was not meant as an ack, merely as the absence of further objections. (And yes, I did mean "accepting".)
Err, OK.
Doug, do you want me to propose a different or expanded wording ?
Ian.
No. I think this good. It sheds light on something that was black magic and that's good. I think you've started the conversation on how we see XEN_CONFIG_EXPERT evolving (due to the shim config) and that's great too. +1 from me.
--
Doug
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 11/18 docs/man: Provide properly-formatted NAME sections
In reply to Ian JacksonA manpage `foo.7.pod' must start with
=head NAME
foo - some summary of what foo is or what this manpage is
because otherwise manpage catalogue systems cannot generate a proper `whatis' entry.
--- docs/man/xen-pci-device-reservations.pod.7 | 4 ++++ docs/man/xen-pv-channel.pod.7 | 2 +- docs/man/xen-tscmode.pod.7 | 4 ++++ docs/man/xen-vtpm.pod.7 | 6 ++++++ docs/man/xen-vtpmmgr.pod.7 | 4 ++++ docs/man/xl-numa-placement.pod.7 | 2 +- 6 files changed, 20 insertions(+), 2 deletions(-)
docs/man/xen-pci-device-reservations.pod.7 +4 -0
@@ -1,3 +1,7 @@ +=head1 NAME + +xen-pci-device-reservations - Xen PCI device ID registry + =head1 Description PCI vendor ID 0x5853 has been reserved for use by Xen systems in order to
docs/man/xen-pv-channel.pod.7 +1 -1
@@ -3,7 +3,7 @@ =head1 NAME -Xen PV Channels +xen-pv-channel - Xen PV Channels =head1 DESCRIPTION
docs/man/xen-tscmode.pod.7 +4 -0
@@ -1,3 +1,7 @@ +=head1 NAME + +xen-tscmode - Xen TSC (time stamp counter) and timekeeping discussion + =head1 OVERVIEW As of Xen 4.0, a new config option called tsc_mode may be specified
docs/man/xen-vtpm.pod.7 +6 -0
@@ -1,3 +1,9 @@ +=head1 NAME + +xen-vtpm - Xen virtual Trusted Platform Module (vTPM) subsystem + +=head1 RUBRIC + Copyright (c) 2010-2012 United States Government, as represented by the Secretary of Defense. All rights reserved. November 12 2012
docs/man/xen-vtpmmgr.pod.7 +4 -0
@@ -1,3 +1,7 @@ +=head1 NAME + +xen-vtpmgr - Xen virtual TPM stubdomain + =head1 Authors =over 4
docs/man/xl-numa-placement.pod.7 +1 -1
@@ -2,7 +2,7 @@ =head1 NAME -Guest Automatic NUMA Placement in libxl and xl +xl-numa-placement - Guest Automatic NUMA Placement in libxl and xl =head1 DESCRIPTION
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 11/18] docs/man: Provide properly-formatted NAME sections
Quoted 10 lines · Ian Jackson
A manpage `foo.7.pod' must start with
=head NAME
foo - some summary of what foo is or what this manpage is
because otherwise manpage catalogue systems cannot generate a proper `whatis' entry.
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 12/18 docs/man/xen-pv-channel.pod.7: Remove a spurious blank line
In reply to Ian JacksonNo functional change.
--- docs/man/xen-pv-channel.pod.7 | 1 - 1 file changed, 1 deletion(-)
docs/man/xen-pv-channel.pod.7 +0 -1
@@ -1,6 +1,5 @@ =encoding utf8 - =head1 NAME xen-pv-channel - Xen PV Channels
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 12/18] docs/man/xen-pv-channel.pod.7: Remove a spurious blank line
Quoted 3 lines · Ian Jackson
No functional change.
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 13/18 tools/xenstat: Fix shared library version
In reply to Ian JacksonFrom: Bastian Blank <[email protected]>
libxenstat does not have a stable ABI. Set its version to the current Xen release version.
--- tools/xenstat/libxenstat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/xenstat/libxenstat/Makefile +1 -1
@@ -18,7 +18,7 @@ include $(XEN_ROOT)/tools/Rules.mk LDCONFIG=ldconfig MAKE_LINK=ln -sf -MAJOR=0 +MAJOR=4.11 MINOR=0 LIB=src/libxenstat.a
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 13/18] tools/xenstat: Fix shared library version
Quoted 6 lines · Ian Jackson
From: Bastian Blank <[email protected]>
libxenstat does not have a stable ABI. Set its version to the current Xen release version.
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 13/18] tools/xenstat: Fix shared library version
In reply to Ian JacksonQuoted 15 lines · Ian Jackson
From: Bastian Blank <[email protected]>
libxenstat does not have a stable ABI. Set its version to the current Xen release version.
Signed-off-by Ian Jackson <[email protected]>--- tools/xenstat/libxenstat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/xenstat/libxenstat/Makefile +0
-0
tools/xenstat/libxenstat/Makefile include $(XEN_ROOT)/tools/Rules.mk · line 21
Quoted 5 lines
tools/xenstat/libxenstat/Makefile +1
-1@@ -18,7 +18,7 @@ include $(XEN_ROOT)/tools/Rules.mk LDCONFIG=ldconfig MAKE_LINK=ln -sf -MAJOR=0 +MAJOR=4.11
I see you've already committed this patch, but you don't mean 4.11 here.
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 14/18 gdbsx: Honour LDFLAGS when linking
In reply to Ian JacksonThis command does the link, so it needs LDFLAGS.
--- tools/debugger/gdbsx/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/debugger/gdbsx/Makefile +1 -1
@@ -26,7 +26,7 @@ uninstall: rm -f $(DESTDIR)$(sbindir)/gdbsx gdbsx: gx/gx_all.a xg/xg_all.a - $(CC) -o $@ $^ + $(CC) $(LDFLAGS) -o $@ $^ xg/xg_all.a: $(MAKE) -C xg
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 15/18 libfsimage: Honour general LDFLAGS
In reply to Ian JacksonDo not reset LDFLAGS to empty. Instead, append the fsimage-special LDFLAGS.
--- tools/libfsimage/common/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/libfsimage/common/Makefile +1 -1
@@ -6,7 +6,7 @@ MINOR = 0 LDFLAGS-$(CONFIG_SunOS) = -Wl,-M -Wl,mapfile-SunOS LDFLAGS-$(CONFIG_Linux) = -Wl,mapfile-GNU -LDFLAGS = $(LDFLAGS-y) +LDFLAGS += $(LDFLAGS-y) CFLAGS += $(PTHREAD_CFLAGS) LDFLAGS += $(PTHREAD_LDFLAGS)
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 15/18] libfsimage: Honour general LDFLAGS
Quoted 4 lines · Ian Jackson
Do not reset LDFLAGS to empty. Instead, append the fsimage-special LDFLAGS.
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 16/18 pygrub fsimage.so: Honour LDFLAGS when building
In reply to Ian JacksonThis seems to have been simply omitted. Obviously this is needed when building and not just when installing. Passing only when installing is ineffective.
--- tools/pygrub/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/pygrub/Makefile +1 -1
@@ -10,7 +10,7 @@ INSTALL_LOG = build/installed_files.txt all: build .PHONY: build build: - CC="$(CC)" CFLAGS="$(PY_CFLAGS)" $(PYTHON) setup.py build + CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) setup.py build .PHONY: install install: all
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 17/18 xenmon: Install as xenmon, not xenmon.py
In reply to Ian JacksonAdding the implementation language as a suffix to a program name is poor practice.
--- tools/xenmon/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/xenmon/Makefile +2 -2
@@ -32,13 +32,13 @@ install: build $(INSTALL_DIR) $(DESTDIR)$(sbindir) $(INSTALL_PROG) xenbaked $(DESTDIR)$(sbindir)/xenbaked $(INSTALL_PROG) xentrace_setmask $(DESTDIR)$(sbindir)/xentrace_setmask - $(INSTALL_PROG) xenmon.py $(DESTDIR)$(sbindir)/xenmon.py + $(INSTALL_PROG) xenmon.py $(DESTDIR)$(sbindir)/xenmon .PHONY: uninstall uninstall: rm -f $(DESTDIR)$(sbindir)/xenbaked rm -f $(DESTDIR)$(sbindir)/xentrace_setmask - rm -f $(DESTDIR)$(sbindir)/xenmon.py + rm -f $(DESTDIR)$(sbindir)/xenmon .PHONY: clean clean:
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 17/18] xenmon: Install as xenmon, not xenmon.py
Quoted 4 lines · Ian Jackson
Adding the implementation language as a suffix to a program name is poor practice.
Signed-off-by Ian Jackson <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 18/18 tools/debugger/kdd: Install as `xen-kdd', not just `kdd'
In reply to Ian Jackson`kdd' is an unfortunate namespace landgrab.
--- tools/debugger/kdd/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/debugger/kdd/Makefile +2 -2
@@ -24,8 +24,8 @@ distclean: clean .PHONY: install install: all [ -d $(DESTDIR)$(sbindir) ] || $(INSTALL_DIR) $(DESTDIR)$(sbindir) - $(INSTALL_PROG) kdd $(DESTDIR)$(sbindir)/kdd + $(INSTALL_PROG) kdd $(DESTDIR)$(sbindir)/xen-kdd .PHONY: uninstall uninstall: - rm -f $(DESTDIR)$(sbindir)/kdd + rm -f $(DESTDIR)$(sbindir)/xen-kdd
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'
Quoted 1 line · Ian Jackson
`kdd' is an unfortunate namespace landgrab.
Bah, humbug, etc. :) Can we have a note in the changelog for the next release to warn the few kdd users that we've done this?
Quoted 1 line
Signed-off-by Ian Jackson <[email protected]>
Cheers,
Tim.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'
Tim Deegan writes ("Re: [PATCH 18/18] tools/debugger/kdd: Install as xen-kdd', not just kdd'"):
Quoted 5 lines
Quoted 1 line · Ian Jackson
`kdd' is an unfortunate namespace landgrab.
Bah, humbug, etc. :) Can we have a note in the changelog for the next release to warn the few kdd users that we've done this?
Mmm, sorry. Err, where are such release notes collected ?
CC'ing Juergen as RM.
Quoted 3 lines
Quoted 1 line
Signed-off-by Ian Jackson <[email protected]>Acked-by Tim Deegan <[email protected]>
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'
Quoted 8 lines · Ian Jackson
Tim Deegan writes ("Re: [PATCH 18/18]
tools/debugger/kdd: Install asxen-kdd', not justkdd'"):Quoted 5 lines
Quoted 1 line · Ian Jackson
`kdd' is an unfortunate namespace landgrab.
Bah, humbug, etc. :) Can we have a note in the changelog for the next release to warn the few kdd users that we've done this?
Mmm, sorry. Err, where are such release notes collected ?
I believe this is a manual process triggered by the Community Manager.
I'm fine with collecting RN snipplets for the upcoming release, of course.
Ian, another question: could we add a link to the release note of the related version on:
https://xenbits.xen.org/docs/unstable/support-matrix.html
like it was done on:
https://wiki.xenproject.org/wiki/Xen_Project_Release_Features
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'
Juergen Gross writes ("Re: [Xen-devel] [PATCH 18/18] tools/debugger/kdd: Install as xen-kdd', not just kdd'"):
Quoted 8 lines · Ian Jackson
Quoted 7 lines
Tim Deegan writes ("Re: [PATCH 18/18]
tools/debugger/kdd: Install asxen-kdd', not justkdd'"):Quoted 5 lines
Quoted 1 line · Ian Jackson
`kdd' is an unfortunate namespace landgrab.
Bah, humbug, etc. :) Can we have a note in the changelog for the next release to warn the few kdd users that we've done this?
Quoted 6 lines
Quoted 1 line
Mmm, sorry. Err, where are such release notes collected ?
I believe this is a manual process triggered by the Community Manager.
I'm fine with collecting RN snipplets for the upcoming release, of course.
Thanks. Can you add kdd -> xen-kdd to that list then please ?
Quoted 4 lines
Ian, another question: could we add a link to the release note of the related version on:
Yes, I think so. That page is generated by
docs/support-matrix-generate
docs/parse-support-md
which consumes
SUPPORT.md
from each tree.
I think if we change SUPPORT.md to have a proper hyperlink to the release notes, in each tree, in the Release Support indented stanza, it will appear on the support matrix page.
That is better than having the url be magically inserted by the matrix generation machinery because it will appear in places like this too
https://xenbits.xen.org/docs/4.11-testing/SUPPORT.html
Would you prepare a patch for 4.11 to add the RN URL ? You can perhaps test the support matrix output by running a variant of the rune at the top of
docs/support-matrix-generate
and I will fix the matrix code it if it doesn't seem to work :-).
Regards,
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Ian Jackson writes ("[PATCH 00/18] Miscellaneous build and docs, fixes from Debian"):
Quoted 2 lines
Bastian Blank (1):
Ian Jackson (17):
Thanks to the reviewers. I have pushed to staging these patches, which were acked/reviewed and seemed to me to be uncontroversial:
Quoted 4 lines
docs/man: Fix two typos detected by the Debian lintian tool
tools/xentrace/xenalyze: Fix typos detected by lintian
Various: Fix typosunkown',retreive' (detected by lintian)
Various: Fix typo `occured'
Quoted 8 lines
Various: Fix typo
reseting' tools/python/xen/lowlevel: Fix typosucess'
Various: Fix typo `infomation'
Various: Fix typo `mappping'
docs/man: Provide properly-formatted NAME sections docs/man/xen-pv-channel.pod.7: Remove a spurious blank linetools/xenstat: Fix shared library version
libfsimage: Honour general LDFLAGS
Subject to further comments, I will repost the remainder as a v2 of the series.
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel