Skip to contentSkip to conversation

Stop enforcing -g for some of the tools.

PATCH In review John Levon 3 participants 3 messages Oct 31, 2006 – Nov 1, 2006

lore
Share & tools
lore

John Levon

author
#0 lore raw

PATCH 1/1 Stop enforcing -g for some of the tools.

# HG changeset patch
# User [email protected]
# Date 1162306981 28800
# Node ID 751794d972d79f1a2db4d6cee2df06bc88c51051 # Parent 48c0b3276b21492477df6c4c430c793e2afefbd4 Stop enforcing -g for some of the tools.

tools/console/Makefile +1 -1
@@ -5,7 +5,7 @@ DAEMON_INSTALL_DIR = /usr/sbin
 DAEMON_INSTALL_DIR = /usr/sbin
 CLIENT_INSTALL_DIR = /usr/$(LIBDIR)/xen/bin
 
-CFLAGS  += -Werror -g
+CFLAGS  += -Werror
 
 CFLAGS  += -I $(XEN_LIBXC)
 CFLAGS  += -I $(XEN_XENSTORE)
tools/xenmon/Makefile +1 -1
@@ -15,7 +15,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 sbindir=/usr/sbin
 
-CFLAGS  += -Werror -g
+CFLAGS  += -Werror
 CFLAGS  += -I $(XEN_XC)
 CFLAGS  += -I $(XEN_LIBXC)
 LDFLAGS += -L $(XEN_LIBXC)
tools/xenstore/Makefile +1 -1
@@ -6,7 +6,7 @@ MINOR = 0
 MINOR = 0
 
 PROFILE=#-pg
-BASECFLAGS=-Wall -g -Werror
+BASECFLAGS=-Werror
 # Make gcc generate dependencies.
 BASECFLAGS += -Wp,-MD,.$(@F).d
 PROG_DEP = .*.d
#1 lore raw

Hi, John

I have small questions.

The following option is written in $(XEN_ROOT)/Config.mk.
=====================
ifneq ($(debug),y)
CFLAGS += -DNDEBUG
else
CFLAGS += -g
endif
=====================

So I think tools is compiled with -g by default if your patch is applied. Am I right?

Quoted 9 lines
tools/xenstore/Makefile +0 -0
@@ -6,7 +6,7 @@ MINOR = 0

MINOR = 0

PROFILE=#-pg

tools/xenstore/Makefile +1 -1
-BASECFLAGS=-Wall -g -Werror
+BASECFLAGS=-Werror
Quoted 3 lines

# Make gcc generate dependencies.
BASECFLAGS += -Wp,-MD,.$(@F).d
PROG_DEP = .*.d

Why do you remove -Wall?

Best Regards,

Akio Takebe

#2 lore raw
Quoted 2 lines · Akio Takebe

So I think tools is compiled with -g by default if your patch is applied. Am I right?

If debug=y, yes.

Quoted 1 line

Why do you remove -Wall?

It's picked up from Config.mk.

-- Keir