icedtea7-native: provide packageconfig for giflib
PATCH 1/6 icedtea7-native: provide packageconfig for giflib
Provide PACKAGECONFIG for giflib to remove dependency on meta-oe layer.
Signed-off-by Maxin B. John <[email protected]>
--- recipes-core/icedtea/icedtea7-native.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
recipes-core/icedtea/icedtea7-native.inc +2 -1
@@ -5,7 +5,7 @@ INC_PR = "r1" DEPENDS = "virtual/javac-native virtual/java-native classpath-native \ rhino-native ant-native libxslt-native attr-native \ - giflib-native jpeg-native libpng-native \ + jpeg-native libpng-native \ glib-2.0-native freetype-native zlib-native \ fontconfig-native zip-native \ unzip-native make-native util-linux-native\
@@ -13,6 +13,7 @@ DEPENDS = "virtual/javac-native virtual/java-native classpath-native \ PACKAGECONFIG ??= "" PACKAGECONFIG[x11] = ",--disable-headful,libx11-native xproto-native libxt-native libxext-native libxrender-native" +PACKAGECONFIG[gif] = ",--disable-system-gif, giflib-native" OEMAKE_BUILD_HEADLESS_ONLY = "${@bb.utils.contains('PACKAGECONFIG', 'x11', '', 'BUILD_HEADLESS_ONLY=1', d)}" CFLAGS_append = "${@bb.utils.contains('PACKAGECONFIG', 'x11', '', ' -DHEADLESS=true', d)}"
Signature · 1 line
2.4.0
PATCH 2/6 openjdk-7-common: provide packageconfig for giflib and krb5
Provide PACKAGECONFIG for giflib and krb5 to remove dependency on meta-oe layer.
Signed-off-by Maxin B. John <[email protected]>
--- recipes-core/openjdk/openjdk-7-common.inc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
recipes-core/openjdk/openjdk-7-common.inc +6 -3
@@ -26,10 +26,9 @@ PROVIDES += "${JDKPN}" DEPENDS = " \ icedtea7-native zip-native ant-native \ zlib libxslt-native \ - jpeg libpng giflib \ + jpeg libpng \ gtk+ glib-2.0 \ - cups fontconfig \ - rhino krb5 \ + cups fontconfig rhino \ libxt libxinerama libxrender libxtst libxi \ freetype alsa-lib libffi \ attr \
@@ -59,6 +58,10 @@ export CACAO_CONFIGURE_ARGS = " \ JAVA_HOME[unexport] = "1" +PACKAGECONFIG ??= "" +PACKAGECONFIG[gif] = ",--disable-system-gif, giflib" +PACKAGECONFIG[kerberos] = ",--disable-system-kerberos, krb5" + EXTRA_OECONF = " \ --enable-downloading=no \ \
Signature · 1 line
2.4.0
PATCH 3/6 openjdk-8-cross: provide packageconfig for krb5
In reply to Maxin B. JohnProvide PACKAGECONFIG for kerberos to remove dependency on meta-oe layer.
Signed-off-by Maxin B. John <[email protected]>
--- recipes-core/openjdk/openjdk-8-cross.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
recipes-core/openjdk/openjdk-8-cross.inc +2 -1
@@ -18,7 +18,7 @@ PATCHES_URI_append = "\ DEPENDS = "\ openjdk-8-native zip-native ant-native libxslt \ - jpeg libpng krb5 libffi fontconfig freetype \ + jpeg libpng libffi fontconfig freetype \ " PRIVATE_LIBS = "\
@@ -49,6 +49,7 @@ PACKAGECONFIG[zero] = "--with-jvm-variants=zero,,," PACKAGECONFIG[shark] = "--with-jvm-variants=zeroshark,,llvm3.5," PACKAGECONFIG[repack] = ",,," +PACKAGECONFIG[kerberos] = "--enable-system-kerberos,,krb5," CACHED_CONFIGUREVARS = " \ ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'ac_x_includes=${STAGING_INCDIR}', '', d)} \
Signature · 1 line
2.4.0
PATCH 4/6 openjdk-8-native: provide packageconfig for giflib
In reply to Maxin B. Johnprovide PACKAGECONFIG for giflib to remove dependency on meta-oe layer.
Signed-off-by Maxin B. John <[email protected]>
--- recipes-core/openjdk/openjdk-8-native.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
recipes-core/openjdk/openjdk-8-native.inc +2 -1
@@ -2,7 +2,7 @@ JDK_DIR = "openjdk-8-native" DEPENDS = "\ icedtea7-native ant-native \ libxslt-native attr-native \ - giflib-native jpeg-native libpng-native \ + jpeg-native libpng-native \ glib-2.0-native freetype-native fontconfig-native \ zlib-native zip-native \ unzip-native make-native \
@@ -14,6 +14,7 @@ PACKAGECONFIG[x11] = "--with-x,,libx11-native xproto-native libxt-native libxext PACKAGECONFIG[cups] = "--with-cups,,cups" PACKAGECONFIG[alsa] = "--with-alsa,,alsa-lib-native" PACKAGECONFIG[jce] = "--enable-unlimited-crypto,," +PACKAGECONFIG[gif] = "--with-giflib,,giflib-native" EXTRA_OECONF_append = "\ --with-jobs=${@java_get_parallel_make(d)} \
Signature · 1 line
2.4.0
PATCH 5/6 bdwgc: import from meta-oe
In reply to Maxin B. Johnkeep a copy of bdwgc recipe in meta-java from meta-oe layer. cacao in meta-java depends on bdwgc.
Signed-off-by Maxin B. John <[email protected]>
--- ...ac-add-check-for-NO_GETCONTEXT-definition.patch | 29 +++++++++++++++ recipes-extended/bdwgc/bdwgc/musl_header_fix.patch | 27 ++++++++++++++ recipes-extended/bdwgc/bdwgc_7.6.0.bb | 42 ++++++++++++++++++++++ 3 files changed, 98 insertions(+) create mode 100644 recipes-extended/bdwgc/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch create mode 100644 recipes-extended/bdwgc/bdwgc/musl_header_fix.patch create mode 100644 recipes-extended/bdwgc/bdwgc_7.6.0.bb
recipes-extended/bdwgc/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch new file +29 -0
@@ -0,0 +1,29 @@ +configure.ac: add check for NO_GETCONTEXT definition + +Signed-off-by: Samuel Martin <[email protected]> +[[email protected]: add a comment, change variable name, use + AS_IF, remove debug traces, use AC_CHECK_FUNCS (as suggested by + Thomas)] +Signed-off-by: "Yann E. MORIN" <[email protected]> +Cc: Thomas Petazzoni <[email protected]> + +--- +Upstream-Status: Pending + configure.ac | 6 ++++++ + 1 file changed, 6 insertions(+) + +--- bdwgc-7.2f.orig/configure.ac 2014-06-01 19:00:47.000000000 +0200 ++++ bdwgc-7.2f/configure.ac 2014-12-23 14:13:11.585716713 +0100 +@@ -365,6 +365,12 @@ + AC_MSG_RESULT($ac_cv_fno_strict_aliasing) + fi + ++# Check for getcontext (uClibc can be configured without it, for example) ++AC_CHECK_FUNCS([getcontext]) ++AS_IF([test "$ac_cv_func_getcontext" = "no"], ++ [CFLAGS="$CFLAGS -DNO_GETCONTEXT" ++ CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"]) ++ + case "$host" in + # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64 + # and unnecessary everywhere.
recipes-extended/bdwgc/bdwgc/musl_header_fix.patch new file +27 -0
@@ -0,0 +1,27 @@ +Add missing header to avoid: + +| 1472659610.016355: ../git/pthread_stop_world.c: In function 'GC_brief_async_signal_safe_sleep': +| 1472659610.0540252: ../git/pthread_stop_world.c:397:22: error: storage size of 'tv' isn't known +| 1472659610.0540252: struct timeval tv; +| 1472659610.0540252: ^~ +| 1472659610.054099: ../git/pthread_stop_world.c:397:22: warning: unused variable 'tv' [-Wunused-variable] +| 1472659610.054099: struct timeval tv; +| 1472659610.054099: ^~ +| 1472659610.054099: Makefile:1530: recipe for target 'pthread_stop_world.lo' failed + +in musl builds. + +Upstream-Status: Pending + +Index: git/pthread_stop_world.c +=================================================================== +--- git.orig/pthread_stop_world.c ++++ git/pthread_stop_world.c +@@ -45,6 +45,7 @@ + #include <semaphore.h> + #include <errno.h> + #include <unistd.h> ++#include <sys/time.h> + #include "atomic_ops.h" + + /* It's safe to call original pthread_sigmask() here. */
recipes-extended/bdwgc/bdwgc_7.6.0.bb new file +42 -0
42 lines not on this page · raw message
Signature · 1 line
2.4.0
Re: [meta-java][PATCH 5/6] bdwgc: import from meta-oe
Quoted 2 lines · Maxin B. John
keep a copy of bdwgc recipe in meta-java from meta-oe layer. cacao in meta-java depends on bdwgc.
Duplicating recipes in recipes is frowned upon.
Shouldn't we have the discussion why you are not proposing this for Openembedded-core instead of duplicating the recipe? Duping a recipe just to drop a layer dependency isn't a long term solution.
Philip
Quoted 128 lines
Signed-off-by Maxin B. John <[email protected]>--- ...ac-add-check-for-NO_GETCONTEXT-definition.patch | 29 +++++++++++++++ recipes-extended/bdwgc/bdwgc/musl_header_fix.patch | 27 ++++++++++++++ recipes-extended/bdwgc/bdwgc_7.6.0.bb | 42 ++++++++++++++++++++++ 3 files changed, 98 insertions(+) create mode 100644 recipes-extended/bdwgc/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch create mode 100644 recipes-extended/bdwgc/bdwgc/musl_header_fix.patch create mode 100644 recipes-extended/bdwgc/bdwgc_7.6.0.bbrecipes-extended/bdwgc/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch new file +29
-0@@ -0,0 +1,29 @@ +configure.ac: add check for NO_GETCONTEXT definition + +Signed-off-by: Samuel Martin <[email protected]> +[[email protected]: add a comment, change variable name, use + AS_IF, remove debug traces, use AC_CHECK_FUNCS (as suggested by + Thomas)] +Signed-off-by: "Yann E. MORIN" <[email protected]> +Cc: Thomas Petazzoni <[email protected]> + +--- +Upstream-Status: Pending + configure.ac | 6 ++++++ + 1 file changed, 6 insertions(+) + +--- bdwgc-7.2f.orig/configure.ac 2014-06-01 19:00:47.000000000 +0200 ++++ bdwgc-7.2f/configure.ac 2014-12-23 14:13:11.585716713 +0100 +@@ -365,6 +365,12 @@ + AC_MSG_RESULT($ac_cv_fno_strict_aliasing) + fi + ++# Check for getcontext (uClibc can be configured without it, for example) ++AC_CHECK_FUNCS([getcontext]) ++AS_IF([test "$ac_cv_func_getcontext" = "no"], ++ [CFLAGS="$CFLAGS -DNO_GETCONTEXT" ++ CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"]) ++ + case "$host" in + # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64 + # and unnecessary everywhere.recipes-extended/bdwgc/bdwgc/musl_header_fix.patch new file +27
-0@@ -0,0 +1,27 @@ +Add missing header to avoid: + +| 1472659610.016355: ../git/pthread_stop_world.c: In function 'GC_brief_async_signal_safe_sleep': +| 1472659610.0540252: ../git/pthread_stop_world.c:397:22: error: storage size of 'tv' isn't known +| 1472659610.0540252: struct timeval tv; +| 1472659610.0540252: ^~ +| 1472659610.054099: ../git/pthread_stop_world.c:397:22: warning: unused variable 'tv' [-Wunused-variable] +| 1472659610.054099: struct timeval tv; +| 1472659610.054099: ^~ +| 1472659610.054099: Makefile:1530: recipe for target 'pthread_stop_world.lo' failed + +in musl builds. + +Upstream-Status: Pending + +Index: git/pthread_stop_world.c +=================================================================== +--- git.orig/pthread_stop_world.c ++++ git/pthread_stop_world.c +@@ -45,6 +45,7 @@ + #include <semaphore.h> + #include <errno.h> + #include <unistd.h> ++#include <sys/time.h> + #include "atomic_ops.h" + + /* It's safe to call original pthread_sigmask() here. */recipes-extended/bdwgc/bdwgc_7.6.0.bb new file +42
-0@@ -0,0 +1,42 @@ +SUMMARY = "A garbage collector for C and C++" + +DESCRIPTION = "The Boehm-Demers-Weiser conservative garbage collector can be\ + used as a garbage collecting replacement for C malloc or C++ new. It allows\ + you to allocate memory basically as you normally would, without explicitly\ + deallocating memory that is no longer useful. The collector automatically\ + recycles memory when it determines that it can no longer be otherwise\ + accessed.\ + The collector is also used by a number of programming language\ + implementations that either use C as intermediate code, want to facilitate\ + easier interoperation with C libraries, or just prefer the simple collector\ + interface.\ + Alternatively, the garbage collector may be used as a leak detector for C\ + or C++ programs, though that is not its primary goal.\ + Empirically, this collector works with most unmodified C programs, simply\ + by replacing malloc with GC_malloc calls, replacing realloc with GC_realloc\ + calls, and removing free calls." + +HOMEPAGE = "http://www.hboehm.info/gc/" +SECTION = "devel" +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://README.QUICK;md5=4f81f24ec69726c312487c2ac740e9e3" + +SRCREV = "8ac1d84a40eb7a431fec1b8097e3f24b48fb23fa" +SRC_URI = "git://github.com/ivmai/bdwgc.git \ + file://0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch \ + file://musl_header_fix.patch \ + " + +FILES_${PN}-doc = "${datadir}" + +S = "${WORKDIR}/git" + +ARM_INSTRUCTION_SET = "arm" + +inherit autotools pkgconfig + +# by default use external libatomic-ops +PACKAGECONFIG ??= "libatomic-ops" +PACKAGECONFIG[libatomic-ops] = "--with-libatomic-ops=yes,--with-libatomic-ops=no,libatomic-ops" + +BBCLASSEXTEND = "native nativesdk"
Re: [meta-java][PATCH 5/6] bdwgc: import from meta-oe
Hi Philip,
Quoted 5 lines · Philip Balister
Quoted 2 lines · Maxin B. John
keep a copy of bdwgc recipe in meta-java from meta-oe layer. cacao in meta-java depends on bdwgc.
Duplicating recipes in recipes is frowned upon.
Thanks for the review. Makes sense here. Will try to find a way to avoid this.
Quoted 3 lines
Shouldn't we have the discussion why you are not proposing this for Openembedded-core instead of duplicating the recipe? Duping a recipe just to drop a layer dependency isn't a long term solution.
agree.
Quoted 1 line
Philip
Best Regards,
Maxin
Quoted 133 lines
Quoted 118 lines
Signed-off-by Maxin B. John <[email protected]>--- ...ac-add-check-for-NO_GETCONTEXT-definition.patch | 29 +++++++++++++++ recipes-extended/bdwgc/bdwgc/musl_header_fix.patch | 27 ++++++++++++++ recipes-extended/bdwgc/bdwgc_7.6.0.bb | 42 ++++++++++++++++++++++ 3 files changed, 98 insertions(+) create mode 100644 recipes-extended/bdwgc/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch create mode 100644 recipes-extended/bdwgc/bdwgc/musl_header_fix.patch create mode 100644 recipes-extended/bdwgc/bdwgc_7.6.0.bbrecipes-extended/bdwgc/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch new file +29
-0@@ -0,0 +1,29 @@ +configure.ac: add check for NO_GETCONTEXT definition + +Signed-off-by: Samuel Martin <[email protected]> +[[email protected]: add a comment, change variable name, use + AS_IF, remove debug traces, use AC_CHECK_FUNCS (as suggested by + Thomas)] +Signed-off-by: "Yann E. MORIN" <[email protected]> +Cc: Thomas Petazzoni <[email protected]> + +--- +Upstream-Status: Pending + configure.ac | 6 ++++++ + 1 file changed, 6 insertions(+) + +--- bdwgc-7.2f.orig/configure.ac 2014-06-01 19:00:47.000000000 +0200 ++++ bdwgc-7.2f/configure.ac 2014-12-23 14:13:11.585716713 +0100 +@@ -365,6 +365,12 @@ + AC_MSG_RESULT($ac_cv_fno_strict_aliasing) + fi + ++# Check for getcontext (uClibc can be configured without it, for example) ++AC_CHECK_FUNCS([getcontext]) ++AS_IF([test "$ac_cv_func_getcontext" = "no"], ++ [CFLAGS="$CFLAGS -DNO_GETCONTEXT" ++ CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"]) ++ + case "$host" in + # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64 + # and unnecessary everywhere.recipes-extended/bdwgc/bdwgc/musl_header_fix.patch new file +27
-0@@ -0,0 +1,27 @@ +Add missing header to avoid: + +| 1472659610.016355: ../git/pthread_stop_world.c: In function 'GC_brief_async_signal_safe_sleep': +| 1472659610.0540252: ../git/pthread_stop_world.c:397:22: error: storage size of 'tv' isn't known +| 1472659610.0540252: struct timeval tv; +| 1472659610.0540252: ^~ +| 1472659610.054099: ../git/pthread_stop_world.c:397:22: warning: unused variable 'tv' [-Wunused-variable] +| 1472659610.054099: struct timeval tv; +| 1472659610.054099: ^~ +| 1472659610.054099: Makefile:1530: recipe for target 'pthread_stop_world.lo' failed + +in musl builds. + +Upstream-Status: Pending + +Index: git/pthread_stop_world.c +=================================================================== +--- git.orig/pthread_stop_world.c ++++ git/pthread_stop_world.c +@@ -45,6 +45,7 @@ + #include <semaphore.h> + #include <errno.h> + #include <unistd.h> ++#include <sys/time.h> + #include "atomic_ops.h" + + /* It's safe to call original pthread_sigmask() here. */recipes-extended/bdwgc/bdwgc_7.6.0.bb new file +32
-0@@ -0,0 +1,42 @@ +SUMMARY = "A garbage collector for C and C++" + +DESCRIPTION = "The Boehm-Demers-Weiser conservative garbage collector can be\ + used as a garbage collecting replacement for C malloc or C++ new. It allows\ + you to allocate memory basically as you normally would, without explicitly\ + deallocating memory that is no longer useful. The collector automatically\ + recycles memory when it determines that it can no longer be otherwise\ + accessed.\ + The collector is also used by a number of programming language\ + implementations that either use C as intermediate code, want to facilitate\ + easier interoperation with C libraries, or just prefer the simple collector\ + interface.\ + Alternatively, the garbage collector may be used as a leak detector for C\ + or C++ programs, though that is not its primary goal.\ + Empirically, this collector works with most unmodified C programs, simply\ + by replacing malloc with GC_malloc calls, replacing realloc with GC_realloc\ + calls, and removing free calls." + +HOMEPAGE = "http://www.hboehm.info/gc/" +SECTION = "devel" +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://README.QUICK;md5=4f81f24ec69726c312487c2ac740e9e3" + +SRCREV = "8ac1d84a40eb7a431fec1b8097e3f24b48fb23fa" +SRC_URI = "git://github.com/ivmai/bdwgc.git \ + file://0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch \ + file://musl_header_fix.patch \ + " + +FILES_${PN}-doc = "${datadir}" + +S = "${WORKDIR}/git"recipes-extended/bdwgc/bdwgc_7.6.0.bb line 42
Quoted 10 lines
recipes-extended/bdwgc/bdwgc_7.6.0.bb new file +10
-0+ +ARM_INSTRUCTION_SET = "arm" + +inherit autotools pkgconfig + +# by default use external libatomic-ops +PACKAGECONFIG ??= "libatomic-ops" +PACKAGECONFIG[libatomic-ops] = "--with-libatomic-ops=yes,--with-libatomic-ops=no,libatomic-ops" + +BBCLASSEXTEND = "native nativesdk"--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
Re: [meta-java][PATCH 5/6] bdwgc: import from meta-oe
Quoted 9 lines · Maxin B. John
Hi Philip,
Quoted 5 lines · Philip Balister
Quoted 2 lines · Maxin B. John
keep a copy of bdwgc recipe in meta-java from meta-oe layer. cacao in meta-java depends on bdwgc.
Duplicating recipes in recipes is frowned upon.
Quoted 7 lines
Thanks for the review. Makes sense here. Will try to find a way to avoid this.
Quoted 3 lines
Shouldn't we have the discussion why you are not proposing this for Openembedded-core instead of duplicating the recipe? Duping a recipe just to drop a layer dependency isn't a long term solution.
agree.
Meta-oe has one recipe that uses it. I'm not sure about other layers.
Does the layer index let us search for recipes that depend on another recipe?
Philip
Quoted 140 lines
Quoted 2 lines
Philip
Best Regards,
MaxinQuoted 133 lines
Quoted 118 lines
Signed-off-by Maxin B. John <[email protected]>--- ...ac-add-check-for-NO_GETCONTEXT-definition.patch | 29 +++++++++++++++ recipes-extended/bdwgc/bdwgc/musl_header_fix.patch | 27 ++++++++++++++ recipes-extended/bdwgc/bdwgc_7.6.0.bb | 42 ++++++++++++++++++++++ 3 files changed, 98 insertions(+) create mode 100644 recipes-extended/bdwgc/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch create mode 100644 recipes-extended/bdwgc/bdwgc/musl_header_fix.patch create mode 100644 recipes-extended/bdwgc/bdwgc_7.6.0.bbrecipes-extended/bdwgc/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch new file +29
-0@@ -0,0 +1,29 @@ +configure.ac: add check for NO_GETCONTEXT definition + +Signed-off-by: Samuel Martin <[email protected]> +[[email protected]: add a comment, change variable name, use + AS_IF, remove debug traces, use AC_CHECK_FUNCS (as suggested by + Thomas)] +Signed-off-by: "Yann E. MORIN" <[email protected]> +Cc: Thomas Petazzoni <[email protected]> + +--- +Upstream-Status: Pending + configure.ac | 6 ++++++ + 1 file changed, 6 insertions(+) + +--- bdwgc-7.2f.orig/configure.ac 2014-06-01 19:00:47.000000000 +0200 ++++ bdwgc-7.2f/configure.ac 2014-12-23 14:13:11.585716713 +0100 +@@ -365,6 +365,12 @@ + AC_MSG_RESULT($ac_cv_fno_strict_aliasing) + fi + ++# Check for getcontext (uClibc can be configured without it, for example) ++AC_CHECK_FUNCS([getcontext]) ++AS_IF([test "$ac_cv_func_getcontext" = "no"], ++ [CFLAGS="$CFLAGS -DNO_GETCONTEXT" ++ CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"]) ++ + case "$host" in + # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64 + # and unnecessary everywhere.recipes-extended/bdwgc/bdwgc/musl_header_fix.patch new file +27
-0@@ -0,0 +1,27 @@ +Add missing header to avoid: + +| 1472659610.016355: ../git/pthread_stop_world.c: In function 'GC_brief_async_signal_safe_sleep': +| 1472659610.0540252: ../git/pthread_stop_world.c:397:22: error: storage size of 'tv' isn't known +| 1472659610.0540252: struct timeval tv; +| 1472659610.0540252: ^~ +| 1472659610.054099: ../git/pthread_stop_world.c:397:22: warning: unused variable 'tv' [-Wunused-variable] +| 1472659610.054099: struct timeval tv; +| 1472659610.054099: ^~ +| 1472659610.054099: Makefile:1530: recipe for target 'pthread_stop_world.lo' failed + +in musl builds. + +Upstream-Status: Pending + +Index: git/pthread_stop_world.c +=================================================================== +--- git.orig/pthread_stop_world.c ++++ git/pthread_stop_world.c +@@ -45,6 +45,7 @@ + #include <semaphore.h> + #include <errno.h> + #include <unistd.h> ++#include <sys/time.h> + #include "atomic_ops.h" + + /* It's safe to call original pthread_sigmask() here. */recipes-extended/bdwgc/bdwgc_7.6.0.bb new file +32
-0@@ -0,0 +1,42 @@ +SUMMARY = "A garbage collector for C and C++" + +DESCRIPTION = "The Boehm-Demers-Weiser conservative garbage collector can be\ + used as a garbage collecting replacement for C malloc or C++ new. It allows\ + you to allocate memory basically as you normally would, without explicitly\ + deallocating memory that is no longer useful. The collector automatically\ + recycles memory when it determines that it can no longer be otherwise\ + accessed.\ + The collector is also used by a number of programming language\ + implementations that either use C as intermediate code, want to facilitate\ + easier interoperation with C libraries, or just prefer the simple collector\ + interface.\ + Alternatively, the garbage collector may be used as a leak detector for C\ + or C++ programs, though that is not its primary goal.\ + Empirically, this collector works with most unmodified C programs, simply\ + by replacing malloc with GC_malloc calls, replacing realloc with GC_realloc\ + calls, and removing free calls." + +HOMEPAGE = "http://www.hboehm.info/gc/" +SECTION = "devel" +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://README.QUICK;md5=4f81f24ec69726c312487c2ac740e9e3" + +SRCREV = "8ac1d84a40eb7a431fec1b8097e3f24b48fb23fa" +SRC_URI = "git://github.com/ivmai/bdwgc.git \ + file://0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch \ + file://musl_header_fix.patch \ + " + +FILES_${PN}-doc = "${datadir}" + +S = "${WORKDIR}/git"recipes-extended/bdwgc/bdwgc_7.6.0.bb line 42
Quoted 10 lines
recipes-extended/bdwgc/bdwgc_7.6.0.bb new file +10
-0+ +ARM_INSTRUCTION_SET = "arm" + +inherit autotools pkgconfig + +# by default use external libatomic-ops +PACKAGECONFIG ??= "libatomic-ops" +PACKAGECONFIG[libatomic-ops] = "--with-libatomic-ops=yes,--with-libatomic-ops=no,libatomic-ops" + +BBCLASSEXTEND = "native nativesdk"--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
Re: [meta-java][PATCH 5/6] bdwgc: import from meta-oe
Hi,
Quoted 12 lines · Philip Balister
Quoted 11 lines · Maxin B. John
Hi Philip,
Quoted 5 lines · Philip Balister
Quoted 2 lines · Maxin B. John
keep a copy of bdwgc recipe in meta-java from meta-oe layer. cacao in meta-java depends on bdwgc.
Duplicating recipes in recipes is frowned upon.
Thanks for the review. Makes sense here. Will try to find a way to avoid this.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Shouldn't we have the discussion why you are not proposing this for Openembedded-core instead of duplicating the recipe? Duping a recipe just to drop a layer dependency isn't a long term solution.
agree.
Meta-oe has one recipe that uses it. I'm not sure about other layers.
zile in meta-oe depends on bdwgc.
Quoted 2 lines
Does the layer index let us search for recipes that depend on another recipe?
https://layers.openembedded.org doesn't seems to help a lot in this case.
Quoted 1 line
Philip
Warm Regards,
Maxin
Quoted 135 lines
Quoted 135 lines
Quoted 134 lines
Quoted 119 lines
Signed-off-by Maxin B. John <[email protected]>--- ...ac-add-check-for-NO_GETCONTEXT-definition.patch | 29 +++++++++++++++ recipes-extended/bdwgc/bdwgc/musl_header_fix.patch | 27 ++++++++++++++ recipes-extended/bdwgc/bdwgc_7.6.0.bb | 42 ++++++++++++++++++++++ 3 files changed, 98 insertions(+) create mode 100644 recipes-extended/bdwgc/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch create mode 100644 recipes-extended/bdwgc/bdwgc/musl_header_fix.patch create mode 100644 recipes-extended/bdwgc/bdwgc_7.6.0.bbrecipes-extended/bdwgc/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch new file +29
-0@@ -0,0 +1,29 @@ +configure.ac: add check for NO_GETCONTEXT definition + +Signed-off-by: Samuel Martin <[email protected]> +[[email protected]: add a comment, change variable name, use + AS_IF, remove debug traces, use AC_CHECK_FUNCS (as suggested by + Thomas)] +Signed-off-by: "Yann E. MORIN" <[email protected]> +Cc: Thomas Petazzoni <[email protected]> + +--- +Upstream-Status: Pending + configure.ac | 6 ++++++ + 1 file changed, 6 insertions(+) + +--- bdwgc-7.2f.orig/configure.ac 2014-06-01 19:00:47.000000000 +0200 ++++ bdwgc-7.2f/configure.ac 2014-12-23 14:13:11.585716713 +0100 +@@ -365,6 +365,12 @@ + AC_MSG_RESULT($ac_cv_fno_strict_aliasing) + fi + ++# Check for getcontext (uClibc can be configured without it, for example) ++AC_CHECK_FUNCS([getcontext]) ++AS_IF([test "$ac_cv_func_getcontext" = "no"], ++ [CFLAGS="$CFLAGS -DNO_GETCONTEXT" ++ CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"]) ++ + case "$host" in + # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64 + # and unnecessary everywhere.recipes-extended/bdwgc/bdwgc/musl_header_fix.patch new file +27
-0@@ -0,0 +1,27 @@ +Add missing header to avoid: + +| 1472659610.016355: ../git/pthread_stop_world.c: In function 'GC_brief_async_signal_safe_sleep': +| 1472659610.0540252: ../git/pthread_stop_world.c:397:22: error: storage size of 'tv' isn't known +| 1472659610.0540252: struct timeval tv; +| 1472659610.0540252: ^~ +| 1472659610.054099: ../git/pthread_stop_world.c:397:22: warning: unused variable 'tv' [-Wunused-variable] +| 1472659610.054099: struct timeval tv; +| 1472659610.054099: ^~ +| 1472659610.054099: Makefile:1530: recipe for target 'pthread_stop_world.lo' failed + +in musl builds. + +Upstream-Status: Pending + +Index: git/pthread_stop_world.c +=================================================================== +--- git.orig/pthread_stop_world.c ++++ git/pthread_stop_world.c +@@ -45,6 +45,7 @@ + #include <semaphore.h> + #include <errno.h> + #include <unistd.h> ++#include <sys/time.h> + #include "atomic_ops.h" + + /* It's safe to call original pthread_sigmask() here. */recipes-extended/bdwgc/bdwgc_7.6.0.bb new file +32
-0@@ -0,0 +1,42 @@ +SUMMARY = "A garbage collector for C and C++" + +DESCRIPTION = "The Boehm-Demers-Weiser conservative garbage collector can be\ + used as a garbage collecting replacement for C malloc or C++ new. It allows\ + you to allocate memory basically as you normally would, without explicitly\ + deallocating memory that is no longer useful. The collector automatically\ + recycles memory when it determines that it can no longer be otherwise\ + accessed.\ + The collector is also used by a number of programming language\ + implementations that either use C as intermediate code, want to facilitate\ + easier interoperation with C libraries, or just prefer the simple collector\ + interface.\ + Alternatively, the garbage collector may be used as a leak detector for C\ + or C++ programs, though that is not its primary goal.\ + Empirically, this collector works with most unmodified C programs, simply\ + by replacing malloc with GC_malloc calls, replacing realloc with GC_realloc\ + calls, and removing free calls." + +HOMEPAGE = "http://www.hboehm.info/gc/" +SECTION = "devel" +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://README.QUICK;md5=4f81f24ec69726c312487c2ac740e9e3" + +SRCREV = "8ac1d84a40eb7a431fec1b8097e3f24b48fb23fa" +SRC_URI = "git://github.com/ivmai/bdwgc.git \ + file://0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch \ + file://musl_header_fix.patch \ + " + +FILES_${PN}-doc = "${datadir}" + +S = "${WORKDIR}/git"recipes-extended/bdwgc/bdwgc_7.6.0.bb line 42
Quoted 10 lines
recipes-extended/bdwgc/bdwgc_7.6.0.bb new file +10
-0+ +ARM_INSTRUCTION_SET = "arm" + +inherit autotools pkgconfig + +# by default use external libatomic-ops +PACKAGECONFIG ??= "libatomic-ops" +PACKAGECONFIG[libatomic-ops] = "--with-libatomic-ops=yes,--with-libatomic-ops=no,libatomic-ops" + +BBCLASSEXTEND = "native nativesdk"--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
Re: [meta-java][PATCH 5/6] bdwgc: import from meta-oe
In reply to Philip BalisterQuoted 2 lines · NZDT Philip Balister
Does the layer index let us search for recipes that depend on another recipe?
At the moment, no. I have explicitly not done anything with dependencies because they can be dependent on configuration (e.g. DISTRO_FEATURES, PACKAGECONFIG) and I haven't taken the time to figure out how to introspect and present such optional dependencies.
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Re: [meta-java][PATCH 5/6] bdwgc: import from meta-oe
Quoted 8 lines · Paul Eggleton
Quoted 2 lines · NZDT Philip Balister
Does the layer index let us search for recipes that depend on another recipe?
At the moment, no. I have explicitly not done anything with dependencies because they can be dependent on configuration (e.g.
DISTRO_FEATURES, PACKAGECONFIG) and I haven't taken the time to figure out how to introspect and present such optional dependencies.
Thanks Paul. I was wondering since I suspect that over time, the question we are asking will become more important. We already ran into a similar issue with sip.
Maybe it is time for oe-core-not-so-common-depends?
Philip
Quoted 4 lines
Cheers,
Paul
Re: [meta-java][PATCH 5/6] bdwgc: import from meta-oe
Quoted 5 lines · NZDT Philip Balister
Quoted 4 lines · Paul Eggleton
Quoted 2 lines · NZDT Philip Balister
Does the layer index let us search for recipes that depend on another recipe?
Quoted 8 lines
Quoted 4 lines
At the moment, no. I have explicitly not done anything with dependencies because they can be dependent on configuration (e.g.
DISTRO_FEATURES, PACKAGECONFIG) and I haven't taken the time to figure out how to introspect and present such optional dependencies.Thanks Paul. I was wondering since I suspect that over time, the question we are asking will become more important. We already ran into a similar issue with sip.
Right, the layer index really is the right place to be doing this. I've filed a bug:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=12129
Quoted 1 line
Maybe it is time for oe-core-not-so-common-depends?
I'd think we'd want a bit more definition around what goes into such a layer, that title is pretty vague.
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
PATCH 6/6 README: remove meta-oe from documentation
In reply to Maxin B. JohnUpdate the README by removing the dependency on meta-openembedded layer from documentation.
Signed-off-by Maxin B. John <[email protected]>
--- README | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
README +1 -6
@@ -7,11 +7,7 @@ Yocto Project build systems. This layer depends on: URI: git://git.openembedded.org/openembedded-core -branch: krogoth (or master) -revision: HEAD - -URI: git://git.openembedded.org/meta-openembedded -branch: krogoth (or master) +branch: pyro (or master) revision: HEAD Contributing
@@ -69,7 +65,6 @@ For conf/bblayers.conf you have to add BBLAYERS ?= " \ ... - path_to_source/meta-openembedded/meta-oe \ path_to_source/sources/meta-java \ "
Signature · 1 line
2.4.0