pwm: fix pwm-rz-mtu3.c build errors
PATCH v2 1/1 pwm: fix pwm-rz-mtu3.c build errors
From: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld: drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld: drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld: drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld: drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled'
ld: drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld: drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld: drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'
Modify the dependencies of PWM_RZ_MTU3 so that COMPILE_TEST is still allowed but PWM_RZ_MTU3 depends on RZ_MTU3 if it is being built but also allow the latter not to be built.
---
v2: fix typo in Subject;
correct my email address while infradead.org is down;drivers/pwm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/pwm/Kconfig +2 -1
@@ -505,7 +505,8 @@ config PWM_ROCKCHIP config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TEST + depends on RZ_MTU3 || RZ_MTU3=n depends on HAS_IOMEM help This driver exposes the MTU3a PWM Timer controller found in Renesas
Quoted 37 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld:drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled'
ld:drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.
Quoted 6 lines
Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]Cc Biju Das <[email protected]>Cc Uwe Kleine-König <[email protected]>Cc Thierry Reding <[email protected]>
I missed this v2 while I still looked at (implicit) v1. The things I said there still apply for v2. I don't repeat my writings, but here is a link to the archive with what I wrote:
https://lore.kernel.org/linux-pwm/[email protected]/
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Hi Randy,
Quoted 77 lines
-----Original Message-----
From: Randy Dunlap <[email protected]>
Sent: Tuesday, July 18, 2023 7:41 AM
To: [email protected]; [email protected]
Cc: Biju Das <[email protected]>; Thierry Reding <[email protected]>; Uwe Kleine-König <u.kleine- [email protected]>
Subject: [PATCH v2] pwm: fixpwm-rz-mtu3.cbuild errorsFrom: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld:drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled'
ld:drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]Cc Biju Das <[email protected]>Cc Uwe Kleine-König <[email protected]>Cc Thierry Reding <[email protected]>---
v2: fix typo in Subject; correct my email address while infradead.org is down;drivers/pwm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 512
Quoted 9 lines
drivers/pwm/Kconfig +2
-1@@ -505,7 +505,8 @@ config PWM_ROCKCHIP config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TEST + depends on RZ_MTU3 || RZ_MTU3=n depends on HAS_IOMEM help This driver exposes the MTU3a PWM Timer controller found in
The below patch also works fine,
drivers/pwm/Kconfig +1 -1
@@ -505,7 +505,7 @@ config PWM_ROCKCHIP config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on RZ_MTU3 || (COMPILE_TEST && RZ_MTU3) depends on HAS_IOMEM help This driver exposes the MTU3a PWM Timer controller found in Renesas
So shall I send this fix instead.
Cheers,
Biju
Quoted 97 lines · Biju Das
Hi Randy,
Quoted 77 lines
-----Original Message-----
From: Randy Dunlap <[email protected]>
Sent: Tuesday, July 18, 2023 7:41 AM
To: [email protected]; [email protected]
Cc: Biju Das <[email protected]>; Thierry Reding <[email protected]>; Uwe Kleine-König <u.kleine- [email protected]>
Subject: [PATCH v2] pwm: fixpwm-rz-mtu3.cbuild errorsFrom: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld:drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled'
ld:drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]Cc Biju Das <[email protected]>Cc Uwe Kleine-König <[email protected]>Cc Thierry Reding <[email protected]>---
v2: fix typo in Subject; correct my email address while infradead.org is down;drivers/pwm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 512
Quoted 9 lines
drivers/pwm/Kconfig +2
-1@@ -505,7 +505,8 @@ config PWM_ROCKCHIP config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TEST + depends on RZ_MTU3 || RZ_MTU3=n depends on HAS_IOMEM help This driver exposes the MTU3a PWM Timer controller found inThe below patch also works fine,
drivers/pwm/Kconfig +0
-0
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 508
Quoted 5 lines
drivers/pwm/Kconfig +1
-1@@ -505,7 +505,7 @@ config PWM_ROCKCHIP config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on RZ_MTU3 || (COMPILE_TEST && RZ_MTU3)
That's a bit pointless, isn't it? That effectively reduces to just:
depends on RZ_MTU3
Thierry
Hi Thierry,
Thanks for the feedback.
Quoted 115 lines
-----Original Message-----
From: Thierry Reding <[email protected]>
Sent: Tuesday, July 18, 2023 12:44 PM
To: Biju Das <[email protected]>
Cc: Randy Dunlap <[email protected]>; [email protected]; [email protected]; Uwe Kleine-König <u.kleine- [email protected]>; Fabrizio Castro <[email protected]>; [email protected]; Geert Uytterhoeven <[email protected]>
Subject: Re: [PATCH v2] pwm: fixpwm-rz-mtu3.cbuild errorsQuoted 14 lines · Biju Das
Hi Randy,
Quoted 12 lines
-----Original Message-----
From: Randy Dunlap <[email protected]>
Sent: Tuesday, July 18, 2023 7:41 AM
To: [email protected]; [email protected]
Cc: Biju Das <[email protected]>; Thierry Reding <[email protected]>; Uwe Kleine-König <u.kleine- [email protected]>
Subject: [PATCH v2] pwm: fixpwm-rz-mtu3.cbuild errorsFrom: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build
errors:
Quoted 3 lines
Quoted 3 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to`rz_mtu3_disable'
Quoted 7 lines
Quoted 7 lines
ld:
drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference toQuoted 8 lines
Quoted 8 lines
`rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to`rz_mtu3_enable'
Quoted 11 lines
Quoted 11 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':
drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to`rz_mtu3_enable'
Quoted 2 lines
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':
drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to`rz_mtu3_is_enabled'
Quoted 53 lines
Quoted 34 lines
ld:
drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]Cc Biju Das <[email protected]>Cc Uwe Kleine-König <[email protected]>Cc Thierry Reding <[email protected]>---
v2: fix typo in Subject; correct my email address while infradead.org is down;drivers/pwm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 512
Quoted 9 lines
drivers/pwm/Kconfig +2
-1@@ -505,7 +505,8 @@ config PWM_ROCKCHIP config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TEST + depends on RZ_MTU3 || RZ_MTU3=n depends on HAS_IOMEM help This driver exposes the MTU3a PWM Timer controller found inThe below patch also works fine,
drivers/pwm/Kconfig index renamed from drivers/pwm/Kconfig +0
-0
1c8dbb064ee5..56ab2f4b91fe100644drivers/pwm/Kconfig +0
-0@@ -505,7 +505,7 @@ config PWM_ROCKCHIP
Quoted 8 lines
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 508
Quoted 4 lines
drivers/pwm/Kconfig +1
-1config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on RZ_MTU3 || (COMPILE_TEST && RZ_MTU3)That's a bit pointless, isn't it? That effectively reduces to just:
depends on
RZ_MTU3
OK, then Uwe's solution is better.
ie, use the existing "depends on RZ_MTU3 || COMPILE_TEST"
and use
-#if IS_ENABLED(CONFIG_RZ_MTU3)
+#if IS_REACHABLE(CONFIG_RZ_MTU3) in include/linux/mfd/rz-mtu3.h
Cheers,
Biju
Hi Randy,
Quoted 33 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld:drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled'
ld:drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'
Quoted 6 lines
Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]
Thanks for your patch!
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 508
Quoted 8 lines
drivers/pwm/Kconfig +1
-1@@ -505,7 +505,8 @@ config PWM_ROCKCHIP config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TEST
This makes the driver always depend on COMPILE_TEST, which is definitely not what we want.
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 512
Quoted 4 lines
drivers/pwm/Kconfig +1
-0+ depends on RZ_MTU3 || RZ_MTU3=n depends on HAS_IOMEM help This driver exposes the MTU3a PWM Timer controller found in Renesas
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Quoted 49 lines · Geert Uytterhoeven
Hi Randy,
Quoted 33 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld:drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled'
ld:drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'Quoted 6 lines
Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]Thanks for your patch!
Quoted 4 lines
drivers/pwm/Kconfig +0
-0@@ -505,7 +505,8 @@ config PWM_ROCKCHIP
Quoted 7 lines
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 508
Quoted 4 lines
drivers/pwm/Kconfig +1
-1config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TESTThis makes the driver always depend on
COMPILE_TEST, which is definitely not what we want.
Honestly, do we really need all of this complexity? I have specific configurations to test all of the PWM drivers to make sure they build. There's probably edge cases that don't get tested, but sooner or later I expect some build bot will encounter those and then we can rectify things. But in many cases that I've seen COMPILE_TEST just happens to do more harm than good.
Thierry
Quoted 58 lines · Thierry Reding
Quoted 49 lines · Geert Uytterhoeven
Hi Randy,
Quoted 33 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld:drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled'
ld:drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'Quoted 6 lines
Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]Thanks for your patch!
Quoted 4 lines
drivers/pwm/Kconfig +0
-0@@ -505,7 +505,8 @@ config PWM_ROCKCHIPQuoted 7 lines
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 508
Quoted 4 lines
drivers/pwm/Kconfig +1
-1config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TESTThis makes the driver always depend on
COMPILE_TEST, which is definitely not what we want.
Quoted 6 lines
Honestly, do we really need all of this complexity? I have specific configurations to test all of the PWM drivers to make sure they build. There's probably edge cases that don't get tested, but sooner or later I expect some build bot will encounter those and then we can rectify things. But in many cases that I've seen
COMPILE_TESTjust happens to do more harm than good.
Without COMPILE_TEST you'd need to build at least for the following archs to build all pwm drivers:
armv4+5 armv7 armv7m arm64 mips riscv shmobile x86
I personally like COMPILE_TEST as it reduces the number of needed test builds to 1 (I think).
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Quoted 69 lines · Uwe Kleine-König
Quoted 58 lines · Thierry Reding
Quoted 49 lines · Geert Uytterhoeven
Hi Randy,
Quoted 33 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld:drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled'
ld:drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'Quoted 6 lines
Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]Thanks for your patch!
Quoted 4 lines
drivers/pwm/Kconfig +0
-0@@ -505,7 +505,8 @@ config PWM_ROCKCHIPQuoted 7 lines
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 508
Quoted 4 lines
drivers/pwm/Kconfig +1
-1config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TESTThis makes the driver always depend on
COMPILE_TEST, which is definitely not what we want.Quoted 6 lines
Honestly, do we really need all of this complexity? I have specific configurations to test all of the PWM drivers to make sure they build. There's probably edge cases that don't get tested, but sooner or later I expect some build bot will encounter those and then we can rectify things. But in many cases that I've seen
COMPILE_TESTjust happens to do more harm than good.Without
COMPILE_TESTyou'd need to build at least for the following archs to build all pwm drivers:
Quoted 7 lines
armv4+5 armv7 armv7m arm64 mips riscv shmobile
This one is actually ARCH_RENESAS and is armv7.
Quoted 1 line
x86
But yeah, those are the platforms that I build for. It's not terribly complicated to do since all of the above have publicly available cross- compilers that are easy to install. Also, most of the time I do incremental builds, so these are quite quick.
Quoted 2 lines
I personally like
COMPILE_TESTas it reduces the number of needed test builds to 1 (I think).
Anyway, I wasn't arguing that we should get rid of COMPILE_TEST altogether, just that for cases like this it doesn't seem worth the extra complexity. RZ_MTU3 is an MFD and already || COMPILE_TEST, so we can easily always enable it.
Thierry
Hello,
Quoted 20 lines · Thierry Reding
Quoted 11 lines · Uwe Kleine-König
Quoted 6 lines · Thierry Reding
Honestly, do we really need all of this complexity? I have specific configurations to test all of the PWM drivers to make sure they build. There's probably edge cases that don't get tested, but sooner or later I expect some build bot will encounter those and then we can rectify things. But in many cases that I've seen
COMPILE_TESTjust happens to do more harm than good.Without
COMPILE_TESTyou'd need to build at least for the following archs to build all pwm drivers:Quoted 7 lines
armv4+5 armv7 armv7m arm64 mips riscv shmobile
Quoted 1 line
This one is actually
ARCH_RENESASand is armv7.
Oh indeed. ARCH_RENESAS exists for both arm and shmobile. TIL
Quoted 7 lines
Quoted 1 line
x86But yeah, those are the platforms that I build for. It's not terribly complicated to do since all of the above have publicly available cross- compilers that are easy to install. Also, most of the time I do incremental builds, so these are quite quick.
Quoted 7 lines
Quoted 2 lines
I personally like
COMPILE_TESTas it reduces the number of needed test builds to 1 (I think).Anyway, I wasn't arguing that we should get rid of
COMPILE_TESTaltogether, just that for cases like this it doesn't seem worth the extra complexity.RZ_MTU3is an MFD and already ||COMPILE_TEST, so we can easily always enable it.
Ah, I got that wrong then. I can life with this one.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Quoted 34 lines
-----Original Message-----
From: Uwe Kleine-König <[email protected]>
Sent: Wednesday, July 19, 2023 11:14 AM
To: Thierry Reding <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>; Randy Dunlap <[email protected]>; [email protected]; linux- [email protected]; Biju Das <[email protected]>
Subject: Re: [PATCH v2] pwm: fixpwm-rz-mtu3.cbuild errorsHello,
Quoted 4 lines · Thierry Reding
Quoted 3 lines · Uwe Kleine-König
Quoted 2 lines · Thierry Reding
Honestly, do we really need all of this complexity? I have specific configurations to test all of the PWM drivers to make
sure they build.
Quoted 16 lines
Quoted 15 lines
Quoted 4 lines
There's probably edge cases that don't get tested, but sooner or later I expect some build bot will encounter those and then we can rectify things. But in many cases that I've seen
COMPILE_TESTjust happens to do more harm than good.Without
COMPILE_TESTyou'd need to build at least for the following archs to build all pwm drivers:armv4+5 armv7 armv7m arm64 mips riscv shmobile
Quoted 3 lines
Quoted 1 line
This one is actually
ARCH_RENESASand is armv7.Oh indeed.
ARCH_RENESASexists for both arm and shmobile. TIL
arm64 and risc-v too. This MTU3 driver should work on RISC-V(RZ/Five) as well(need to test at some point).
Cheers,
Biju
Quoted 26 lines
Quoted 8 lines
Quoted 2 lines
x86But yeah, those are the platforms that I build for. It's not terribly complicated to do since all of the above have publicly available cross- compilers that are easy to install. Also, most of the time I do incremental builds, so these are quite quick.
Quoted 7 lines
Quoted 2 lines
I personally like
COMPILE_TESTas it reduces the number of needed test builds to 1 (I think).Anyway, I wasn't arguing that we should get rid of
COMPILE_TESTaltogether, just that for cases like this it doesn't seem worth the extra complexity.RZ_MTU3is an MFD and already ||COMPILE_TEST, so we can easily always enable it.Ah, I got that wrong then. I can life with this one.
Best regards
Uwe--
Pengutronix e.K. | Uwe Kleine-König
|
Industrial Linux Solutions | https://www.pengutronix.de/
|
Hi Uwe,
Quoted 21 lines · Uwe Kleine-König
Quoted 20 lines · Thierry Reding
Quoted 18 lines · Uwe Kleine-König
Quoted 6 lines · Thierry Reding
Honestly, do we really need all of this complexity? I have specific configurations to test all of the PWM drivers to make sure they build. There's probably edge cases that don't get tested, but sooner or later I expect some build bot will encounter those and then we can rectify things. But in many cases that I've seen
COMPILE_TESTjust happens to do more harm than good.Without
COMPILE_TESTyou'd need to build at least for the following archs to build all pwm drivers:armv4+5 armv7 armv7m arm64 mips riscv shmobile
Quoted 3 lines
Quoted 1 line
This one is actually
ARCH_RENESASand is armv7.Oh indeed.
ARCH_RENESASexists for both arm and shmobile. TIL
No, SH-Mobile can be either sh, arm, or both ;-)
ARCH_SHMOBILE is sh.ARCH_RENESAS is arm, arm64, or riscv.
The Renesas/arm defconfig is called shmobile_defconfig for historical reasons.
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Randy,
Quoted 75 lines
From: Randy Dunlap <[email protected]>
Subject: [PATCH v2] pwm: fixpwm-rz-mtu3.cbuild errorsFrom: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld:drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled'
ld:drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]Cc Biju Das <[email protected]>Cc Uwe Kleine-König <[email protected]>Cc Thierry Reding <[email protected]>---
v2: fix typo in Subject; correct my email address while infradead.org is down;drivers/pwm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 509
Quoted 6 lines
drivers/pwm/Kconfig +2
-1@@ -505,7 +505,8 @@ config PWM_ROCKCHIP config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TEST + depends on RZ_MTU3 || RZ_MTU3=n
Isn't this a tautology?
Cheers,
Fab
Quoted 4 lines
drivers/pwm/Kconfig +0
-0depends on HAS_IOMEM help This driver exposes the MTU3a PWM Timer controller found inRenesas
Quoted 23 lines · Fabrizio Castro
Hi Randy,
Quoted 21 lines
From: Randy Dunlap <[email protected]>
Subject: [PATCH v2] pwm: fixpwm-rz-mtu3.cbuild errorsFrom: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.drivers/pwm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
drivers/pwm/Kconfig +0
-0@@ -505,7 +505,8 @@ config PWM_ROCKCHIP
Quoted 7 lines
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 509
Quoted 5 lines
drivers/pwm/Kconfig +2
-1config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TEST + depends on RZ_MTU3 || RZ_MTU3=nIsn't this a tautology?
Not at all. It's used in Kconfig quite a bit.
This is tristate logic.
It says that if RZ_MTU3 is y/m, PWM_RZ_MTU3 is limited by that. But if RZ_MTU3 is n, PWM_RZ_MTU3 can be y or m.
Is that clearer?
Signature · 1 line
~Randy
Hi Randy,
Quoted 36 lines
From: Randy Dunlap <[email protected]>
Subject: Re: [PATCH v2] pwm: fixpwm-rz-mtu3.cbuild errorsQuoted 13 lines · Fabrizio Castro
Hi Randy,
Quoted 11 lines
From: Randy Dunlap <[email protected]>
Subject: [PATCH v2] pwm: fixpwm-rz-mtu3.cbuild errorsFrom: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is beingbuilt
Quoted 10 lines
Quoted 10 lines
but also allow the latter not to be built.
drivers/pwm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
drivers/pwm/Kconfig +0
-0@@ -505,7 +505,8 @@ config PWM_ROCKCHIPQuoted 7 lines
drivers/pwm/Kconfig config PWM_ROCKCHIP · line 509
Quoted 5 lines
drivers/pwm/Kconfig +2
-1config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TEST + depends on RZ_MTU3 || RZ_MTU3=nIsn't this a tautology?
Quoted 7 lines
Not at all. It's used in
Kconfigquite a bit.
This is tristate logic.It says that if
RZ_MTU3is y/m,PWM_RZ_MTU3is limited by that. But ifRZ_MTU3is n,PWM_RZ_MTU3can be y or m.Is that clearer?
It is, thanks for the explanation!
Cheers,
Fab
Quoted 3 lines
--
~Randy