Skip to contentSkip to conversation

status="ok" treated as disabled by DM

DISCUSSION Roger Quadros 2 participants 3 messages Aug 19, 2021 – Aug 20, 2021

lore
Share & tools
lore
#0 lore raw

Hi,

If the device tree node has status="ok" then the u-boot DM will treat the device as disabled. There are still quite many devices using "ok" instead of "okay" or no status and those devices will not be bound.

What is the right fix?
1) make u-boot DM to treat satus="ok" as enabled.
2) fix device tree by changing "ok" to "okay".

cheers,
-roger

#1 lore raw
Quoted 11 lines · Roger Quadros

Hi,

If the device tree node has status="ok" then the u-boot DM will treat the device as disabled. There are still quite many devices using "ok" instead of "okay" or no status and those devices will not be bound.

What is the right fix?
1) make u-boot DM to treat satus="ok" as enabled.
2) fix device tree by changing "ok" to "okay".

cheers,
-roger

https://github.com/devicetree-org/dt-schema/blob/master/schemas/dt-core.yaml#L36

I believe, the correct fix is (2) change the dt to "okay".

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#2 lore raw
Quoted 10 lines · Nishanth Menon
Quoted 9 lines · Roger Quadros

Hi,

If the device tree node has status="ok" then the u-boot DM will treat the device as disabled. There are still quite many devices using "ok" instead of "okay" or no status and those devices will not be bound.

What is the right fix?
1) make u-boot DM to treat satus="ok" as enabled.
2) fix device tree by changing "ok" to "okay".

Quoted 7 lines
Quoted 2 lines

cheers,
-roger

https://github.com/devicetree-org/dt-schema/blob/master/schemas/dt-core.yaml#L36

I believe, the correct fix is (2) change the dt to "okay".

Also in u-boot code it does mention to fix DT node status to "okay".
https://elixir.bootlin.com/u-boot/v2021.07/source/lib/fdtdec.c#L278

--
cheers,
-roger