Skip to contentSkip to conversation

Add message explaining early TLS client hello failure

PATCH In review Arne Schwabe 5 participants 9 messages Sep 25, 2018 – Oct 10, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add message explaining early TLS client hello failure

In my tests an OpenSSL 1.1.1 server does not accept TLS 1.0 only clients anymore. Unfortunately, Debian 8 still has OpenVPN 2.3.4, which is TLS 1.0 only without setting tls-version-min.

We currently log only
OpenSSL: error:14209102:SSL routines:tls_early_post_process_client_hello:unsupported protocol which indicates the right technical error but is not very helpful to a
person without deep knowledge in SSL/TLS and OpenVPN's TLS version
history.

This commit adds a hopefully helpful message and also tells users how to fix the old Debian 8 clients.

---
 src/openvpn/crypto_openssl.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
src/openvpn/crypto_openssl.c +9 -1
index 9ec2048d..3360bb19 100644
@@ -199,7 +199,15 @@ crypto_print_openssl_errors(const unsigned int flags)
                 "in common with the client. Your --tls-cipher setting might be "
                 "too restrictive.");
         }
-
+        else if (ERR_GET_REASON(err) == SSL_R_UNSUPPORTED_PROTOCOL)
+        {
+            msg(D_CRYPT_ERRORS, "TLS error: Unsupported protocol. This typically "
+                 "indicates that client and server have no common TLS version enabled. "
+                 "This can be caused mismatched tls-version-min and tls-version-max options "
+                 "on client and server. "
+                 "If your client is 2.3.6 or older  consider adding tls-version 1.1"
+                 "to the the configuration to use TLS 1.1+ instead of TLS 1.0 only");
+        }
         msg(flags, "OpenSSL: %s", ERR_error_string(err, NULL));
     }
 }
Signature · 1 line
2.19.0
#1 lore raw
Quoted 23 lines · Arne Schwabe

In my tests an OpenSSL 1.1.1 server does not accept TLS 1.0 only clients anymore. Unfortunately, Debian 8 still has OpenVPN 2.3.4, which is TLS 1.0 only without setting tls-version-min.

We currently log only
OpenSSL: error:14209102:SSL routines:tls_early_post_process_client_hello:unsupported protocol which indicates the right technical error but is not very helpful to a
person without deep knowledge in SSL/TLS and OpenVPN's TLS version
history.

This commit adds a hopefully helpful message and also tells users how to fix the old Debian 8 clients.

---
 src/openvpn/crypto_openssl.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
src/openvpn/crypto_openssl.c +0 -0
index 9ec2048d..3360bb19 100644
@@ -199,7 +199,15 @@ crypto_print_openssl_errors(const unsigned int flags)
                 "in common with the client. Your --tls-cipher setting might be "
                 "too restrictive.");

src/openvpn/crypto_openssl.c crypto_print_openssl_errors(const unsigned int flags) · line 209

Quoted 10 lines
src/openvpn/crypto_openssl.c +8 -1
         }
-
+        else if (ERR_GET_REASON(err) == SSL_R_UNSUPPORTED_PROTOCOL)
+        {
+            msg(D_CRYPT_ERRORS, "TLS error: Unsupported protocol. This typically "
+                 "indicates that client and server have no common TLS version enabled. "
+                 "This can be caused mismatched tls-version-min and tls-version-max options "
+                 "on client and server. "
+                 "If your client is 2.3.6 or older  consider adding tls-version 1.1"
+                 "to the the configuration to use TLS 1.1+ instead of TLS 1.0 only");

Good advice in the log. But should this be added in the local or remote configuration? It is the 2.3.6 reference which makes it confusing for me, otherwise I would have interpreted this as the local side where this warning occurs. So this could be clearer.

I also think this should be mentioned in the man page as well.

And a little nitpick ... the version reference should be either "OpenVPN 2.3.6" or "v2.3.6", as discussed here:
<https://www.mail-archive.com/[email protected]/msg15260.html>

Signature · 4 lines
kind regards,

David Sommerseth
OpenVPN Inc
#2 lore raw

Am 25.09.18 um 16:31 schrieb David Sommerseth:

Quoted 32 lines · Arne Schwabe
Quoted 31 lines

In my tests an OpenSSL 1.1.1 server does not accept TLS 1.0 only clients anymore. Unfortunately, Debian 8 still has OpenVPN 2.3.4, which is TLS 1.0 only without setting tls-version-min.

We currently log only
OpenSSL: error:14209102:SSL routines:tls_early_post_process_client_hello:unsupported protocol which indicates the right technical error but is not very helpful to a
person without deep knowledge in SSL/TLS and OpenVPN's TLS version
history.

This commit adds a hopefully helpful message and also tells users how to fix the old Debian 8 clients.

---
 src/openvpn/crypto_openssl.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
src/openvpn/crypto_openssl.c +6 -1
index 9ec2048d..3360bb19 100644
@@ -199,7 +199,15 @@ crypto_print_openssl_errors(const unsigned int flags)
                 "in common with the client. Your --tls-cipher setting might be "
                 "too restrictive.");
         }
-
+        else if (ERR_GET_REASON(err) == SSL_R_UNSUPPORTED_PROTOCOL)
+        {
+            msg(D_CRYPT_ERRORS, "TLS error: Unsupported protocol. This typically "
+                 "indicates that client and server have no common TLS version enabled. "
+                 "This can be caused mismatched tls-version-min and tls-version-max options "
+                 "on client and server. "
Quoted 8 lines

src/openvpn/crypto_openssl.c crypto_print_openssl_errors(const unsigned int flags) · line 209

Quoted 2 lines
src/openvpn/crypto_openssl.c +2 -0
+                 "If your client is 2.3.6 or older  consider adding tls-version 1.1"
+                 "to the the configuration to use TLS 1.1+ instead of TLS 1.0 only");

Good advice in the log. But should this be added in the local or remote configuration? It is the 2.3.6 reference which makes it confusing for me, otherwise I would have interpreted this as the local side where this warning occurs. So this could be clearer.

2.3.7 is the first version of OpenVPN which enables TLS 1.0+ instead TLS 1.0 only by default. See this commit by Steffan:

https://github.com/OpenVPN/openvpn/commit/8dc6ed28941cb9b9167e0b466e96b5f11359eb59

Quoted 2 lines

I also think this should be mentioned in the man page as well.

Hm, I am not sure what you want put into the manpage. That mismatching tls-version breaks things? That should be obvious. Documenting the old 2.3.x behaviour of tls version in current man page does not seem to be a good idea either.

Arne

#3 lore raw

Hi,

Quoted 42 lines · Arne Schwabe

Am 25.09.18 um 16:31 schrieb David Sommerseth:

Quoted 32 lines · Arne Schwabe
Quoted 31 lines

In my tests an OpenSSL 1.1.1 server does not accept TLS 1.0 only clients anymore. Unfortunately, Debian 8 still has OpenVPN 2.3.4, which is TLS 1.0 only without setting tls-version-min.

We currently log only
OpenSSL: error:14209102:SSL routines:tls_early_post_process_client_hello:unsupported protocol which indicates the right technical error but is not very helpful to a
person without deep knowledge in SSL/TLS and OpenVPN's TLS version
history.

This commit adds a hopefully helpful message and also tells users how to fix the old Debian 8 clients.

---
 src/openvpn/crypto_openssl.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
src/openvpn/crypto_openssl.c +6 -1
index 9ec2048d..3360bb19 100644
@@ -199,7 +199,15 @@ crypto_print_openssl_errors(const unsigned int flags)
                 "in common with the client. Your --tls-cipher setting might be "
                 "too restrictive.");
         }
-
+        else if (ERR_GET_REASON(err) == SSL_R_UNSUPPORTED_PROTOCOL)
+        {
+            msg(D_CRYPT_ERRORS, "TLS error: Unsupported protocol. This typically "
+                 "indicates that client and server have no common TLS version enabled. "
+                 "This can be caused mismatched tls-version-min and tls-version-max options "
+                 "on client and server. "
Quoted 8 lines

src/openvpn/crypto_openssl.c crypto_print_openssl_errors(const unsigned int flags) · line 209

Quoted 2 lines
src/openvpn/crypto_openssl.c +2 -0
+                 "If your client is 2.3.6 or older  consider adding tls-version 1.1"
+                 "to the the configuration to use TLS 1.1+ instead of TLS 1.0 only");

Good advice in the log. But should this be added in the local or remote configuration? It is the 2.3.6 reference which makes it confusing for me, otherwise I would have interpreted this as the local side where this warning occurs. So this could be clearer.

Quoted 5 lines

2.3.7 is the first version of OpenVPN which enables TLS 1.0+ instead TLS 1.0 only by default. See this commit by Steffan:

https://github.com/OpenVPN/openvpn/commit/8dc6ed28941cb9b9167e0b466e96b5f11359eb59

I think the problem is: we apply this patch to the latest 2.3.x release, so it will never appear on "2.3.6 or older" clients.
Hence, does it really make sense to print that particular sentence?

Cheers,

Signature · 1 line
Antonio Quartulli
#4 lore raw

PATCH 1/1 Add message explaining early TLS client hello failure

Am 26.09.18 um 08:52 schrieb Antonio Quartulli:

Quoted 48 lines

Hi,

Quoted 45 lines · Arne Schwabe

Am 25.09.18 um 16:31 schrieb David Sommerseth:

Quoted 32 lines · Arne Schwabe
Quoted 31 lines

In my tests an OpenSSL 1.1.1 server does not accept TLS 1.0 only clients anymore. Unfortunately, Debian 8 still has OpenVPN 2.3.4, which is TLS 1.0 only without setting tls-version-min.

We currently log only
OpenSSL: error:14209102:SSL routines:tls_early_post_process_client_hello:unsupported protocol which indicates the right technical error but is not very helpful to a
person without deep knowledge in SSL/TLS and OpenVPN's TLS version
history.

This commit adds a hopefully helpful message and also tells users how to fix the old Debian 8 clients.

---
 src/openvpn/crypto_openssl.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
src/openvpn/crypto_openssl.c +6 -1
index 9ec2048d..3360bb19 100644
@@ -199,7 +199,15 @@ crypto_print_openssl_errors(const unsigned int flags)
                 "in common with the client. Your --tls-cipher setting might be "
                 "too restrictive.");
         }
-
+        else if (ERR_GET_REASON(err) == SSL_R_UNSUPPORTED_PROTOCOL)
+        {
+            msg(D_CRYPT_ERRORS, "TLS error: Unsupported protocol. This typically "
+                 "indicates that client and server have no common TLS version enabled. "
+                 "This can be caused by mismatched tls-version-min and tls-version-max options "
+                 "on client and server. "
Quoted 8 lines

src/openvpn/crypto_openssl.c crypto_print_openssl_errors(const unsigned int flags) · line 209

Quoted 2 lines
src/openvpn/crypto_openssl.c +2 -0
+                 "If your client is 2.3.6 or older  consider adding tls-version 1.1"
+                 "to the the configuration to use TLS 1.1+ instead of TLS 1.0 only");

Good advice in the log. But should this be added in the local or remote configuration? It is the 2.3.6 reference which makes it confusing for me, otherwise I would have interpreted this as the local side where this warning occurs. So this could be clearer.

2.3.7 is the first version of OpenVPN which enables TLS 1.0+ instead TLS 1.0 only by default. See this commit by Steffan:

Quoted 6 lines
Quoted 2 lines

https://github.com/OpenVPN/openvpn/commit/8dc6ed28941cb9b9167e0b466e96b5f11359eb59

I think the problem is: we apply this patch to the latest 2.3.x release, so it will never appear on "2.3.6 or older" clients.
Hence, does it really make sense to print that particular sentence?

This appears in the server log when a 2.3.6 client or older tries to connect to a server that has OpenSSL 1.1.1.

I am not sure that OpenVPN 2.3.x has OpenSSL 1.1 support.

Arne

#5 lore raw
In reply to Arne Schwabe

Grammar check by tincantech (my new role)

Quoted 21 lines · Arne Schwabe

In my tests an OpenSSL 1.1.1 server does not accept TLS 1.0 only clients anymore. Unfortunately, Debian 8 still has OpenVPN 2.3.4, which is TLS 1.0 only without setting tls-version-min.

We currently log only
OpenSSL: error:14209102:SSL routines:tls_early_post_process_client_hello:unsupported protocol which indicates the right technical error but is not very helpful to a
person without deep knowledge in SSL/TLS and OpenVPN's TLS version
history.

This commit adds a hopefully helpful message and also tells users how to fix the old Debian 8 clients.

---
  src/openvpn/crypto_openssl.c | 10 +++++++++-
  1 file changed, 9 insertions(+), 1 deletion(-)
src/openvpn/crypto_openssl.c +0 -0
index 9ec2048d..3360bb19 100644

src/openvpn/crypto_openssl.c crypto_print_openssl_errors(const unsigned int flags) · line 206

Quoted 9 lines
src/openvpn/crypto_openssl.c +5 -1
@@ -199,7 +199,15 @@ crypto_print_openssl_errors(const unsigned int flags)
                  "in common with the client. Your --tls-cipher setting might be "
                  "too restrictive.");
          }
-
+        else if (ERR_GET_REASON(err) == SSL_R_UNSUPPORTED_PROTOCOL)
+        {
+            msg(D_CRYPT_ERRORS, "TLS error: Unsupported protocol. This typically "
+                 "indicates that client and server have no common TLS version enabled. "
+                 "This can be caused mismatched tls-version-min and tls-version-max options "

This can be caused *by*

src/openvpn/crypto_openssl.c crypto_print_openssl_errors(const unsigned int flags) · line 207

Quoted 1 line
src/openvpn/crypto_openssl.c +1 -0
+                 "on client and server. "

this could be removed as it is implicit anyway.

src/openvpn/crypto_openssl.c crypto_print_openssl_errors(const unsigned int flags) · line 208

Quoted 1 line
src/openvpn/crypto_openssl.c +1 -0
+                 "If your client is 2.3.6 or older  consider adding tls-version 1.1"

older":space::space:"consider ... missing :space: at EOL.

Quoted 6 lines
src/openvpn/crypto_openssl.c +2 -0
+                 "to the the configuration to use TLS 1.1+ instead of TLS 1.0 only");
+        }
          msg(flags, "OpenSSL: %s", ERR_error_string(err, NULL));
      }
  }
#6 lore raw
In reply to Arne Schwabe

src/openvpn/crypto_openssl.c crypto_print_openssl_errors(const unsigned int flags) · line 209

Quoted 2 lines · Arne Schwabe
src/openvpn/crypto_openssl.c +2 -0
+                 "If your client is 2.3.6 or older  consider adding tls-version 1.1"
+                 "to the the configuration to use TLS 1.1+ instead of TLS 1.0 only");

Don't you mean "adding tls-version-min 1.0 to the configuration to use TLS 1.0+ instead of TLS 1.0 only." ?

Note both the -min postfix, and the use of 1.0 instead of 1.1. I'd expect that people that have such old clients around might even have pre-2.3.2 clients, which only support TLS 1.0. Those would not work when setting tls-version-min 1.1 at the other end.

-Steffan

#7 lore raw

PATCH v2 1/1 Add message explaining early TLS client hello failure

In reply to Arne Schwabe

In my tests an OpenSSL 1.1.1 server does not accept TLS 1.0 only clients anymore. Unfortunately, Debian 8 still has OpenVPN 2.3.4, which is TLS 1.0 only without setting tls-version-min.

We currently log only
OpenSSL: error:14209102:SSL routines:tls_early_post_process_client_hello:unsupported protocol which indicates the right technical error but is not very helpful to a
person without deep knowledge in SSL/TLS and OpenVPN's TLS version
history.

This commit adds a hopefully helpful message and also tells users how to fix the old Debian 8 clients. The error message will be displayed on the server side only.

Note that connecting with an OpenSSL 1.1.1 client to a TLS 1.0 only server works fine.

This behaviour is also not specific to OpenVPN. Using an openssl s_client with the -tls1 option against an openssl s_server exhibits the same behaviour.

Patch V2: fixed message grammar, use tls-version-min 1.0 and clarify 2.3.6 and older to be actually between 2.3.2 and 2.3.6

---
 src/openvpn/crypto_openssl.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
src/openvpn/crypto_openssl.c +10 -1
index 9ec2048d..43d75b89 100644
@@ -199,7 +199,16 @@ crypto_print_openssl_errors(const unsigned int flags)
                 "in common with the client. Your --tls-cipher setting might be "
                 "too restrictive.");
         }
-
+        else if (ERR_GET_REASON(err) == SSL_R_UNSUPPORTED_PROTOCOL)
+        {
+            msg(D_CRYPT_ERRORS, "TLS error: Unsupported protocol. This typically "
+                 "indicates that client and server have no common TLS version enabled. "
+                 "This can be caused by mismatched tls-version-min and tls-version-max "
+                 "options on client and server. "
+                 "If your OpenVPN client is between v2.3.6 and v2.3.2 try adding "
+                 "tls-version-min 1.0 to the client configuration to use TLS 1.0+ "
+                 "instead of TLS 1.0 only");
+        }
         msg(flags, "OpenSSL: %s", ERR_error_string(err, NULL));
     }
 }
Signature · 1 line
2.19.0
Acked-by on v2 1/1
#8 lore raw

Hi,

Quoted 40 lines · Arne Schwabe

In my tests an OpenSSL 1.1.1 server does not accept TLS 1.0 only clients anymore. Unfortunately, Debian 8 still has OpenVPN 2.3.4, which is TLS 1.0 only without setting tls-version-min.

We currently log only
OpenSSL: error:14209102:SSL routines:tls_early_post_process_client_hello:unsupported protocol which indicates the right technical error but is not very helpful to a
person without deep knowledge in SSL/TLS and OpenVPN's TLS version
history.

This commit adds a hopefully helpful message and also tells users how to fix the old Debian 8 clients. The error message will be displayed on the server side only.

Note that connecting with an OpenSSL 1.1.1 client to a TLS 1.0 only server works fine.

This behaviour is also not specific to OpenVPN. Using an openssl s_client with the -tls1 option against an openssl s_server exhibits the same behaviour.

Patch V2: fixed message grammar, use tls-version-min 1.0 and clarify 2.3.6 and older to be actually between 2.3.2 and 2.3.6

---
 src/openvpn/crypto_openssl.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
src/openvpn/crypto_openssl.c +3 -1
index 9ec2048d..43d75b89 100644
@@ -199,7 +199,16 @@ crypto_print_openssl_errors(const unsigned int flags)
                 "in common with the client. Your --tls-cipher setting might be "
                 "too restrictive.");
         }
-
+        else if (ERR_GET_REASON(err) == SSL_R_UNSUPPORTED_PROTOCOL)
+        {
+            msg(D_CRYPT_ERRORS, "TLS error: Unsupported protocol. This typically "

src/openvpn/crypto_openssl.c crypto_print_openssl_errors(const unsigned int flags) · line 214

Quoted 10 lines
src/openvpn/crypto_openssl.c +7 -0
+                 "indicates that client and server have no common TLS version enabled. "
+                 "This can be caused by mismatched tls-version-min and tls-version-max "
+                 "options on client and server. "
+                 "If your OpenVPN client is between v2.3.6 and v2.3.2 try adding "
+                 "tls-version-min 1.0 to the client configuration to use TLS 1.0+ "
+                 "instead of TLS 1.0 only");
+        }
         msg(flags, "OpenSSL: %s", ERR_error_string(err, NULL));
     }
 }

Helpful message, patch looks good and passes the test suite. I didn't manually test connecting with a tls 1.0-only client, but trust that you have.

-Steffan