Skip to contentSkip to conversation

build: create relative symlinks for PMDs in libdir

PATCH Applied Luca Boccassi 4 participants 4 messages Sep 12, 2018 – Sep 17, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: create relative symlinks for PMDs in libdir

Add -r option to ln, otherwise the link will be absolute and contain the build path and break packaging among other things:

lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
-> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
drivers/librte_mempool_dpaa.so.1.1

With -r:

lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
-> dpdk/drivers/librte_pmd_zlib.so.1.1

Fixes ed4d43d73e2b ("build: symlink drivers to library directory")
---
 buildtools/symlink-drivers-solibs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
buildtools/symlink-drivers-solibs.sh +1 -1
index 803dfec491..9826c6ae37 100644
@@ -9,4 +9,4 @@
 # parameters to script are paths relative to install prefix:
 # 1. directory containing driver files e.g. lib64/dpdk/drivers
 # 2. directory for installed regular libs e.g. lib64
-ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
+ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
Signature · 1 line
2.18.0
Tested-by on v1 1/1
#1 lore raw
Quoted 10 lines · On Wed, 12 Sep 2018 18:21:34 +0100 Luca Boccassi <[email protected]> wrote:

Add -r option to ln, otherwise the link will be absolute and contain the build path and break packaging among other things:

lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17
librte_mempool_dpaa.so.1.1
-> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/ drivers/librte_mempool_dpaa.so.1.1

With -r:

Quoted 7 lines

lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
-> dpdk/drivers/librte_pmd_zlib.so.1.1

Fixes ed4d43d73e2b ("build: symlink drivers to library directory")

Tested on Fedora 28 by building dpdk using meson from a spec file

Acked-by on v1 1/1
#2 lore raw
In reply to Luca Boccassi
Quoted 26 lines · Luca Boccassi

Add -r option to ln, otherwise the link will be absolute and contain the build path and break packaging among other things:

lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
-> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
drivers/librte_mempool_dpaa.so.1.1

With -r:

lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
-> dpdk/drivers/librte_pmd_zlib.so.1.1

Fixes ed4d43d73e2b ("build: symlink drivers to library directory")
---
 buildtools/symlink-drivers-solibs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
buildtools/symlink-drivers-solibs.sh +0 -0
index 803dfec491..9826c6ae37 100644

buildtools/symlink-drivers-solibs.sh line 12

Quoted 5 lines
buildtools/symlink-drivers-solibs.sh +1 -1
@@ -9,4 +9,4 @@
 # parameters to script are paths relative to install prefix:
 # 1. directory containing driver files e.g. lib64/dpdk/drivers
 # 2. directory for installed regular libs e.g. lib64
-ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
+ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
#3 lore raw

13/09/2018 11:11, Bruce Richardson:

Quoted 21 lines · Luca Boccassi
Quoted 20 lines

Add -r option to ln, otherwise the link will be absolute and contain the build path and break packaging among other things:

lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
-> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
drivers/librte_mempool_dpaa.so.1.1

With -r:

lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
-> dpdk/drivers/librte_pmd_zlib.so.1.1

Fixes ed4d43d73e2b ("build: symlink drivers to library directory")
---
 buildtools/symlink-drivers-solibs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

buildtools/symlink-drivers-solibs.sh line 12

Quoted 10 lines
buildtools/symlink-drivers-solibs.sh +1 -1
index 803dfec491..9826c6ae37 100644
@@ -9,4 +9,4 @@
 # parameters to script are paths relative to install prefix:
 # 1. directory containing driver files e.g. lib64/dpdk/drivers
 # 2. directory for installed regular libs e.g. lib64
-ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
+ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2

Applied, thanks