build: create relative symlinks for PMDs in libdir
PATCH 1/1 build: create relative symlinks for PMDs in libdir
Add -r option to ln, otherwise the link will be absolute and contain the build path and break packaging among other things:
lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
-> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
drivers/librte_mempool_dpaa.so.1.1
With -r:
lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
-> dpdk/drivers/librte_pmd_zlib.so.1.1
--- buildtools/symlink-drivers-solibs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
buildtools/symlink-drivers-solibs.sh +1 -1
@@ -9,4 +9,4 @@ # parameters to script are paths relative to install prefix: # 1. directory containing driver files e.g. lib64/dpdk/drivers # 2. directory for installed regular libs e.g. lib64 -ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2 +ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
Signature · 1 line
2.18.0
Quoted 10 lines · On Wed, 12 Sep 2018 18:21:34 +0100 Luca Boccassi <[email protected]> wrote:
Add -r option to ln, otherwise the link will be absolute and contain the build path and break packaging among other things:
lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17
librte_mempool_dpaa.so.1.1
->/home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/drivers/librte_mempool_dpaa.so.1.1With -r:
Quoted 7 lines
lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
-> dpdk/drivers/librte_pmd_zlib.so.1.1Fixes ed4d43d73e2b ("build: symlink drivers to library directory")Signed-off-by Luca Boccassi <[email protected]>
Tested on Fedora 28 by building dpdk using meson from a spec file
Quoted 26 lines · Luca Boccassi
Add -r option to ln, otherwise the link will be absolute and contain the build path and break packaging among other things:
lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
->/home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
drivers/librte_mempool_dpaa.so.1.1With -r:
lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
-> dpdk/drivers/librte_pmd_zlib.so.1.1Fixes ed4d43d73e2b ("build: symlink drivers to library directory")Signed-off-by Luca Boccassi <[email protected]>--- buildtools/symlink-drivers-solibs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)buildtools/symlink-drivers-solibs.sh +0
-0
buildtools/symlink-drivers-solibs.sh line 12
Quoted 5 lines
buildtools/symlink-drivers-solibs.sh +1
-1@@ -9,4 +9,4 @@ # parameters to script are paths relative to install prefix: # 1. directory containing driver files e.g. lib64/dpdk/drivers # 2. directory for installed regular libs e.g. lib64 -ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2 +ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
Thomas Monjalon
Applied13/09/2018 11:11, Bruce Richardson:
Quoted 21 lines · Luca Boccassi
Quoted 20 lines
Add -r option to ln, otherwise the link will be absolute and contain the build path and break packaging among other things:
lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
->/home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
drivers/librte_mempool_dpaa.so.1.1With -r:
lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
-> dpdk/drivers/librte_pmd_zlib.so.1.1Fixes ed4d43d73e2b ("build: symlink drivers to library directory")Signed-off-by Luca Boccassi <[email protected]>--- buildtools/symlink-drivers-solibs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines
buildtools/symlink-drivers-solibs.sh line 12
Quoted 10 lines
buildtools/symlink-drivers-solibs.sh +1
-1@@ -9,4 +9,4 @@ # parameters to script are paths relative to install prefix: # 1. directory containing driver files e.g. lib64/dpdk/drivers # 2. directory for installed regular libs e.g. lib64 -ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2 +ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2Acked-by Bruce Richardson <[email protected]>
Applied, thanks