x86/boot: Drop 'noapic' suggestion from check_timer()
PATCH 1/1 x86/boot: Drop 'noapic' suggestion from check_timer()
In practice, there is no such thing as a real 64bit system without APICs. (PVH style virtual environments, sure, but they don't end up here).
The suggestion to try and use noapic only makes a bad situation worse.
---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Wei Liu <[email protected]>
CC: Ian Jackson <[email protected]>
I wanted to have enough time to drop all of the pre-APIC infrastructure, but that is a massive can of decades-old-worms. For 4.15, suffice just to to prevent misleading users more than necessary.
--- xen/arch/x86/io_apic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
xen/arch/x86/io_apic.c +1 -2
@@ -1994,8 +1994,7 @@ static void __init check_timer(void)return ; }printk (" failed :(.\n" ); -panic ("IO-APIC + timer doesn't work! Boot with apic_verbosity=debug " -"and send a report. Then try booting with the 'noapic' option\n" ); +panic ("IO-APIC + timer doesn't work! Boot with apic_verbosity=debug and send a report\n" ); }/*
Signature · 1 line
2.11.0
Quoted 6 lines · Andrew Cooper
In practice, there is no such thing as a real 64bit system without APICs. (PVH style virtual environments, sure, but they don't end up here).
The suggestion to try and use noapic only makes a bad situation worse.
Signed-off-by Andrew Cooper <[email protected]>
Jan Beulich writes ("Re: [PATCH for-4.15] x86/boot: Drop 'noapic' suggestion from check_timer()"):
Quoted 9 lines · Andrew Cooper
Quoted 6 lines
In practice, there is no such thing as a real 64bit system without APICs. (PVH style virtual environments, sure, but they don't end up here).
The suggestion to try and use noapic only makes a bad situation worse.
Signed-off-by Andrew Cooper <[email protected]>Acked-by Jan Beulich <[email protected]>
Not sure if this is a bugfix but it is a change to a message so fine.
Ian.
Quoted 10 lines · Ian Jackson
Jan Beulich writes ("Re: [PATCH for-4.15] x86/boot: Drop 'noapic' suggestion from
check_timer()"):Quoted 8 lines · Andrew Cooper
Quoted 6 lines
In practice, there is no such thing as a real 64bit system without APICs. (PVH style virtual environments, sure, but they don't end up here).
The suggestion to try and use noapic only makes a bad situation worse.
Signed-off-by Andrew Cooper <[email protected]>Acked-by Jan Beulich <[email protected]>Release-Acked-by Ian Jackson <[email protected]>
Thanks.
Quoted 1 line
Not sure if this is a bugfix but it is a change to a message so fine.
It was one of many delaying factors with the "Xen doesn't boot on modern Intel client CPUs".
~Andrew