Skip to contentSkip to conversation

trap handler for unaligned memory read/write

DISCUSSION Jun Sun 2 participants 4 messages Sep 15, 2000 – Sep 16, 2000 MIPS

lore
Share & tools
lore

Jun Sun

author
#0 lore raw

I was trying to run some PCI ether drivers and always got bus error, at least when I use ipconfig bootp code.

However, the problem seems to be generic.

Ethernet device writes a whole packet in the memory. Driver and network stack code often directly dereference a pointer in to the packet. However, the ether header is 14 byte long. If you align packet from the beginning, then IP header will be off-aligned.

Any suggestions?

If this is a valid problem, I think the long term solution should be in network code, which should not assume they can dereference on an unaligned address.

For short-term solutions, we can have trap handler that supports the unaligned read/write. Does anybody know if there is such a trap handler for MIPS?

Thanks.

Jun

author
#1 lore raw

As usual, I am replying to my own question. Maybe I was asking to soon ... :-)

I found some drivers offer an copy-only-tiny-buffer which will copy small packets (for what purpose?). Apparently after the copying the misalignment disappears. So MIPS, you just set a high copy_break_size so that a copying always happens.

In fact this is what is done for other non-x86 architectures in tulip drivers.

Jun

Quoted 24 lines · Jun Sun

I was trying to run some PCI ether drivers and always got bus error, at least when I use ipconfig bootp code.

However, the problem seems to be generic.

Ethernet device writes a whole packet in the memory. Driver and network stack code often directly dereference a pointer in to the packet. However, the ether header is 14 byte long. If you align packet from the beginning, then IP header will be off-aligned.

Any suggestions?

If this is a valid problem, I think the long term solution should be in network code, which should not assume they can dereference on an unaligned address.

For short-term solutions, we can have trap handler that supports the unaligned read/write. Does anybody know if there is such a trap handler for MIPS?

Thanks.

Jun

#2 lore raw
In reply to Jun Sun
Quoted 11 lines · Jun Sun

I was trying to run some PCI ether drivers and always got bus error, at least when I use ipconfig bootp code.

However, the problem seems to be generic.

Ethernet device writes a whole packet in the memory. Driver and network stack code often directly dereference a pointer in to the packet. However, the ether header is 14 byte long. If you align packet from the beginning, then IP header will be off-aligned.

Any suggestions?

The strategy is to get the alignment right for the IP header, that is to make the received packet start on a address with bit 1 set.

Quoted 3 lines

If this is a valid problem, I think the long term solution should be in network code, which should not assume they can dereference on an unaligned address.

It tries to avoid unaligned accesses - if necessary even at the price of wasting some memory.

Quoted 3 lines

For short-term solutions, we can have trap handler that supports the unaligned read/write. Does anybody know if there is such a trap handler for MIPS?

It's right there in your kernel ...

You _really_ _really_ want to avoid relying on the unaligned trap handler. Performancewise that's equivalent to a swapping on a floppy disk on the Mars over NFS via avian carriers ...

However unaligned accesses will result in an address error exception not bus error therefore I suspect you've got another problem.

Ralf

author
#3 lore raw
Quoted 6 lines · Ralf Baechle
Quoted 3 lines

For short-term solutions, we can have trap handler that supports the unaligned read/write. Does anybody know if there is such a trap handler for MIPS?

It's right there in your kernel ...

Cool! I found it.

Quoted 7 lines

You _really_ _really_ want to avoid relying on the unaligned trap handler. Performancewise that's equivalent to a swapping on a floppy disk on the Mars over NFS via avian carriers ...

However unaligned accesses will result in an address error exception not bus error therefore I suspect you've got another problem.

I got the error when I use gdb to debug kernel. I suppose the gdb stub intercepted the error and report it as BUS error. We should make gdb-stub a little smarter ...

Jun