Skip to contentSkip to conversation

select CRC32

PATCH In review Brian Gerst 2 participants 2 messages Sep 26, 2003 – Sep 27, 2003

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 select CRC32

Use "select CRC32" in Kconfig instead of makefile includes.

drivers/media/dvb/dvb-core/Kconfig +1 -0
diff -urN linux-2.6.0-test5-bk/drivers/media/dvb/dvb-core/Kconfig linux/drivers/media/dvb/dvb-core/Kconfig
@@ -1,6 +1,7 @@
 config DVB_CORE
 	tristate "DVB Core Support"
 	depends on DVB
+	select CRC32
 	help
 	  DVB core utility functions for device handling, software fallbacks etc.
 
drivers/media/dvb/dvb-core/Makefile.lib +0 -1
diff -urN linux-2.6.0-test5-bk/drivers/media/dvb/dvb-core/Makefile.lib linux/drivers/media/dvb/dvb-core/Makefile.lib
@@ -1 +0,0 @@
-obj-$(CONFIG_DVB_CORE)		+= crc32.o
drivers/net/arm/Kconfig +2 -0
diff -urN linux-2.6.0-test5-bk/drivers/net/arm/Kconfig linux/drivers/net/arm/Kconfig
@@ -5,6 +5,7 @@
 config ARM_AM79C961A
 	bool "ARM EBSA110 AM79C961A support"
 	depends on NET_ETHERNET && ARM && ARCH_EBSA110
+	select CRC32
 	help
 	  If you wish to compile a kernel for the EBSA-110, then you should
 	  always answer Y to this.
@@ -26,6 +27,7 @@
 config ARM_ETHERH
 	tristate "I-cubed EtherH/ANT EtherM support"
 	depends on NET_ETHERNET && ARM && ARCH_ACORN
+	select CRC32
 	help
 	  If you have an Acorn system with one of these network cards, you
 	  should say Y to this option if you wish to use it with Linux.
drivers/net/Kconfig +57 -0

399 lines not on this page · raw message

drivers/net/Makefile.lib +0 -76

76 lines not on this page · raw message

drivers/net/pcmcia/Kconfig +3 -0
diff -urN linux-2.6.0-test5-bk/drivers/net/pcmcia/Kconfig linux/drivers/net/pcmcia/Kconfig
@@ -44,6 +44,7 @@
 config PCMCIA_FMVJ18X
 	tristate "Fujitsu FMV-J18x PCMCIA support"
 	depends on NET_PCMCIA && PCMCIA
+	select CRC32
 	help
 	  Say Y here if you intend to attach a Fujitsu FMV-J18x or compatible
 	  PCMCIA (PC-card) Ethernet card to your computer.
@@ -54,6 +55,7 @@
 config PCMCIA_PCNET
 	tristate "NE2000 compatible PCMCIA support"
 	depends on NET_PCMCIA && PCMCIA
+	select CRC32
 	help
 	  Say Y here if you intend to attach an NE2000 compatible PCMCIA
 	  (PC-card) Ethernet or Fast Ethernet card to your computer.
@@ -74,6 +76,7 @@
 config PCMCIA_SMC91C92
 	tristate "SMC 91Cxx PCMCIA support"
 	depends on NET_PCMCIA && PCMCIA
+	select CRC32
 	help
 	  Say Y here if you intend to attach an SMC 91Cxx compatible PCMCIA
 	  (PC-card) Ethernet or Fast Ethernet card to your computer.
drivers/net/tulip/Kconfig +6 -0
diff -urN linux-2.6.0-test5-bk/drivers/net/tulip/Kconfig linux/drivers/net/tulip/Kconfig
@@ -13,6 +13,7 @@
 config DE2104X
 	tristate "Early DECchip Tulip (dc2104x) PCI support (EXPERIMENTAL)"
 	depends on NET_TULIP && PCI && EXPERIMENTAL
+	select CRC32
 	---help---
 	  This driver is developed for the SMC EtherPower series Ethernet
 	  cards and also works with cards based on the DECchip
@@ -30,6 +31,7 @@
 config TULIP
 	tristate "DECchip Tulip (dc2114x) PCI support"
 	depends on NET_TULIP && PCI
+	select CRC32
 	---help---
 	  This driver is developed for the SMC EtherPower series Ethernet
 	  cards and also works with cards based on the DECchip 
@@ -69,6 +71,7 @@
 config DE4X5
 	tristate "Generic DECchip & DIGITAL EtherWORKS PCI/EISA"
 	depends on NET_TULIP && (PCI || EISA)
+	select CRC32
 	---help---
 	  This is support for the DIGITAL series of PCI/EISA Ethernet cards.
 	  These include the DE425, DE434, DE435, DE450 and DE500 models.  If
@@ -85,6 +88,7 @@
 config WINBOND_840
 	tristate "Winbond W89c840 Ethernet support"
 	depends on NET_TULIP && PCI
+	select CRC32
 	help
 	  This driver is for the Winbond W89c840 chip.  It also works with 
 	  the TX9882 chip on the Compex RL100-ATX board.
@@ -94,6 +98,7 @@
 config DM9102
 	tristate "Davicom DM910x/DM980x support"
 	depends on NET_TULIP && PCI
+	select CRC32
 	---help---
 	  This driver is for DM9102(A)/DM9132/DM9801 compatible PCI cards from
 	  Davicom (<http://www.davicom.com.tw/>).  If you have such a network
@@ -120,6 +125,7 @@
 config PCMCIA_XIRTULIP
 	tristate "Xircom Tulip-like CardBus support (old driver)"
 	depends on NET_TULIP && CARDBUS && BROKEN_ON_SMP
+	select CRC32
 	---help---
 	  This driver is for the Digital "Tulip" Ethernet CardBus adapters.
 	  It should work with most DEC 21*4*-based chips/ethercards, as well
drivers/usb/Makefile.lib +0 -3
diff -urN linux-2.6.0-test5-bk/drivers/usb/Makefile.lib linux/drivers/usb/Makefile.lib
@@ -1,3 +0,0 @@
-obj-$(CONFIG_USB_CATC)		+= crc32.o
-obj-$(CONFIG_USB_SPEEDTOUCH)	+= crc32.o
-obj-$(CONFIG_USB_USBNET)	+= crc32.o
drivers/usb/misc/Kconfig +1 -0
diff -urN linux-2.6.0-test5-bk/drivers/usb/misc/Kconfig linux/drivers/usb/misc/Kconfig
@@ -84,6 +84,7 @@
 config USB_SPEEDTOUCH
 	tristate "Alcatel Speedtouch USB support"
 	depends on USB && ATM
+	select CRC32
 	help
 	  Say Y here if you have an Alcatel SpeedTouch USB or SpeedTouch 330
 	  modem.  In order to use your modem you will need to install some user
drivers/usb/net/Kconfig +2 -0
diff -urN linux-2.6.0-test5-bk/drivers/usb/net/Kconfig linux/drivers/usb/net/Kconfig
@@ -10,6 +10,7 @@
 config USB_CATC
 	tristate "USB CATC NetMate-based Ethernet device support (EXPERIMENTAL)"
 	depends on USB && NET && EXPERIMENTAL
+	select CRC32
 	---help---
 	  Say Y if you want to use one of the following 10Mbps USB Ethernet
 	  device based on the EL1210A chip. Supported devices are:
@@ -94,6 +95,7 @@
 config USB_USBNET
 	tristate "Multi-purpose USB Networking Framework"
 	depends on USB && NET
+	select CRC32
 	---help---
 	  This driver supports several kinds of network links over USB,
 	  with "minidrivers" built around a common network driver core
fs/Kconfig +1 -0
diff -urN linux-2.6.0-test5-bk/fs/Kconfig linux/fs/Kconfig
@@ -1046,6 +1046,7 @@
 config JFFS2_FS
 	tristate "Journalling Flash File System v2 (JFFS2) support"
 	depends on MTD
+	select CRC32
 	help
 	  JFFS2 is the second generation of the Journalling Flash File System
 	  for use on diskless embedded devices. It provides improved wear
fs/Makefile.lib +0 -2
diff -urN linux-2.6.0-test5-bk/fs/Makefile.lib linux/fs/Makefile.lib
@@ -1,2 +0,0 @@
-obj-$(CONFIG_JFFS2_FS)		+= crc32.o
-obj-$(CONFIG_EFI_PARTITION)	+= crc32.o
fs/partitions/Kconfig +1 -0
diff -urN linux-2.6.0-test5-bk/fs/partitions/Kconfig linux/fs/partitions/Kconfig
@@ -227,6 +227,7 @@
 config EFI_PARTITION
 	bool "EFI GUID Partition support"
 	depends on PARTITION_ADVANCED
+	select CRC32
 	help
 	  Say Y here if you would like to use hard disks under Linux which
 	  were partitioned using EFI GPT.  Presently only useful on the
lib/Makefile +0 -6
diff -urN linux-2.6.0-test5-bk/lib/Makefile linux/lib/Makefile
@@ -20,12 +20,6 @@
 obj-$(CONFIG_ZLIB_INFLATE) += zlib_inflate/
 obj-$(CONFIG_ZLIB_DEFLATE) += zlib_deflate/
 
-include drivers/net/Makefile.lib
-include drivers/usb/Makefile.lib
-include fs/Makefile.lib
-include net/bluetooth/bnep/Makefile.lib
-include drivers/media/dvb/dvb-core/Makefile.lib
-
 host-progs	:= gen_crc32table
 clean-files	:= crc32table.h
 
net/bluetooth/bnep/Kconfig +1 -0
diff -urN linux-2.6.0-test5-bk/net/bluetooth/bnep/Kconfig linux/net/bluetooth/bnep/Kconfig
@@ -1,6 +1,7 @@
 config BT_BNEP
 	tristate "BNEP protocol support"
 	depends on BT && BT_L2CAP
+	select CRC32
 	help
 	  BNEP (Bluetooth Network Encapsulation Protocol) is Ethernet
 	  emulation layer on top of Bluetooth. BNEP is required for Bluetooth
net/bluetooth/bnep/Makefile.lib +0 -1
diff -urN linux-2.6.0-test5-bk/net/bluetooth/bnep/Makefile.lib linux/net/bluetooth/bnep/Makefile.lib
@@ -1 +0,0 @@
-obj-$(CONFIG_BT_BNEP) += crc32.o
#1 lore raw
Quoted 1 line · Brian Gerst

Use "select CRC32" in Kconfig instead of makefile includes.

Hi Brian - looks good to me.
I will apply it to my local tree if Linus does not take it.

Sam