Skip to contentSkip to conversation

ARM: imx: Update Novena to DM/DT

PATCH Superseded Marek Vasut 3 participants 26 messages May 17, 2019 – Jan 27, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover ARM: imx: Update Novena to DM/DT

Update Kosagi Novena to DM / DT and remove the warnings. This depends on the following patches / series:

https://patchwork.ozlabs.org/patch/1095618/
https://patchwork.ozlabs.org/patch/1101171/
https://patchwork.ozlabs.org/project/uboot/list/?series=108463

Marek Vasut (7):
ARM: dts: imx: novena: Import Novena DT from Linux
ARM: imx: novena: Enable DM pin control
ARM: imx: novena: Enable DM GPIO
ARM: imx: novena: Convert block devices to DM
ARM: imx: novena: Enable DM USB
ARM: imx: novena: Enable DM PCI
ARM: imx: novena: Convert to DM VIDEO

 arch/arm/dts/Makefile         |   3 +-
 arch/arm/dts/imx6q-novena.dts | 797 ++++++++++++++++++++++++++++++++++
 board/kosagi/novena/novena.c  |  77 +---
 board/kosagi/novena/video.c   |   3 +
 configs/novena_defconfig      |  18 +-
 include/configs/novena.h      |   9 +-
 6 files changed, 838 insertions(+), 69 deletions(-)
 create mode 100644 arch/arm/dts/imx6q-novena.dts
Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/7 ARM: dts: imx: novena: Import Novena DT from Linux

Import iMX6Q Novena device tree from Linux 5.1-rc7 37624b58542f . Enable DT control in full U-Boot .

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
V2: No change

---
 arch/arm/dts/Makefile         |   3 +-
 arch/arm/dts/imx6q-novena.dts | 792 ++++++++++++++++++++++++++++++++++
 configs/novena_defconfig      |   3 +-
 3 files changed, 796 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/dts/imx6q-novena.dts
arch/arm/dts/Makefile +2 -1
index 0ec7bc987d..dad47144e7 100644
@@ -535,7 +535,8 @@ dtb-$(CONFIG_MX53) += imx53-cx9020.dtb \
 dtb-$(CONFIG_MX6Q) += \
 	imx6-apalis.dtb \
 	imx6q-display5.dtb \
-	imx6q-logicpd.dtb
+	imx6q-logicpd.dtb \
+	imx6q-novena.dtb
 
 dtb-$(CONFIG_TARGET_TBS2910) += \
 	imx6q-tbs2910.dtb
arch/arm/dts/imx6q-novena.dts new file +792 -0

792 lines not on this page · raw message

configs/novena_defconfig +2 -1
index 340e1cd91c..04c944c6d8 100644
@@ -40,6 +40,8 @@ CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y
 CONFIG_CMD_EXT4_WRITE=y
 # CONFIG_SPL_PARTITION_UUIDS is not set
+CONFIG_OF_CONTROL=y
+CONFIG_DEFAULT_DEVICE_TREE="imx6q-novena"
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_DWC_AHSATA=y
 CONFIG_FSL_ESDHC=y
@@ -62,4 +64,3 @@ CONFIG_VIDEO_IPUV3=y
 CONFIG_VIDEO=y
 # CONFIG_VIDEO_SW_CURSOR is not set
 CONFIG_FAT_WRITE=y
-CONFIG_OF_LIBFDT=y
Signature · 1 line
2.20.1
#2 lore raw

PATCH v2 1/7 ARM: dts: imx: novena: Import Novena DT

Quoted 6 lines

Import iMX6Q Novena device tree from Linux 5.1-rc7 37624b58542f . Enable DT control in full U-Boot .

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH v2 2/7 ARM: imx: novena: Enable DM pin control

In reply to Marek Vasut

Enable DM pin control support on iMX6Q Novena.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
V2: No change

---
 configs/novena_defconfig | 5 +++++
 1 file changed, 5 insertions(+)
configs/novena_defconfig +5 -0
index 04c944c6d8..31a32da0dc 100644
@@ -14,6 +14,7 @@ CONFIG_SPL_FS_FAT=y
 CONFIG_SPL_LIBDISK_SUPPORT=y
 CONFIG_CMD_HDMIDETECT=y
 CONFIG_DISTRO_DEFAULTS=y
+# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT=y
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg,MX6Q"
 CONFIG_USE_BOOTARGS=y
@@ -29,6 +30,7 @@ CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_CMD_ASKENV=y
 CONFIG_CMD_EEPROM=y
+CONFIG_CMD_DM=y
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
@@ -43,6 +45,7 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="imx6q-novena"
 CONFIG_ENV_IS_IN_MMC=y
+CONFIG_DM=y
 CONFIG_DWC_AHSATA=y
 CONFIG_FSL_ESDHC=y
 CONFIG_PHYLIB=y
@@ -50,6 +53,8 @@ CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ90X1=y
 CONFIG_MII=y
 CONFIG_PCI=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX6=y
 CONFIG_USB=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_CONTROL_EP=y
Signature · 1 line
2.20.1
#4 lore raw

PATCH v2 2/7 ARM: imx: novena: Enable DM pin control

Quoted 5 lines

Enable DM pin control support on iMX6Q Novena.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#5 lore raw

PATCH v2 3/7 ARM: imx: novena: Enable DM GPIO

In reply to Marek Vasut

Enable DM GPIO support on iMX6Q Novena and fix up board code where applicable.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
V2: No change

---
 board/kosagi/novena/novena.c | 2 ++
 board/kosagi/novena/video.c  | 3 +++
 configs/novena_defconfig     | 1 +
 3 files changed, 6 insertions(+)
board/kosagi/novena/novena.c +2 -0
index 9f2586521d..0750c4667e 100644
@@ -83,6 +83,8 @@ int drv_keyboard_init(void)
 		.tstc	= novena_gpio_button_tstc,
 	};
 
+	gpio_request(NOVENA_BUTTON_GPIO, "button");
+
 	error = input_init(&button_input, 0);
 	if (error) {
 		debug("%s: Cannot set up input\n", __func__);
board/kosagi/novena/video.c +3 -0
index f1351b9e28..7083b6e103 100644
@@ -270,6 +270,7 @@ static void enable_lvds(struct display_info_t const *dev)
 		return;
 
 	/* ITE IT6251 power enable. */
+	gpio_request(NOVENA_ITE6251_PWR_GPIO, "ite6251-power");
 	gpio_direction_output(NOVENA_ITE6251_PWR_GPIO, 0);
 	mdelay(10);
 	gpio_direction_output(NOVENA_ITE6251_PWR_GPIO, 1);
@@ -447,6 +448,8 @@ void setup_display_lvds(void)
 	/* Init the LVDS-to-eDP chip and if it succeeded, enable backlight. */
 	ret = it6251_init();
 	if (!ret) {
+		gpio_request(NOVENA_BACKLIGHT_PWR_GPIO, "backlight-power");
+		gpio_request(NOVENA_BACKLIGHT_PWM_GPIO, "backlight-pwm");
 		/* Backlight power enable. */
 		gpio_direction_output(NOVENA_BACKLIGHT_PWR_GPIO, 1);
 		/* PWM backlight pin, always on for full brightness. */
configs/novena_defconfig +1 -0
index 31a32da0dc..c74f635121 100644
@@ -47,6 +47,7 @@ CONFIG_DEFAULT_DEVICE_TREE="imx6q-novena"
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_DM=y
 CONFIG_DWC_AHSATA=y
+CONFIG_DM_GPIO=y
 CONFIG_FSL_ESDHC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
Signature · 1 line
2.20.1
#6 lore raw

PATCH v2 3/7 ARM: imx: novena: Enable DM GPIO

Quoted 6 lines

Enable DM GPIO support on iMX6Q Novena and fix up board code where applicable.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#7 lore raw

PATCH v2 4/7 ARM: imx: novena: Convert block devices to DM

In reply to Marek Vasut

Enable DM block, DM MMC and DM SATA support on iMX6Q Novena convert board code to match the DM support.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
V2: - Drop the ad-hoc sata binding, this is superseded by
CONFIG_DWC_AHSATA_AHCI=y resp. drivers/ata/dwc_ahsata.c
- Drop dangling setup_sata() call

---
 arch/arm/dts/imx6q-novena.dts |  5 +++
 board/kosagi/novena/novena.c  | 62 +++--------------------------------
 configs/novena_defconfig      |  3 ++
 include/configs/novena.h      |  5 ---
 4 files changed, 12 insertions(+), 63 deletions(-)
arch/arm/dts/imx6q-novena.dts +5 -0
index 61347a545d..35383c9a2b 100644
@@ -61,6 +61,11 @@
 		reg = <0x10000000 0>;
 	};
 
+	aliases {
+		mmc0 = &usdhc3;
+		mmc1 = &usdhc2;
+	};
+
 	chosen {
 		stdout-path = &uart2;
 	};
board/kosagi/novena/novena.c +4 -58

86 lines not on this page · raw message

configs/novena_defconfig +3 -0
index c74f635121..fa5fdea278 100644
@@ -13,6 +13,7 @@ CONFIG_SPL=y
 CONFIG_SPL_FS_FAT=y
 CONFIG_SPL_LIBDISK_SUPPORT=y
 CONFIG_CMD_HDMIDETECT=y
+CONFIG_AHCI=y
 CONFIG_DISTRO_DEFAULTS=y
 # CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT=y
@@ -48,6 +49,7 @@ CONFIG_ENV_IS_IN_MMC=y
 CONFIG_DM=y
 CONFIG_DWC_AHSATA=y
 CONFIG_DM_GPIO=y
+CONFIG_DM_MMC=y
 CONFIG_FSL_ESDHC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
@@ -56,6 +58,7 @@ CONFIG_MII=y
 CONFIG_PCI=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX6=y
+CONFIG_DM_SCSI=y
 CONFIG_USB=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_CONTROL_EP=y
include/configs/novena.h +0 -5
index bb5bf808c2..bc7383e957 100644
@@ -102,12 +102,7 @@
 #define CONFIG_POWER_PFUZE100_I2C_ADDR	0x08
 
 /* SATA Configs */
-#ifdef CONFIG_CMD_SATA
-#define CONFIG_SYS_SATA_MAX_DEVICE	1
-#define CONFIG_DWC_AHSATA_PORT_ID	0
-#define CONFIG_DWC_AHSATA_BASE_ADDR	SATA_ARB_BASE_ADDR
 #define CONFIG_LBA48
-#endif
 
 /* UART */
 #define CONFIG_MXC_UART
Signature · 1 line
2.20.1
#8 lore raw

PATCH v2 4/7 ARM: imx: novena: Convert block devices to DM

Quoted 6 lines

Enable DM block, DM MMC and DM SATA support on iMX6Q Novena convert board code to match the DM support.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#9 lore raw

PATCH v2 5/7 ARM: imx: novena: Enable DM USB

In reply to Marek Vasut

Enable DM USB support on iMX6Q Novena.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
V2: No change

---
 configs/novena_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/novena_defconfig +1 -0
index fa5fdea278..c5dbbb0b4d 100644
@@ -60,6 +60,7 @@ CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX6=y
 CONFIG_DM_SCSI=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_CONTROL_EP=y
 CONFIG_USB_GADGET=y
Signature · 1 line
2.20.1
#10 lore raw

PATCH v2 5/7 ARM: imx: novena: Enable DM USB

Quoted 5 lines

Enable DM USB support on iMX6Q Novena.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#11 lore raw

PATCH v2 6/7 ARM: imx: novena: Enable DM PCI

In reply to Marek Vasut

Enable DM PCI support on iMX6Q Novena.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
V2: New patch

---
 configs/novena_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/novena_defconfig +1 -0
index c5dbbb0b4d..bbed972a44 100644
@@ -56,6 +56,7 @@ CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ90X1=y
 CONFIG_MII=y
 CONFIG_PCI=y
+CONFIG_DM_PCI=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX6=y
 CONFIG_DM_SCSI=y
Signature · 1 line
2.20.1
#12 lore raw

PATCH v2 6/7 ARM: imx: novena: Enable DM PCI

Hi Marek,

Quoted 18 lines · Marek Vasut

Enable DM PCI support on iMX6Q Novena.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
V2: New patch

---
 configs/novena_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/novena_defconfig +0 -0
index c5dbbb0b4d..bbed972a44 100644

configs/novena_defconfig CONFIG_PHY_MICREL=y · line 62

Quoted 7 lines
configs/novena_defconfig +1 -0
@@ -56,6 +56,7 @@ CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ90X1=y
 CONFIG_MII=y
 CONFIG_PCI=y
+CONFIG_DM_PCI=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX6=y
 CONFIG_DM_SCSI=y

I cannot build novena with this enabled - do you see the same error or am I missing something ?

arm: + novena
+ pci_set_ops(hose,
+ ^~~~~~~~~~~
+drivers/pci/pcie_imx.c:686:7: error:
?pci_hose_read_config_byte_via_dword? undeclared (first use in this function)
+ pci_hose_read_config_byte_via_dword,
+ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+drivers/pci/pcie_imx.c:686:7: note: each undeclared identifier is reported only once for each function it appears in +drivers/pci/pcie_imx.c:687:7: error:
?pci_hose_read_config_word_via_dword? undeclared (first use in this function)
+ pci_hose_read_config_word_via_dword,
+drivers/pci/pcie_imx.c:689:7: error:
?pci_hose_write_config_byte_via_dword? undeclared (first use in this function)
+ pci_hose_write_config_byte_via_dword,
+ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+drivers/pci/pcie_imx.c:690:7: error:
?pci_hose_write_config_word_via_dword? undeclared (first use in this function)
+ pci_hose_write_config_word_via_dword,

+   pci_register_hose(hose);
+   ^~~~~~~~~~~~~~~~~
+   hose->last_busno = pci_hose_scan(hose);

+ ^~~~~~~~~~~~~
+make[3]: *** [drivers/pci/pcie_imx.o] Error 1 +make[2]: *** [drivers/pci] Error 2
+make[1]: *** [drivers] Error 2
+make: *** [sub-make] Error 2
w+drivers/pci/pcie_imx.c: In function ?imx_pcie_init?:
w+drivers/pci/pcie_imx.c:685:2: warning: implicit declaration of function ?pci_set_ops? [-Wimplicit-function-declaration] w+drivers/pci/pcie_imx.c:697:3: warning: implicit declaration of function ?pci_register_hose? [-Wimplicit-function-declaration] w+drivers/pci/pcie_imx.c:698:22: warning: implicit declaration of function ?pci_hose_scan? [-Wimplicit-function-declaration]

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#13 lore raw

PATCH v2 6/7 ARM: imx: novena: Enable DM PCI

Quoted 63 lines · Stefano Babic

Hi Marek,

Quoted 18 lines · Marek Vasut

Enable DM PCI support on iMX6Q Novena.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
V2: New patch

---
 configs/novena_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/novena_defconfig +0 -0
index c5dbbb0b4d..bbed972a44 100644

configs/novena_defconfig CONFIG_PHY_MICREL=y · line 62

Quoted 7 lines
configs/novena_defconfig +1 -0
@@ -56,6 +56,7 @@ CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ90X1=y
 CONFIG_MII=y
 CONFIG_PCI=y
+CONFIG_DM_PCI=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX6=y
 CONFIG_DM_SCSI=y

I cannot build novena with this enabled - do you see the same error or am I missing something ?

arm: + novena

(quoted diff) +3 -0
+  pci_set_ops(hose,
+  ^~~~~~~~~~~
+drivers/pci/pcie_imx.c:686:7: error:

?pci_hose_read_config_byte_via_dword? undeclared (first use in this function)

(quoted diff) +3 -0
+       pci_hose_read_config_byte_via_dword,
+       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+drivers/pci/pcie_imx.c:686:7: note: each undeclared identifier is

reported only once for each function it appears in +drivers/pci/pcie_imx.c:687:7: error:
?pci_hose_read_config_word_via_dword? undeclared (first use in this function)

(quoted diff) +2 -0
+       pci_hose_read_config_word_via_dword,
+drivers/pci/pcie_imx.c:689:7: error:

?pci_hose_write_config_byte_via_dword? undeclared (first use in this function)

(quoted diff) +3 -0
+       pci_hose_write_config_byte_via_dword,
+       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+drivers/pci/pcie_imx.c:690:7: error:

?pci_hose_write_config_word_via_dword? undeclared (first use in this function)

(quoted diff) +9 -0
+       pci_hose_write_config_word_via_dword,
+   pci_register_hose(hose);
+   ^~~~~~~~~~~~~~~~~
+   hose->last_busno = pci_hose_scan(hose);
+                      ^~~~~~~~~~~~~
+make[3]: *** [drivers/pci/pcie_imx.o] Error 1
+make[2]: *** [drivers/pci] Error 2
+make[1]: *** [drivers] Error 2
+make: *** [sub-make] Error 2
Quoted 7 lines

w+drivers/pci/pcie_imx.c: In function ?imx_pcie_init?:
w+drivers/pci/pcie_imx.c:685:2: warning: implicit declaration of function ?pci_set_ops? [-Wimplicit-function-declaration] w+drivers/pci/pcie_imx.c:697:3: warning: implicit declaration of function ?pci_register_hose? [-Wimplicit-function-declaration] w+drivers/pci/pcie_imx.c:698:22: warning: implicit declaration of function ?pci_hose_scan? [-Wimplicit-function-declaration]

I collected the patches here [1], CI passed:

https://github.com/marex/u-boot-imx/tree/imx-dm

Signature · 2 lines
Best regards,
Marek Vasut
#14 lore raw

PATCH v2 6/7 ARM: imx: novena: Enable DM PCI

Quoted 74 lines · Marek Vasut
Quoted 63 lines · Stefano Babic

Hi Marek,

Quoted 18 lines · Marek Vasut

Enable DM PCI support on iMX6Q Novena.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
V2: New patch

---
 configs/novena_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/novena_defconfig +0 -0
index c5dbbb0b4d..bbed972a44 100644

configs/novena_defconfig CONFIG_PHY_MICREL=y · line 62

Quoted 7 lines
configs/novena_defconfig +1 -0
@@ -56,6 +56,7 @@ CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ90X1=y
 CONFIG_MII=y
 CONFIG_PCI=y
+CONFIG_DM_PCI=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX6=y
 CONFIG_DM_SCSI=y

I cannot build novena with this enabled - do you see the same error or am I missing something ?

arm: + novena

(quoted diff) +3 -0
+  pci_set_ops(hose,
+  ^~~~~~~~~~~
+drivers/pci/pcie_imx.c:686:7: error:

?pci_hose_read_config_byte_via_dword? undeclared (first use in this function)

(quoted diff) +3 -0
+       pci_hose_read_config_byte_via_dword,
+       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+drivers/pci/pcie_imx.c:686:7: note: each undeclared identifier is

reported only once for each function it appears in +drivers/pci/pcie_imx.c:687:7: error:
?pci_hose_read_config_word_via_dword? undeclared (first use in this function)

(quoted diff) +2 -0
+       pci_hose_read_config_word_via_dword,
+drivers/pci/pcie_imx.c:689:7: error:

?pci_hose_write_config_byte_via_dword? undeclared (first use in this function)

(quoted diff) +3 -0
+       pci_hose_write_config_byte_via_dword,
+       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+drivers/pci/pcie_imx.c:690:7: error:

?pci_hose_write_config_word_via_dword? undeclared (first use in this function)

(quoted diff) +9 -0
+       pci_hose_write_config_word_via_dword,
+   pci_register_hose(hose);
+   ^~~~~~~~~~~~~~~~~
+   hose->last_busno = pci_hose_scan(hose);
+                      ^~~~~~~~~~~~~
+make[3]: *** [drivers/pci/pcie_imx.o] Error 1
+make[2]: *** [drivers/pci] Error 2
+make[1]: *** [drivers] Error 2
+make: *** [sub-make] Error 2
Quoted 7 lines

w+drivers/pci/pcie_imx.c: In function ?imx_pcie_init?:
w+drivers/pci/pcie_imx.c:685:2: warning: implicit declaration of function ?pci_set_ops? [-Wimplicit-function-declaration] w+drivers/pci/pcie_imx.c:697:3: warning: implicit declaration of function ?pci_register_hose? [-Wimplicit-function-declaration] w+drivers/pci/pcie_imx.c:698:22: warning: implicit declaration of function ?pci_hose_scan? [-Wimplicit-function-declaration]

I collected the patches here [1], CI passed:

Quoted 1 line

https://github.com/marex/u-boot-imx/tree/imx-dm

Fine, thanks - I had not applied your pcie patches before novena. I see you sent V2 for pcie, I am picking up the new version then

Thanks,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#15 lore raw

PATCH v2 6/7 ARM: imx: novena: Enable DM PCI

In reply to Marek Vasut
Quoted 5 lines

Enable DM PCI support on iMX6Q Novena.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#16 lore raw

PATCH v2 7/7 ARM: imx: novena: Convert to DM VIDEO

In reply to Marek Vasut

Enable DM Video support on iMX6Q Novena and fix minor details to restore previous behavior of the system.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
V2: Print U-Boot version information on the LCD

---
 board/kosagi/novena/novena.c | 13 +++++++++++++
 configs/novena_defconfig     |  6 +++---
 include/configs/novena.h     |  4 ++--
 3 files changed, 18 insertions(+), 5 deletions(-)
board/kosagi/novena/novena.c +13 -0
index d897f8f1cd..78294b820e 100644
@@ -39,6 +39,7 @@
 #include <power/pmic.h>
 #include <power/pfuze100_pmic.h>
 #include <stdio_dev.h>
+#include <video_console.h>
 
 #include "novena.h"
 
@@ -125,7 +126,19 @@ int board_init(void)
 int board_late_init(void)
 {
 #if defined(CONFIG_VIDEO_IPUV3)
+	struct udevice *con;
+	char buf[DISPLAY_OPTIONS_BANNER_LENGTH];
+	int ret;
+
 	setup_display_lvds();
+
+	ret = uclass_get_device(UCLASS_VIDEO_CONSOLE, 0, &con);
+	if (ret)
+		return ret;
+
+	display_options_get_banner(false, buf, sizeof(buf));
+	vidconsole_position_cursor(con, 0, 0);
+	vidconsole_put_string(con, buf);
 #endif
 	return 0;
 }
configs/novena_defconfig +3 -3
index bbed972a44..e649ebb549 100644
@@ -4,6 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x17800000
 CONFIG_SPL_GPIO_SUPPORT=y
 CONFIG_SPL_LIBCOMMON_SUPPORT=y
 CONFIG_SPL_LIBGENERIC_SUPPORT=y
+CONFIG_SYS_MALLOC_F_LEN=0x2000
 CONFIG_MX6_DDRCAL=y
 CONFIG_TARGET_KOSAGI_NOVENA=y
 CONFIG_SPL_MMC_SUPPORT=y
@@ -15,7 +16,6 @@ CONFIG_SPL_LIBDISK_SUPPORT=y
 CONFIG_CMD_HDMIDETECT=y
 CONFIG_AHCI=y
 CONFIG_DISTRO_DEFAULTS=y
-# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT=y
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg,MX6Q"
 CONFIG_USE_BOOTARGS=y
@@ -71,7 +71,7 @@ CONFIG_USB_ETH_CDC=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
 CONFIG_USB_ETHER_SMSC95XX=y
+CONFIG_DM_VIDEO=y
+CONFIG_SYS_WHITE_ON_BLACK=y
 CONFIG_VIDEO_IPUV3=y
-CONFIG_VIDEO=y
-# CONFIG_VIDEO_SW_CURSOR is not set
 CONFIG_FAT_WRITE=y
include/configs/novena.h +2 -2
index bc7383e957..cdc437c492 100644
@@ -119,14 +119,12 @@
 #endif
 
 /* Video output */
-#ifdef CONFIG_VIDEO
 #define CONFIG_VIDEO_BMP_RLE8
 #define CONFIG_SPLASH_SCREEN
 #define CONFIG_BMP_16BPP
 #define CONFIG_VIDEO_LOGO
 #define CONFIG_IMX_HDMI
 #define CONFIG_IMX_VIDEO_SKIP
-#endif
 
 /* Extra U-Boot environment. */
 #ifndef CONFIG_SPL_BUILD
@@ -144,6 +142,8 @@
 	"ramdisk_addr_r=0x28000000\0"		   			\
 	"fdt_addr_r=0x18000000\0"					\
 	"fdtfile=imx6q-novena.dtb\0"					\
+	"stdout=serial,vidconsole\0"					\
+	"stderr=serial,vidconsole\0"					\
 	"addcons="							\
 		"setenv bootargs ${bootargs} "				\
 		"console=${consdev},${baudrate}\0"			\
Signature · 1 line
2.20.1
#17 lore raw

PATCH v2 7/7 ARM: imx: novena: Convert to DM VIDEO

Quoted 6 lines

Enable DM Video support on iMX6Q Novena and fix minor details to restore previous behavior of the system.

Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#18 lore raw

v2 cover ARM: imx: Update Novena to DM/DT

In reply to Marek Vasut
Quoted 5 lines · Marek Vasut

Update Kosagi Novena to DM / DT and remove the warnings. This depends on the following patches / series:

https://patchwork.ozlabs.org/patch/1095618/
https://patchwork.ozlabs.org/patch/1101171/

These are now merged in 2019.07-rc3.

Quoted 1 line

https://patchwork.ozlabs.org/project/uboot/list/?series=108463

These were not yet.

I have two oustanding issues... with some files it sometimes fails to load one or more from SATA:

Retrieving file: /boot/initrd.img-5.0.0-trunk-armmp
20077960 bytes read in 375 ms (51.1 MiB/s)
Retrieving file: /boot/vmlinuz-5.0.0-trunk-armmp
4215296 bytes read in 40 ms (100.5 MiB/s)
append: root=UUID=9666ab0b-f932-4e2f-95d7-0e96a12a4540 ro quiet Retrieving file: /usr/lib/linux-image-5.0.0-trunk-armmp/imx6q-novena.dtb
CACHE: Misaligned operation at range [fafb5398, fafb6398]
CACHE: Misaligned operation at range [fafb5398, fafb6398]
ERROR: v7_outer_cache_inval_range - start address is not aligned - 0xfafb5398
ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0xfafb6398
invalid extent block

It then falls back to one of the other kernels (using the extlinux.conf parsing) and succeeds. It consistantly gets a cache/alignment error with this specific file. A bit-for-bit identical .dtb loaded from another path works just fine. Older versions of u-boot boot this fine. Would some particular EXT4 flag possibly be causing issues?

Several other kernel+initrd+dtb combinations work fine.

I have not noticed issues loading from PXE.

The second issue is still using one out of four exposed USB ports fails and resets the board:

load usb 0:1 $kernel_addr_r misc/Binaries/linux/Image data abort

pc : [<fefbb67a>]          lr : [<fefbb0fd>]

reloc pc : [<1783367a>] lr : [<178330fd>]
sp : faf7c6e8 ip : 00000003 fp : 00000005
r10: faf8b200 r9 : faf87ea0 r8 : 00000001
r7 : faf8b2c0 r6 : f9f7a040 r5 : faf7c710 r4 : 00000038
r3 : 0000006d r2 : f9f7a0a3 r1 : faf8b32c r0 : f9f7a09f
Flags: nzCv IRQs off FIQs off Mode SVC_32

Code: 4630fc5b 81f0e8bd e7d84606 bf082b2f (f822235c)

Resetting CPU ...

The three other usb ports work just fine with the same USB stick and file. All four ports work with 2019.01.

Despite those two issues somewhat significant issues... it does appear to work in general... so, with 2019.07-rc3 +
https://patchwork.ozlabs.org/project/uboot/list/?series=108463 and this series applied, with the above caveats:

live well,
vagrant

Quoted 18 lines

Marek Vasut (7):
ARM: dts: imx: novena: Import Novena DT from Linux
ARM: imx: novena: Enable DM pin control
ARM: imx: novena: Enable DM GPIO
ARM: imx: novena: Convert block devices to DM
ARM: imx: novena: Enable DM USB
ARM: imx: novena: Enable DM PCI
ARM: imx: novena: Convert to DM VIDEO

 arch/arm/dts/Makefile         |   3 +-
 arch/arm/dts/imx6q-novena.dts | 797 ++++++++++++++++++++++++++++++++++
 board/kosagi/novena/novena.c  |  77 +---
 board/kosagi/novena/video.c   |   3 +
 configs/novena_defconfig      |  18 +-
 include/configs/novena.h      |   9 +-
 6 files changed, 838 insertions(+), 69 deletions(-)
 create mode 100644 arch/arm/dts/imx6q-novena.dts
Quoted 5 lines
Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Vagrant Cascadian <[email protected]>
Signature · 1 line
2.20.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190604/8b8f5db2/attachment.sig>

#19 lore raw

v2 cover ARM: imx: Update Novena to DM/DT

Quoted 1 line · Vagrant Cascadian

On 2019-05-17, Marek Vasut wrote:

Retried with a build from:

https://github.com/marex/u-boot-imx/tree/imx-dm
commit:7a381bb7edfd43aefc1dbfea6d574234ef9d7771

Which contains the two patchsets needed.

Quoted 17 lines

I have two oustanding issues... with some files it sometimes fails to load one or more from SATA:

Retrieving file: /boot/initrd.img-5.0.0-trunk-armmp
20077960 bytes read in 375 ms (51.1 MiB/s)
Retrieving file: /boot/vmlinuz-5.0.0-trunk-armmp
4215296 bytes read in 40 ms (100.5 MiB/s)
append: root=UUID=9666ab0b-f932-4e2f-95d7-0e96a12a4540 ro quiet Retrieving file: /usr/lib/linux-image-5.0.0-trunk-armmp/imx6q-novena.dtb
CACHE: Misaligned operation at range [fafb5398, fafb6398]
CACHE: Misaligned operation at range [fafb5398, fafb6398]
ERROR: v7_outer_cache_inval_range - start address is not aligned - 0xfafb5398
ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0xfafb6398
invalid extent block

Quoted 7 lines

It then falls back to one of the other kernels (using the extlinux.conf parsing) and succeeds. It consistantly gets a cache/alignment error with this specific file. A bit-for-bit identical .dtb loaded from another path works just fine. Older versions of u-boot boot this fine. Would some particular EXT4 flag possibly be causing issues?

Several other kernel+initrd+dtb combinations work fine.

Running "dcache off" before booting still produces the warnings/errors, but actually does boot successfully. Of course, it's much slower.

Quoted 12 lines

The second issue is still using one out of four exposed USB ports fails and resets the board:

load usb 0:1 $kernel_addr_r misc/Binaries/linux/Image data abort

pc : [<fefbb67a>]          lr : [<fefbb0fd>]

reloc pc : [<1783367a>] lr : [<178330fd>]
sp : faf7c6e8 ip : 00000003 fp : 00000005
r10: faf8b200 r9 : faf87ea0 r8 : 00000001
r7 : faf8b2c0 r6 : f9f7a040 r5 : faf7c710 r4 : 00000038
r3 : 0000006d r2 : f9f7a0a3 r1 : faf8b32c r0 : f9f7a09f
Flags: nzCv IRQs off FIQs off Mode SVC_32

Quoted 5 lines
Code: 4630fc5b 81f0e8bd e7d84606 bf082b2f (f822235c)

Resetting CPU ...

The three other usb ports work just fine with the same USB stick and file. All four ports work with 2019.01.

Got a bit-for-bit identical error on this one.

I was able to get the objdump output with the reloc pc value:

  $ arm-linux-gnueabihf-objdump -d u-boot | grep 178337aa
  178337aa:       f822 3b02       strh.w  r3, [r2], #2

Hope that's helpful!

live well,
vagrant

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190606/66fcebfb/attachment.sig>

#20 lore raw

v2 cover ARM: imx: Update Novena to DM/DT

Quoted 34 lines · Vagrant Cascadian
Quoted 1 line · Vagrant Cascadian

On 2019-05-17, Marek Vasut wrote:

Retried with a build from:

https://github.com/marex/u-boot-imx/tree/imx-dm
commit:7a381bb7edfd43aefc1dbfea6d574234ef9d7771

Which contains the two patchsets needed.

Quoted 23 lines

I have two oustanding issues... with some files it sometimes fails to load one or more from SATA:

Retrieving file: /boot/initrd.img-5.0.0-trunk-armmp
20077960 bytes read in 375 ms (51.1 MiB/s)
Retrieving file: /boot/vmlinuz-5.0.0-trunk-armmp
4215296 bytes read in 40 ms (100.5 MiB/s)
append: root=UUID=9666ab0b-f932-4e2f-95d7-0e96a12a4540 ro quiet Retrieving file: /usr/lib/linux-image-5.0.0-trunk-armmp/imx6q-novena.dtb
CACHE: Misaligned operation at range [fafb5398, fafb6398]
CACHE: Misaligned operation at range [fafb5398, fafb6398]
ERROR: v7_outer_cache_inval_range - start address is not aligned - 0xfafb5398
ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0xfafb6398
invalid extent block

It then falls back to one of the other kernels (using the extlinux.conf parsing) and succeeds. It consistantly gets a cache/alignment error with this specific file. A bit-for-bit identical .dtb loaded from another path works just fine. Older versions of u-boot boot this fine. Would some particular EXT4 flag possibly be causing issues?

Quoted 4 lines
Quoted 1 line

Several other kernel+initrd+dtb combinations work fine.

Running "dcache off" before booting still produces the warnings/errors, but actually does boot successfully. Of course, it's much slower.

Well, someone needs to debug this :-)

Quoted 18 lines
Quoted 12 lines

The second issue is still using one out of four exposed USB ports fails and resets the board:

load usb 0:1 $kernel_addr_r misc/Binaries/linux/Image data abort

pc : [<fefbb67a>]          lr : [<fefbb0fd>]

reloc pc : [<1783367a>] lr : [<178330fd>]
sp : faf7c6e8 ip : 00000003 fp : 00000005
r10: faf8b200 r9 : faf87ea0 r8 : 00000001
r7 : faf8b2c0 r6 : f9f7a040 r5 : faf7c710 r4 : 00000038
r3 : 0000006d r2 : f9f7a0a3 r1 : faf8b32c r0 : f9f7a09f
Flags: nzCv IRQs off FIQs off Mode SVC_32

Quoted 5 lines
Code: 4630fc5b 81f0e8bd e7d84606 bf082b2f (f822235c)

Resetting CPU ...

The three other usb ports work just fine with the same USB stick and file. All four ports work with 2019.01.

Quoted 8 lines

Got a bit-for-bit identical error on this one.

I was able to get the objdump output with the reloc pc value:

  $ arm-linux-gnueabihf-objdump -d u-boot | grep 178337aa
  178337aa:       f822 3b02       strh.w  r3, [r2], #2

Hope that's helpful!

Not at all, it basically says "writing unknown value to unknown offset in memory causes data abort". If you run ...objdump -lSD u-boot, you can likely find more information in the dump and also where/why it crashes.

Signature · 2 lines
Best regards,
Marek Vasut
#21 lore raw

v2 cover ARM: imx: Update Novena to DM/DT

In reply to Vagrant Cascadian
Quoted 30 lines · Vagrant Cascadian
Quoted 5 lines · Marek Vasut

Update Kosagi Novena to DM / DT and remove the warnings. This depends on the following patches / series:

https://patchwork.ozlabs.org/patch/1095618/
https://patchwork.ozlabs.org/patch/1101171/

These are now merged in 2019.07-rc3.

Quoted 1 line

https://patchwork.ozlabs.org/project/uboot/list/?series=108463

These were not yet.

I have two oustanding issues... with some files it sometimes fails to load one or more from SATA:

Retrieving file: /boot/initrd.img-5.0.0-trunk-armmp
20077960 bytes read in 375 ms (51.1 MiB/s)
Retrieving file: /boot/vmlinuz-5.0.0-trunk-armmp
4215296 bytes read in 40 ms (100.5 MiB/s)
append: root=UUID=9666ab0b-f932-4e2f-95d7-0e96a12a4540 ro quiet Retrieving file: /usr/lib/linux-image-5.0.0-trunk-armmp/imx6q-novena.dtb
CACHE: Misaligned operation at range [fafb5398, fafb6398]
CACHE: Misaligned operation at range [fafb5398, fafb6398]
ERROR: v7_outer_cache_inval_range - start address is not aligned - 0xfafb5398
ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0xfafb6398
invalid extent block

Quoted 5 lines

It then falls back to one of the other kernels (using the extlinux.conf parsing) and succeeds. It consistantly gets a cache/alignment error with this specific file. A bit-for-bit identical .dtb loaded from another path works just fine. Older versions of u-boot boot this fine. Would some particular EXT4 flag possibly be causing issues?

I don't know. Do you still run into this with u-boot/master ?

Quoted 17 lines

Several other kernel+initrd+dtb combinations work fine.

I have not noticed issues loading from PXE.

The second issue is still using one out of four exposed USB ports fails and resets the board:

load usb 0:1 $kernel_addr_r misc/Binaries/linux/Image data abort

pc : [<fefbb67a>]          lr : [<fefbb0fd>]

reloc pc : [<1783367a>] lr : [<178330fd>]
sp : faf7c6e8 ip : 00000003 fp : 00000005
r10: faf8b200 r9 : faf87ea0 r8 : 00000001
r7 : faf8b2c0 r6 : f9f7a040 r5 : faf7c710 r4 : 00000038
r3 : 0000006d r2 : f9f7a0a3 r1 : faf8b32c r0 : f9f7a09f
Flags: nzCv IRQs off FIQs off Mode SVC_32

Quoted 5 lines
Code: 4630fc5b 81f0e8bd e7d84606 bf082b2f (f822235c)

Resetting CPU ...

The three other usb ports work just fine with the same USB stick and file. All four ports work with 2019.01.

Can you debug it ? I think some of this was due to the EFI stuff , which I think was fixed since. Can you re-check that ?

#22 lore raw

v2 cover ARM: imx: Update Novena to DM/DT

Quoted 3 lines · Marek Vasut
Quoted 2 lines · Vagrant Cascadian
Quoted 1 line · Marek Vasut

Update Kosagi Novena to DM / DT and remove the warnings.

...

Quoted 17 lines
Quoted 17 lines

I have two oustanding issues... with some files it sometimes fails to load one or more from SATA:

Retrieving file: /boot/initrd.img-5.0.0-trunk-armmp
20077960 bytes read in 375 ms (51.1 MiB/s)
Retrieving file: /boot/vmlinuz-5.0.0-trunk-armmp
4215296 bytes read in 40 ms (100.5 MiB/s)
append: root=UUID=9666ab0b-f932-4e2f-95d7-0e96a12a4540 ro quiet Retrieving file: /usr/lib/linux-image-5.0.0-trunk-armmp/imx6q-novena.dtb
CACHE: Misaligned operation at range [fafb5398, fafb6398]
CACHE: Misaligned operation at range [fafb5398, fafb6398]
ERROR: v7_outer_cache_inval_range - start address is not aligned - 0xfafb5398
ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0xfafb6398
invalid extent block

Quoted 7 lines
Quoted 5 lines

It then falls back to one of the other kernels (using the extlinux.conf parsing) and succeeds. It consistantly gets a cache/alignment error with this specific file. A bit-for-bit identical .dtb loaded from another path works just fine. Older versions of u-boot boot this fine. Would some particular EXT4 flag possibly be causing issues?

I don't know. Do you still run into this with u-boot/master ?

Still occurring with 2019.10-rc2. Haven't tested with master yet.

Using "dcache off" before booting still outputs the CACHE and ERROR messages, but does successfully boot.

Quoted 15 lines
Quoted 15 lines

The second issue is still using one out of four exposed USB ports fails and resets the board:

load usb 0:1 $kernel_addr_r misc/Binaries/linux/Image data abort

pc : [<fefbb67a>]          lr : [<fefbb0fd>]

reloc pc : [<1783367a>] lr : [<178330fd>]
sp : faf7c6e8 ip : 00000003 fp : 00000005
r10: faf8b200 r9 : faf87ea0 r8 : 00000001
r7 : faf8b2c0 r6 : f9f7a040 r5 : faf7c710 r4 : 00000038
r3 : 0000006d r2 : f9f7a0a3 r1 : faf8b32c r0 : f9f7a09f
Flags: nzCv IRQs off FIQs off Mode SVC_32

Code: 4630fc5b 81f0e8bd e7d84606 bf082b2f (f822235c)

Resetting CPU ...

Quoted 5 lines
Quoted 2 lines

The three other usb ports work just fine with the same USB stick and file. All four ports work with 2019.01.

Can you debug it ? I think some of this was due to the EFI stuff , which I think was fixed since. Can you re-check that ?

USB appears to be working fine with 2019.10-rc2.

live well,
vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190820/f9476fa2/attachment.sig>

#23 lore raw

[U-Boot] dcache issues with wandboard too (was: [PATCH V2 0/7] ARM: imx: Update Novena to DM/DT)

Quoted 28 lines · Vagrant Cascadian
Quoted 3 lines · Marek Vasut
Quoted 2 lines · Vagrant Cascadian
Quoted 1 line · Marek Vasut

Update Kosagi Novena to DM / DT and remove the warnings.

...

Quoted 23 lines
Quoted 22 lines

I have two oustanding issues... with some files it sometimes fails to load one or more from SATA:

Retrieving file: /boot/initrd.img-5.0.0-trunk-armmp
20077960 bytes read in 375 ms (51.1 MiB/s)
Retrieving file: /boot/vmlinuz-5.0.0-trunk-armmp
4215296 bytes read in 40 ms (100.5 MiB/s)
append: root=UUID=9666ab0b-f932-4e2f-95d7-0e96a12a4540 ro quiet Retrieving file: /usr/lib/linux-image-5.0.0-trunk-armmp/imx6q-novena.dtb
CACHE: Misaligned operation at range [fafb5398, fafb6398]
CACHE: Misaligned operation at range [fafb5398, fafb6398]
ERROR: v7_outer_cache_inval_range - start address is not aligned - 0xfafb5398
ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0xfafb6398
invalid extent block

It then falls back to one of the other kernels (using the extlinux.conf parsing) and succeeds. It consistantly gets a cache/alignment error with this specific file. A bit-for-bit identical .dtb loaded from another path works just fine. Older versions of u-boot boot this fine. Would some particular EXT4 flag possibly be causing issues?

Quoted 6 lines
Quoted 1 line

I don't know. Do you still run into this with u-boot/master ?

Still occurring with 2019.10-rc2. Haven't tested with master yet.

Using "dcache off" before booting still outputs the CACHE and ERROR messages, but does successfully boot.

Also seeing this problem with wandboard solo with 2019.10-rc4 booting from microSD. Haven't retested with novena recently.

Setting CONFIG_SYS_DCACHE_OFF=y avoids the need to manually type "dcache off" ... though obviously doesn't address the real problem.

live well,
vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190926/d010c567/attachment.sig>

#24 lore raw

[U-Boot] dcache issues with wandboard too (was: [PATCH V2 0/7] ARM: imx: Update Novena to DM/DT)

Quoted 33 lines · Vagrant Cascadian
Quoted 32 lines · Vagrant Cascadian
Quoted 3 lines · Marek Vasut
Quoted 2 lines · Vagrant Cascadian
Quoted 1 line · Marek Vasut

Update Kosagi Novena to DM / DT and remove the warnings.

...

Quoted 17 lines
Quoted 17 lines

I have two oustanding issues... with some files it sometimes fails to load one or more from SATA:

Retrieving file: /boot/initrd.img-5.0.0-trunk-armmp
20077960 bytes read in 375 ms (51.1 MiB/s)
Retrieving file: /boot/vmlinuz-5.0.0-trunk-armmp
4215296 bytes read in 40 ms (100.5 MiB/s)
append: root=UUID=9666ab0b-f932-4e2f-95d7-0e96a12a4540 ro quiet Retrieving file: /usr/lib/linux-image-5.0.0-trunk-armmp/imx6q-novena.dtb
CACHE: Misaligned operation at range [fafb5398, fafb6398]
CACHE: Misaligned operation at range [fafb5398, fafb6398]
ERROR: v7_outer_cache_inval_range - start address is not aligned - 0xfafb5398
ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0xfafb6398
invalid extent block

Quoted 7 lines
Quoted 5 lines

It then falls back to one of the other kernels (using the extlinux.conf parsing) and succeeds. It consistantly gets a cache/alignment error with this specific file. A bit-for-bit identical .dtb loaded from another path works just fine. Older versions of u-boot boot this fine. Would some particular EXT4 flag possibly be causing issues?

I don't know. Do you still run into this with u-boot/master ?

Still occurring with 2019.10-rc2. Haven't tested with master yet.

Quoted 8 lines
Quoted 2 lines

Using "dcache off" before booting still outputs the CACHE and ERROR messages, but does successfully boot.

Also seeing this problem with wandboard solo with 2019.10-rc4 booting from microSD. Haven't retested with novena recently.

Setting CONFIG_SYS_DCACHE_OFF=y avoids the need to manually type "dcache off" ... though obviously doesn't address the real problem.

Can you debug it further or prepare a reproducible testcase ?

#25 lore raw

v2 cover ARM: imx: Update Novena to DM/DT

In reply to Vagrant Cascadian
Quoted 51 lines · Vagrant Cascadian
Quoted 3 lines · Marek Vasut
Quoted 2 lines · Vagrant Cascadian
Quoted 1 line · Marek Vasut

Update Kosagi Novena to DM / DT and remove the warnings.

...

Quoted 17 lines
Quoted 17 lines

I have two oustanding issues... with some files it sometimes fails to load one or more from SATA:

Retrieving file: /boot/initrd.img-5.0.0-trunk-armmp
20077960 bytes read in 375 ms (51.1 MiB/s)
Retrieving file: /boot/vmlinuz-5.0.0-trunk-armmp
4215296 bytes read in 40 ms (100.5 MiB/s)
append: root=UUID=9666ab0b-f932-4e2f-95d7-0e96a12a4540 ro quiet Retrieving file: /usr/lib/linux-image-5.0.0-trunk-armmp/imx6q-novena.dtb
CACHE: Misaligned operation at range [fafb5398, fafb6398]
CACHE: Misaligned operation at range [fafb5398, fafb6398]
ERROR: v7_outer_cache_inval_range - start address is not aligned - 0xfafb5398
ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0xfafb6398
invalid extent block

Quoted 7 lines
Quoted 5 lines

It then falls back to one of the other kernels (using the extlinux.conf parsing) and succeeds. It consistantly gets a cache/alignment error with this specific file. A bit-for-bit identical .dtb loaded from another path works just fine. Older versions of u-boot boot this fine. Would some particular EXT4 flag possibly be causing issues?

I don't know. Do you still run into this with u-boot/master ?

Still occurring with 2019.10-rc2. Haven't tested with master yet.

Using "dcache off" before booting still outputs the CACHE and ERROR messages, but does successfully boot.

Quoted 15 lines
Quoted 15 lines

The second issue is still using one out of four exposed USB ports fails and resets the board:

load usb 0:1 $kernel_addr_r misc/Binaries/linux/Image data abort

pc : [<fefbb67a>]          lr : [<fefbb0fd>]

reloc pc : [<1783367a>] lr : [<178330fd>]
sp : faf7c6e8 ip : 00000003 fp : 00000005
r10: faf8b200 r9 : faf87ea0 r8 : 00000001
r7 : faf8b2c0 r6 : f9f7a040 r5 : faf7c710 r4 : 00000038
r3 : 0000006d r2 : f9f7a0a3 r1 : faf8b32c r0 : f9f7a09f
Flags: nzCv IRQs off FIQs off Mode SVC_32

Code: 4630fc5b 81f0e8bd e7d84606 bf082b2f (f822235c)

Resetting CPU ...

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

The three other usb ports work just fine with the same USB stick and file. All four ports work with 2019.01.

Can you debug it ? I think some of this was due to the EFI stuff , which I think was fixed since. Can you re-check that ?

USB appears to be working fine with 2019.10-rc2.

So what's the current status ?