Introduce ASPEED AST27XX BMC SoC
Subsystems (8)
cover Introduce ASPEED AST27XX BMC SoC
This patchset adds initial support for the ASPEED. AST27XX Board Management controller (BMC) SoC family.
AST2700 is ASPEED's 8th-generation server management processor. Featuring a quad-core ARM Cortex A35 64-bit processor and two independent ARM Cortex M4 processors
This patchset adds minimal architecture and drivers such as:
Clocksource, Clock and Reset
This patchset was tested on the ASPEED AST2700 evaluation board.
Kevin Chen (10):
dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700
SCU
dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock
clk: ast2700: add clock controller
dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset
dt-bindings: arm: aspeed: Add maintainer
dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
arm64: aspeed: Add support for ASPEED AST2700 BMC SoC
arm64: dts: aspeed: Add initial AST27XX device tree
arm64: dts: aspeed: Add initial AST2700 EVB device tree
arm64: defconfig: Add ASPEED AST2700 family support
.../bindings/arm/aspeed/aspeed.yaml | 6 + .../bindings/mfd/aspeed,ast2x00-scu.yaml | 3 + MAINTAINERS | 3 + arch/arm64/Kconfig.platforms | 14 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/aspeed/Makefile | 4 + arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 +++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 + arch/arm64/configs/defconfig | 1 + drivers/clk/Makefile | 1 + drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++ .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 +++ .../dt-bindings/reset/aspeed,ast2700-reset.h | 126 ++ 13 files changed, 1772 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts create mode 100644 drivers/clk/clk-ast2700.c create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.h
Signature · 1 line
2.34.1
PATCH 1/10 dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 SCU
--- Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml +3 -0
@@ -13,6 +13,7 @@ description: maintainers: - Joel Stanley <[email protected]> - Andrew Jeffery <[email protected]> + - Kevin Chen <[email protected]> properties: compatible:
@@ -21,6 +22,7 @@ properties: - aspeed,ast2400-scu - aspeed,ast2500-scu - aspeed,ast2600-scu + - aspeed,ast2700-scu - const: syscon - const: simple-mfd
@@ -76,6 +78,7 @@ patternProperties: - aspeed,ast2400-silicon-id - aspeed,ast2500-silicon-id - aspeed,ast2600-silicon-id + - aspeed,ast2700-silicon-id - const: aspeed,silicon-id reg:
Signature · 1 line
2.34.1
Krzysztof Kozlowski
maintainerRe: [PATCH v1 01/10] dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 SCU
Quoted 1 line · Kevin Chen
Signed-off-by Kevin Chen <[email protected]>
Missing commit msg.
Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Best regards,
Krzysztof
回覆: [PATCH v1 01/10] dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 SCU
Hi Krzk,
I will speperate clock part in the v3 patch into Ryan's clock series.
Quoted 8 lines
Missing commit msg.
Please use subject prefixes matching the subsystem. You can get them for example with
git log --oneline -- DIRECTORY_OR_FILEon the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Quoted 4 lines
A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Agree, already fixed in another commit in Ryan's series.
[1/4] dt-bindings: mfd: aspeed: support for AST2700 - Patchwork (kernel.org)<https://patchwork.kernel.org/project/linux-clk/patch/[email protected]/>
--
Best Regards,
Kevin. Chen
________________________________
???: Krzysztof Kozlowski <[email protected]>
????: 2024?7?26? ?? 07:10
???: Kevin Chen <[email protected]>; robh at kernel.org <[email protected]>; krzk+dt at kernel.org <[email protected]>; conor+dt at kernel.org <[email protected]>; joel at jms.id.au <[email protected]>; andrew at codeconstruct.com.au <[email protected]>; lee at kernel.org <[email protected]>; catalin.marinas at arm.com <[email protected]>; will at kernel.org <[email protected]>; arnd at arndb.de <[email protected]>; olof at lixom.net <[email protected]>; soc at kernel.org <[email protected]>; mturquette at baylibre.com <[email protected]>; sboyd at kernel.org <[email protected]>; p.zabel at pengutronix.de <[email protected]>; quic_bjorande at quicinc.com <[email protected]>; geert+renesas at glider.be <[email protected]>; dmitry.baryshkov at linaro.org <[email protected]>; shawnguo at kernel.org <[email protected]>; neil.armstrong at linaro.org <[email protected]>; m.szyprowski at samsung.com <[email protected]>; nfraprado at collabora.com <[email protected]>; u-kumar1 at ti.com <[email protected]>; devicetree at vger.kernel.org <[email protected]>; linux-arm-kernel at lists.infradead.org <[email protected]>; linux-aspeed at lists.ozlabs.org <[email protected]>; linux-kernel at vger.kernel.org <[email protected]>; linux-clk at vger.kernel.org <[email protected]> ??: Re: [PATCH v1 01/10] dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 SCU
Quoted 1 line · Kevin Chen
Signed-off-by Kevin Chen <[email protected]>
Missing commit msg.
Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Best regards,
Krzysztof
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you. -------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240815/b56b5015/attachment-0001.htm>
Krzysztof Kozlowski
maintainerRe: 回覆: [PATCH v1 01/10] dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 SCU
Quoted 12 lines · Kevin Chen
Hi Krzk,
I will speperate clock part in the v3 patch into Ryan's clock series.
Quoted 8 lines
Missing commit msg.
Please use subject prefixes matching the subsystem. You can get them for example with
git log --oneline -- DIRECTORY_OR_FILEon the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Quoted 6 lines
Quoted 4 lines
A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18Agree, already fixed in another commit in Ryan's series. [1/4] dt-bindings: mfd: aspeed: support fo
Just to make it clear: you responded after 2.5 months. This patchset is neither in my mailbox nor in my brain.
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerRe: 回覆: [PATCH v1 01/10] dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 SCU
Quoted 17 lines · Krzysztof Kozlowski
Quoted 16 lines · Kevin Chen
Hi Krzk,
I will speperate clock part in the v3 patch into Ryan's clock series.
Quoted 12 lines
Missing commit msg.
Please use subject prefixes matching the subsystem. You can get them for example with
git log --oneline -- DIRECTORY_OR_FILEon the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submittersA nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Quoted 5 lines
Quoted 2 lines
Agree, already fixed in another commit in Ryan's series. [1/4] dt-bindings: mfd: aspeed: support fo
Just to make it clear: you responded after 2.5 months. This patchset is neither in my mailbox nor in my brain.
Uh, this was supposed to be replied to your recent emails.
Best regards,
Krzysztof
RE: [PATCH v1 01/10] dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 SCU
In reply to Krzysztof KozlowskiHi Krzk,
I will separate clock part in the v3 patch into Ryan's clock series.
Quoted 9 lines
Missing commit msg.
Please use subject prefixes matching the subsystem. You can get them for example with
git log --oneline -- DIRECTORY_OR_FILEon the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patch
es.html#i-for-patch-submitters
Quoted 5 lines
A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bin
dings/submitting-patches.rst#L18
Agree, already fixed in another commit in Ryan's series.
https://patchwork.kernel.org/project/linux-clk/patch/20240808075937.2756733-2-ryan_chen at aspeedtech.com/
Quoted 5 lines
Best regards,
Krzysztof
--
Best Regards,
Kevin.Chen
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
PATCH 2/10 dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock
In reply to Kevin Chen--- .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 ++++++++++++++++++ 1 file changed, 180 insertions(+) create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +180 -0
@@ -0,0 +1,180 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* +* Device Tree binding constants for AST2700 clock controller. +* +* Copyright (c) 2023 Aspeed Technology Inc. +*/ + +#ifndef __DT_BINDINGS_CLOCK_AST2700_H +#define __DT_BINDINGS_CLOCK_AST2700_H + +/* SOC0 clk-gate */ +#define SCU0_CLK_GATE_MCLK (0) +#define SCU0_CLK_GATE_ECLK (1) +#define SCU0_CLK_GATE_GCLK (2) +#define SCU0_CLK_GATE_VCLK (3) +#define SCU0_CLK_GATE_BCLK (4) +#define SCU0_CLK_GATE_D1CLK (5) +#define SCU0_CLK_GATE_REFCLK (6) +#define SCU0_CLK_GATE_USB0CLK (7) +#define SCU0_CLK_GATE_RSV8 (8) +#define SCU0_CLK_GATE_USB1CLK (9) +#define SCU0_CLK_GATE_D2CLK (10) +#define SCU0_CLK_GATE_RSV11 (11) +#define SCU0_CLK_GATE_RSV12 (12) +#define SCU0_CLK_GATE_YCLK (13) +#define SCU0_CLK_GATE_USB2CLK (14) +#define SCU0_CLK_GATE_UART4CLK (15) +#define SCU0_CLK_GATE_SLICLK (16) +#define SCU0_CLK_GATE_DACCLK (17) +#define SCU0_CLK_GATE_DP (18) +#define SCU0_CLK_GATE_RSV19 (19) +#define SCU0_CLK_GATE_CRT1CLK (20) +#define SCU0_CLK_GATE_CRT2CLK (21) +#define SCU0_CLK_GATE_VLCLK (22) +#define SCU0_CLK_GATE_ECCCLK (23) +#define SCU0_CLK_GATE_RSACLK (24) +#define SCU0_CLK_GATE_RVAS0CLK (25) +#define SCU0_CLK_GATE_UFSCLK (26) +#define SCU0_CLK_GATE_EMMCCLK (27) +#define SCU0_CLK_GATE_RVAS1CLK (28) +/* reserved 29 ~ 31*/ +#define SOC0_CLK_GATE_NUM (SCU0_CLK_GATE_RVAS1CLK + 1) + +/* SOC0 clk */ +#define SCU0_CLKIN (SOC0_CLK_GATE_NUM + 0) +#define SCU0_CLK_24M (SOC0_CLK_GATE_NUM + 1) +#define SCU0_CLK_192M (SOC0_CLK_GATE_NUM + 2) +#define SCU0_CLK_UART (SOC0_CLK_GATE_NUM + 3) +#define SCU0_CLK_PSP (SOC0_CLK_GATE_NUM + 4) +#define SCU0_CLK_HPLL (SOC0_CLK_GATE_NUM + 5) +#define SCU0_CLK_HPLL_DIV2 (SOC0_CLK_GATE_NUM + 6) +#define SCU0_CLK_HPLL_DIV4 (SOC0_CLK_GATE_NUM + 7) +#define SCU0_CLK_DPLL (SOC0_CLK_GATE_NUM + 8) +#define SCU0_CLK_MPLL (SOC0_CLK_GATE_NUM + 9) +#define SCU0_CLK_MPLL_DIV2 (SOC0_CLK_GATE_NUM + 10) +#define SCU0_CLK_MPLL_DIV4 (SOC0_CLK_GATE_NUM + 11) +#define SCU0_CLK_MPLL_DIV8 (SOC0_CLK_GATE_NUM + 12) +#define SCU0_CLK_D1CLK (SOC0_CLK_GATE_NUM + 13) +#define SCU0_CLK_D2CLK (SOC0_CLK_GATE_NUM + 14) +#define SCU0_CLK_CRT1 (SOC0_CLK_GATE_NUM + 15) +#define SCU0_CLK_CRT2 (SOC0_CLK_GATE_NUM + 16) +#define SCU0_CLK_MPHY (SOC0_CLK_GATE_NUM + 17) +#define SCU0_CLK_AXI (SOC0_CLK_GATE_NUM + 18) +#define SCU0_CLK_AXI1 (SOC0_CLK_GATE_NUM + 19) +#define SCU0_CLK_AHB (SOC0_CLK_GATE_NUM + 20) +#define SCU0_CLK_APB (SOC0_CLK_GATE_NUM + 21) +#define SCU0_CLK_MCLK (SOC0_CLK_GATE_NUM + 22) +#define SCU0_CLK_ECLK (SOC0_CLK_GATE_NUM + 23) +#define SCU0_CLK_GCLK (SOC0_CLK_GATE_NUM + 24) +#define SCU0_CLK_VCLK (SOC0_CLK_GATE_NUM + 25) +#define SCU0_CLK_BCLK (SOC0_CLK_GATE_NUM + 26) +#define SCU0_CLK_REF (SOC0_CLK_GATE_NUM + 27) +#define SCU0_CLK_USB0CLK (SOC0_CLK_GATE_NUM + 28) +#define SCU0_CLK_USB1CLK (SOC0_CLK_GATE_NUM + 29) +#define SCU0_CLK_USB2CLK (SOC0_CLK_GATE_NUM + 30) +#define SCU0_CLK_YCLK (SOC0_CLK_GATE_NUM + 31) +#define SCU0_CLK_UART4 (SOC0_CLK_GATE_NUM + 32) +#define SCU0_CLK_SLI (SOC0_CLK_GATE_NUM + 33) +#define SCU0_CLK_ECC (SOC0_CLK_GATE_NUM + 34) +#define SCU0_CLK_RSA (SOC0_CLK_GATE_NUM + 35) +#define SCU0_CLK_RVAS0 (SOC0_CLK_GATE_NUM + 36) +#define SCU0_CLK_UFS (SOC0_CLK_GATE_NUM + 37) +#define SCU0_CLK_RVAS1 (SOC0_CLK_GATE_NUM + 38) +#define SCU0_CLK_EMMCMUX (SOC0_CLK_GATE_NUM + 39) +#define SCU0_CLK_EMMC (SOC0_CLK_GATE_NUM + 40) +#define SCU0_CLK_U2PHY_CLK12M (SOC0_CLK_GATE_NUM + 41) +#define SCU0_CLK_U2PHY_REFCLK (SOC0_CLK_GATE_NUM + 42) + +#define SOC0_NUM_CLKS (SCU0_CLK_U2PHY_REFCLK + 1) + +/* SOC1 clk gate */ +#define SCU1_CLK_GATE_LCLK0 (0) +#define SCU1_CLK_GATE_LCLK1 (1) +#define SCU1_CLK_GATE_ESPI0CLK (2) +#define SCU1_CLK_GATE_ESPI1CLK (3) +#define SCU1_CLK_GATE_SDCLK (4) +#define SCU1_CLK_GATE_REFCLK (5) +#define SCU1_CLK_GATE_RSV5CLK (6) +#define SCU1_CLK_GATE_LPCHCLK (7) +#define SCU1_CLK_GATE_MAC0CLK (8) +#define SCU1_CLK_GATE_MAC1CLK (9) +#define SCU1_CLK_GATE_MAC2CLK (10) +#define SCU1_CLK_GATE_UART0CLK (11) +#define SCU1_CLK_GATE_UART1CLK (12) +#define SCU1_CLK_GATE_UART2CLK (13) +#define SCU1_CLK_GATE_UART3CLK (14) +/* reserved bit 15*/ +#define SCU1_CLK_GATE_I3C0CLK (16) +#define SCU1_CLK_GATE_I3C1CLK (17) +#define SCU1_CLK_GATE_I3C2CLK (18) +#define SCU1_CLK_GATE_I3C3CLK (19) +#define SCU1_CLK_GATE_I3C4CLK (20) +#define SCU1_CLK_GATE_I3C5CLK (21) +#define SCU1_CLK_GATE_I3C6CLK (22) +#define SCU1_CLK_GATE_I3C7CLK (23) +#define SCU1_CLK_GATE_I3C8CLK (24) +#define SCU1_CLK_GATE_I3C9CLK (25) +#define SCU1_CLK_GATE_I3C10CLK (26) +#define SCU1_CLK_GATE_I3C11CLK (27) +#define SCU1_CLK_GATE_I3C12CLK (28) +#define SCU1_CLK_GATE_I3C13CLK (29) +#define SCU1_CLK_GATE_I3C14CLK (30) +#define SCU1_CLK_GATE_I3C15CLK (31) + +#define SCU1_CLK_GATE_UART5CLK (32 + 0) +#define SCU1_CLK_GATE_UART6CLK (32 + 1) +#define SCU1_CLK_GATE_UART7CLK (32 + 2) +#define SCU1_CLK_GATE_UART8CLK (32 + 3) +#define SCU1_CLK_GATE_UART9CLK (32 + 4) +#define SCU1_CLK_GATE_UART10CLK (32 + 5) +#define SCU1_CLK_GATE_UART11CLK (32 + 6) +#define SCU1_CLK_GATE_UART12CLK (32 + 7) +#define SCU1_CLK_GATE_FSICLK (32 + 8) +#define SCU1_CLK_GATE_LTPIPHYCLK (32 + 9) +#define SCU1_CLK_GATE_LTPICLK (32 + 10) +#define SCU1_CLK_GATE_VGALCLK (32 + 11) +#define SCU1_CLK_GATE_USBUARTCLK (32 + 12) +#define SCU1_CLK_GATE_CANCLK (32 + 13) +#define SCU1_CLK_GATE_PCICLK (32 + 14) +#define SCU1_CLK_GATE_SLICLK (32 + 15) + +#define SOC1_CLK_GATE_NUM (SCU1_CLK_GATE_SLICLK + 1) + +/* SOC1 clk */ +#define SCU1_CLKIN (SOC1_CLK_GATE_NUM + 0) +#define SCU1_CLK_HPLL (SOC1_CLK_GATE_NUM + 1) +#define SCU1_CLK_APLL (SOC1_CLK_GATE_NUM + 2) +#define SCU1_CLK_APLL_DIV2 (SOC1_CLK_GATE_NUM + 3) +#define SCU1_CLK_APLL_DIV4 (SOC1_CLK_GATE_NUM + 4) +#define SCU1_CLK_DPLL (SOC1_CLK_GATE_NUM + 5) +#define SCU1_CLK_UXCLK (SOC1_CLK_GATE_NUM + 6) +#define SCU1_CLK_HUXCLK (SOC1_CLK_GATE_NUM + 7) +#define SCU1_CLK_UARTX (SOC1_CLK_GATE_NUM + 8) +#define SCU1_CLK_HUARTX (SOC1_CLK_GATE_NUM + 9) +#define SCU1_CLK_AHB (SOC1_CLK_GATE_NUM + 10) +#define SCU1_CLK_APB (SOC1_CLK_GATE_NUM + 11) +#define SCU1_CLK_UART0 (SOC1_CLK_GATE_NUM + 12) +#define SCU1_CLK_UART1 (SOC1_CLK_GATE_NUM + 13) +#define SCU1_CLK_UART2 (SOC1_CLK_GATE_NUM + 14) +#define SCU1_CLK_UART3 (SOC1_CLK_GATE_NUM + 15) +#define SCU1_CLK_UART5 (SOC1_CLK_GATE_NUM + 16) +#define SCU1_CLK_UART6 (SOC1_CLK_GATE_NUM + 17) +#define SCU1_CLK_UART7 (SOC1_CLK_GATE_NUM + 18) +#define SCU1_CLK_UART8 (SOC1_CLK_GATE_NUM + 19) +#define SCU1_CLK_UART9 (SOC1_CLK_GATE_NUM + 20) +#define SCU1_CLK_UART10 (SOC1_CLK_GATE_NUM + 21) +#define SCU1_CLK_UART11 (SOC1_CLK_GATE_NUM + 22) +#define SCU1_CLK_UART12 (SOC1_CLK_GATE_NUM + 23) +#define SCU1_CLK_APLL_DIVN (SOC1_CLK_GATE_NUM + 24) +#define SCU1_CLK_SDMUX (SOC1_CLK_GATE_NUM + 25) +#define SCU1_CLK_SDCLK (SOC1_CLK_GATE_NUM + 26) +#define SCU1_CLK_RMII (SOC1_CLK_GATE_NUM + 27) +#define SCU1_CLK_RGMII (SOC1_CLK_GATE_NUM + 28) +#define SCU1_CLK_MACHCLK (SOC1_CLK_GATE_NUM + 29) +#define SCU1_CLK_MAC0RCLK (SOC1_CLK_GATE_NUM + 30) +#define SCU1_CLK_MAC1RCLK (SOC1_CLK_GATE_NUM + 31) + +#define SOC1_NUM_CLKS (SCU1_CLK_MAC1RCLK + 1) + +#endif
Signature · 1 line
2.34.1
Krzysztof Kozlowski
maintainerRe: [PATCH v1 02/10] dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock
Quoted 1 line · Kevin Chen
Signed-off-by Kevin Chen <[email protected]>
Missing commit msg.
A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Quoted 2 lines
--- .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 ++++++++++++++++++
This is supposed to be part of bindings adding the clock controller.
Quoted 12 lines
1 file changed, 180 insertions(+) create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.hinclude/dt-bindings/clock/aspeed,ast2700-clk.h new file +3
-0@@ -0,0 +1,180 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* +* Device Tree binding constants for AST2700 clock controller.
include/dt-bindings/clock/aspeed,ast2700-clk.h line 13
Quoted 10 lines
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +10
-0+* +* Copyright (c) 2023 Aspeed Technology Inc. +*/ + +#ifndef __DT_BINDINGS_CLOCK_AST2700_H +#define __DT_BINDINGS_CLOCK_AST2700_H + +/* SOC0 clk-gate */ +#define SCU0_CLK_GATE_MCLK (0) +#define SCU0_CLK_GATE_ECLK (1)
Drop all (). Not needed, not useful.
Quoted 18 lines
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +18
-0+#define SCU0_CLK_GATE_GCLK (2) +#define SCU0_CLK_GATE_VCLK (3) +#define SCU0_CLK_GATE_BCLK (4) +#define SCU0_CLK_GATE_D1CLK (5) +#define SCU0_CLK_GATE_REFCLK (6) +#define SCU0_CLK_GATE_USB0CLK (7) +#define SCU0_CLK_GATE_RSV8 (8) +#define SCU0_CLK_GATE_USB1CLK (9) +#define SCU0_CLK_GATE_D2CLK (10) +#define SCU0_CLK_GATE_RSV11 (11) +#define SCU0_CLK_GATE_RSV12 (12) +#define SCU0_CLK_GATE_YCLK (13) +#define SCU0_CLK_GATE_USB2CLK (14) +#define SCU0_CLK_GATE_UART4CLK (15) +#define SCU0_CLK_GATE_SLICLK (16) +#define SCU0_CLK_GATE_DACCLK (17) +#define SCU0_CLK_GATE_DP (18) +#define SCU0_CLK_GATE_RSV19 (19)
include/dt-bindings/clock/aspeed,ast2700-clk.h line 41
Quoted 10 lines
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +10
-0+#define SCU0_CLK_GATE_CRT1CLK (20) +#define SCU0_CLK_GATE_CRT2CLK (21) +#define SCU0_CLK_GATE_VLCLK (22) +#define SCU0_CLK_GATE_ECCCLK (23) +#define SCU0_CLK_GATE_RSACLK (24) +#define SCU0_CLK_GATE_RVAS0CLK (25) +#define SCU0_CLK_GATE_UFSCLK (26) +#define SCU0_CLK_GATE_EMMCCLK (27) +#define SCU0_CLK_GATE_RVAS1CLK (28) +/* reserved 29 ~ 31*/
IDs cannot be reserved. It is a binding, not a hardware number.
include/dt-bindings/clock/aspeed,ast2700-clk.h line 42
Quoted 1 line
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +1
-0+#define SOC0_CLK_GATE_NUM (SCU0_CLK_GATE_RVAS1CLK + 1)
No drop. Others as well.
Best regards,
Krzysztof
回覆: [PATCH v1 02/10] dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock
Hi Krzk,
Quoted 7 lines
Missing commit msg.
A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Quoted 5 lines
Please use subject prefixes matching the subsystem. You can get them for example with
git log --oneline -- DIRECTORY_OR_FILEon the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Agree, already fixed in another commit in Ryan's series.
[3/4] dt-bindings: clock: Add AST2700 clock bindings - Patchwork (kernel.org)<https://patchwork.kernel.org/project/linux-clk/patch/[email protected]/>
--
Best Regards,
Kevin. Chen
________________________________
???: Krzysztof Kozlowski <[email protected]>
????: 2024?7?26? ?? 07:11
???: Kevin Chen <[email protected]>; robh at kernel.org <[email protected]>; krzk+dt at kernel.org <[email protected]>; conor+dt at kernel.org <[email protected]>; joel at jms.id.au <[email protected]>; andrew at codeconstruct.com.au <[email protected]>; lee at kernel.org <[email protected]>; catalin.marinas at arm.com <[email protected]>; will at kernel.org <[email protected]>; arnd at arndb.de <[email protected]>; olof at lixom.net <[email protected]>; soc at kernel.org <[email protected]>; mturquette at baylibre.com <[email protected]>; sboyd at kernel.org <[email protected]>; p.zabel at pengutronix.de <[email protected]>; quic_bjorande at quicinc.com <[email protected]>; geert+renesas at glider.be <[email protected]>; dmitry.baryshkov at linaro.org <[email protected]>; shawnguo at kernel.org <[email protected]>; neil.armstrong at linaro.org <[email protected]>; m.szyprowski at samsung.com <[email protected]>; nfraprado at collabora.com <[email protected]>; u-kumar1 at ti.com <[email protected]>; devicetree at vger.kernel.org <[email protected]>; linux-arm-kernel at lists.infradead.org <[email protected]>; linux-aspeed at lists.ozlabs.org <[email protected]>; linux-kernel at vger.kernel.org <[email protected]>; linux-clk at vger.kernel.org <[email protected]> ??: Re: [PATCH v1 02/10] dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock
Quoted 1 line · Kevin Chen
Signed-off-by Kevin Chen <[email protected]>
Missing commit msg.
A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Quoted 2 lines
--- .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 ++++++++++++++++++
This is supposed to be part of bindings adding the clock controller.
Quoted 12 lines
1 file changed, 180 insertions(+) create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.hinclude/dt-bindings/clock/aspeed,ast2700-clk.h new file +3
-0@@ -0,0 +1,180 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* +* Device Tree binding constants for AST2700 clock controller.
include/dt-bindings/clock/aspeed,ast2700-clk.h line 13
Quoted 10 lines
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +10
-0+* +* Copyright (c) 2023 Aspeed Technology Inc. +*/ + +#ifndef __DT_BINDINGS_CLOCK_AST2700_H +#define __DT_BINDINGS_CLOCK_AST2700_H + +/* SOC0 clk-gate */ +#define SCU0_CLK_GATE_MCLK (0) +#define SCU0_CLK_GATE_ECLK (1)
Drop all (). Not needed, not useful.
Quoted 18 lines
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +18
-0+#define SCU0_CLK_GATE_GCLK (2) +#define SCU0_CLK_GATE_VCLK (3) +#define SCU0_CLK_GATE_BCLK (4) +#define SCU0_CLK_GATE_D1CLK (5) +#define SCU0_CLK_GATE_REFCLK (6) +#define SCU0_CLK_GATE_USB0CLK (7) +#define SCU0_CLK_GATE_RSV8 (8) +#define SCU0_CLK_GATE_USB1CLK (9) +#define SCU0_CLK_GATE_D2CLK (10) +#define SCU0_CLK_GATE_RSV11 (11) +#define SCU0_CLK_GATE_RSV12 (12) +#define SCU0_CLK_GATE_YCLK (13) +#define SCU0_CLK_GATE_USB2CLK (14) +#define SCU0_CLK_GATE_UART4CLK (15) +#define SCU0_CLK_GATE_SLICLK (16) +#define SCU0_CLK_GATE_DACCLK (17) +#define SCU0_CLK_GATE_DP (18) +#define SCU0_CLK_GATE_RSV19 (19)
include/dt-bindings/clock/aspeed,ast2700-clk.h line 41
Quoted 10 lines
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +10
-0+#define SCU0_CLK_GATE_CRT1CLK (20) +#define SCU0_CLK_GATE_CRT2CLK (21) +#define SCU0_CLK_GATE_VLCLK (22) +#define SCU0_CLK_GATE_ECCCLK (23) +#define SCU0_CLK_GATE_RSACLK (24) +#define SCU0_CLK_GATE_RVAS0CLK (25) +#define SCU0_CLK_GATE_UFSCLK (26) +#define SCU0_CLK_GATE_EMMCCLK (27) +#define SCU0_CLK_GATE_RVAS1CLK (28) +/* reserved 29 ~ 31*/
IDs cannot be reserved. It is a binding, not a hardware number.
include/dt-bindings/clock/aspeed,ast2700-clk.h line 42
Quoted 1 line
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +1
-0+#define SOC0_CLK_GATE_NUM (SCU0_CLK_GATE_RVAS1CLK + 1)
No drop. Others as well.
Best regards,
Krzysztof
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you. -------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240815/c9988c0f/attachment-0001.htm>
RE: [PATCH v1 02/10] dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock
In reply to Krzysztof KozlowskiHi Krzk,
I will separate clock part in the v3 patch into Ryan's clock series.
Quoted 9 lines
Missing commit msg.
A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bin
dings/submitting-patches.rst#L18
Quoted 5 lines
Please use subject prefixes matching the subsystem. You can get them for example with
git log --oneline -- DIRECTORY_OR_FILEon the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patch
es.html#i-for-patch-submitters
Agree, already fixed in another commit in Ryan's series.
https://patchwork.kernel.org/project/linux-clk/patch/20240808075937.2756733-4-ryan_chen at aspeedtech.com/
Quoted 56 lines
Quoted 5 lines
--- .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 ++++++++++++++++++This is supposed to be part of bindings adding the clock controller.
Quoted 13 lines
1 file changed, 180 insertions(+) create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.hinclude/dt-bindings/clock/aspeed,ast2700-clk.h new file +3
-0@@ -0,0 +1,180 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* +* Device Tree binding constants for AST2700 clock controller. include/dt-bindings/clock/aspeed,ast2700-clk.h line 13
Quoted 10 lines
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +10
-0+* +* Copyright (c) 2023 Aspeed Technology Inc. +*/ + +#ifndef __DT_BINDINGS_CLOCK_AST2700_H#define +__DT_BINDINGS_CLOCK_AST2700_H + +/* SOC0 clk-gate */ +#define SCU0_CLK_GATE_MCLK (0) +#define SCU0_CLK_GATE_ECLK (1)Drop all (). Not needed, not useful.
Quoted 22 lines
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +22
-0+#define SCU0_CLK_GATE_GCLK (2) +#define SCU0_CLK_GATE_VCLK (3) +#define SCU0_CLK_GATE_BCLK (4) +#define SCU0_CLK_GATE_D1CLK (5) +#define SCU0_CLK_GATE_REFCLK (6) +#define SCU0_CLK_GATE_USB0CLK (7) +#define SCU0_CLK_GATE_RSV8 (8) +#define SCU0_CLK_GATE_USB1CLK (9) +#define SCU0_CLK_GATE_D2CLK (10) +#define SCU0_CLK_GATE_RSV11 (11) +#define SCU0_CLK_GATE_RSV12 (12) +#define SCU0_CLK_GATE_YCLK (13) +#define SCU0_CLK_GATE_USB2CLK (14) +#define SCU0_CLK_GATE_UART4CLK (15) +#define SCU0_CLK_GATE_SLICLK (16) +#define SCU0_CLK_GATE_DACCLK (17) +#define SCU0_CLK_GATE_DP (18) +#define SCU0_CLK_GATE_RSV19 (19) +#define SCU0_CLK_GATE_CRT1CLK (20) +#define SCU0_CLK_GATE_CRT2CLK (21) +#define SCU0_CLK_GATE_VLCLK (22) +#define SCU0_CLK_GATE_ECCCLK (23)
Quoted 8 lines
include/dt-bindings/clock/aspeed,ast2700-clk.h line 41
Quoted 6 lines
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +6
-0+#define SCU0_CLK_GATE_RSACLK (24) +#define SCU0_CLK_GATE_RVAS0CLK (25) +#define SCU0_CLK_GATE_UFSCLK (26) +#define SCU0_CLK_GATE_EMMCCLK (27) +#define SCU0_CLK_GATE_RVAS1CLK (28) +/* reserved 29 ~ 31*/ IDs cannot be reserved. It is a binding, not a hardware number.
Agree, already fixed in another commit in Ryan's series.
https://patchwork.kernel.org/project/linux-clk/patch/20240808075937.2756733-4-ryan_chen at aspeedtech.com/
Quoted 4 lines
include/dt-bindings/clock/aspeed,ast2700-clk.h line 42
Quoted 2 lines
include/dt-bindings/clock/aspeed,ast2700-clk.h new file +1
-0+#define SOC0_CLK_GATE_NUM (SCU0_CLK_GATE_RVAS1CLK + 1)No drop. Others as well.
Agree, already fixed in another commit in Ryan's series.
https://patchwork.kernel.org/project/linux-clk/patch/20240808075937.2756733-4-ryan_chen at aspeedtech.com/
Quoted 3 lines
Best regards,
Krzysztof
--
Best Regards,
Kevin.Chen
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
PATCH 3/10 clk: ast2700: add clock controller
In reply to Kevin Chen--- drivers/clk/Makefile | 1 + drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++++++++++++++++++++++ 2 files changed, 1167 insertions(+) create mode 100644 drivers/clk/clk-ast2700.c
drivers/clk/Makefile +1 -0
@@ -38,6 +38,7 @@ obj-$(CONFIG_COMMON_CLK_FSL_SAI) += clk-fsl-sai.o obj-$(CONFIG_COMMON_CLK_GEMINI) += clk-gemini.o obj-$(CONFIG_COMMON_CLK_ASPEED) += clk-aspeed.o obj-$(CONFIG_MACH_ASPEED_G6) += clk-ast2600.o +obj-$(CONFIG_MACH_ASPEED_G7) += clk-ast2700.o obj-$(CONFIG_ARCH_HIGHBANK) += clk-highbank.o obj-$(CONFIG_CLK_HSDK) += clk-hsdk-pll.o obj-$(CONFIG_COMMON_CLK_K210) += clk-k210.o
drivers/clk/clk-ast2700.c new file +1166 -0
1,166 lines not on this page · raw message
Signature · 1 line
2.34.1
Krzysztof Kozlowski
maintainerRe: [PATCH v1 03/10] clk: ast2700: add clock controller
Quoted 1 line · Kevin Chen
Signed-off-by Kevin Chen <[email protected]>
So you did not write commit msgs to none of the commits?
Quoted 15 lines
--- drivers/clk/Makefile | 1 + drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++++++++++++++++++++++ 2 files changed, 1167 insertions(+) create mode 100644 drivers/clk/clk-ast2700.cdrivers/clk/Makefile +1
-0@@ -38,6 +38,7 @@ obj-$(CONFIG_COMMON_CLK_FSL_SAI) += clk-fsl-sai.o obj-$(CONFIG_COMMON_CLK_GEMINI) += clk-gemini.o obj-$(CONFIG_COMMON_CLK_ASPEED) += clk-aspeed.o obj-$(CONFIG_MACH_ASPEED_G6) += clk-ast2600.o +obj-$(CONFIG_MACH_ASPEED_G7) += clk-ast2700.o
...
Quoted 25 lines
drivers/clk/Makefile +25
-0+ +static const char *const pspclk_sel[] = { + "soc0-mpll", + "soc0-hpll", +}; + +static const char *const soc0_uartclk_sel[] = { + "soc0-clk24Mhz", + "soc0-clk192Mhz", +}; + +static const char *const emmcclk_sel[] = { + "soc0-mpll_div4", + "soc0-hpll_div4", +}; + +static int ast2700_soc0_clk_init(struct device_node *soc0_node) +{ + struct clk_hw_onecell_data *clk_data; + void __iomem *clk_base; + struct ast2700_reset *reset; + struct clk_hw **clks; + int div; + u32 val; + int ret;
drivers/clk/Makefile
Quoted 10 lines
drivers/clk/Makefile +10
-0+ + clk_data = kzalloc(struct_size(clk_data, hws, SOC0_NUM_CLKS), GFP_KERNEL); + if (!clk_data) + return -ENOMEM; + + clk_data->num = SOC0_NUM_CLKS; + clks = clk_data->hws; + + clk_base = of_iomap(soc0_node, 0); + if (WARN_ON(IS_ERR(clk_base)))
Drop WARN_ON
Quoted 10 lines
drivers/clk/Makefile +10
-0+ return PTR_ERR(clk_base); + + reset = kzalloc(sizeof(*reset), GFP_KERNEL); + if (!reset) + return -ENOMEM; + + reset->base = clk_base; + + reset->rcdev.owner = THIS_MODULE; + reset->rcdev.nr_resets = SOC0_RESET_NUMS;
drivers/clk/Makefile
Quoted 10 lines
drivers/clk/Makefile +10
-0+ reset->rcdev.ops = &ast2700_reset_ops; + reset->rcdev.of_node = soc0_node; + + ret = reset_controller_register(&reset->rcdev); + if (ret) { + pr_err("soc0 failed to register reset controller\n"); + return ret; + } + + //refclk
Weird comment. Please read Coding Style.
Quoted 24 lines
drivers/clk/Makefile +24
-0+ clks[SCU0_CLKIN] = + clk_hw_register_fixed_rate(NULL, "soc0-clkin", NULL, 0, SCU_CLK_25MHZ); + + clks[SCU0_CLK_24M] = + clk_hw_register_fixed_rate(NULL, "soc0-clk24Mhz", NULL, 0, SCU_CLK_24MHZ); + + clks[SCU0_CLK_192M] = + clk_hw_register_fixed_rate(NULL, "soc0-clk192Mhz", NULL, 0, SCU_CLK_192MHZ); + + //hpll + val = readl(clk_base + SCU0_HWSTRAP1); + if ((val & GENMASK(3, 2)) != 0) { + switch ((val & GENMASK(3, 2)) >> 2) { + case 1: + clks[SCU0_CLK_HPLL] = + clk_hw_register_fixed_rate(NULL, "soc0-hpll", NULL, 0, 1900000000); + break; + case 2: + clks[SCU0_CLK_HPLL] = + clk_hw_register_fixed_rate(NULL, "soc0-hpll", NULL, 0, 1800000000); + break; + case 3: + clks[SCU0_CLK_HPLL] = + clk_hw_register_fixed_rate(NULL, "soc0-hpll", NULL, 0, 1700000000);
drivers/clk/Makefile
Quoted 10 lines
drivers/clk/Makefile +10
-0+ break; + } + } else { + val = readl(clk_base + SCU0_HPLL_PARAM); + clks[SCU0_CLK_HPLL] = ast2700_soc0_hw_pll("soc0-hpll", "soc0-clkin", val); + } + clks[SCU0_CLK_HPLL_DIV2] = clk_hw_register_fixed_factor(NULL, "soc0-hpll_div2", "soc0-hpll", 0, 1, 2); + clks[SCU0_CLK_HPLL_DIV4] = clk_hw_register_fixed_factor(NULL, "soc0-hpll_div4", "soc0-hpll", 0, 1, 4); + + //dpll
Best regards,
Krzysztof
回覆: [PATCH v1 03/10] clk: ast2700: add clock controller
Hi Krzk,
I will speperate clock part in the v3 patch into Ryan's clock series.
Quoted 49 lines
So you did not write commit msgs to none of the commits?
Quoted 15 lines
--- drivers/clk/Makefile | 1 + drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++++++++++++++++++++++ 2 files changed, 1167 insertions(+) create mode 100644 drivers/clk/clk-ast2700.cdrivers/clk/Makefile +1
-0@@ -38,6 +38,7 @@ obj-$(CONFIG_COMMON_CLK_FSL_SAI) += clk-fsl-sai.o obj-$(CONFIG_COMMON_CLK_GEMINI) += clk-gemini.o obj-$(CONFIG_COMMON_CLK_ASPEED) += clk-aspeed.o obj-$(CONFIG_MACH_ASPEED_G6) += clk-ast2600.o +obj-$(CONFIG_MACH_ASPEED_G7) += clk-ast2700.o...
Quoted 29 lines
drivers/clk/Makefile +29
-0+ +static const char *const pspclk_sel[] = { + "soc0-mpll", + "soc0-hpll", +}; + +static const char *const soc0_uartclk_sel[] = { + "soc0-clk24Mhz", + "soc0-clk192Mhz", +}; + +static const char *const emmcclk_sel[] = { + "soc0-mpll_div4", + "soc0-hpll_div4", +}; + +static int ast2700_soc0_clk_init(struct device_node *soc0_node) +{ + struct clk_hw_onecell_data *clk_data; + void __iomem *clk_base; + struct ast2700_reset *reset; + struct clk_hw **clks; + int div; + u32 val; + int ret; + + clk_data = kzalloc(struct_size(clk_data, hws, SOC0_NUM_CLKS), GFP_KERNEL); + if (!clk_data) + return -ENOMEM;
Quoted 8 lines
drivers/clk/Makefile
Quoted 6 lines
drivers/clk/Makefile +6
-0+ + clk_data->num = SOC0_NUM_CLKS; + clks = clk_data->hws; + + clk_base = of_iomap(soc0_node, 0); + if (WARN_ON(IS_ERR(clk_base)))Drop
WARN_ON
I remind Ryan for this fix. He will reply in these series.
[4/4] dt-bindings: clock: Add AST2700 clock bindings - Patchwork (kernel.org)<https://patchwork.kernel.org/project/linux-clk/patch/[email protected]/>
Quoted 14 lines
Quoted 14 lines
drivers/clk/Makefile +14
-0+ return PTR_ERR(clk_base); + + reset = kzalloc(sizeof(*reset), GFP_KERNEL); + if (!reset) + return -ENOMEM; + + reset->base = clk_base; + + reset->rcdev.owner = THIS_MODULE; + reset->rcdev.nr_resets = SOC0_RESET_NUMS; + reset->rcdev.ops = &ast2700_reset_ops; + reset->rcdev.of_node = soc0_node; + + ret = reset_controller_register(&reset->rcdev);
Quoted 8 lines
drivers/clk/Makefile
Quoted 6 lines
drivers/clk/Makefile +6
-0+ if (ret) { + pr_err("soc0 failed to register reset controller\n"); + return ret; + } + + //refclkWeird comment. Please read Coding Style.
I remind Ryan for this fix. He will reply in these series.
[4/4] dt-bindings: clock: Add AST2700 clock bindings - Patchwork (kernel.org)<https://patchwork.kernel.org/project/linux-clk/patch/[email protected]/>
Quoted 28 lines
Quoted 28 lines
drivers/clk/Makefile +26
-0+ clks[SCU0_CLKIN] = + clk_hw_register_fixed_rate(NULL, "soc0-clkin", NULL, 0, SCU_CLK_25MHZ); + + clks[SCU0_CLK_24M] = + clk_hw_register_fixed_rate(NULL, "soc0-clk24Mhz", NULL, 0, SCU_CLK_24MHZ); + + clks[SCU0_CLK_192M] = + clk_hw_register_fixed_rate(NULL, "soc0-clk192Mhz", NULL, 0, SCU_CLK_192MHZ); + + //hpll + val = readl(clk_base + SCU0_HWSTRAP1); + if ((val & GENMASK(3, 2)) != 0) { + switch ((val & GENMASK(3, 2)) >> 2) { + case 1: + clks[SCU0_CLK_HPLL] = + clk_hw_register_fixed_rate(NULL, "soc0-hpll", NULL, 0, 1900000000); + break; + case 2: + clks[SCU0_CLK_HPLL] = + clk_hw_register_fixed_rate(NULL, "soc0-hpll", NULL, 0, 1800000000); + break; + case 3: + clks[SCU0_CLK_HPLL] = + clk_hw_register_fixed_rate(NULL, "soc0-hpll", NULL, 0, 1700000000); + break; + }
Quoted 9 lines
drivers/clk/Makefile
Quoted 8 lines
drivers/clk/Makefile +8
-0+ } else { + val = readl(clk_base + SCU0_HPLL_PARAM); + clks[SCU0_CLK_HPLL] = ast2700_soc0_hw_pll("soc0-hpll", "soc0-clkin", val); + } + clks[SCU0_CLK_HPLL_DIV2] = clk_hw_register_fixed_factor(NULL, "soc0-hpll_div2", "soc0-hpll", 0, 1, 2); + clks[SCU0_CLK_HPLL_DIV4] = clk_hw_register_fixed_factor(NULL, "soc0-hpll_div4", "soc0-hpll", 0, 1, 4); + + //dpll
--
Best Regards,
Kevin. Chen
________________________________
???: Krzysztof Kozlowski <[email protected]>
????: 2024?7?26? ?? 07:13
???: Kevin Chen <[email protected]>; robh at kernel.org <[email protected]>; krzk+dt at kernel.org <[email protected]>; conor+dt at kernel.org <[email protected]>; joel at jms.id.au <[email protected]>; andrew at codeconstruct.com.au <[email protected]>; lee at kernel.org <[email protected]>; catalin.marinas at arm.com <[email protected]>; will at kernel.org <[email protected]>; arnd at arndb.de <[email protected]>; olof at lixom.net <[email protected]>; soc at kernel.org <[email protected]>; mturquette at baylibre.com <[email protected]>; sboyd at kernel.org <[email protected]>; p.zabel at pengutronix.de <[email protected]>; quic_bjorande at quicinc.com <[email protected]>; geert+renesas at glider.be <[email protected]>; dmitry.baryshkov at linaro.org <[email protected]>; shawnguo at kernel.org <[email protected]>; neil.armstrong at linaro.org <[email protected]>; m.szyprowski at samsung.com <[email protected]>; nfraprado at collabora.com <[email protected]>; u-kumar1 at ti.com <[email protected]>; devicetree at vger.kernel.org <[email protected]>; linux-arm-kernel at lists.infradead.org <[email protected]>; linux-aspeed at lists.ozlabs.org <[email protected]>; linux-kernel at vger.kernel.org <[email protected]>; linux-clk at vger.kernel.org <[email protected]> ??: Re: [PATCH v1 03/10] clk: ast2700: add clock controller
Quoted 1 line · Kevin Chen
Signed-off-by Kevin Chen <[email protected]>
So you did not write commit msgs to none of the commits?
Quoted 15 lines
--- drivers/clk/Makefile | 1 + drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++++++++++++++++++++++ 2 files changed, 1167 insertions(+) create mode 100644 drivers/clk/clk-ast2700.cdrivers/clk/Makefile +1
-0@@ -38,6 +38,7 @@ obj-$(CONFIG_COMMON_CLK_FSL_SAI) += clk-fsl-sai.o obj-$(CONFIG_COMMON_CLK_GEMINI) += clk-gemini.o obj-$(CONFIG_COMMON_CLK_ASPEED) += clk-aspeed.o obj-$(CONFIG_MACH_ASPEED_G6) += clk-ast2600.o +obj-$(CONFIG_MACH_ASPEED_G7) += clk-ast2700.o
...
Quoted 25 lines
drivers/clk/Makefile +25
-0+ +static const char *const pspclk_sel[] = { + "soc0-mpll", + "soc0-hpll", +}; + +static const char *const soc0_uartclk_sel[] = { + "soc0-clk24Mhz", + "soc0-clk192Mhz", +}; + +static const char *const emmcclk_sel[] = { + "soc0-mpll_div4", + "soc0-hpll_div4", +}; + +static int ast2700_soc0_clk_init(struct device_node *soc0_node) +{ + struct clk_hw_onecell_data *clk_data; + void __iomem *clk_base; + struct ast2700_reset *reset; + struct clk_hw **clks; + int div; + u32 val; + int ret;
drivers/clk/Makefile
Quoted 10 lines
drivers/clk/Makefile +10
-0+ + clk_data = kzalloc(struct_size(clk_data, hws, SOC0_NUM_CLKS), GFP_KERNEL); + if (!clk_data) + return -ENOMEM; + + clk_data->num = SOC0_NUM_CLKS; + clks = clk_data->hws; + + clk_base = of_iomap(soc0_node, 0); + if (WARN_ON(IS_ERR(clk_base)))
Drop WARN_ON
Quoted 10 lines
drivers/clk/Makefile +10
-0+ return PTR_ERR(clk_base); + + reset = kzalloc(sizeof(*reset), GFP_KERNEL); + if (!reset) + return -ENOMEM; + + reset->base = clk_base; + + reset->rcdev.owner = THIS_MODULE; + reset->rcdev.nr_resets = SOC0_RESET_NUMS;
drivers/clk/Makefile
Quoted 10 lines
drivers/clk/Makefile +10
-0+ reset->rcdev.ops = &ast2700_reset_ops; + reset->rcdev.of_node = soc0_node; + + ret = reset_controller_register(&reset->rcdev); + if (ret) { + pr_err("soc0 failed to register reset controller\n"); + return ret; + } + + //refclk
Weird comment. Please read Coding Style.
Quoted 24 lines
drivers/clk/Makefile +24
-0+ clks[SCU0_CLKIN] = + clk_hw_register_fixed_rate(NULL, "soc0-clkin", NULL, 0, SCU_CLK_25MHZ); + + clks[SCU0_CLK_24M] = + clk_hw_register_fixed_rate(NULL, "soc0-clk24Mhz", NULL, 0, SCU_CLK_24MHZ); + + clks[SCU0_CLK_192M] = + clk_hw_register_fixed_rate(NULL, "soc0-clk192Mhz", NULL, 0, SCU_CLK_192MHZ); + + //hpll + val = readl(clk_base + SCU0_HWSTRAP1); + if ((val & GENMASK(3, 2)) != 0) { + switch ((val & GENMASK(3, 2)) >> 2) { + case 1: + clks[SCU0_CLK_HPLL] = + clk_hw_register_fixed_rate(NULL, "soc0-hpll", NULL, 0, 1900000000); + break; + case 2: + clks[SCU0_CLK_HPLL] = + clk_hw_register_fixed_rate(NULL, "soc0-hpll", NULL, 0, 1800000000); + break; + case 3: + clks[SCU0_CLK_HPLL] = + clk_hw_register_fixed_rate(NULL, "soc0-hpll", NULL, 0, 1700000000);
drivers/clk/Makefile
Quoted 10 lines
drivers/clk/Makefile +10
-0+ break; + } + } else { + val = readl(clk_base + SCU0_HPLL_PARAM); + clks[SCU0_CLK_HPLL] = ast2700_soc0_hw_pll("soc0-hpll", "soc0-clkin", val); + } + clks[SCU0_CLK_HPLL_DIV2] = clk_hw_register_fixed_factor(NULL, "soc0-hpll_div2", "soc0-hpll", 0, 1, 2); + clks[SCU0_CLK_HPLL_DIV4] = clk_hw_register_fixed_factor(NULL, "soc0-hpll_div4", "soc0-hpll", 0, 1, 4); + + //dpll
Best regards,
Krzysztof
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you. -------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240815/7113cfd0/attachment-0001.htm>
RE: [PATCH v1 03/10] clk: ast2700: add clock controller
In reply to Krzysztof KozlowskiHi Krzk,
I will separate clock part in the v3 patch into Ryan's clock series.
Quoted 49 lines
So you did not write commit msgs to none of the commits?
Quoted 16 lines
--- drivers/clk/Makefile | 1 + drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++++++++++++++++++++++ 2 files changed, 1167 insertions(+) create mode 100644 drivers/clk/clk-ast2700.cdrivers/clk/Makefile index renamed from drivers/clk/Makefile +0
-0
f793a16cad40..0d5992ea0fa4100644drivers/clk/Makefile +1
-0@@ -38,6 +38,7 @@ obj-$(CONFIG_COMMON_CLK_FSL_SAI) += clk-fsl-sai.o obj-$(CONFIG_COMMON_CLK_GEMINI) += clk-gemini.o obj-$(CONFIG_COMMON_CLK_ASPEED) += clk-aspeed.o obj-$(CONFIG_MACH_ASPEED_G6) += clk-ast2600.o +obj-$(CONFIG_MACH_ASPEED_G7) += clk-ast2700.o...
Quoted 16 lines
drivers/clk/Makefile +16
-0+ +static const char *const pspclk_sel[] = { + "soc0-mpll", + "soc0-hpll", +}; + +static const char *const soc0_uartclk_sel[] = { + "soc0-clk24Mhz", + "soc0-clk192Mhz", +}; + +static const char *const emmcclk_sel[] = { + "soc0-mpll_div4", + "soc0-hpll_div4", +}; +drivers/clk/Makefile
Quoted 10 lines
drivers/clk/Makefile +10
-0+static int ast2700_soc0_clk_init(struct device_node *soc0_node) { + struct clk_hw_onecell_data *clk_data; + void __iomem *clk_base; + struct ast2700_reset *reset; + struct clk_hw **clks; + int div; + u32 val; + int ret; + + clk_data = kzalloc(struct_size(clk_data, hws, SOC0_NUM_CLKS),
GFP_KERNEL);
Quoted 10 lines
drivers/clk/Makefile
Quoted 8 lines
drivers/clk/Makefile +8
-0+ if (!clk_data) + return -ENOMEM; + + clk_data->num = SOC0_NUM_CLKS; + clks = clk_data->hws; + + clk_base = of_iomap(soc0_node, 0); + if (WARN_ON(IS_ERR(clk_base)))Drop
WARN_ON
I remind Ryan for this fix. He will reply in these series.
https://patchwork.kernel.org/project/linux-clk/patch/20240808075937.2756733-5-ryan_chen at aspeedtech.com/
Quoted 15 lines
Quoted 15 lines
drivers/clk/Makefile +14
-0+ return PTR_ERR(clk_base); + + reset = kzalloc(sizeof(*reset), GFP_KERNEL); + if (!reset) + return -ENOMEM; + + reset->base = clk_base; + + reset->rcdev.owner = THIS_MODULE; + reset->rcdev.nr_resets = SOC0_RESET_NUMS; + reset->rcdev.ops = &ast2700_reset_ops; + reset->rcdev.of_node = soc0_node; + + ret = reset_controller_register(&reset->rcdev);
Quoted 8 lines
drivers/clk/Makefile
Quoted 6 lines
drivers/clk/Makefile +6
-0+ if (ret) { + pr_err("soc0 failed to register reset controller\n"); + return ret; + } + + //refclkWeird comment. Please read Coding Style.
I remind Ryan for this fix. He will reply in these series.
https://patchwork.kernel.org/project/linux-clk/patch/20240808075937.2756733-5-ryan_chen at aspeedtech.com/
Quoted 48 lines
Quoted 11 lines
drivers/clk/Makefile +9
-0+ clks[SCU0_CLKIN] = + clk_hw_register_fixed_rate(NULL, "soc0-clkin", NULL, 0, +SCU_CLK_25MHZ); + + clks[SCU0_CLK_24M] = + clk_hw_register_fixed_rate(NULL, "soc0-clk24Mhz", NULL, 0, +SCU_CLK_24MHZ); + + clks[SCU0_CLK_192M] =drivers/clk/Makefile
Quoted 10 lines
drivers/clk/Makefile +10
-0+ clk_hw_register_fixed_rate(NULL, "soc0-clk192Mhz", NULL, 0, +SCU_CLK_192MHZ); + + //hpll + val = readl(clk_base + SCU0_HWSTRAP1); + if ((val & GENMASK(3, 2)) != 0) { + switch ((val & GENMASK(3, 2)) >> 2) { + case 1: + clks[SCU0_CLK_HPLL] = + clk_hw_register_fixed_rate(NULL, "soc0-hpll", NULL, 0,1900000000);
drivers/clk/Makefile
Quoted 4 lines
drivers/clk/Makefile +4
-0+ break; + case 2: + clks[SCU0_CLK_HPLL] = + clk_hw_register_fixed_rate(NULL, "soc0-hpll", NULL, 0,1800000000);
drivers/clk/Makefile
Quoted 4 lines
drivers/clk/Makefile +4
-0+ break; + case 3: + clks[SCU0_CLK_HPLL] = + clk_hw_register_fixed_rate(NULL, "soc0-hpll", NULL, 0,1700000000);
drivers/clk/Makefile
Quoted 5 lines
drivers/clk/Makefile +5
-0+ break; + } + } else { + val = readl(clk_base + SCU0_HPLL_PARAM); + clks[SCU0_CLK_HPLL] = ast2700_soc0_hw_pll("soc0-hpll","soc0-clkin", val);
drivers/clk/Makefile
Quoted 2 lines
drivers/clk/Makefile +2
-0+ } + clks[SCU0_CLK_HPLL_DIV2] = clk_hw_register_fixed_factor(NULL,"soc0-hpll_div2", "soc0-hpll", 0, 1, 2);
drivers/clk/Makefile
Quoted 4 lines
drivers/clk/Makefile +4
-0+ clks[SCU0_CLK_HPLL_DIV4] = clk_hw_register_fixed_factor(NULL, +"soc0-hpll_div4", "soc0-hpll", 0, 1, 4); + + //dpll
Quoted 2 lines
Best regards,
Krzysztof
--
Best Regards,
Kevin.Chen
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
PATCH 4/10 dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset
In reply to Kevin Chen--- .../dt-bindings/reset/aspeed,ast2700-reset.h | 126 ++++++++++++++++++ 1 file changed, 126 insertions(+) create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.h
include/dt-bindings/reset/aspeed,ast2700-reset.h new file +126 -0
@@ -0,0 +1,126 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* +* Device Tree binding constants for AST2700 reset controller. +* +* Copyright (c) 2023 Aspeed Technology Inc. +*/ + +#ifndef _MACH_ASPEED_AST2700_RESET_H_ +#define _MACH_ASPEED_AST2700_RESET_H_ + +/* SOC0 */ +#define SCU0_RESET_SDRAM (0) +#define SCU0_RESET_DDRPHY (1) +#define SCU0_RESET_RSA (2) +#define SCU0_RESET_SHA3 (3) +#define SCU0_RESET_HACE (4) +#define SCU0_RESET_SOC (5) +#define SCU0_RESET_VIDEO (6) +#define SCU0_RESET_2D (7) +#define SCU0_RESET_PCIS (8) +#define SCU0_RESET_RVAS0 (9) +#define SCU0_RESET_RVAS1 (10) +#define SCU0_RESET_SM3 (11) +#define SCU0_RESET_SM4 (12) +#define SCU0_RESET_CRT0 (13) +#define SCU0_RESET_ECC (14) +#define SCU0_RESET_DP_PCI (15) +#define SCU0_RESET_UFS (16) +#define SCU0_RESET_EMMC (17) +#define SCU0_RESET_PCIE1RST (18) +#define SCU0_RESET_PCIE1RSTOE (19) +#define SCU0_RESET_PCIE0RST (20) +#define SCU0_RESET_PCIE0RSTOE (21) +#define SCU0_RESET_JTAG0 (22) +#define SCU0_RESET_MCTP0 (23) +#define SCU0_RESET_MCTP1 (24) +#define SCU0_RESET_XDMA0 (25) +#define SCU0_RESET_XDMA1 (26) +#define SCU0_RESET_H2X1 (27) +#define SCU0_RESET_DP (28) +#define SCU0_RESET_DP_MCU (29) +#define SCU0_RESET_GP_MCU (30) +#define SCU0_RESET_H2X0 (31) +#define SCU0_RESET_P0_VHUB2 (32) +#define SCU0_RESET_P0_PHY3 (33) +#define SCU0_RESET_P0_XHCI (34) +#define SCU0_RESET_P1_VHUB2 (35) +#define SCU0_RESET_P1_PHY3 (36) +#define SCU0_RESET_P1_XHCI (37) +#define SCU0_RESET_P0_USB2 (38) +#define SCU0_RESET_P1_USB2 (39) +#define SCU0_RESET_USB11 (40) +#define SCU0_RESET_RESERVED (41) +#define SCU0_RESET_E2M0 (42) +#define SCU0_RESET_E2M1 (43) + +#define SOC0_RESET_NUMS (SCU0_RESET_E2M1 + 1) + +/* SOC1 */ +#define SCU1_RESET_LPC0 (0) +#define SCU1_RESET_LPC1 (1) +#define SCU1_RESET_MII (2) +#define SCU1_RESET_PECI (3) +#define SCU1_RESET_PWM (4) +#define SCU1_RESET_MAC0 (5) +#define SCU1_RESET_MAC1 (6) +#define SCU1_RESET_MAC2 (7) +#define SCU1_RESET_ADC (8) +#define SCU1_RESET_SD (9) +#define SCU1_RESET_ESPI0 (10) +#define SCU1_RESET_ESPI1 (11) +#define SCU1_RESET_JTAG1 (12) +#define SCU1_RESET_SPI0 (13) +#define SCU1_RESET_SPI1 (14) +#define SCU1_RESET_SPI2 (15) +#define SCU1_RESET_I3C0 (16) +#define SCU1_RESET_I3C1 (17) +#define SCU1_RESET_I3C2 (18) +#define SCU1_RESET_I3C3 (19) +#define SCU1_RESET_I3C4 (20) +#define SCU1_RESET_I3C5 (21) +#define SCU1_RESET_I3C6 (22) +#define SCU1_RESET_I3C7 (23) +#define SCU1_RESET_I3C8 (24) +#define SCU1_RESET_I3C9 (25) +#define SCU1_RESET_I3C10 (26) +#define SCU1_RESET_I3C11 (27) +#define SCU1_RESET_I3C12 (28) +#define SCU1_RESET_I3C13 (29) +#define SCU1_RESET_I3C14 (30) +#define SCU1_RESET_I3C15 (31) +/* reserved 32 */ +#define SCU1_RESET_IOMCU (33) +#define SCU1_RESET_H2A_SPI1 (34) +#define SCU1_RESET_H2A_SPI2 (35) +#define SCU1_RESET_UART0 (36) +#define SCU1_RESET_UART1 (37) +#define SCU1_RESET_UART2 (38) +#define SCU1_RESET_UART3 (39) +#define SCU1_RESET_I2C_FILTER (40) +#define SCU1_RESET_CALIPTRA (41) +/* reserved 42:43 */ +#define SCU1_RESET_FSI (44) +#define SCU1_RESET_CAN (45) +#define SCU1_RESET_MCTP (46) +#define SCU1_RESET_I2C (47) +#define SCU1_RESET_UART6 (48) +#define SCU1_RESET_UART7 (49) +#define SCU1_RESET_UART8 (50) +#define SCU1_RESET_UART9 (51) +#define SCU1_RESET_LTPI (52) +#define SCU1_RESET_VGAL (53) +#define SCU1_RESET_LTPI1 (54) +#define SCU1_RESET_ACE (55) +#define SCU1_RESET_E2M2 (56) +#define SCU1_RESET_UHCI (57) +#define SCU1_RESET_PORTC_USB2H (58) +#define SCU1_RESET_PORTC_USB2V (59) +#define SCU1_RESET_PORTD_USB2H (60) +#define SCU1_RESET_PORTD_USB2V (61) +#define SCU1_RESET_H2X2 (62) +#define SCU1_RESET_I3CDMA (63) + +#define SOC1_RESET_NUMS (SCU1_RESET_I3CDMA + 1) + +#endif /* _MACH_ASPEED_AST2700_RESET_H_ */
Signature · 1 line
2.34.1
Krzysztof Kozlowski
maintainerRe: [PATCH v1 04/10] dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset
Quoted 1 line · Kevin Chen
---
Sorry, that's not acceptable. This does not have even SoB.
All previous comments apply.
Best regards,
Krzysztof
RE: [PATCH v1 04/10] dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset
Hi Krzk,
I will separate clock part in the v3 patch into Ryan's clock series.
Quoted 3 lines
Quoted 1 line
---
Sorry, that's not acceptable. This does not have even SoB.
Agree.
Quoted 2 lines
All previous comments apply.
Agree.
Quoted 3 lines
Best regards,
Krzysztof
--
Best Regards,
Kevin.Chen
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
PATCH 5/10 dt-bindings: arm: aspeed: Add maintainer
In reply to Kevin Chen--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
@@ -8,6 +8,7 @@ title: Aspeed SoC based boards maintainers: - Joel Stanley <[email protected]> + - Kevin Chen <[email protected]> properties: $nodename:
Signature · 1 line
2.34.1
Krzysztof Kozlowski
maintainerRe: [PATCH v1 05/10] dt-bindings: arm: aspeed: Add maintainer
On 26/07/2024 13:03, Kevin Chen wrote:
Why?
Quoted 3 lines
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)
Best regards,
Krzysztof
回覆: [PATCH v1 05/10] dt-bindings: arm: aspeed: Add maintainer
Hi Krzk,
Quoted 5 lines
Why?
Quoted 3 lines
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)
Agree, I will remove it.
--
Best Regards,
Kevin. Chen
________________________________
???: Krzysztof Kozlowski <[email protected]>
????: 2024?7?26? ?? 07:14
???: Kevin Chen <[email protected]>; robh at kernel.org <[email protected]>; krzk+dt at kernel.org <[email protected]>; conor+dt at kernel.org <[email protected]>; joel at jms.id.au <[email protected]>; andrew at codeconstruct.com.au <[email protected]>; lee at kernel.org <[email protected]>; catalin.marinas at arm.com <[email protected]>; will at kernel.org <[email protected]>; arnd at arndb.de <[email protected]>; olof at lixom.net <[email protected]>; soc at kernel.org <[email protected]>; mturquette at baylibre.com <[email protected]>; sboyd at kernel.org <[email protected]>; p.zabel at pengutronix.de <[email protected]>; quic_bjorande at quicinc.com <[email protected]>; geert+renesas at glider.be <[email protected]>; dmitry.baryshkov at linaro.org <[email protected]>; shawnguo at kernel.org <[email protected]>; neil.armstrong at linaro.org <[email protected]>; m.szyprowski at samsung.com <[email protected]>; nfraprado at collabora.com <[email protected]>; u-kumar1 at ti.com <[email protected]>; devicetree at vger.kernel.org <[email protected]>; linux-arm-kernel at lists.infradead.org <[email protected]>; linux-aspeed at lists.ozlabs.org <[email protected]>; linux-kernel at vger.kernel.org <[email protected]>; linux-clk at vger.kernel.org <[email protected]> ??: Re: [PATCH v1 05/10] dt-bindings: arm: aspeed: Add maintainer
On 26/07/2024 13:03, Kevin Chen wrote:
Why?
Quoted 3 lines
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)
Best regards,
Krzysztof
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you. -------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240815/c9fd3a9d/attachment-0001.htm>
RE: [PATCH v1 05/10] dt-bindings: arm: aspeed: Add maintainer
In reply to Krzysztof KozlowskiHi Krzk,
Quoted 2 lines
Why?
Agree, I will remove it.
Quoted 6 lines
Quoted 4 lines
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)Best regards,
Krzysztof
--
Best Regards,
Kevin.Chen
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
PATCH 6/10 dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
In reply to Kevin Chen--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +5 -0
@@ -99,4 +99,9 @@ properties: - ufispace,ncplite-bmc - const: aspeed,ast2600 + - description: AST2700 based boards + items: + - enum: + - aspeed,ast2700-evb + additionalProperties: true
Signature · 1 line
2.34.1
Re: [PATCH v1 06/10] dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
Quoted 9 lines · Kevin Chen
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +0
-0
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml properties: · line 105
Quoted 7 lines
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +4
-0@@ -99,4 +99,9 @@ properties: - ufispace,ncplite-bmc - const: aspeed,ast2600 + - description: AST2700 based boards + items: + - enum: + - aspeed,ast2700-evb
NAK, this cannot be alone. Look at all other examples. Why are you doing things differently?
Best regards,
Krzysztof
Kevin Chen
NAK回覆: [PATCH v1 06/10] dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
Hi Krzk,
Quoted 12 lines
Quoted 12 lines
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +0
-0@@ -99,4 +99,9 @@ properties: - ufispace,ncplite-bmc - const: aspeed,ast2600
Quoted 7 lines
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml properties: · line 105
Quoted 4 lines
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +4
-0+ - description: AST2700 based boards + items: + - enum: + - aspeed,ast2700-evbNAK, this cannot be alone. Look at all other examples. Why are you doing things differently?
Disagree, ast2700-evb is 7th generation IC in ASPEED. It not in the sub-set of AST2400/AST2500/AST2600 based boards.
--
Best Regards,
Kevin. Chen
________________________________
???: Krzysztof Kozlowski <[email protected]>
????: 2024?7?26? ?? 07:15
???: Kevin Chen <[email protected]>; robh at kernel.org <[email protected]>; krzk+dt at kernel.org <[email protected]>; conor+dt at kernel.org <[email protected]>; joel at jms.id.au <[email protected]>; andrew at codeconstruct.com.au <[email protected]>; lee at kernel.org <[email protected]>; catalin.marinas at arm.com <[email protected]>; will at kernel.org <[email protected]>; arnd at arndb.de <[email protected]>; olof at lixom.net <[email protected]>; soc at kernel.org <[email protected]>; mturquette at baylibre.com <[email protected]>; sboyd at kernel.org <[email protected]>; p.zabel at pengutronix.de <[email protected]>; quic_bjorande at quicinc.com <[email protected]>; geert+renesas at glider.be <[email protected]>; dmitry.baryshkov at linaro.org <[email protected]>; shawnguo at kernel.org <[email protected]>; neil.armstrong at linaro.org <[email protected]>; m.szyprowski at samsung.com <[email protected]>; nfraprado at collabora.com <[email protected]>; u-kumar1 at ti.com <[email protected]>; devicetree at vger.kernel.org <[email protected]>; linux-arm-kernel at lists.infradead.org <[email protected]>; linux-aspeed at lists.ozlabs.org <[email protected]>; linux-kernel at vger.kernel.org <[email protected]>; linux-clk at vger.kernel.org <[email protected]> ??: Re: [PATCH v1 06/10] dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
Quoted 9 lines · Kevin Chen
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +0
-0
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml properties: · line 105
Quoted 7 lines
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +4
-0@@ -99,4 +99,9 @@ properties: - ufispace,ncplite-bmc - const: aspeed,ast2600 + - description: AST2700 based boards + items: + - enum: + - aspeed,ast2700-evb
NAK, this cannot be alone. Look at all other examples. Why are you doing things differently?
Best regards,
Krzysztof
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you. -------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240815/369eeeac/attachment-0001.htm>
RE: [PATCH v1 06/10] dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
In reply to Krzysztof KozlowskiHi Krzk,
Quoted 13 lines
Quoted 13 lines
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +0
-0@@ -99,4 +99,9 @@ properties: - ufispace,ncplite-bmc - const: aspeed,ast2600
Quoted 7 lines
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml properties: · line 105
Quoted 4 lines
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +4
-0+ - description: AST2700 based boards + items: + - enum: + - aspeed,ast2700-evbNAK, this cannot be alone. Look at all other examples. Why are you doing things differently?
Disagree, ast2700-evb is 7th generation IC in ASPEED. It not in the sub-set of AST2400/AST2500/AST2600 based boards.
Quoted 3 lines
Best regards,
Krzysztof
--
Best Regards,
Kevin.Chen
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
Krzysztof Kozlowski
maintainerRe: [PATCH v1 06/10] dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
Quoted 15 lines · Kevin Chen
Hi Krzk,
Quoted 13 lines
Quoted 13 lines
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +0
-0@@ -99,4 +99,9 @@ properties: - ufispace,ncplite-bmc - const: aspeed,ast2600
Quoted 8 lines
Quoted 7 lines
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml properties: · line 105
Quoted 4 lines
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +4
-0+ - description: AST2700 based boards + items: + - enum: + - aspeed,ast2700-evbNAK, this cannot be alone. Look at all other examples. Why are you doing things differently?
Disagree, ast2700-evb is 7th generation IC in ASPEED.
I gave you argument and you just respond "disagree" with unrelated statement?
Quoted 1 line
It not in the sub-set of AST2400/AST2500/AST2600 based boards.
? That does not answer at all my concerns. Bring me any example doing this that way: single board compatible.
Answer to the argument, instead of bringing useless text "ast is a board". Yeah, of course it is. What else could it be? A ship? A car?
Best regards,
Krzysztof
RE: [PATCH v1 06/10] dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
Quoted 25 lines
Quoted 16 lines
Hi Krzk,
Quoted 14 lines
Quoted 14 lines
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++ 1 file changed, 5 insertions(+)diff --git
a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yamlb/Documentation/devicetree/bindings/arm/aspeed/aspeed.yamlindex71c31c08a8ad..b21551817f44100644Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +0
-0@@ -99,4 +99,9 @@ properties: - ufispace,ncplite-bmc - const: aspeed,ast2600Quoted 8 lines
Quoted 7 lines
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml properties: · line 105
Quoted 4 lines
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +4
-0+ - description: AST2700 based boards + items: + - enum: + - aspeed,ast2700-evbNAK, this cannot be alone. Look at all other examples. Why are you doing things differently?
Disagree, ast2700-evb is 7th generation IC in ASPEED.
Quoted 7 lines
I gave you argument and you just respond "disagree" with unrelated statement?
Quoted 1 line
It not in the sub-set of AST2400/AST2500/AST2600 based boards.
? That does not answer at all my concerns. Bring me any example doing this that way: single board compatible.
In current stage, we only have one kind of ASPEED AST2700 evaluation board. Should I add const for aspeed,ast2700 as the following.
- description: AST2700 based boards
items:
- enum:
- aspeed,ast2700-evb
- const: aspeed,ast2700
Quoted 7 lines
Answer to the argument, instead of bringing useless text "ast is a board". Yeah, of course it is. What else could it be? A ship? A car?
Best regards,
Krzysztof
PATCH 7/10 arm64: aspeed: Add support for ASPEED AST2700 BMC SoC
In reply to Kevin Chen--- MAINTAINERS | 3 +++ arch/arm64/Kconfig.platforms | 14 ++++++++++++++ 2 files changed, 17 insertions(+)
MAINTAINERS +3 -0
@@ -2121,7 +2121,10 @@ Q: https://patchwork.ozlabs.org/project/linux-aspeed/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git F: Documentation/devicetree/bindings/arm/aspeed/ F: arch/arm/boot/dts/aspeed/ +F: arch/arm64/boot/dts/aspeed/ F: arch/arm/mach-aspeed/ +F: include/dt-bindings/clock/aspeed,ast2700-clk.h +F: include/dt-bindings/reset/aspeed,ast2700-reset.h N: aspeed ARM/AXM LSI SOC
arch/arm64/Kconfig.platforms +14 -0
@@ -40,6 +40,20 @@ config ARCH_APPLE This enables support for Apple's in-house ARM SoC family, starting with the Apple M1. +config ARCH_ASPEED + bool "Aspeed SoC family" + select MACH_ASPEED_G7 + help + Say yes if you intend to run on an Aspeed ast2700 or similar + seventh generation Aspeed BMCs. + +config MACH_ASPEED_G7 + bool "Aspeed SoC AST2700" + help + Say yes if you intend to run on an Aspeed ast2700 + seventh generation Aspeed BMCs. + Aspeed ast2700 BMC based on the Cortex A35. + menuconfig ARCH_BCM bool "Broadcom SoC Support"
Signature · 1 line
2.34.1
Krzysztof Kozlowski
maintainerRe: [PATCH v1 07/10] arm64: aspeed: Add support for ASPEED AST2700 BMC SoC
Quoted 27 lines · Kevin Chen
--- MAINTAINERS | 3 +++ arch/arm64/Kconfig.platforms | 14 ++++++++++++++ 2 files changed, 17 insertions(+)MAINTAINERS +3
-0@@ -2121,7 +2121,10 @@ Q: https://patchwork.ozlabs.org/project/linux-aspeed/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git F: Documentation/devicetree/bindings/arm/aspeed/ F: arch/arm/boot/dts/aspeed/ +F: arch/arm64/boot/dts/aspeed/ F: arch/arm/mach-aspeed/ +F: include/dt-bindings/clock/aspeed,ast2700-clk.h +F: include/dt-bindings/reset/aspeed,ast2700-reset.h N: aspeed ARM/AXM LSI SOCarch/arm64/Kconfig.platforms +0
-0@@ -40,6 +40,20 @@ config ARCH_APPLE This enables support for Apple's in-house ARM SoC family, starting with the Apple M1.
arch/arm64/Kconfig.platforms config ARCH_APPLE · line 51
Quoted 10 lines
arch/arm64/Kconfig.platforms +9
-0+config ARCH_ASPEED + bool "Aspeed SoC family" + select MACH_ASPEED_G7 + help + Say yes if you intend to run on an Aspeed ast2700 or similar + seventh generation Aspeed BMCs. + +config MACH_ASPEED_G7 + bool "Aspeed SoC AST2700"
There are no MACHines for arm64. Look at this code. Do you see MACH anywhere else? No. Then why Aspeed must be different?
No. Drop.
Best regards,
Krzysztof
回覆: [PATCH v1 07/10] arm64: aspeed: Add support for ASPEED AST2700 BMC SoC
Hi Krzk,
Quoted 41 lines
Quoted 27 lines
--- MAINTAINERS | 3 +++ arch/arm64/Kconfig.platforms | 14 ++++++++++++++ 2 files changed, 17 insertions(+)MAINTAINERS +3
-0@@ -2121,7 +2121,10 @@ Q: https://patchwork.ozlabs.org/project/linux-aspeed/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git F: Documentation/devicetree/bindings/arm/aspeed/ F: arch/arm/boot/dts/aspeed/ +F: arch/arm64/boot/dts/aspeed/ F: arch/arm/mach-aspeed/ +F: include/dt-bindings/clock/aspeed,ast2700-clk.h +F: include/dt-bindings/reset/aspeed,ast2700-reset.h N: aspeed ARM/AXM LSI SOCarch/arm64/Kconfig.platforms +0
-0@@ -40,6 +40,20 @@ config ARCH_APPLE This enables support for Apple's in-house ARM SoC family, starting with the Apple M1.arch/arm64/Kconfig.platforms config ARCH_APPLE · line 51
Quoted 10 lines
arch/arm64/Kconfig.platforms +9
-0+config ARCH_ASPEED + bool "Aspeed SoC family" + select MACH_ASPEED_G7 + help + Say yes if you intend to run on an Aspeed ast2700 or similar + seventh generation Aspeed BMCs. + +config MACH_ASPEED_G7 + bool "Aspeed SoC AST2700"There are no MACHines for arm64. Look at this code. Do you see MACH anywhere else? No. Then why Aspeed must be different?
Quoted 1 line
No. Drop.
Agree.
--
Best Regards,
Kevin. Chen
________________________________
???: Krzysztof Kozlowski <[email protected]>
????: 2024?7?26? ?? 07:16
???: Kevin Chen <[email protected]>; robh at kernel.org <[email protected]>; krzk+dt at kernel.org <[email protected]>; conor+dt at kernel.org <[email protected]>; joel at jms.id.au <[email protected]>; andrew at codeconstruct.com.au <[email protected]>; lee at kernel.org <[email protected]>; catalin.marinas at arm.com <[email protected]>; will at kernel.org <[email protected]>; arnd at arndb.de <[email protected]>; olof at lixom.net <[email protected]>; soc at kernel.org <[email protected]>; mturquette at baylibre.com <[email protected]>; sboyd at kernel.org <[email protected]>; p.zabel at pengutronix.de <[email protected]>; quic_bjorande at quicinc.com <[email protected]>; geert+renesas at glider.be <[email protected]>; dmitry.baryshkov at linaro.org <[email protected]>; shawnguo at kernel.org <[email protected]>; neil.armstrong at linaro.org <[email protected]>; m.szyprowski at samsung.com <[email protected]>; nfraprado at collabora.com <[email protected]>; u-kumar1 at ti.com <[email protected]>; devicetree at vger.kernel.org <[email protected]>; linux-arm-kernel at lists.infradead.org <[email protected]>; linux-aspeed at lists.ozlabs.org <[email protected]>; linux-kernel at vger.kernel.org <[email protected]>; linux-clk at vger.kernel.org <[email protected]> ??: Re: [PATCH v1 07/10] arm64: aspeed: Add support for ASPEED AST2700 BMC SoC
Quoted 27 lines · Kevin Chen
--- MAINTAINERS | 3 +++ arch/arm64/Kconfig.platforms | 14 ++++++++++++++ 2 files changed, 17 insertions(+)MAINTAINERS +3
-0@@ -2121,7 +2121,10 @@ Q: https://patchwork.ozlabs.org/project/linux-aspeed/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git F: Documentation/devicetree/bindings/arm/aspeed/ F: arch/arm/boot/dts/aspeed/ +F: arch/arm64/boot/dts/aspeed/ F: arch/arm/mach-aspeed/ +F: include/dt-bindings/clock/aspeed,ast2700-clk.h +F: include/dt-bindings/reset/aspeed,ast2700-reset.h N: aspeed ARM/AXM LSI SOCarch/arm64/Kconfig.platforms +0
-0@@ -40,6 +40,20 @@ config ARCH_APPLE This enables support for Apple's in-house ARM SoC family, starting with the Apple M1.
arch/arm64/Kconfig.platforms config ARCH_APPLE · line 51
Quoted 10 lines
arch/arm64/Kconfig.platforms +9
-0+config ARCH_ASPEED + bool "Aspeed SoC family" + select MACH_ASPEED_G7 + help + Say yes if you intend to run on an Aspeed ast2700 or similar + seventh generation Aspeed BMCs. + +config MACH_ASPEED_G7 + bool "Aspeed SoC AST2700"
There are no MACHines for arm64. Look at this code. Do you see MACH anywhere else? No. Then why Aspeed must be different?
No. Drop.
Best regards,
Krzysztof
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you. -------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240815/23685db3/attachment-0001.htm>
RE: [PATCH v1 07/10] arm64: aspeed: Add support for ASPEED AST2700 BMC SoC
In reply to Krzysztof KozlowskiHi Krzk,
Quoted 42 lines
MAINTAINERS Q:
Quoted 10 lines
--- MAINTAINERS | 3 +++ arch/arm64/Kconfig.platforms | 14 ++++++++++++++ 2 files changed, 17 insertions(+)MAINTAINERS index renamed from MAINTAINERS +0
-0
c0a3d9e93689..08609430cfe0100644MAINTAINERS +0
-0@@ -2121,7 +2121,10 @@ Q:Quoted 17 lines
MAINTAINERS +3
-0T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git F: Documentation/devicetree/bindings/arm/aspeed/ F: arch/arm/boot/dts/aspeed/ +F: arch/arm64/boot/dts/aspeed/ F: arch/arm/mach-aspeed/ +F: include/dt-bindings/clock/aspeed,ast2700-clk.h +F: include/dt-bindings/reset/aspeed,ast2700-reset.h N: aspeed ARM/AXM LSI SOC(quoted diff) +0
-0b/arch/arm64/Kconfig.platforms index
6c6d11536b42..1db7b6f1ee0a100644arch/arm64/Kconfig.platforms +0
-0@@ -40,6 +40,20 @@ config ARCH_APPLE This enables support for Apple's in-house ARM SoC family, starting with the Apple M1.arch/arm64/Kconfig.platforms config ARCH_APPLE · line 51
Quoted 10 lines
arch/arm64/Kconfig.platforms +9
-0+config ARCH_ASPEED + bool "Aspeed SoC family" + select MACH_ASPEED_G7 + help + Say yes if you intend to run on an Aspeed ast2700 or similar + seventh generation Aspeed BMCs. + +config MACH_ASPEED_G7 + bool "Aspeed SoC AST2700"There are no MACHines for arm64. Look at this code. Do you see MACH anywhere else? No. Then why Aspeed must be different?
Quoted 1 line
No. Drop.
Agree.
Quoted 3 lines
Best regards,
Krzysztof
--
Best Regards,
Kevin.Chen
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
PATCH 8/10 arm64: dts: aspeed: Add initial AST27XX device tree
In reply to Kevin Chen--- arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 ++++++++++++++++++++++ 2 files changed, 218 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
arch/arm64/boot/dts/Makefile +1 -0
@@ -34,3 +34,4 @@ subdir-y += tesla subdir-y += ti subdir-y += toshiba subdir-y += xilinx +subdir-y += aspeed
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +217 -0
217 lines not on this page · raw message
Signature · 1 line
2.34.1
Krzysztof Kozlowski
maintainerRe: [PATCH v1 08/10] arm64: dts: aspeed: Add initial AST27XX device tree
Quoted 21 lines · Kevin Chen
--- arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 ++++++++++++++++++++++ 2 files changed, 218 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsiarch/arm64/boot/dts/Makefile +1
-0@@ -34,3 +34,4 @@ subdir-y += tesla subdir-y += ti subdir-y += toshiba subdir-y += xilinx +subdir-y += aspeedarch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +0
-0
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 8
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +8
-0@@ -0,0 +1,217 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +#include <dt-bindings/clock/aspeed,ast2700-clk.h> +#include <dt-bindings/reset/aspeed,ast2700-reset.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/aspeed-scu-ic.h> + +/ { + model = "Aspeed BMC";
Model of what? No, drop.
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 9
Quoted 1 line
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +1
-0+ compatible = "aspeed,ast2700";
Please run scripts/checkpatch.pl and fix reported warnings. Then please run scripts/checkpatch.pl --strict and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 15
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+ #address-cells = <2>; + #size-cells = <2>; + interrupt-parent = <&gic>; + + aliases { + serial12 = &uart12;
Nope. Such aliases are board specific.
Quoted 68 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +68
-0+ }; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu at 0 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <0>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + cpu at 1 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <1>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + cpu at 2 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <2>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + cpu at 3 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <3>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + l2: l2-cache0 { + compatible = "cache"; + cache-size = <0x80000>; + cache-line-size = <64>; + cache-sets = <1024>; + cache-level = <2>;
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 93
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +10
-0+ }; + }; + + pmu { + compatible = "arm,cortex-a35-pmu"; + interrupt-parent = <&gic>; + interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>; + }; + + psci {
Order the nodes according to DTS coding style.
Fix all your patches:
1. To pass flawlessly checkpatch (you did not run it)
2. To pass dt_binding_check and dtbs_check (you did not run these)
3. To adhere to kernel coding style
4. To adhere to DTS coding style
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 5 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +5
-0+ compatible = "arm,psci-1.0"; + method = "smc"; + }; + + gic: interrupt-controller at 12200000 {
Nope, this cannot be outside of SoC.
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 107
Quoted 9 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +9
-0+ compatible = "arm,gic-v3"; + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>; + #interrupt-cells = <3>; + interrupt-controller; + interrupt-parent = <&gic>; + #redistributor-regions = <1>; + reg = <0 0x12200000 0 0x10000>, //GICD + <0 0x12280000 0 0x80000>, //GICR + <0 0x40440000 0 0x1000>; //GICC
Read DTS coding style and order this correctly.
Quoted 38 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +38
-0+ }; + + timer { + compatible = "arm,armv8-timer"; + interrupt-parent = <&gic>; + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; + arm,cpu-registers-not-fw-configured; + always-on; + }; + + soc0: soc at 10000000 { + compatible = "simple-bus"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + soc0_sram: sram at 10000000 { + compatible = "mmio-sram"; + reg = <0x0 0x10000000 0x0 0x20000>; /* 128KiB SRAM on soc0 */ + ranges = <0x0 0x0 0x0 0x10000000 0x0 0x20000>; + #address-cells = <2>; + #size-cells = <2>; + no-memory-wc; + + exported at 0 { + reg = <0 0x0 0 0x20000>; + export; + }; + }; + + syscon0: syscon at 12c02000 { + compatible = "aspeed,ast2700-scu0", "syscon", "simple-mfd"; + reg = <0x0 0x12c02000 0x0 0x1000>; + ranges = <0x0 0x0 0 0x12c02000 0 0x1000>; + #address-cells = <2>;
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +10
-0+ #size-cells = <2>; + #clock-cells = <1>; + #reset-cells = <1>; + + silicon-id at 0 { + compatible = "aspeed,ast2700-silicon-id", "aspeed,silicon-id"; + reg = <0 0x0 0 0x4>; + }; + + scu_ic0: interrupt-controller at 1D0 {
DTS coding style...
Quoted 17 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +17
-0+ #interrupt-cells = <1>; + compatible = "aspeed,ast2700-scu-ic0"; + reg = <0 0x1d0 0 0xc>; + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>; + interrupt-controller; + }; + + scu_ic1: interrupt-controller at 1E0 { + #interrupt-cells = <1>; + compatible = "aspeed,ast2700-scu-ic1"; + reg = <0 0x1e0 0 0xc>; + interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; + interrupt-controller; + }; + + soc0_rst: reset-controller at 200 { + reg = <0 0x200 0 0x40>;
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +10
-0+ }; + + soc0_clk: clock-controller at 240 { + reg = <0 0x240 0 0x1c0>; + }; + }; + + }; + + soc1: soc at 14000000 {
Wait, what, to socs?
Quoted 21 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +21
-0+ compatible = "simple-bus"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + syscon1: syscon at 14c02000 { + compatible = "aspeed,ast2700-scu1", "syscon", "simple-mfd"; + reg = <0x0 0x14c02000 0x0 0x1000>; + ranges = <0x0 0x0 0x0 0x14c02000 0x0 0x1000>; + #address-cells = <2>; + #size-cells = <2>; + #clock-cells = <1>; + #reset-cells = <1>; + + soc1_rst: reset-controller at 200 { + #reset-cells = <1>; + }; + + soc1_clk: clock-controller at 240 { + reg = <0 0x240 0 0x1c0>; + };
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 213
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +10
-0+ }; + + uart12: serial at 14c33b00 { + compatible = "ns16550a"; + reg = <0x0 0x14c33b00 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clocks = <&syscon1 SCU1_CLK_GATE_UART12CLK>; + no-loopback-test; + pinctrl-names = "default";
What is this?
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 49
Quoted 4 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +4
-0+ }; + }; +}; +
Best regards,
Krzysztof
回覆: [PATCH v1 08/10] arm64: dts: aspeed: Add initial AST27XX device tree
Hi Krzk,
Quoted 23 lines
Quoted 23 lines
--- arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 ++++++++++++++++++++++ 2 files changed, 218 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsiarch/arm64/boot/dts/Makefile +1
-0@@ -34,3 +34,4 @@ subdir-y += tesla subdir-y += ti subdir-y += toshiba subdir-y += xilinx +subdir-y += aspeedarch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +2
-0@@ -0,0 +1,217 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +#include <dt-bindings/clock/aspeed,ast2700-clk.h>
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 8
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+#include <dt-bindings/reset/aspeed,ast2700-reset.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/aspeed-scu-ic.h> + +/ { + model = "Aspeed BMC";Model of what? No, drop.
Can I change to "model = "AST2700 EVB""
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 9
Quoted 2 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +1
-0+ compatible = "aspeed,ast2700";Please run
scripts/checkpatch.pland fix reported warnings. Then please runscripts/checkpatch.pl --strictand (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 15
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+ #address-cells = <2>; + #size-cells = <2>; + interrupt-parent = <&gic>; + + aliases { + serial12 = &uart12;Nope. Such aliases are board specific.
Agree, I will move to ast2700-evb.dts.
Quoted 82 lines
Quoted 69 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +68
-0+ }; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu at 0 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <0>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + cpu at 1 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <1>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + cpu at 2 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <2>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + cpu at 3 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <3>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + l2: l2-cache0 { + compatible = "cache"; + cache-size = <0x80000>; + cache-line-size = <64>; + cache-sets = <1024>; + cache-level = <2>;arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 93
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +10
-0+ }; + }; + + pmu { + compatible = "arm,cortex-a35-pmu"; + interrupt-parent = <&gic>; + interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>; + }; + + psci {Order the nodes according to DTS coding style.
Quoted 5 lines
Fix all your patches:
1. To pass flawlessly checkpatch (you did not run it)
2. To passdt_binding_checkanddtbs_check(you did not run these)
3. To adhere to kernel coding style
4. To adhere to DTS coding style
Agree.
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +5
-0+ compatible = "arm,psci-1.0"; + method = "smc"; + }; + + gic: interrupt-controller at 12200000 {Nope, this cannot be outside of SoC.
Agree.
Quoted 11 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 107
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +9
-0+ compatible = "arm,gic-v3"; + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>; + #interrupt-cells = <3>; + interrupt-controller; + interrupt-parent = <&gic>; + #redistributor-regions = <1>; + reg = <0 0x12200000 0 0x10000>, //GICD + <0 0x12280000 0 0x80000>, //GICR + <0 0x40440000 0 0x1000>; //GICC
Quoted 1 line
Read DTS coding style and order this correctly.
Agree.
Quoted 43 lines
Quoted 43 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +42
-0+ }; + + timer { + compatible = "arm,armv8-timer"; + interrupt-parent = <&gic>; + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; + arm,cpu-registers-not-fw-configured; + always-on; + }; + + soc0: soc at 10000000 { + compatible = "simple-bus"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + soc0_sram: sram at 10000000 { + compatible = "mmio-sram"; + reg = <0x0 0x10000000 0x0 0x20000>; /* 128KiB SRAM on soc0 */ + ranges = <0x0 0x0 0x0 0x10000000 0x0 0x20000>; + #address-cells = <2>; + #size-cells = <2>; + no-memory-wc; + + exported at 0 { + reg = <0 0x0 0 0x20000>; + export; + }; + }; + + syscon0: syscon at 12c02000 { + compatible = "aspeed,ast2700-scu0", "syscon", "simple-mfd"; + reg = <0x0 0x12c02000 0x0 0x1000>; + ranges = <0x0 0x0 0 0x12c02000 0 0x1000>; + #address-cells = <2>; + #size-cells = <2>; + #clock-cells = <1>; + #reset-cells = <1>; +
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+ silicon-id at 0 { + compatible = "aspeed,ast2700-silicon-id", "aspeed,silicon-id"; + reg = <0 0x0 0 0x4>; + }; + + scu_ic0: interrupt-controller at 1D0 {DTS coding style...
Agree. I will fix to "scu_ic0: interrupt-controller at 1d0 {"
Quoted 22 lines
Quoted 22 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +21
-0+ #interrupt-cells = <1>; + compatible = "aspeed,ast2700-scu-ic0"; + reg = <0 0x1d0 0 0xc>; + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>; + interrupt-controller; + }; + + scu_ic1: interrupt-controller at 1E0 { + #interrupt-cells = <1>; + compatible = "aspeed,ast2700-scu-ic1"; + reg = <0 0x1e0 0 0xc>; + interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; + interrupt-controller; + }; + + soc0_rst: reset-controller at 200 { + reg = <0 0x200 0 0x40>; + }; + + soc0_clk: clock-controller at 240 { + reg = <0 0x240 0 0x1c0>;
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+ }; + }; + + }; + + soc1: soc at 14000000 {Wait, what, to socs?
Yes, two socs in different die.
Quoted 26 lines
Quoted 26 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +25
-0+ compatible = "simple-bus"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + syscon1: syscon at 14c02000 { + compatible = "aspeed,ast2700-scu1", "syscon", "simple-mfd"; + reg = <0x0 0x14c02000 0x0 0x1000>; + ranges = <0x0 0x0 0x0 0x14c02000 0x0 0x1000>; + #address-cells = <2>; + #size-cells = <2>; + #clock-cells = <1>; + #reset-cells = <1>; + + soc1_rst: reset-controller at 200 { + #reset-cells = <1>; + }; + + soc1_clk: clock-controller at 240 { + reg = <0 0x240 0 0x1c0>; + }; + }; + + uart12: serial at 14c33b00 { + compatible = "ns16550a";
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 213
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+ reg = <0x0 0x14c33b00 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clocks = <&syscon1 SCU1_CLK_GATE_UART12CLK>; + no-loopback-test; + pinctrl-names = "default";What is this?
BMC uart using in uart12 in soc1.
Quoted 5 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 49
Quoted 5 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +4
-0+ }; + }; +}; +
--
Best Regards,
Kevin. Chen
________________________________
???: Krzysztof Kozlowski <[email protected]>
????: 2024?7?26? ?? 07:19
???: Kevin Chen <[email protected]>; robh at kernel.org <[email protected]>; krzk+dt at kernel.org <[email protected]>; conor+dt at kernel.org <[email protected]>; joel at jms.id.au <[email protected]>; andrew at codeconstruct.com.au <[email protected]>; lee at kernel.org <[email protected]>; catalin.marinas at arm.com <[email protected]>; will at kernel.org <[email protected]>; arnd at arndb.de <[email protected]>; olof at lixom.net <[email protected]>; soc at kernel.org <[email protected]>; mturquette at baylibre.com <[email protected]>; sboyd at kernel.org <[email protected]>; p.zabel at pengutronix.de <[email protected]>; quic_bjorande at quicinc.com <[email protected]>; geert+renesas at glider.be <[email protected]>; dmitry.baryshkov at linaro.org <[email protected]>; shawnguo at kernel.org <[email protected]>; neil.armstrong at linaro.org <[email protected]>; m.szyprowski at samsung.com <[email protected]>; nfraprado at collabora.com <[email protected]>; u-kumar1 at ti.com <[email protected]>; devicetree at vger.kernel.org <[email protected]>; linux-arm-kernel at lists.infradead.org <[email protected]>; linux-aspeed at lists.ozlabs.org <[email protected]>; linux-kernel at vger.kernel.org <[email protected]>; linux-clk at vger.kernel.org <[email protected]> ??: Re: [PATCH v1 08/10] arm64: dts: aspeed: Add initial AST27XX device tree
Quoted 21 lines · Kevin Chen
--- arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 ++++++++++++++++++++++ 2 files changed, 218 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsiarch/arm64/boot/dts/Makefile +1
-0@@ -34,3 +34,4 @@ subdir-y += tesla subdir-y += ti subdir-y += toshiba subdir-y += xilinx +subdir-y += aspeedarch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +0
-0
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 8
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +8
-0@@ -0,0 +1,217 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +#include <dt-bindings/clock/aspeed,ast2700-clk.h> +#include <dt-bindings/reset/aspeed,ast2700-reset.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/aspeed-scu-ic.h> + +/ { + model = "Aspeed BMC";
Model of what? No, drop.
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 9
Quoted 1 line
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +1
-0+ compatible = "aspeed,ast2700";
Please run scripts/checkpatch.pl and fix reported warnings. Then please run scripts/checkpatch.pl --strict and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 15
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+ #address-cells = <2>; + #size-cells = <2>; + interrupt-parent = <&gic>; + + aliases { + serial12 = &uart12;
Nope. Such aliases are board specific.
Quoted 68 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +68
-0+ }; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu at 0 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <0>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + cpu at 1 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <1>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + cpu at 2 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <2>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + cpu at 3 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <3>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + l2: l2-cache0 { + compatible = "cache"; + cache-size = <0x80000>; + cache-line-size = <64>; + cache-sets = <1024>; + cache-level = <2>;
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 93
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +10
-0+ }; + }; + + pmu { + compatible = "arm,cortex-a35-pmu"; + interrupt-parent = <&gic>; + interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>; + }; + + psci {
Order the nodes according to DTS coding style.
Fix all your patches:
1. To pass flawlessly checkpatch (you did not run it)
2. To pass dt_binding_check and dtbs_check (you did not run these)
3. To adhere to kernel coding style
4. To adhere to DTS coding style
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 5 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +5
-0+ compatible = "arm,psci-1.0"; + method = "smc"; + }; + + gic: interrupt-controller at 12200000 {
Nope, this cannot be outside of SoC.
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 107
Quoted 9 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +9
-0+ compatible = "arm,gic-v3"; + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>; + #interrupt-cells = <3>; + interrupt-controller; + interrupt-parent = <&gic>; + #redistributor-regions = <1>; + reg = <0 0x12200000 0 0x10000>, //GICD + <0 0x12280000 0 0x80000>, //GICR + <0 0x40440000 0 0x1000>; //GICC
Read DTS coding style and order this correctly.
Quoted 38 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +38
-0+ }; + + timer { + compatible = "arm,armv8-timer"; + interrupt-parent = <&gic>; + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; + arm,cpu-registers-not-fw-configured; + always-on; + }; + + soc0: soc at 10000000 { + compatible = "simple-bus"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + soc0_sram: sram at 10000000 { + compatible = "mmio-sram"; + reg = <0x0 0x10000000 0x0 0x20000>; /* 128KiB SRAM on soc0 */ + ranges = <0x0 0x0 0x0 0x10000000 0x0 0x20000>; + #address-cells = <2>; + #size-cells = <2>; + no-memory-wc; + + exported at 0 { + reg = <0 0x0 0 0x20000>; + export; + }; + }; + + syscon0: syscon at 12c02000 { + compatible = "aspeed,ast2700-scu0", "syscon", "simple-mfd"; + reg = <0x0 0x12c02000 0x0 0x1000>; + ranges = <0x0 0x0 0 0x12c02000 0 0x1000>; + #address-cells = <2>;
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +10
-0+ #size-cells = <2>; + #clock-cells = <1>; + #reset-cells = <1>; + + silicon-id at 0 { + compatible = "aspeed,ast2700-silicon-id", "aspeed,silicon-id"; + reg = <0 0x0 0 0x4>; + }; + + scu_ic0: interrupt-controller at 1D0 {
DTS coding style...
Quoted 17 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +17
-0+ #interrupt-cells = <1>; + compatible = "aspeed,ast2700-scu-ic0"; + reg = <0 0x1d0 0 0xc>; + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>; + interrupt-controller; + }; + + scu_ic1: interrupt-controller at 1E0 { + #interrupt-cells = <1>; + compatible = "aspeed,ast2700-scu-ic1"; + reg = <0 0x1e0 0 0xc>; + interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; + interrupt-controller; + }; + + soc0_rst: reset-controller at 200 { + reg = <0 0x200 0 0x40>;
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +10
-0+ }; + + soc0_clk: clock-controller at 240 { + reg = <0 0x240 0 0x1c0>; + }; + }; + + }; + + soc1: soc at 14000000 {
Wait, what, to socs?
Quoted 21 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +21
-0+ compatible = "simple-bus"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + syscon1: syscon at 14c02000 { + compatible = "aspeed,ast2700-scu1", "syscon", "simple-mfd"; + reg = <0x0 0x14c02000 0x0 0x1000>; + ranges = <0x0 0x0 0x0 0x14c02000 0x0 0x1000>; + #address-cells = <2>; + #size-cells = <2>; + #clock-cells = <1>; + #reset-cells = <1>; + + soc1_rst: reset-controller at 200 { + #reset-cells = <1>; + }; + + soc1_clk: clock-controller at 240 { + reg = <0 0x240 0 0x1c0>; + };
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 213
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +10
-0+ }; + + uart12: serial at 14c33b00 { + compatible = "ns16550a"; + reg = <0x0 0x14c33b00 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clocks = <&syscon1 SCU1_CLK_GATE_UART12CLK>; + no-loopback-test; + pinctrl-names = "default";
What is this?
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 49
Quoted 4 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +4
-0+ }; + }; +}; +
Best regards,
Krzysztof
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you. -------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240815/5620dfdb/attachment-0001.htm>
Krzysztof Kozlowski
maintainerRe: 回覆: [PATCH v1 08/10] arm64: dts: aspeed: Add initial AST27XX device tree
Quoted 16 lines · Kevin Chen
Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +2
-0@@ -0,0 +1,217 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +#include <dt-bindings/clock/aspeed,ast2700-clk.h>Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 8
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+#include <dt-bindings/reset/aspeed,ast2700-reset.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/aspeed-scu-ic.h> + +/ { + model = "Aspeed BMC";Model of what? No, drop.
Quoted 1 line
Can I change to "model = "AST2700 EVB""
Model of what? No, it does not make sense here.
..
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +9
-0+ + uart12: serial at 14c33b00 { + compatible = "ns16550a"; + reg = <0x0 0x14c33b00 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clocks = <&syscon1 SCU1_CLK_GATE_UART12CLK>; + no-loopback-test; + pinctrl-names = "default";
Quoted 2 lines
Quoted 1 line
What is this?
BMC uart using in uart12 in soc1.
No, that line. pinctrl-names do not make sense here without values.
Quoted 16 lines
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 49
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +4
-0+ }; + }; +}; +--
Best Regards,
Kevin. Chen
________________________________
???: Krzysztof Kozlowski <[email protected]>
????: 2024?7?26? ?? 07:19
???: Kevin Chen <[email protected]>; robh at kernel.org <[email protected]>; krzk+dt at kernel.org <[email protected]>; conor+dt at kernel.org <[email protected]>; joel at jms.id.au <[email protected]>; andrew at codeconstruct.com.au <[email protected]>; lee at kernel.org <[email protected]>; catalin.marinas at arm.com <[email protected]>; will at kernel.org <[email protected]>; arnd at arndb.de <[email protected]>; olof at lixom.net <[email protected]>; soc at kernel.org <[email protected]>; mturquette at baylibre.com <[email protected]>; sboyd at kernel.org <[email protected]>; p.zabel at pengutronix.de <[email protected]>;quic_bjorandeat quicinc.com <[email protected]>; geert+renesas at glider.be <[email protected]>; dmitry.baryshkov at linaro.org <[email protected]>; shawnguo at kernel.org <[email protected]>; neil.armstrong at linaro.org <[email protected]>; m.szyprowski at samsung.com <[email protected]>; nfraprado at collabora.com <[email protected]>; u-kumar1 at ti.com <[email protected]>; devicetree at vger.kernel.org <[email protected]>; linux-arm-kernel at lists.infradead.org <[email protected]>; linux-aspeed at lists.ozlabs.org <[email protected]>; linux-kernel at vger.kernel.org <[email protected]>; linux-clk at vger.kernel.org <[email protected]> ??: Re: [PATCH v1 08/10] arm64: dts: aspeed: Add initial AST27XX device tree
Why do you quote my email twice?
...
Quoted 19 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 213
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +8
-0+ uart12: serial at 14c33b00 { + compatible = "ns16550a"; + reg = <0x0 0x14c33b00 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clocks = <&syscon1 SCU1_CLK_GATE_UART12CLK>; + no-loopback-test; + pinctrl-names = "default";What is this?
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 49
Quoted 4 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +4
-0+ }; + }; +}; +Best regards,
Krzysztof
Quoted 6 lines
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
Maybe I am the intended recipient of your message, maybe not. I don't want to have any legal questions regarding upstream, public collaboration, thus probably I should just remove your messages.
Please talk with your IT that such disclaimers in open-source are not desired (and maybe even harmful).
If you do not understand why, please also see:
https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835
If you need to go around company SMTP server, then consider using b4
web-relay: https://b4.docs.kernel.org/en/latest/contributor/send.html
Please be informed that by responding to this email you agree that all communications from you and/or your company is made public. In other words, all messages originating from you and/or your company will be made public.
Best regards,
Krzysztof
RE: 回覆: [PATCH v1 08/10] arm64: dts: aspeed: Add initial AST27XX device tree
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 7 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +0
-0arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 8
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +8
-0@@ -0,0 +1,217 @@ +// SPDX-License-Identifier: GPL-2.0-or-later #include +<dt-bindings/clock/aspeed,ast2700-clk.h> +#include <dt-bindings/reset/aspeed,ast2700-reset.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/aspeed-scu-ic.h> + +/ { + model = "Aspeed BMC";Model of what? No, drop.
Quoted 3 lines
Quoted 1 line
Can I change to "model = "AST2700 EVB""
Model of what? No, it does not make sense here.
Should I change to model = "Aspeed BMC SoC";
Quoted 12 lines
..
Quoted 7 lines
Quoted 7 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 7 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +7
-0+ + uart12: serial at 14c33b00 { + compatible = "ns16550a"; + reg = <0x0 0x14c33b00 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clocks = <&syscon1
Quoted 8 lines
SCU1_CLK_GATE_UART12CLK>;Quoted 5 lines
Quoted 4 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 213
Quoted 2 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +2
-0+ no-loopback-test; + pinctrl-names = "default";What is this?
BMC uart using in uart12 in soc1.
No, that line. pinctrl-names do not make sense here without values.
Agree, I will remove the line of pinctrl-names in next patch. Pinctrl property needed to be defined in the future patches.
Quoted 60 lines
Quoted 12 lines
Quoted 7 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 49
Quoted 7 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +4
-0+ }; + }; +}; +--
Best Regards,
Kevin. ChenWhy do you quote my email twice?
...
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+ uart12: serial at 14c33b00 { + compatible = "ns16550a"; + reg = <0x0 0x14c33b00 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clocks = <&syscon1
SCU1_CLK_GATE_UART12CLK>;Quoted 5 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 213
Quoted 2 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +2
-0+ no-loopback-test; + pinctrl-names = "default";What is this?
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 49
Quoted 4 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +4
-0+ }; + }; +}; +Best regards,
Krzysztofother confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
Maybe I am the intended recipient of your message, maybe not. I don't want to have any legal questions regarding upstream, public collaboration, thus probably I should just remove your messages.
Please talk with your IT that such disclaimers in open-source are not desired (and maybe even harmful).
If you do not understand why, please also see:
https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835If you need to go around company SMTP server, then consider using b4
web-relay: https://b4.docs.kernel.org/en/latest/contributor/send.htmlPlease be informed that by responding to this email you agree that all communications from you and/or your company is made public. In other words, all messages originating from you and/or your company will be made public.
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerRe: 回覆: [PATCH v1 08/10] arm64: dts: aspeed: Add initial AST27XX device tree
Quoted 17 lines · Kevin Chen
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 7 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +0
-0arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 8
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +8
-0@@ -0,0 +1,217 @@ +// SPDX-License-Identifier: GPL-2.0-or-later #include +<dt-bindings/clock/aspeed,ast2700-clk.h> +#include <dt-bindings/reset/aspeed,ast2700-reset.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/aspeed-scu-ic.h> + +/ { + model = "Aspeed BMC";Model of what? No, drop.
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Can I change to "model = "AST2700 EVB""
Model of what? No, it does not make sense here.
Should I change to model = "Aspeed BMC SoC";
SoCs do not have models. Please take a look how *every* other SoC is doing.
Best regards,
Krzysztof
RE: [PATCH v1 08/10] arm64: dts: aspeed: Add initial AST27XX device tree
In reply to Krzysztof KozlowskiHi Krzk,
Quoted 26 lines
Quoted 9 lines
--- arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 ++++++++++++++++++++++ 2 files changed, 218 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi(quoted diff) +0
-0b/arch/arm64/boot/dts/Makefile index
21cd3a87f385..c909c19dc5dd100644
Quoted 16 lines
arch/arm64/boot/dts/Makefile +1
-0@@ -34,3 +34,4 @@ subdir-y += tesla subdir-y += ti subdir-y += toshiba subdir-y += xilinx +subdir-y += aspeedarch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +2
-0@@ -0,0 +1,217 @@ +// SPDX-License-Identifier: GPL-2.0-or-later #include +<dt-bindings/clock/aspeed,ast2700-clk.h>
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 8
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+#include <dt-bindings/reset/aspeed,ast2700-reset.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/aspeed-scu-ic.h> + +/ { + model = "Aspeed BMC";Model of what? No, drop.
Can I change to "model = "AST2700 EVB""
Quoted 9 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 9
Quoted 2 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +1
-0+ compatible = "aspeed,ast2700";Please run
scripts/checkpatch.pland fix reported warnings. Then please runscripts/checkpatch.pl --strictand (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 15
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+ #address-cells = <2>; + #size-cells = <2>; + interrupt-parent = <&gic>; + + aliases { + serial12 = &uart12;Nope. Such aliases are board specific.
Agree, I will move to ast2700-evb.dts.
Quoted 81 lines
Quoted 66 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +65
-0+ }; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu at 0 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <0>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + cpu at 1 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <1>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + cpu at 2 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <2>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + cpu at 3 { + compatible = "arm,cortex-a35"; + enable-method = "psci"; + device_type = "cpu"; + reg = <3>; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; + next-level-cache = <&l2>; + }; + + l2: l2-cache0 { + compatible = "cache"; + cache-size = <0x80000>;arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +10
-0+ cache-line-size = <64>; + cache-sets = <1024>; + cache-level = <2>; + }; + }; + + pmu { + compatible = "arm,cortex-a35-pmu"; + interrupt-parent = <&gic>; + interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(2) |
IRQ_TYPE_LEVEL_HIGH)>;arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 93
Quoted 3 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +3
-0+ }; + + psci {
Quoted 6 lines
Order the nodes according to DTS coding style.
Fix all your patches:
1. To pass flawlessly checkpatch (you did not run it) 2. To passdt_binding_checkanddtbs_check(you did not run these) 3. To adhere to kernel coding style 4. To adhere to DTS coding style
Agree.
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +5
-0+ compatible = "arm,psci-1.0"; + method = "smc"; + }; + + gic: interrupt-controller at 12200000 {Nope, this cannot be outside of SoC.
Agree.
Quoted 12 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 100
Quoted 3 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +2
-0+ compatible = "arm,gic-v3"; + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(2) |
IRQ_TYPE_LEVEL_HIGH)>;arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 107
Quoted 7 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +7
-0+ #interrupt-cells = <3>; + interrupt-controller; + interrupt-parent = <&gic>; + #redistributor-regions = <1>; + reg = <0 0x12200000 0 0x10000>, //GICD + <0 0x12280000 0 0x80000>, //GICR + <0 0x40440000 0 0x1000>; //GICC
Quoted 1 line
Read DTS coding style and order this correctly.
Agree.
Quoted 51 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 7 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+ }; + + timer { + compatible = "arm,armv8-timer"; + interrupt-parent = <&gic>; + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) |
IRQ_TYPE_LEVEL_LOW)>,arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 114
Quoted 1 line
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +1
-0+ <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) |
IRQ_TYPE_LEVEL_LOW)>,arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 115
Quoted 1 line
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +1
-0+ <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) |
IRQ_TYPE_LEVEL_LOW)>,arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 116
Quoted 1 line
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +1
-0+ <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) |
IRQ_TYPE_LEVEL_LOW)>;arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 13 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +13
-0+ arm,cpu-registers-not-fw-configured; + always-on; + }; + + soc0: soc at 10000000 { + compatible = "simple-bus"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + soc0_sram: sram at 10000000 { + compatible = "mmio-sram"; + reg = <0x0 0x10000000 0x0 0x20000>; /* 128KiB SRAM on soc0*/
Quoted 12 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +12
-0+ ranges = <0x0 0x0 0x0 0x10000000 0x0 0x20000>; + #address-cells = <2>; + #size-cells = <2>; + no-memory-wc; + + exported at 0 { + reg = <0 0x0 0 0x20000>; + export; + }; + }; + + syscon0: syscon at 12c02000 {arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 10 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +10
-0+ compatible = "aspeed,ast2700-scu0", "syscon", "simple-mfd"; + reg = <0x0 0x12c02000 0x0 0x1000>; + ranges = <0x0 0x0 0 0x12c02000 0 0x1000>; + #address-cells = <2>; + #size-cells = <2>; + #clock-cells = <1>; + #reset-cells = <1>; + + silicon-id at 0 { + compatible = "aspeed,ast2700-silicon-id","aspeed,silicon-id";
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 4 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +4
-0+ reg = <0 0x0 0 0x4>; + }; + + scu_ic0: interrupt-controller at 1D0 {DTS coding style...
Agree. I will fix to "scu_ic0: interrupt-controller at 1d0 {"
Quoted 22 lines
Quoted 22 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +21
-0+ #interrupt-cells = <1>; + compatible = "aspeed,ast2700-scu-ic0"; + reg = <0 0x1d0 0 0xc>; + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>; + interrupt-controller; + }; + + scu_ic1: interrupt-controller at 1E0 { + #interrupt-cells = <1>; + compatible = "aspeed,ast2700-scu-ic1"; + reg = <0 0x1e0 0 0xc>; + interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; + interrupt-controller; + }; + + soc0_rst: reset-controller at 200 { + reg = <0 0x200 0 0x40>; + }; + + soc0_clk: clock-controller at 240 { + reg = <0 0x240 0 0x1c0>;
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+ }; + }; + + }; + + soc1: soc at 14000000 {Wait, what, to socs?
Yes.
In AST2700, there are two socs with different base address for use.
Quoted 26 lines
Quoted 26 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +25
-0+ compatible = "simple-bus"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + syscon1: syscon at 14c02000 { + compatible = "aspeed,ast2700-scu1", "syscon", "simple-mfd"; + reg = <0x0 0x14c02000 0x0 0x1000>; + ranges = <0x0 0x0 0x0 0x14c02000 0x0 0x1000>; + #address-cells = <2>; + #size-cells = <2>; + #clock-cells = <1>; + #reset-cells = <1>; + + soc1_rst: reset-controller at 200 { + #reset-cells = <1>; + }; + + soc1_clk: clock-controller at 240 { + reg = <0 0x240 0 0x1c0>; + }; + }; + + uart12: serial at 14c33b00 { + compatible = "ns16550a";
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 213
Quoted 6 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +6
-0+ reg = <0x0 0x14c33b00 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + clocks = <&syscon1 SCU1_CLK_GATE_UART12CLK>; + no-loopback-test; + pinctrl-names = "default";What is this?
BMC UART is used in uart12 in soc1.
Quoted 8 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi line 49
Quoted 5 lines
arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi new file +4
-0+ }; + }; +}; +Best regards,
Krzysztof
--
Best Regards,
Kevin.Chen
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
PATCH 9/10 arm64: dts: aspeed: Add initial AST2700 EVB device tree
In reply to Kevin Chen--- arch/arm64/boot/dts/aspeed/Makefile | 4 ++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 ++++++++++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts
arch/arm64/boot/dts/aspeed/Makefile new file +4 -0
@@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0 + +dtb-$(CONFIG_ARCH_ASPEED) += \ + ast2700-evb.dtb
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +50 -0
50 lines not on this page · raw message
Signature · 1 line
2.34.1
Krzysztof Kozlowski
maintainerRe: [PATCH v1 09/10] arm64: dts: aspeed: Add initial AST2700 EVB device tree
Quoted 23 lines · Kevin Chen
--- arch/arm64/boot/dts/aspeed/Makefile | 4 ++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 ++++++++++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dtsarch/arm64/boot/dts/aspeed/Makefile new file +4
-0@@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0 + +dtb-$(CONFIG_ARCH_ASPEED) += \ + ast2700-evb.dtbarch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +0
-0
arch/arm64/boot/dts/aspeed/ast2700-evb.dts line 10
Quoted 10 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +10
-0@@ -0,0 +1,50 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +/dts-v1/; + +#include "aspeed-g7.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> + +/ { + model = "AST2700A1-EVB"; + compatible = "aspeed,ast2700a1-evb", "aspeed,ast2700";
You have never tested this.
Sorry, test your DTS first.
arch/arm64/boot/dts/aspeed/ast2700-evb.dts line 13
Quoted 3 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +3
-0+ + chosen { + bootargs = "console=ttyS12,115200n8";
Drop.
Quoted 21 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +21
-0+ stdout-path = &uart12; + }; + + firmware { + optee: optee { + compatible = "linaro,optee-tz"; + method = "smc"; + }; + }; + + memory at 400000000 { + device_type = "memory"; + reg = <0x4 0x00000000 0x0 0x40000000>; + }; + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + mcu_fw: mcu-firmware at 42fe00000 {
arch/arm64/boot/dts/aspeed/ast2700-evb.dts
Quoted 10 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +10
-0+ reg = <0x4 0x2fe00000 0x0 0x200000>; + no-map; + }; + + atf: trusted-firmware-a at 430000000 { + reg = <0x4 0x30000000 0x0 0x80000>; + no-map; + }; + + optee_core: optee_core at 430080000 {
Read DTS coding style.
arch/arm64/boot/dts/aspeed/ast2700-evb.dts line 50
Quoted 6 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +6
-0+ reg = <0x4 0x30080000 0x0 0x1000000>; + no-map; + }; + }; +}; +
Remove stray blank line.
Best regards,
Krzysztof
回覆: [PATCH v1 09/10] arm64: dts: aspeed: Add initial AST2700 EVB device tree
Hi Krzk,
Quoted 36 lines
Quoted 23 lines
--- arch/arm64/boot/dts/aspeed/Makefile | 4 ++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 ++++++++++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dtsarch/arm64/boot/dts/aspeed/Makefile new file +4
-0@@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0 + +dtb-$(CONFIG_ARCH_ASPEED) += \ + ast2700-evb.dtbarch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +0
-0arch/arm64/boot/dts/aspeed/ast2700-evb.dts line 10
Quoted 10 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +10
-0@@ -0,0 +1,50 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +/dts-v1/; + +#include "aspeed-g7.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> + +/ { + model = "AST2700A1-EVB"; + compatible = "aspeed,ast2700a1-evb", "aspeed,ast2700";You have never tested this.
Quoted 1 line
Sorry, test your DTS first.
Agree. I will test my dts by make dtbs_check W=1
Quoted 6 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts line 13
Quoted 4 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +3
-0+ + chosen { + bootargs = "console=ttyS12,115200n8";Drop.
Agree.
Quoted 26 lines
Quoted 26 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +25
-0+ stdout-path = &uart12; + }; + + firmware { + optee: optee { + compatible = "linaro,optee-tz"; + method = "smc"; + }; + }; + + memory at 400000000 { + device_type = "memory"; + reg = <0x4 0x00000000 0x0 0x40000000>; + }; + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + mcu_fw: mcu-firmware at 42fe00000 { + reg = <0x4 0x2fe00000 0x0 0x200000>; + no-map; + }; +
Quoted 8 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts
Quoted 6 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +6
-0+ atf: trusted-firmware-a at 430000000 { + reg = <0x4 0x30000000 0x0 0x80000>; + no-map; + }; + + optee_core: optee_core at 430080000 {Read DTS coding style.
Agree. Should I change to optee_core: optee-core at 430080000 {
Quoted 9 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts line 50
Quoted 7 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +6
-0+ reg = <0x4 0x30080000 0x0 0x1000000>; + no-map; + }; + }; +}; +Remove stray blank line.
Agree.
--
Best Regards,
Kevin. Chen
________________________________
???: Krzysztof Kozlowski <[email protected]>
????: 2024?7?26? ?? 07:16
???: Kevin Chen <[email protected]>; robh at kernel.org <[email protected]>; krzk+dt at kernel.org <[email protected]>; conor+dt at kernel.org <[email protected]>; joel at jms.id.au <[email protected]>; andrew at codeconstruct.com.au <[email protected]>; lee at kernel.org <[email protected]>; catalin.marinas at arm.com <[email protected]>; will at kernel.org <[email protected]>; arnd at arndb.de <[email protected]>; olof at lixom.net <[email protected]>; soc at kernel.org <[email protected]>; mturquette at baylibre.com <[email protected]>; sboyd at kernel.org <[email protected]>; p.zabel at pengutronix.de <[email protected]>; quic_bjorande at quicinc.com <[email protected]>; geert+renesas at glider.be <[email protected]>; dmitry.baryshkov at linaro.org <[email protected]>; shawnguo at kernel.org <[email protected]>; neil.armstrong at linaro.org <[email protected]>; m.szyprowski at samsung.com <[email protected]>; nfraprado at collabora.com <[email protected]>; u-kumar1 at ti.com <[email protected]>; devicetree at vger.kernel.org <[email protected]>; linux-arm-kernel at lists.infradead.org <[email protected]>; linux-aspeed at lists.ozlabs.org <[email protected]>; linux-kernel at vger.kernel.org <[email protected]>; linux-clk at vger.kernel.org <[email protected]> ??: Re: [PATCH v1 09/10] arm64: dts: aspeed: Add initial AST2700 EVB device tree
Quoted 23 lines · Kevin Chen
--- arch/arm64/boot/dts/aspeed/Makefile | 4 ++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 ++++++++++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dtsarch/arm64/boot/dts/aspeed/Makefile new file +4
-0@@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0 + +dtb-$(CONFIG_ARCH_ASPEED) += \ + ast2700-evb.dtbarch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +0
-0
arch/arm64/boot/dts/aspeed/ast2700-evb.dts line 10
Quoted 10 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +10
-0@@ -0,0 +1,50 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +/dts-v1/; + +#include "aspeed-g7.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> + +/ { + model = "AST2700A1-EVB"; + compatible = "aspeed,ast2700a1-evb", "aspeed,ast2700";
You have never tested this.
Sorry, test your DTS first.
arch/arm64/boot/dts/aspeed/ast2700-evb.dts line 13
Quoted 3 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +3
-0+ + chosen { + bootargs = "console=ttyS12,115200n8";
Drop.
Quoted 21 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +21
-0+ stdout-path = &uart12; + }; + + firmware { + optee: optee { + compatible = "linaro,optee-tz"; + method = "smc"; + }; + }; + + memory at 400000000 { + device_type = "memory"; + reg = <0x4 0x00000000 0x0 0x40000000>; + }; + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + mcu_fw: mcu-firmware at 42fe00000 {
arch/arm64/boot/dts/aspeed/ast2700-evb.dts
Quoted 10 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +10
-0+ reg = <0x4 0x2fe00000 0x0 0x200000>; + no-map; + }; + + atf: trusted-firmware-a at 430000000 { + reg = <0x4 0x30000000 0x0 0x80000>; + no-map; + }; + + optee_core: optee_core at 430080000 {
Read DTS coding style.
arch/arm64/boot/dts/aspeed/ast2700-evb.dts line 50
Quoted 6 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +6
-0+ reg = <0x4 0x30080000 0x0 0x1000000>; + no-map; + }; + }; +}; +
Remove stray blank line.
Best regards,
Krzysztof
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you. -------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240815/be8746ea/attachment-0001.htm>
RE: [PATCH v1 09/10] arm64: dts: aspeed: Add initial AST2700 EVB device tree
In reply to Krzysztof KozlowskiHi Krzk,
Quoted 39 lines
Quoted 3 lines
--- arch/arm64/boot/dts/aspeed/Makefile | 4 ++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50++++++++++++++++++++++
Review
Quoted 5 lines
2 files changed, 54 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts(quoted diff) +0
-0b/arch/arm64/boot/dts/aspeed/Makefile
Review
Quoted 10 lines
new file mode 100644
index 000000000000..ffe7e15017ccarch/arm64/boot/dts/aspeed/Makefile new file +4
-0@@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0 + +dtb-$(CONFIG_ARCH_ASPEED) += \ + ast2700-evb.dtb(quoted diff) +0
-0
b/arch/arm64/boot/dts/aspeed/ast2700-evb.dtsQuoted 5 lines
new file mode 100644
index 000000000000..187c458e566barch/arm64/boot/dts/aspeed/ast2700-evb.dts line 10
Quoted 10 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +10
-0@@ -0,0 +1,50 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +/dts-v1/; + +#include "aspeed-g7.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> + +/ { + model = "AST2700A1-EVB"; + compatible = "aspeed,ast2700a1-evb", "aspeed,ast2700";You have never tested this.
Quoted 1 line
Sorry, test your DTS first.
Agree. I will test my dts by make dtbs_check W=1
Quoted 6 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts line 13
Quoted 4 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +3
-0+ + chosen { + bootargs = "console=ttyS12,115200n8";Drop.
Agree.
Quoted 26 lines
Quoted 26 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +25
-0+ stdout-path = &uart12; + }; + + firmware { + optee: optee { + compatible = "linaro,optee-tz"; + method = "smc"; + }; + }; + + memory at 400000000 { + device_type = "memory"; + reg = <0x4 0x00000000 0x0 0x40000000>; + }; + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + mcu_fw: mcu-firmware at 42fe00000 { + reg = <0x4 0x2fe00000 0x0 0x200000>; + no-map; + }; +
Quoted 8 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts
Quoted 6 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +6
-0+ atf: trusted-firmware-a at 430000000 { + reg = <0x4 0x30000000 0x0 0x80000>; + no-map; + }; + + optee_core: optee_core at 430080000 {Read DTS coding style.
Agree. Should I change to optee_core: optee-core at 430080000 {
Quoted 9 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts line 50
Quoted 7 lines
arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file +6
-0+ reg = <0x4 0x30080000 0x0 0x1000000>; + no-map; + }; + }; +}; +Remove stray blank line.
Agree.
Quoted 3 lines
Best regards,
Krzysztof
--
Best Regards,
Kevin.Chen
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
PATCH 10/10 arm64: defconfig: Add ASPEED AST2700 family support
In reply to Kevin Chen--- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
@@ -38,6 +38,7 @@ CONFIG_ARCH_AIROHA=y CONFIG_ARCH_SUNXI=y CONFIG_ARCH_ALPINE=y CONFIG_ARCH_APPLE=y +CONFIG_ARCH_ASPEED=y CONFIG_ARCH_BCM=y CONFIG_ARCH_BCM2835=y CONFIG_ARCH_BCM_IPROC=y
Signature · 1 line
2.34.1
Rob Herring (Arm)
maintainerQuoted 46 lines · Kevin Chen
This patchset adds initial support for the ASPEED. AST27XX Board Management controller (BMC) SoC family.
AST2700 is ASPEED's 8th-generation server management processor. Featuring a quad-core ARM Cortex A35 64-bit processor and two independent ARM Cortex M4 processors
This patchset adds minimal architecture and drivers such as:
Clocksource, Clock and ResetThis patchset was tested on the ASPEED AST2700 evaluation board.
Kevin Chen (10):
dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700
SCU
dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock
clk: ast2700: add clock controller
dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset
dt-bindings: arm: aspeed: Add maintainer
dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
arm64: aspeed: Add support for ASPEED AST2700 BMC SoC
arm64: dts: aspeed: Add initial AST27XX device tree
arm64: dts: aspeed: Add initial AST2700 EVB device tree
arm64: defconfig: Add ASPEED AST2700 family support.../bindings/arm/aspeed/aspeed.yaml | 6 + .../bindings/mfd/aspeed,ast2x00-scu.yaml | 3 + MAINTAINERS | 3 + arch/arm64/Kconfig.platforms | 14 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/aspeed/Makefile | 4 + arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 +++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 + arch/arm64/configs/defconfig | 1 + drivers/clk/Makefile | 1 + drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++ .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 +++ .../dt-bindings/reset/aspeed,ast2700-reset.h | 126 ++ 13 files changed, 1772 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts create mode 100644 drivers/clk/clk-ast2700.c create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.h
Quoted 5 lines
--
2.34.1
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y aspeed/ast2700-evb.dtb' for 20240726110355.2181563-1-kevin_chen at aspeedtech.com:
arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: /: failed to match any schema with compatible: ['aspeed,ast2700a1-evb', 'aspeed,ast2700'] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: /: failed to match any schema with compatible: ['aspeed,ast2700a1-evb', 'aspeed,ast2700'] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: l2-cache0: 'cache-unified' is a dependency of 'cache-size'
from schema $id: http://devicetree.org/schemas/cache.yaml#arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: l2-cache0: 'cache-unified' is a dependency of 'cache-sets'
from schema $id: http://devicetree.org/schemas/cache.yaml#arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: l2-cache0: 'cache-unified' is a dependency of 'cache-line-size'
from schema $id: http://devicetree.org/schemas/cache.yaml#arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: l2-cache0: 'cache-unified' is a required property
from schema $id: http://devicetree.org/schemas/cache.yaml#arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: l2-cache0: Unevaluated properties are not allowed ('cache-level', 'cache-line-size', 'cache-sets', 'cache-size' were unexpected)
from schema $id: http://devicetree.org/schemas/cache.yaml#arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: sram at 10000000: #address-cells: 1 was expected
from schema $id: http://devicetree.org/schemas/sram/sram.yaml#arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: sram at 10000000: #size-cells: 1 was expected
from schema $id: http://devicetree.org/schemas/sram/sram.yaml#arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: sram at 10000000: 'exported at 0' does not match any of the regexes: '^([a-z0-9]*-)?sram(-section)?@[a-f0-9]+$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/sram/sram.yaml#arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: /soc at 10000000/syscon at 12c02000: failed to match any schema with compatible: ['aspeed,ast2700-scu0', 'syscon', 'simple-mfd'] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: /soc at 10000000/syscon at 12c02000/interrupt-controller at 1D0: failed to match any schema with compatible: ['aspeed,ast2700-scu-ic0'] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: /soc at 10000000/syscon at 12c02000/interrupt-controller at 1E0: failed to match any schema with compatible: ['aspeed,ast2700-scu-ic1'] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: /soc at 14000000/syscon at 14c02000: failed to match any schema with compatible: ['aspeed,ast2700-scu1', 'syscon', 'simple-mfd'] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: serial at 14c33b00: 'oneOf' conditional failed, one must be fixed:
'interrupts' is a required property
'interrupts-extended' is a required property
from schema $id: http://devicetree.org/schemas/serial/8250.yaml#arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: serial at 14c33b00: 'pinctrl-0' is a dependency of 'pinctrl-names'
from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-consumer.yaml#
Krzysztof Kozlowski
maintainerQuoted 63 lines · Rob Herring (Arm)
Quoted 46 lines · Kevin Chen
This patchset adds initial support for the ASPEED. AST27XX Board Management controller (BMC) SoC family.
AST2700 is ASPEED's 8th-generation server management processor. Featuring a quad-core ARM Cortex A35 64-bit processor and two independent ARM Cortex M4 processors
This patchset adds minimal architecture and drivers such as:
Clocksource, Clock and ResetThis patchset was tested on the ASPEED AST2700 evaluation board.
Kevin Chen (10):
dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700
SCU
dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock
clk: ast2700: add clock controller
dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset
dt-bindings: arm: aspeed: Add maintainer
dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
arm64: aspeed: Add support for ASPEED AST2700 BMC SoC
arm64: dts: aspeed: Add initial AST27XX device tree
arm64: dts: aspeed: Add initial AST2700 EVB device tree
arm64: defconfig: Add ASPEED AST2700 family support.../bindings/arm/aspeed/aspeed.yaml | 6 + .../bindings/mfd/aspeed,ast2x00-scu.yaml | 3 + MAINTAINERS | 3 + arch/arm64/Kconfig.platforms | 14 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/aspeed/Makefile | 4 + arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 +++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 + arch/arm64/configs/defconfig | 1 + drivers/clk/Makefile | 1 + drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++ .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 +++ .../dt-bindings/reset/aspeed,ast2700-reset.h | 126 ++ 13 files changed, 1772 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts create mode 100644 drivers/clk/clk-ast2700.c create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.hQuoted 5 lines
--
2.34.1My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
Quoted 7 lines
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgradeNew warnings running 'make CHECK_DTBS=y aspeed/ast2700-evb.dtb' for 20240726110355.2181563-1-kevin_chen at aspeedtech.com:
Kevin,
Just to clarify. Looking at the patches it was quite obvious you did not test it with dtbs_check. For a new arm64 platform without any legacy, having 0 warnings is a must.
Consider Documentation/process/maintainer-soc-clean-dts.rst being implied for this platform.
Best regards,
Krzysztof
Hi Krzk,
I will speperate clock part in the v3 patch into Ryan's clock series.
Quoted 69 lines
Quoted 69 lines · Kevin Chen
Quoted 46 lines
This patchset adds initial support for the ASPEED. AST27XX Board Management controller (BMC) SoC family.
AST2700 is ASPEED's 8th-generation server management processor. Featuring a quad-core ARM Cortex A35 64-bit processor and two independent ARM Cortex M4 processors
This patchset adds minimal architecture and drivers such as:
Clocksource, Clock and ResetThis patchset was tested on the ASPEED AST2700 evaluation board.
Kevin Chen (10):
dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700
SCU
dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock
clk: ast2700: add clock controller
dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset
dt-bindings: arm: aspeed: Add maintainer
dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
arm64: aspeed: Add support for ASPEED AST2700 BMC SoC
arm64: dts: aspeed: Add initial AST27XX device tree
arm64: dts: aspeed: Add initial AST2700 EVB device tree
arm64: defconfig: Add ASPEED AST2700 family support.../bindings/arm/aspeed/aspeed.yaml | 6 + .../bindings/mfd/aspeed,ast2x00-scu.yaml | 3 + MAINTAINERS | 3 + arch/arm64/Kconfig.platforms | 14 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/aspeed/Makefile | 4 + arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 +++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 + arch/arm64/configs/defconfig | 1 + drivers/clk/Makefile | 1 + drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++ .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 +++ .../dt-bindings/reset/aspeed,ast2700-reset.h | 126 ++ 13 files changed, 1772 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts create mode 100644 drivers/clk/clk-ast2700.c create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.hQuoted 5 lines
--
2.34.1My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
Quoted 6 lines
Quoted 1 line
New warnings running 'make CHECK_DTBS=y aspeed/ast2700-evb.dtb' for 20240726110355.2181563-1-kevin_chen at aspeedtech.com:
Kevin,
Just to clarify. Looking at the patches it was quite obvious you did not test it withdtbs_check. For a new arm64 platform without any legacy, having 0 warnings is a must.
Agree.
Quoted 3 lines
Consider
Documentation/process/maintainer-soc-clean-dts.rstbeing implied for this platform.
--
Best Regards,
Kevin. Chen
________________________________
???: Krzysztof Kozlowski <[email protected]>
????: 2024?7?26? ?? 09:33
???: Kevin Chen <[email protected]>
??: soc at kernel.org <[email protected]>; m.szyprowski at samsung.com <[email protected]>; nfraprado at collabora.com <[email protected]>; olof at lixom.net <[email protected]>; will at kernel.org <[email protected]>; mturquette at baylibre.com <[email protected]>; linux-kernel at vger.kernel.org <[email protected]>; linux-clk at vger.kernel.org <[email protected]>; conor+dt at kernel.org <[email protected]>; devicetree at vger.kernel.org <[email protected]>; andrew at codeconstruct.com.au <[email protected]>; catalin.marinas at arm.com <[email protected]>; sboyd at kernel.org <[email protected]>; p.zabel at pengutronix.de <[email protected]>; u-kumar1 at ti.com <[email protected]>; arnd at arndb.de <[email protected]>; joel at jms.id.au <[email protected]>; quic_bjorande at quicinc.com <[email protected]>; lee at kernel.org <[email protected]>; krzk+dt at kernel.org <[email protected]>; linux-arm-kernel at lists.infradead.org <[email protected]>; neil.armstrong at linaro.org <[email protected]>; linux-aspeed at lists.ozlabs.org <[email protected]>; dmitry.baryshkov at linaro.org <[email protected]>; shawnguo at kernel.org <[email protected]>; geert+renesas at glider.be <[email protected]>; Rob Herring (Arm) <[email protected]> ??: Re: [PATCH v1 00/10] Introduce ASPEED AST27XX BMC SoC
Quoted 63 lines · Rob Herring (Arm)
Quoted 46 lines · Kevin Chen
This patchset adds initial support for the ASPEED. AST27XX Board Management controller (BMC) SoC family.
AST2700 is ASPEED's 8th-generation server management processor. Featuring a quad-core ARM Cortex A35 64-bit processor and two independent ARM Cortex M4 processors
This patchset adds minimal architecture and drivers such as:
Clocksource, Clock and ResetThis patchset was tested on the ASPEED AST2700 evaluation board.
Kevin Chen (10):
dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700
SCU
dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock
clk: ast2700: add clock controller
dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset
dt-bindings: arm: aspeed: Add maintainer
dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
arm64: aspeed: Add support for ASPEED AST2700 BMC SoC
arm64: dts: aspeed: Add initial AST27XX device tree
arm64: dts: aspeed: Add initial AST2700 EVB device tree
arm64: defconfig: Add ASPEED AST2700 family support.../bindings/arm/aspeed/aspeed.yaml | 6 + .../bindings/mfd/aspeed,ast2x00-scu.yaml | 3 + MAINTAINERS | 3 + arch/arm64/Kconfig.platforms | 14 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/aspeed/Makefile | 4 + arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 +++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 + arch/arm64/configs/defconfig | 1 + drivers/clk/Makefile | 1 + drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++ .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 +++ .../dt-bindings/reset/aspeed,ast2700-reset.h | 126 ++ 13 files changed, 1772 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts create mode 100644 drivers/clk/clk-ast2700.c create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.hQuoted 5 lines
--
2.34.1My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
Quoted 7 lines
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgradeNew warnings running 'make CHECK_DTBS=y aspeed/ast2700-evb.dtb' for 20240726110355.2181563-1-kevin_chen at aspeedtech.com:
Kevin,
Just to clarify. Looking at the patches it was quite obvious you did not test it with dtbs_check. For a new arm64 platform without any legacy, having 0 warnings is a must.
Consider Documentation/process/maintainer-soc-clean-dts.rst being implied for this platform.
Best regards,
Krzysztof
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you. -------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240815/7dcdea2d/attachment-0001.htm>
Hi Krzk,
I will separate clock part in the v3 patch into Ryan's clock series.
Quoted 72 lines · Rob Herring (Arm)
Quoted 27 lines · Kevin Chen
Quoted 25 lines
This patchset adds initial support for the ASPEED. AST27XX Board Management controller (BMC) SoC family.
AST2700 is ASPEED's 8th-generation server management processor. Featuring a quad-core ARM Cortex A35 64-bit processor and two independent ARM Cortex M4 processors
This patchset adds minimal architecture and drivers such as:
Clocksource, Clock and ResetThis patchset was tested on the ASPEED AST2700 evaluation board.
Kevin Chen (10):
dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700
SCU
dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock
clk: ast2700: add clock controller
dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset
dt-bindings: arm: aspeed: Add maintainer
dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string
arm64: aspeed: Add support for ASPEED AST2700 BMC SoC
arm64: dts: aspeed: Add initial AST27XX device tree
arm64: dts: aspeed: Add initial AST2700 EVB device tree
arm64: defconfig: Add ASPEED AST2700 family supportQuoted 11 lines
Quoted 11 lines
.../bindings/arm/aspeed/aspeed.yaml | 6 + .../bindings/mfd/aspeed,ast2x00-scu.yaml | 3 + MAINTAINERS | 3 + arch/arm64/Kconfig.platforms | 14 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/aspeed/Makefile | 4 + arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 +++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 + arch/arm64/configs/defconfig | 1 + drivers/clk/Makefile | 1 + drivers/clk/clk-ast2700.c | 1166+++++++++++++++++
Quoted 31 lines
Quoted 10 lines
.../dt-bindings/clock/aspeed,ast2700-clk.h | 180 +++ .../dt-bindings/reset/aspeed,ast2700-reset.h | 126 ++ 13 files changed, 1772 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts create mode 100644 drivers/clk/clk-ast2700.c create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.hQuoted 5 lines
--
2.34.1My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
Quoted 7 lines
Quoted 1 line
New warnings running 'make CHECK_DTBS=y aspeed/ast2700-evb.dtb' for
20240726110355.2181563-1-kevin_chen at aspeedtech.com:
Kevin,
Just to clarify. Looking at the patches it was quite obvious you did not test it withdtbs_check. For a new arm64 platform without any legacy, having 0 warnings is a must.
Agree.
Quoted 6 lines
Consider
Documentation/process/maintainer-soc-clean-dts.rstbeing implied for this platform.Best regards,
Krzysztof
--
Best Regards,
Kevin.Chen
************* Email Confidentiality Notice ********************
????:
???(????)????????????????? ???????????????????????????, ??????????????????????????????!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.