Skip to contentSkip to conversation

net: phy: remove preliminary workaround for not loading PHY driver

PATCH Applied Heiner Kallweit 3 participants 3 messages Jan 15, 2019 – Jan 17, 2019

Subsystems (3)
lore
Share & tools
lore

Heiner Kallweit

author maintainer
#0 lore raw

PATCH 1/1 net: phy: remove preliminary workaround for not loading PHY driver

This workaround attempt helped for some but not all affected users. With commit 11287b693d03 ("r8169: load Realtek PHY driver module before r8169") we have a better workaround now, so we an remove the first attempt.

---
 drivers/net/phy/phy_device.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/net/phy/phy_device.c +0 -8
index 51990002d..a2423cbb2 100644
@@ -2250,14 +2250,6 @@ int phy_driver_register(struct phy_driver *new_driver, struct module *owner)
 	new_driver->mdiodrv.driver.remove = phy_remove;
 	new_driver->mdiodrv.driver.owner = owner;
 
-	/* The following works around an issue where the PHY driver doesn't bind
-	 * to the device, resulting in the genphy driver being used instead of
-	 * the dedicated driver. The root cause of the issue isn't known yet
-	 * and seems to be in the base driver core. Once this is fixed we may
-	 * remove this workaround.
-	 */
-	new_driver->mdiodrv.driver.probe_type = PROBE_FORCE_SYNCHRONOUS;
-
 	retval = driver_register(&new_driver->mdiodrv.driver);
 	if (retval) {
 		pr_err("%s: Error %d in registering driver\n",
Signature · 1 line
2.20.1