Skip to contentSkip to conversation

dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema

PATCH Applied Bhargav Joshi 3 participants 5 messages Jun 11 – Jun 25

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema

Convert TI irq-crossbar binding from text format to DT schema.

As part of conversion following changes are made:
- Add '#interrupt-cells' as a required property which was missing in text binding
- As irq-crossbar is interrupt-controller. Move binding from bindings/arm/omap to bindings/interrupt-controller

---
Changes in v3:
- Fixed typo in property description
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Dropped property name change and driver updates.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 .../devicetree/bindings/arm/omap/crossbar.txt      | 55 -------------
 .../interrupt-controller/ti,irq-crossbar.yaml      | 96 ++++++++++++++++++++++
 2 files changed, 96 insertions(+), 55 deletions(-)
Documentation/devicetree/bindings/arm/omap/crossbar.txt deleted +0 -55
deleted file mode 100644
index a43e4c7aba3d..000000000000
@@ -1,55 +0,0 @@
-Some socs have a large number of interrupts requests to service
-the needs of its many peripherals and subsystems. All of the
-interrupt lines from the subsystems are not needed at the same
-time, so they have to be muxed to the irq-controller appropriately.
-In such places a interrupt controllers are preceded by an CROSSBAR
-that provides flexibility in muxing the device requests to the controller
-inputs.
-
-Required properties:
-- compatible : Should be "ti,irq-crossbar"
-- reg: Base address and the size of the crossbar registers.
-- interrupt-controller: indicates that this block is an interrupt controller.
-- ti,max-irqs: Total number of irqs available at the parent interrupt controller.
-- ti,max-crossbar-sources: Maximum number of crossbar sources that can be routed.
-- ti,reg-size: Size of a individual register in bytes. Every individual
-	    register is assumed to be of same size. Valid sizes are 1, 2, 4.
-- ti,irqs-reserved: List of the reserved irq lines that are not muxed using
-		 crossbar. These interrupt lines are reserved in the soc,
-		 so crossbar bar driver should not consider them as free
-		 lines.
-
-Optional properties:
-- ti,irqs-skip: This is similar to "ti,irqs-reserved", but these are for
-  SOC-specific hard-wiring of those irqs which unexpectedly bypasses the
-  crossbar. These irqs have a crossbar register, but still cannot be used.
-
-- ti,irqs-safe-map: integer which maps to a safe configuration to use
-  when the interrupt controller irq is unused (when not provided, default is 0)
-
-Examples:
-		crossbar_mpu: crossbar@4a002a48 {
-			compatible = "ti,irq-crossbar";
-			reg = <0x4a002a48 0x130>;
-			ti,max-irqs = <160>;
-			ti,max-crossbar-sources = <400>;
-			ti,reg-size = <2>;
-			ti,irqs-reserved = <0 1 2 3 5 6 131 132>;
-			ti,irqs-skip = <10 133 139 140>;
-		};
-
-Consumer:
-========
-See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt and
-Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml for
-further details.
-
-An interrupt consumer on an SoC using crossbar will use:
-	interrupts = <GIC_SPI request_number interrupt_level>
-
-Example:
-	device_x@4a023000 {
-		/* Crossbar 8 used */
-		interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
-		...
-	};
Documentation/devicetree/bindings/interrupt-controller/ti,irq-crossbar.yaml new file +96 -0

96 lines not on this page · raw message

---
base-commit: eb3f4b7426cfd2b79d65b7d37155480b32259a11
change-id: 20260528-crossbar-2b9a641d2146

Best regards,

Signature · 1 line
Bhargav
maintainer Applied
#1 lore raw
Quoted 14 lines · Bhargav Joshi

Convert TI irq-crossbar binding from text format to DT schema.

As part of conversion following changes are made:
- Add '#interrupt-cells' as a required property which was missing in text binding
- As irq-crossbar is interrupt-controller. Move binding from bindings/arm/omap to bindings/interrupt-controller

---
Changes in v3:
- Fixed typo in property description
- Link to v2: https://lore.kernel.org/r/[email protected]

Quoted 8 lines

Changes in v2:
- Dropped property name change and driver updates.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 .../devicetree/bindings/arm/omap/crossbar.txt      | 55 -------------
 .../interrupt-controller/ti,irq-crossbar.yaml      | 96 ++++++++++++++++++++++
 2 files changed, 96 insertions(+), 55 deletions(-)

Applied, thanks!

#2 lore raw
Quoted 25 lines · Rob Herring (Arm)
Quoted 14 lines · Bhargav Joshi

Convert TI irq-crossbar binding from text format to DT schema.

As part of conversion following changes are made:
- Add '#interrupt-cells' as a required property which was missing in text binding
- As irq-crossbar is interrupt-controller. Move binding from bindings/arm/omap to bindings/interrupt-controller

---
Changes in v3:
- Fixed typo in property description
- Link to v2: https://lore.kernel.org/r/[email protected]

Quoted 8 lines

Changes in v2:
- Dropped property name change and driver updates.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 .../devicetree/bindings/arm/omap/crossbar.txt      | 55 -------------
 .../interrupt-controller/ti,irq-crossbar.yaml      | 96 ++++++++++++++++++++++
 2 files changed, 96 insertions(+), 55 deletions(-)
Quoted 1 line

Applied, thanks!

With:

$ dt-validate --version
2026.4

on next-20260623

I'm getting:

$ LC_ALL=C make ARCH=arm64 LLVM=1 -j24 dt_binding_check
SCHEMA  Documentation/devicetree/bindings/processed-schema.json
Traceback (most recent call last):
  File "/home/konrad/.local/bin/dt-mk-schema", line 6, in <module>
    sys.exit(main())
             ~~~~^^
  File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/mk_schema.py", line 28, in main
    schemas = dtschema.DTValidator(args.schemas).schemas
              ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/validator.py", line 399, in __init__
    self.make_property_type_cache()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/validator.py", line 528, in make_property_type_cache
    self.check_duplicate_property_types()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/validator.py", line 522, in check_duplicate_property_types
    print(f"{self.schemas[sch_id]['$filename']}: {p}: multiple incompatible types: {v['type']}", file=sys.stderr)
             ~~~~~~~~~~~~^^^^^^^^
KeyError: 'http://devicetree.org/schemas/interrupt-controller/ti,irq-crossbar.yaml#'
make[2]: *** [Documentation/devicetree/bindings/Makefile:75: Documentation/devicetree/bindings/processed-schema.json] Błąd 1
make[2]: *** Kasuję plik 'Documentation/devicetree/bindings/processed-schema.json'
make[1]: *** [<snip>/linux/Makefile:1672: dt_binding_schemas] Błąd 2
make: *** [Makefile:248: __sub-make] Error 2

Konrad

maintainer
#3 lore raw
Quoted 27 lines · Konrad Dybcio
Quoted 25 lines · Rob Herring (Arm)
Quoted 22 lines · Bhargav Joshi

Convert TI irq-crossbar binding from text format to DT schema.

As part of conversion following changes are made:
- Add '#interrupt-cells' as a required property which was missing in text binding
- As irq-crossbar is interrupt-controller. Move binding from bindings/arm/omap to bindings/interrupt-controller

---
Changes in v3:
- Fixed typo in property description
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Dropped property name change and driver updates.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 .../devicetree/bindings/arm/omap/crossbar.txt      | 55 -------------
 .../interrupt-controller/ti,irq-crossbar.yaml      | 96 ++++++++++++++++++++++
 2 files changed, 96 insertions(+), 55 deletions(-)
Quoted 6 lines
Quoted 1 line

Applied, thanks!

With:

$ dt-validate --version
2026.4

There is 2026.6 now which fixes this.

Quoted 20 lines

on next-20260623

I'm getting:

$ LC_ALL=C make ARCH=arm64 LLVM=1 -j24 dt_binding_check
SCHEMA  Documentation/devicetree/bindings/processed-schema.json
Traceback (most recent call last):
  File "/home/konrad/.local/bin/dt-mk-schema", line 6, in <module>
    sys.exit(main())
             ~~~~^^
  File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/mk_schema.py", line 28, in main
    schemas = dtschema.DTValidator(args.schemas).schemas
              ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/validator.py", line 399, in __init__
    self.make_property_type_cache()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/validator.py", line 528, in make_property_type_cache
    self.check_duplicate_property_types()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
Quoted 8 lines
  File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/validator.py", line 522, in check_duplicate_property_types
    print(f"{self.schemas[sch_id]['$filename']}: {p}: multiple incompatible types: {v['type']}", file=sys.stderr)
             ~~~~~~~~~~~~^^^^^^^^
KeyError: 'http://devicetree.org/schemas/interrupt-controller/ti,irq-crossbar.yaml#'
make[2]: *** [Documentation/devicetree/bindings/Makefile:75: Documentation/devicetree/bindings/processed-schema.json] Błąd 1
make[2]: *** Kasuję plik 'Documentation/devicetree/bindings/processed-schema.json'
make[1]: *** [<snip>/linux/Makefile:1672: dt_binding_schemas] Błąd 2
make: *** [Makefile:248: __sub-make] Error 2

We should fix this to avoid the splat, but that would still be a new tool version.

So we either need to revert this and delay adding this schema or force people to upgrade.

Rob

#4 lore raw
Quoted 15 lines · Rob Herring
Quoted 14 lines · Konrad Dybcio
Quoted 12 lines · Rob Herring (Arm)
Quoted 10 lines · Bhargav Joshi

Convert TI irq-crossbar binding from text format to DT schema.

As part of conversion following changes are made:
- Add '#interrupt-cells' as a required property which was missing in text binding
- As irq-crossbar is interrupt-controller. Move binding from bindings/arm/omap to bindings/interrupt-controller

---

[...]

Quoted 11 lines
Quoted 5 lines

KeyError: 'http://devicetree.org/schemas/interrupt-controller/ti,irq-crossbar.yaml#'
make[2]: *** [Documentation/devicetree/bindings/Makefile:75: Documentation/devicetree/bindings/processed-schema.json] Błąd 1 make[2]: *** Kasuję plik 'Documentation/devicetree/bindings/processed-schema.json'
make[1]: *** [<snip>/linux/Makefile:1672: dt_binding_schemas] Błąd 2
make: *** [Makefile:248: __sub-make] Error 2

We should fix this to avoid the splat, but that would still be a new tool version.

So we either need to revert this and delay adding this schema or force people to upgrade.

I think we may find a static version check useful (i.e. something akin to what scripts/cc-version.sh does with compilers) to make things more obvious

Konrad