Skip to contentSkip to conversation

Patch to make VIA sata board bootable again.

PATCH Johnny Strom 4 participants 7 messages Sep 1, 2006 – Sep 4, 2006 PCI

lore
Share & tools
lore
#0 lore raw

Hello

The quirks.c update that went into 2.6.16.17 made an VIA machine here non bootable from an sata drive (via_sata), the error is:

"ATA1 qc timout"
"Failed to set xfermode".

And later kernel panic becouse no sata disk was found.
I tracked it down to the quirk update in 2.6.16.17. Below is a patch against 2.6.17.11 that reverses the uppdate and makse the system bootable again.

Another option is to find out the PCI_DEVICE_ID_VIA for the motherboard in question but I could not get that info. Dose someone have an idea how to find that info? then I can provide an patch that adds the right PCI_DEVICE_ID_VIA for my motherboard.

drivers/pci/quirks.c +1 -7
diff -ur linux-2.6.17.11-org/drivers/pci/quirks.c linux-2.6.17.11/drivers/pci/quirks.c
@@ -652,13 +652,7 @@
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
 }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_1, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_2, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_3, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
 
 /*
  * VIA VT82C598 has its device ID settable and many BIOSes
Signed-off-by [email protected]
#1 lore raw
Quoted 9 lines · On Fri, 01 Sep 2006 11:15:17 +0300 Johnny Strom <[email protected]> wrote:

Hello

The quirks.c update that went into 2.6.16.17 made an VIA machine here non bootable from an sata drive (via_sata), the error is:

"ATA1 qc timout"
"Failed to set xfermode".

argh.

Does 2.6.18-rc5 work?

Quoted 30 lines

And later kernel panic becouse no sata disk was found.
I tracked it down to the quirk update in 2.6.16.17. Below is a patch against 2.6.17.11 that reverses the uppdate and makse the system bootable again.

Another option is to find out the PCI_DEVICE_ID_VIA for the motherboard in question but I could not get that info. Dose someone have an idea how to find that info? then I can provide an patch that adds the right PCI_DEVICE_ID_VIA for my motherboard.

diff -ur linux-2.6.17.11-org/drivers/pci/quirks.c
linux-2.6.17.11/drivers/pci/quirks.c
--- linux-2.6.17.11-org/drivers/pci/quirks.c 2006-09-01
10:38:31.135747500 +0300
+++ linux-2.6.17.11/drivers/pci/quirks.c 2006-09-01 10:42:28.870605000 +0300

(quoted diff) +0 -5
@@ -652,13 +652,7 @@
  		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
  	}
  }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0, 
 quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_1, 
 quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_2, 
 quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_3, 
 quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, 
Quoted 7 lines

quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);

That's wordwrapped.

#2 lore raw
Quoted 9 lines · Andrew Morton
Quoted 5 lines · On Fri, 01 Sep 2006 11:15:17 +0300 Johnny Strom <[email protected]> wrote:

Hello

The quirks.c update that went into 2.6.16.17 made an VIA machine here non bootable from an sata drive (via_sata), the error is:

Quoted 8 lines
Quoted 2 lines

"ATA1 qc timout"
"Failed to set xfermode".

argh.

Does 2.6.18-rc5 work?

No it is the same problem with 2.6.18-rc5.

Quoted 9 lines
Quoted 5 lines

And later kernel panic becouse no sata disk was found.
I tracked it down to the quirk update in 2.6.16.17. Below is a patch against 2.6.17.11 that reverses the uppdate and makse the system bootable again.

Another option is to find out the PCI_DEVICE_ID_VIA for the motherboard in question but I could not get that info. Dose someone have an idea how to find that info? then I can provide an patch that adds the right PCI_DEVICE_ID_VIA for my motherboard.

That's wordwrapped.

Attached an new diff.

Johnny

drivers/pci/quirks.c +1 -7
diff -ur linux-2.6.17.11-org/drivers/pci/quirks.c linux-2.6.17.11/drivers/pci/quirks.c
@@ -652,13 +652,7 @@
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
 }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_1, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_2, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_3, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
 
 /*
  * VIA VT82C598 has its device ID settable and many BIOSes
#3 lore raw
Quoted 1 line · Johnny Strom

No it is the same problem with 2.6.18-rc5.

Did either the patches from Daniel Drake or Sergio Monteiro Basto help?

Quoted 1 line

Attached an new diff.

Which breaks other a different class of machines. A can you try -mm, there is a patch in that and tell us if that works?

#4 lore raw
Quoted 10 lines · Chris Wedgwood
Quoted 1 line · Johnny Strom

No it is the same problem with 2.6.18-rc5.

Did either the patches from Daniel Drake or Sergio Monteiro Basto help?

hello

I have now tested the patch found here:

http://lkml.org/lkml/2006/9/3/148

And that patchs works fine, I can now boot the system.

I have also tested this patch pci-quirk_via_irq-behaviour-change.patch and it works fine as well, I can boot the system again.

It is kernel version 2.6.17.11 that I have tested the patches on.

So any of those two patches makes my system boot again.

Johnny

Signature · 1 line
VGER BF report: H 0
#5 lore raw
In reply to Johnny Strom

Hi, Can you give me the information of interrupts
cat /proc/interrupts

XT_PIC or IO-APIC-edge/level ?

Quoted 57 lines · Johnny Strom

Hello

The quirks.c update that went into 2.6.16.17 made an VIA machine here non bootable from an sata drive (via_sata), the error is:

"ATA1 qc timout"
"Failed to set xfermode".

And later kernel panic becouse no sata disk was found.
I tracked it down to the quirk update in 2.6.16.17. Below is a patch against 2.6.17.11 that reverses the uppdate and makse the system bootable again.

Another option is to find out the PCI_DEVICE_ID_VIA for the motherboard in question but I could not get that info. Dose someone have an idea how to find that info? then I can provide an patch that adds the right PCI_DEVICE_ID_VIA for my motherboard.

diff -ur linux-2.6.17.11-org/drivers/pci/quirks.c
linux-2.6.17.11/drivers/pci/quirks.c
--- linux-2.6.17.11-org/drivers/pci/quirks.c 2006-09-01
10:38:31.135747500 +0300
+++ linux-2.6.17.11/drivers/pci/quirks.c 2006-09-01 10:42:28.870605000 +0300

(quoted diff) +0 -5
@@ -652,13 +652,7 @@
  		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
  	}
  }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0, 
 quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_1, 
 quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_2, 
 quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_3, 
 quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, 

quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);

/*
* VIA VT82C598 has its device ID settable and many BIOSes

Signed-off-by [email protected]

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#6 lore raw
Quoted 5 lines · Sergio Monteiro Basto

Hi, Can you give me the information of interrupts cat /proc/interrupts

XT_PIC or IO-APIC-edge/level ?

Here it is.

cat /proc/interrupts
CPU0

  0:    1692278          XT-PIC  timer
  1:         40          XT-PIC  i8042
  2:          0          XT-PIC  cascade
  7:     414568          XT-PIC  libata, ohci1394, uhci_hcd:usb2, 
uhci_hcd:usb3, radeon@pci:0000:01:00.0
  8:          4          XT-PIC  rtc
  9:          0          XT-PIC  acpi
 10:     534456          XT-PIC  sk98lin, ehci_hcd:usb1, VIA8237, eth0
 11:          0          XT-PIC  uhci_hcd:usb4, uhci_hcd:usb5
 12:        130          XT-PIC  i8042
 14:         53          XT-PIC  ide0
 15:        101          XT-PIC  ide1
NMI:          0
ERR:          0

Johnny

Quoted 54 lines · Johnny Strom
Quoted 50 lines

Hello

The quirks.c update that went into 2.6.16.17 made an VIA machine here non bootable from an sata drive (via_sata), the error is:

"ATA1 qc timout"
"Failed to set xfermode".

And later kernel panic becouse no sata disk was found.
I tracked it down to the quirk update in 2.6.16.17. Below is a patch against 2.6.17.11 that reverses the uppdate and makse the system bootable again.

Another option is to find out the PCI_DEVICE_ID_VIA for the motherboard in question but I could not get that info. Dose someone have an idea how to find that info? then I can provide an patch that adds the right PCI_DEVICE_ID_VIA for my motherboard.

diff -ur linux-2.6.17.11-org/drivers/pci/quirks.c linux-2.6.17.11/drivers/pci/quirks.c
--- linux-2.6.17.11-org/drivers/pci/quirks.c 2006-09-01
10:38:31.135747500 +0300
+++ linux-2.6.17.11/drivers/pci/quirks.c 2006-09-01 10:42:28.870605000 +0300

(quoted diff) +0 -5
@@ -652,13 +652,7 @@
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
 }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0, 
 quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_1, 
 quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_2, 
 quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_3, 
 quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, 

quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);

/*
* VIA VT82C598 has its device ID settable and many BIOSes

Signed-off-by [email protected]

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/