Skip to contentSkip to conversation

auto-starting viewer for virtual frame buffer

RFC PATCH In review Charles Coffing 2 participants 2 messages Sep 1, 2006 – Sep 2, 2006

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 auto-starting viewer for virtual frame buffer

It seems that discussion of the virtual frame buffer has died down; I assume this is being held off until after 3.0.3 splits...

Nevertheless, I was playing with it and wanted to put this patch out for discussion. This patch is a rough attempt to make the SDL/VNC viewers behave similarly for both paravirtual and fully virtual domains. For example, if you specify "sdl=1" in a paravirtual config file, "xm create" will cause sdlfb to start automatically.

My desire is to make para vs. full not appear so different to the casual user. Config file syntax should be similar, viewers should start in similar ways, etc.

If others agree, then there's certainly more to do. (Killing the VM should close the viewer and vice versa; the vncviewer setting is not yet hooked up; viewer paths are hard coded; etc...) But I wanted to put the idea out there to see if others agree with this direction.

Thanks,
Charles

tools/python/xen/xend/XendDomainInfo.py +1 -1
Index: xen-unstable/tools/python/xen/xend/XendDomainInfo.py
===================================================================
@@ -1481,7 +1481,7 @@ class XendDomainInfo:
             self.createDevice(n, c)
 
         if self.image:
-            self.image.createDeviceModel()
+            self.image.spawnHelper()
 
     ## public:
 
tools/python/xen/xend/image.py +52 -25

134 lines not on this page · raw message

tools/python/xen/xm/create.py +7 -2
Index: xen-unstable/tools/python/xen/xm/create.py
===================================================================
@@ -481,6 +481,11 @@ def configure_image(vals):
     if vals.extra:
         config_image.append(['args', vals.extra])
 
+    args = [ 'vnc', 'sdl', 'display', 'xauthority' ]
+    for a in args:
+        if (vals.__dict__[a]):
+            config_image.append([a, vals.__dict__[a]])
+
     if vals.builder == 'hvm':
         configure_hvm(config_image, vals)
         
@@ -636,8 +641,8 @@ def configure_hvm(config_image, vals):
     """
     args = [ 'device_model', 'pae', 'vcpus', 'boot', 'fda', 'fdb',
              'localtime', 'serial', 'stdvga', 'isa', 'nographic', 'soundhw',
-             'vnc', 'vncdisplay', 'vncunused', 'vncconsole', 'sdl', 'display',
-             'acpi', 'apic', 'xauthority', 'usb', 'usbdevice' ]
+             'vncdisplay', 'vncunused', 'vncconsole',
+             'acpi', 'apic', 'usb', 'usbdevice' ]
     for a in args:
         if (vals.__dict__[a]):
             config_image.append([a, vals.__dict__[a]])

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 2 lines · Charles Coffing

It seems that discussion of the virtual frame buffer has died down; I assume this is being held off until after 3.0.3 splits...

I sent a new set of patches about a week ago. There was then a rundown of some concerns and Markus has gone through and fixed up most of those. I'll hopefully be posting an updated series with the patches later today -- just a matter of integrating the fixes, splitting out patches, etc.

Quoted 8 lines

Nevertheless, I was playing with it and wanted to put this patch out for discussion. This patch is a rough attempt to make the SDL/VNC viewers behave similarly for both paravirtual and fully virtual domains. For example, if you specify "sdl=1" in a paravirtual config file, "xm create" will cause sdlfb to start automatically.

My desire is to make para vs. full not appear so different to the casual user. Config file syntax should be similar, viewers should start in similar ways, etc.

Agree 100% -- my last set of patches mostly implemented everything needed here. I think the only thing that's not being done similar between PV and FV with them is vncviewer. Which should be pretty trivial, it's just not one that I regularly use so I haven't gotten the itch.

Jeremy