Skip to contentSkip to conversation

cpufreq: nforce2: Remove meaningless return

PATCH In review Yangtao Li 3 participants 3 messages Dec 5, 2018 – Dec 17, 2018 CPU frequency scaling framework

lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH v2 1/1 cpufreq: nforce2: Remove meaningless return

Delete a line of meaningless return and some useless blank lines. In a function whose return type is void, returning on the last line is not required.

---
Changes in v2:
-revert modify of MODULE_
-delete some blank lines

---
 drivers/cpufreq/cpufreq-nforce2.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/cpufreq/cpufreq-nforce2.c +0 -3
index dbf82f36d270..33c309a08c64 100644
@@ -123,8 +123,6 @@ static void nforce2_write_pll(int pll)
 	/* Now write the value in all 64 registers */
 	for (temp = 0; temp <= 0x3f; temp++)
 		pci_write_config_dword(nforce2_dev, NFORCE2_PLLREG, pll);
-
-	return;
 }
 
 /**
@@ -438,4 +436,3 @@ static void __exit nforce2_exit(void)
 
 module_init(nforce2_init);
 module_exit(nforce2_exit);
-
Signature · 1 line
2.17.0
maintainer Acked-by on v2 1/1
#1 lore raw

Review

Quoted 11 lines · Yangtao Li

Delete a line of meaningless return and some useless blank lines. In a function whose return type is void, returning on the last line is not required.

---
Changes in v2:

(quoted diff) +0 -3
-revert modify of MODULE_
-delete some blank lines
---
 drivers/cpufreq/cpufreq-nforce2.c | 3 ---
 1 file changed, 3 deletions(-)
Signature · 1 line
viresh
#2 lore raw
Quoted 4 lines · CET Viresh Kumar
Quoted 3 lines · Yangtao Li

Delete a line of meaningless return and some useless blank lines. In a function whose return type is void, returning on the last line is not required.

Quoted 10 lines

Review

Quoted 8 lines

---
Changes in v2:

(quoted diff) +0 -3
-revert modify of MODULE_
-delete some blank lines
---
 drivers/cpufreq/cpufreq-nforce2.c | 3 ---
 1 file changed, 3 deletions(-)

Patch applied, thanks!