Skip to contentSkip to conversation

_snd_cmipci_uswitch_put doesn't set zero flags

PATCH In review Timofei V. Bondarenko 2 participants 2 messages Dec 20, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 _snd_cmipci_uswitch_put doesn't set zero flags

Hi.

Playing with spdif output on cmipci i've noticed the SPDO5V option does not change appropriate bits the register.

The _snd_cmipci_uswitch_put checks the change in flags in wrong way.
If 'active' state of an option corresponds to a _zero_ bits in a hw register then function fails. The SPDO5V is the sample. In the most cases 'active' state of option is set through an non-zerio bits in a register. This case works fine.

The fix attached.
Unfortunately i was unable to change spdif output voltage anyway. Although the register changes right at least.

Regards.
Tim.

cmipci.c renamed from cmipci.c.old +2 -1
@@ -2198,7 +2198,8 @@ static int _snd_cmipci_uswitch_put(struc
 		val = inb(cm->iobase + args->reg);
 	else
 		val = snd_cmipci_read(cm, args->reg);
-	change = (val & args->mask) != (ucontrol->value.integer.value[0] ? args->mask : 0);
+	change = (val & args->mask) != (ucontrol->value.integer.value[0] ? 
+			args->mask_on : (args->mask & ~args->mask_on));
 	if (change) {
 		val &= ~args->mask;
 		if (ucontrol->value.integer.value[0])

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#1 lore raw

At Wed, 20 Dec 2006 19:09:24 +0300,

Quoted 12 lines · Timofei V. Bondarenko

Hi.

Playing with spdif output on cmipci i've noticed the SPDO5V option does not change appropriate bits the register.

The _snd_cmipci_uswitch_put checks the change in flags in wrong way. If 'active' state of an option corresponds to a _zero_ bits in a hw register then function fails. The SPDO5V is the sample.
In the most cases 'active' state of option is set through an non-zerio bits in a register. This case works fine.

Quoted 3 lines

The fix attached.
Unfortunately i was unable to change spdif output voltage anyway. Although the register changes right at least.

Thanks, I applied it to HG tree now.

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV