Skip to contentSkip to conversation

linux-2.6.21: apm.c remove unused variables

KJ walter harms 2 participants 4 messages May 11, 2007 – May 28, 2007 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hello list,

this patch removes the unused variables
clock_cmos_diff
got_clock_diff
from apm.c

note:
an other clock_cmos_diff is defined (and used):
x86_64/kernel/time.c:static long clock_cmos_diff;

arch/i386/kernel/apm.c 2007-05-11 15:25:47.000000000 +0200 renamed from arch/i386/kernel/apm.c.org 2007-05-11 15:25:06.000000000 +0200 +0 -8
@@ -383,14 +383,6 @@
 static int                     ignore_sys_suspend;
 static int                     ignore_normal_resume;
 static int                     bounce_interval __read_mostly = DEFAULT_BOUNCE_INTERVAL;
-
-#ifdef CONFIG_APM_RTC_IS_GMT
-#      define  clock_cmos_diff 0
-#      define  got_clock_diff  1
-#else
-static long                    clock_cmos_diff;
-static int                     got_clock_diff;
-#endif
 static int                     debug __read_mostly;
 static int                     smp __read_mostly;
 static int                     apm_disabled = -1;

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

#1 lore raw

hi list,
i did not get any comment about this patch. does that mean everyone is happy ?

re,
wh

Quoted 32 lines · walter harms

Hello list,

this patch removes the unused variables
clock_cmos_diff
got_clock_diff
from apm.c

note:
an other clock_cmos_diff is defined (and used):
x86_64/kernel/time.c:static long clock_cmos_diff;

arch/i386/kernel/apm.c 2007-05-11 15:25:47.000000000 +0200 renamed from arch/i386/kernel/apm.c.org 2007-05-11 15:25:06.000000000 +0200 +0 -8
@@ -383,14 +383,6 @@
 static int                     ignore_sys_suspend;
 static int                     ignore_normal_resume;
 static int                     bounce_interval __read_mostly = DEFAULT_BOUNCE_INTERVAL;
-
-#ifdef CONFIG_APM_RTC_IS_GMT
-#      define  clock_cmos_diff 0
-#      define  got_clock_diff  1
-#else
-static long                    clock_cmos_diff;
-static int                     got_clock_diff;
-#endif
 static int                     debug __read_mostly;
 static int                     smp __read_mostly;
 static int                     apm_disabled = -1;
Quoted 7 lines

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

#3 lore raw
In reply to walter harms

thx for info

Quoted 13 lines · Florian Westphal
Quoted 1 line · walter harms

i did not get any comment about this patch. does that mean everyone is happy ?

These changes are already in Linus' tree (commit 78eea47ac3e256559d97f0c2434928be39cba524).

Florian
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors