Skip to contentSkip to conversation

remove unnecessary execute perms

PATCH New Charles Coffing 1 participant 1 message May 22, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove unnecessary execute perms

Hi,

rpmlint complains that various blktap files are installed with unnecessary execute permissions:

E: xen-devel spurious-executable-perm (Badness: 100) /usr/lib64/libblktap.a
E: xen-devel spurious-executable-perm (Badness: 100) /usr/include/blktaplib.h

The patch below fixes the problem. It applies against xen-unstable.

Thank you.

tools/blktap/lib/Makefile 2007-05-22 14:01:46.000000000 -0600 renamed from tools/blktap/lib/Makefile 2007-03-12 09:01:04.000000000 -0600 +2 -2
diff -ru xen-unstable.hg/tools/blktap/lib/Makefile xen-unstable/tools/blktap/lib/Makefile
@@ -42,10 +42,10 @@
 install: all
        $(INSTALL_DIR) $(DESTDIR)/usr/$(LIBDIR)
        $(INSTALL_DIR) $(DESTDIR)/usr/include
-       $(INSTALL_PROG) $(LIB) $(DESTDIR)/usr/$(LIBDIR)
+       $(INSTALL_DATA) $(LIB) $(DESTDIR)/usr/$(LIBDIR)
        ln -sf libblktap.so.$(MAJOR).$(MINOR) $(DESTDIR)/usr/$(LIBDIR)/libblktap.so.$(MAJOR)
        ln -sf libblktap.so.$(MAJOR) $(DESTDIR)/usr/$(LIBDIR)/libblktap.so
-       $(INSTALL_PROG) blktaplib.h $(DESTDIR)/usr/include
+       $(INSTALL_DATA) blktaplib.h $(DESTDIR)/usr/include
 
 clean:
        rm -rf *.a *.so* *.o *.rpm $(LIB) *~ $(DEPS) xen TAGS