Skip to contentSkip to conversation

drbdadm segfaults with incorrect drbd.conf

Drbd-dev Dave Jiang 2 participants 3 messages Jun 20, 2007 – Jun 25, 2007 1 message not in the archive DRBD driver

lore
Share & tools
lore

Dave Jiang

author
#0 lore raw

It seems that when the resources aren't setup exactly right in drbd.conf drbdadm can segfault due to using a pointer that is NULL. Attached is a patch that fixes the issue.

Signature · 6 lines
------------------------------------------------------
Dave Jiang
Software Engineer
MontaVista Software, Inc.
http://www.mvista.com
------------------------------------------------------
user/drbdadm_main.c +4 -1
diff -Naurp drbd-8.0.3/user/drbdadm_main.c drbd-8.0.3-mod/user/drbdadm_main.c
@@ -1029,6 +1029,7 @@ struct d_resource* res_by_minor(const ch
   mm = m_strtoll(id+6,1);
 
   for_each_resource(res,t,config) {
+    if( !res->me ) continue;
     if( mm == dt_minor_of_dev(res->me->device)) return res;
   }
   return NULL;
@@ -1818,7 +1819,9 @@ int main(int argc, char** argv)
 
     highest_minor=0;
     for_each_resource(res,tmp,config) {
-      int m = dt_minor_of_dev(res->me->device);
+      int m;
+      if ( !res->me ) continue;
+      m = dt_minor_of_dev(res->me->device);
       if ( m > highest_minor ) highest_minor = m;
       nr_resources++;
     }
maintainer
#1 lore raw
Quoted 3 lines · On Wednesday 20 June 2007 18:34:03 Dave Jiang wrote:

It seems that when the resources aren't setup exactly right in drbd.conf drbdadm can segfault due to using a pointer that is NULL. Attached is a patch that fixes the issue.

Could you provide such an drbd.conf file as well, so that we can see the issue, that gets fixed by the patch ?

Thanks!

-Phil

Signature · 3 lines
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Vivenotgasse 48, 1120 Vienna, Austria        http://www.linbit.com :

A message that is not in the archive (sent off-list or not yet received): [email protected]

maintainer
#3 lore raw
Quoted 6 lines · On Wednesday 20 June 2007 20:08:30 Dave Jiang wrote:
Quoted 5 lines · Philipp Reisner
Quoted 3 lines · On Wednesday 20 June 2007 18:34:03 Dave Jiang wrote:

It seems that when the resources aren't setup exactly right in drbd.conf drbdadm can segfault due to using a pointer that is NULL. Attached is a patch that fixes the issue.

Quoted 8 lines
Quoted 6 lines

Could you provide such an drbd.conf file as well, so that we can see the issue, that gets fixed by the patch ?

Thanks!

-Phil

Ah I got one that does it. You can use it as it is.

Hi Dave,

Now I understand what you wanted to fix ;) I did a patch that rejects such config files beforehand.

http://lists.linbit.com/pipermail/drbd-cvs/2007-June/001562.html

-phil

Signature · 3 lines
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Vivenotgasse 48, 1120 Vienna, Austria        http://www.linbit.com :

#

# drbd.conf example
#
# parameters you _need_ to change are the hostname, device, disk,
# meta-disk, address and port in the "on <hostname> {}" sections.
#
# you ought to know about the protocol, and the various timeouts.
#
# you probably want to set the rate in the syncer sections

#
# NOTE common pitfall:

# rate is given in units of _byte_ not bit
#

#

# increase timeout and maybe ping-int in net{}, if you see
# problems with "connection lost/connection established"
# (or change your setup to reduce network latency; make sure full
#  duplex behaves as such; check average roundtrip times while
#  network is saturated; and so on ...)
#

skip {
As you can see, you can also comment chunks of text with a 'skip[optional nonsense]{ skipped text }' section. This comes in handy, if you just want to comment out some 'resource <some name> {...}' section:
just precede it with 'skip'.

The basic format of option assignment is
<option name><linear whitespace><value>;

It should be obvious from the examples below,
but if you really care to know the details:

<option name> :=
valid options in the respective scope
<value> := <num>|<string>|<choice>|...
depending on the set of allowed values for the respective option.
<num> := [0-9]+, sometimes with an optional suffix of K,M,G
<string> := (<name>|\"([^\"\\\n]*|\\.)*\")+
<name> := [/_.A-Za-z0-9-]+
}

#
# At most ONE global section is allowed.
# It must precede any resource section.
#
global {
# By default we load the module with a minor-count of 32. In case you # have more devices in your config, the module gets loaded with # a minor-count that ensures that you have 10 minors spare. # In case 10 spare minors are too little for you, you can set the # minor-count exeplicit here. ( Note, in contrast to DRBD-0.7 an # unused, spare minor has only a very little overhead of allocated # memory (a single pointer to be exact). )
#
# minor-count 64;

# The user dialog counts and displays the seconds it waited so # far. You might want to disable this if you have the console # of your server connected to a serial terminal server with # limited logging capacity.
# The Dialog will print the count each 'dialog-refresh' seconds, # set it to 0 to disable redrawing completely. [ default = 1 ] #
# dialog-refresh 5; # 5 seconds

# You might disable one of drbdadm's sanity check. # disable-ip-verification;

# Participate in DRBD's online usage counter at http://usage.drbd.org
# possilbe options: ask, yes, no. Default is ask. In case you do not # know, set it to ask, and follow the on screen instructions later. usage-count yes;
}

#
# The common section can have all the sections a resource can have but

# not the host section (started with the "on" keyword).
# The common section must precede all resources.
# All resources inherit the settings from the common section.
# Whereas settings in the resources have precedence over the common
# setting.
#

common {
syncer { rate 10M; }
}

#

# this need not be r#, you may use phony resource names,
# like "resource web" or "resource mail", too
#

resource r0 {

  # transfer protocol to use.
  # C: write IO is reported as completed, if we know it has
  #    reached _both_ local and remote DISK.
  #    * for critical transactional data.
  # B: write IO is reported as completed, if it has reached
  #    local DISK and remote buffer cache.
  #    * for most cases.
  # A: write IO is reported as completed, if it has reached
  #    local DISK and local tcp send buffer. (see also sndbuf-size)
  #    * for high latency networks
  #
  #**********
  # uhm, benchmarks have shown that C is actually better than B.
  # this note shall disappear, when we are convinced that B is
  # the right choice "for most cases".
  # Until then, always use C unless you have a reason not to.
  #	--lge
  #**********
  #
  protocol C;
  handlers {
    # what should be done in case the node is primary, degraded
    # (=no connection) and has inconsistent data.
    pri-on-incon-degr "echo o > /proc/sysrq-trigger ; halt -f";

# The node is currently primary, but lost the after split brain # auto recovery procedure. As as consequence it should go away. pri-lost-after-sb "echo o > /proc/sysrq-trigger ; halt -f";

# In case you have set the on-io-error option to "call-local-io-error", # this script will get executed in case of a local IO error. It is # expected that this script will case a immediate failover in the # cluster.
local-io-error "echo o > /proc/sysrq-trigger ; halt -f";

# Commands to run in case we need to downgrade the peer's disk
# state to "Outdated". Should be implemented by the superior
# communication possibilities of our cluster manager.
# The provided script uses ssh, and is for demonstration/development
# purposis.
# outdate-peer "/usr/lib/drbd/outdate-peer.sh on amd 192.168.22.11 192.168.23.11 on alf 192.168.22.12 192.168.23.12"; #
# Update: Now there is a solution that relies on heartbeat's
# communication layers. You should really use this.
outdate-peer "/usr/sbin/drbd-peer-outdater";
}

  startup {
    # Wait for connection timeout.
    # The init script blocks the boot process until the resources
    # are connected. This is so when the cluster manager starts later,
    # it does not see a resource with internal split-brain.
    # In case you want to limit the wait time, do it here.
    # Default is 0, which means unlimited. Unit is seconds.
    #
    # wfc-timeout  0;

# Wait for connection timeout if this node was a degraded cluster. # In case a degraded cluster (= cluster with only one node left) # is rebooted, this timeout value is used.
#
degr-wfc-timeout 120; # 2 minutes.
}

  disk {
    # if the lower level device reports io-error you have the choice of
    #  "pass_on"  ->  Report the io-error to the upper layers.
    #                 Primary   -> report it to the mounted file system.
    #                 Secondary -> ignore it.
    #  "call-local-io-error"
    #	          ->  Call the script configured by the name "local-io-error".
    #  "detach"   ->  The node drops its backing storage device, and
    #                 continues in disk less mode.
    #
    on-io-error   detach;

    # Controls the fencing policy, default is "dont-care". Before you
    # set any policy you need to make sure that you have a working
    # outdate-peer handler. Possible values are:
    #  "dont-care"     -> Never call the outdate-peer handler. [ DEFAULT ]
    #  "resource-only" -> Call the outdate-peer handler if we primary and
    #			  loose the connection to the secondary. As well
    #			  whenn a unconnected secondary wants to become
    #			  primary.
    #  "resource-and-stonith"
    #                  -> Calls the outdate-peer handler and freezes local
    #                     IO immediately after loss of connection. This is
    #			  necessary if your heartbeat can STONITH the other
    #                     node.
    # fencing resource-only;

    # In case you only want to use a fraction of the available space
    # you might use the "size" option here.
    #
    # size 10G;

}

  net {
    # this is the size of the tcp socket send buffer
    # increase it _carefully_ if you want to use protocol A over a
    # high latency network with reasonable write throughput.
    # defaults to 2*65535; you might try even 1M, but if your kernel or
    # network driver chokes on that, you have been warned.
    # sndbuf-size 512k;
    # timeout       60;    #  6 seconds  (unit = 0.1 seconds)
    # connect-int   10;    # 10 seconds  (unit = 1 second)
    # ping-int      10;    # 10 seconds  (unit = 1 second)
    # ping-timeout   5;    # 500 ms (unit = 0.1 seconds)

# Maximal number of requests (4K) to be allocated by DRBD. # The minimum is hardcoded to 32 (=128 kByte).
# For high performance installations it might help if you # increase that number. These buffers are used to hold # datablocks while they are written to disk.
#
# max-buffers 2048;

# When the number of outstanding requests on a standby (secondary) # node exceeds bdev-threshold, we start to kick the backing device # to start its request processing. This is an advanced tuning # parameter to get more performance out of capable storage controlers. # Some controlers like to be kicked often, other controlers # deliver better performance when they are kicked less frequently. # Set it to the value of max-buffers to get the least possible # number of run_task_queue_disk() / q->unplug_fn(q) calls. #
# unplug-watermark 128;

# The highest number of data blocks between two write barriers. # If you set this < 10 you might decrease your performance. # max-epoch-size 2048;

# if some block send times out this many times, the peer is # considered dead, even if it still answers ping requests. # ko-count 4;

# If you want to use OCFS2/openGFS on top of DRBD enable # this optione, and only enable it if you are going to use # one of these filesystems. Do not enable it for ext2, # ext3,reiserFS,XFS,JFS etc...
# allow-two-primaries;

# This enables peer authentication. Without this everybody # on the network could connect to one of your DRBD nodes with # a program that emulates DRBD's protocoll and could suck off # all your data.
# Specify one of the kernel's digest algorithms, e.g.:
# md5, sha1, sha256, sha512, wp256, wp384, wp512, michael_mic ... # an a shared secret.
# Authentication is only done once after the TCP connection # is establised, there are no disadvantages from using authentication, # therefore I suggest to enable it in any case.
# cram-hmac-alg "sha1";
# shared-secret "FooFunFactory";

# In case the nodes of your cluster nodes see each other again, after # an split brain situation in which both nodes where primary # at the same time, you have two diverged versions of your data. #
# In case both nodes are secondary you can control DRBD's # auto recovery strategy by the "after-sb-0pri" options. The # default is to disconnect.
# "disconnect" ... No automatic resynchronisation, simply disconnect.
# "discard-younger-primary"
# Auto sync from the node that was primary before
# the split brain situation happened.
# "discard-older-primary"
# Auto sync from the node that became primary
# as second during the split brain situation.
# "discard-least-changes"
# Auto sync from the node that touched more
# blocks during the split brain situation.
# "discard-node-NODENAME"
# Auto sync _to_ the named node.
after-sb-0pri disconnect;

# In one of the nodes is already primary, then the auto-recovery # strategie is controled by the "after-sb-1pri" options.
# "disconnect" ... always disconnect
# "consensus" ... discard the version of the secondary if the outcome
# of the "after-sb-0pri" algorithm would also destroy
# the current secondary's data. Otherwise disconnect.
# "violently-as0p" Always take the decission of the "after-sb-0pri"
# algorithm. Even if that causes case an erratic change
# of the primarie's view of the data.
# This is only usefull if you use an 1node FS (i.e.
# not OCFS2 or GFS) with the allow-two-primaries
# flag, _AND_ you really know what you are doing.
# This is DANGEROUS and MAY CRASH YOUR MACHINE if you
# have a FS mounted on the primary node.
# "discard-secondary"
# discard the version of the secondary.
# "call-pri-lost-after-sb" Always honour the outcome of the "after-sb-0pri"
# algorithm. In case it decides the the current
# secondary has the right data, it panics the
# current primary.
# "suspend-primary" ???
after-sb-1pri disconnect;

# In case both nodes are primary you control DRBD's strategy by # the "after-sb-2pri" option.
# "disconnect" ... Go to StandAlone mode on both sides.
# "violently-as0p" Always take the decission of the "after-sb-0pri".
# "call-pri-lost-after-sb" ... Honor the outcome of the "after-sb-0pri"
# algorithm and panic the other node.

after-sb-2pri disconnect;

# To solve the cases when the outcome of the resync descissions is # incompatible to the current role asignment in the cluster.
# "disconnect" ... No automatic resynchronisation, simply disconnect.
# "violently" .... Sync to the primary node is allowed, violating the
# assumption that data on a block device is stable
# for one of the nodes. DANGEROUS, DO NOT USE.
# "call-pri-lost" Call the "pri-lost" helper program on one of the
# machines. This program is expected to reboot the
# machine. (I.e. make it secondary.)
rr-conflict disconnect;

# DRBD-0.7's behaviour is equivalent to
# after-sb-0pri discard-younger-primary;
# after-sb-1pri consensus;
# after-sb-2pri disconnect;
}

  syncer {
    # Limit the bandwith used by the resynchronisation process.
    # default unit is kByte/sec; optional suffixes K,M,G are allowed.
    #
    # Even though this is a network setting, the units are based
    # on _byte_ (octet for our french friends) not bit.
    # We are storage guys.
    #
    # Note that on 100Mbit ethernet, you cannot expect more than
    # 12.5 MByte total transfer rate.
    # Consider using GigaBit Ethernet.
    #
    rate 10M;

# Normally all devices are resynchronized parallel.
# To achieve better resynchronisation performance you should resync # DRBD resources which have their backing storage on one physical # disk sequentially. The express this use the "after" keyword. after "r2";

# Configures the size of the active set. Each extent is 4M, # 257 Extents ~> 1GB active set size. In case your syncer # runs @ 10MB/sec, all resync after a primary's crash will last # 1GB / ( 10MB/sec ) ~ 102 seconds ~ One Minute and 42 Seconds. # BTW, the hash algorithm works best if the number of al-extents # is prime. (To test the worst case performace use a power of 2) al-extents 257;
}

  on TARGET1 {
    device     /dev/drbd0;
    disk       /dev/sda2;
    address    10.40.20.47:7788;
    flexible-meta-disk  internal;

# on amd {

#    device     /dev/drbd0;
#    disk       /dev/hde5;
#    address    192.168.22.11:7788;
#    flexible-meta-disk  internal;
    # meta-disk is either 'internal' or '/dev/ice/name [idx]'
    #
    # You can use a single block device to store meta-data
    # of multiple DRBD's.
    # E.g. use meta-disk /dev/hde6[0]; and meta-disk /dev/hde6[1];
    # for two different resources. In this case the meta-disk
    # would need to be at least 256 MB in size.
    #
    # 'internal' means, that the last 128 MB of the lower device
    # are used to store the meta-data.
    # You must not give an index with 'internal'.
  }

# on alf {

#    device    /dev/drbd0;
#    disk      /dev/hdc5;
#    address   192.168.22.12:7788;
#    meta-disk internal;

# }
}

#
# yes, you may also quote the resource name.

# but don't include whitespace, unless you mean it :)
#
#resource "r1" {
#  protocol C;
#  startup {
#    wfc-timeout         0;  ## Infinite!
#    degr-wfc-timeout  120;  ## 2 minutes.
#  }
#  disk {
#    on-io-error detach;
#  }
#  net {
#    # timeout           60;
#    # connect-int       10;
#    # ping-int          10;
#    # max-buffers     2048;
#    # max-epoch-size  2048;
#  }
#  syncer {
#  }

# on amd {

#    device	/dev/drbd1;
#    disk	/dev/hde6;
#    address	192.168.22.11:7789;
#    meta-disk	/dev/somewhere [7];

# }

# on alf {

#    device     /dev/drbd1;
#    disk       /dev/hdc6;
#    address    192.168.22.12:7789;
#    meta-disk  /dev/somewhere [7];

# }
#}

#resource r2 {
# protocol C;
#

#  startup { wfc-timeout 0; degr-wfc-timeout 120; }
#  disk    { on-io-error detach; }
#  net     { timeout 60; connect-int 10; ping-int 10;

# max-buffers 2048; max-epoch-size 2048; }
# syncer { rate 4M; } # sync when r0 and r1 are finished syncing. # on amd {
# address 192.168.22.11:7790;
# disk /dev/hde7; device /dev/drbd2; meta-disk "internal";
# }
# on alf {
# device "/dev/drbd2"; disk "/dev/hdc7"; meta-disk "internal";
# address 192.168.22.12:7790;
# }
#}
#
#resource r3 {
# protocol C;
#

#  startup { wfc-timeout	0; degr-wfc-timeout	120; }
#  disk { on-io-error detach; }
#  syncer {
#  }
#  on amd {
#    device	/dev/drbd3;
#    disk	/dev/hde8;
#    address	192.168.22.11:7791;
#    meta-disk	internal;
#  }
#  on alf {
#    device	/dev/drbd3;
#    disk	/dev/hdc8;
#    address	192.168.22.12:7791;
#    meta-disk	/some/where[8];

# }
#}