Skip to contentSkip to conversation

EDD still failing on some systems with 2.6.23-rc6-git2

DISCUSSION Chuck Ebbert 2 participants 4 messages Sep 14, 2007 – Sep 17, 2007

lore
Share & tools
lore
#1 lore raw
Quoted 7 lines · Chuck Ebbert

I added debugging code to print a letter for each step in i386 setup, and it gets to 'J', then it hangs:

        /* Query EDD information */
#if defined(CONFIG_EDD) || defined(CONFIG_EDD_MODULE)
        putchar('J');
        query_edd();
Quoted 7 lines

#endif

Multiple reports of this happening on 2.6.23-rc6 can be found at the end of:

https://bugzilla.redhat.com/show_bug.cgi?id=251724
https://bugzilla.redhat.com/show_bug.cgi?id=239585

I just attached a test patch to the bug report shown above. If someone with access to the relevant hardware could test out the patch, I would greatly appreciate it.

-hpa

#2 lore raw
Quoted 13 lines · H. Peter Anvin
Quoted 12 lines · Chuck Ebbert

I added debugging code to print a letter for each step in i386 setup, and it gets to 'J', then it hangs:

        /* Query EDD information */
#if defined(CONFIG_EDD) || defined(CONFIG_EDD_MODULE)
        putchar('J');
        query_edd();

#endif

Multiple reports of this happening on 2.6.23-rc6 can be found at the end of:

Quoted 7 lines
Quoted 2 lines

https://bugzilla.redhat.com/show_bug.cgi?id=251724
https://bugzilla.redhat.com/show_bug.cgi?id=239585

I just attached a test patch to the bug report shown above. If someone with access to the relevant hardware could test out the patch, I would greatly appreciate it.

Still fails. And apparently fails on disk 0, because it hangs right after printing a zero:

arch/i386/boot/edd.c +1 -0
@@ -151,6 +151,7 @@ void query_edd(void)
                 * Scan the BIOS-supported hard disks and query EDD
                 * information...
                 */
+               putchar('0' + (devno - 0x80) % 10);
                get_edd_info(devno, &ei);
 
                if (boot_params.eddbuf_entries < EDDMAXNR) {
#3 lore raw
Quoted 7 lines · Chuck Ebbert

Still fails. And apparently fails on disk 0, because it hangs right after printing a zero:

arch/i386/boot/edd.c void query_edd(void) · line 157

Quoted 7 lines
arch/i386/boot/edd.c +1 -0
@@ -151,6 +151,7 @@ void query_edd(void)
                 * Scan the BIOS-supported hard disks and query EDD
                 * information...
                 */
+               putchar('0' + (devno - 0x80) % 10);
                get_edd_info(devno, &ei);
 
                if (boot_params.eddbuf_entries < EDDMAXNR) {

You know... we actually do have printf()... you don't have to play this kind of games; you can just printf("Drive %x...\n", devno);

So does this happen ONLY when booting from CD-ROM, or is there any other case when it fails, too?

-hpa