dt-bindings: mxsfb: Document i.MX8M power-domains property
Subsystems (4)
Marek Vasut
maintainerPATCH v2 1/1 dt-bindings: mxsfb: Document i.MX8M power-domains property
The power-domains property is mandatory on i.MX8M Mini, Nano, Plus. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.
---
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Liu Ying <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: - Add AB from Krzysztof
- Add mx6sx power domain into the list
--- .../devicetree/bindings/display/fsl,lcdif.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +15 -0
@@ -52,6 +52,9 @@ properties: interrupts: maxItems: 1 + power-domains: + maxItems: 1 + port: $ref: /schemas/graph.yaml#/properties/port description: The LCDIF output port
@@ -87,6 +90,18 @@ allOf: maxItems: 1 clock-names: maxItems: 1 + - if: + properties: + compatible: + contains: + enum: + - fsl,imx6sx-lcdif + - fsl,imx8mm-lcdif + - fsl,imx8mn-lcdif + - fsl,imx8mp-lcdif + then: + required: + - power-domains examples: - |
Signature · 1 line
2.35.1
Quoted 3 lines · Marek Vasut
The power-domains property is mandatory on i.MX8M Mini, Nano, Plus. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.
Please mention both i.MX6sl and i.MX6sx SoCs in the patch subject and commit message.
Quoted 37 lines
Signed-off-by Marek Vasut <[email protected]>---
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Liu Ying <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: - Add AB from Krzysztof
- Add mx6sx power domain into the list--- .../devicetree/bindings/display/fsl,lcdif.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+)Documentation/devicetree/bindings/display/fsl,lcdif.yaml +3
-0@@ -52,6 +52,9 @@ properties: interrupts: maxItems: 1 + power-domains: + maxItems: 1 + port: $ref: /schemas/graph.yaml#/properties/port description: The LCDIF output port
Documentation/devicetree/bindings/display/fsl,lcdif.yaml allOf: · line 97
Quoted 8 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +5
-0@@ -87,6 +90,18 @@ allOf: maxItems: 1 clock-names: maxItems: 1 + - if: + properties: + compatible: + contains: + enum:
As I mentioned in v1 review comment, please add '- fsl,imx6sl-lcdif' here too?
Documentation/devicetree/bindings/display/fsl,lcdif.yaml allOf: · line 104
Quoted 7 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +7
-0+ - fsl,imx6sx-lcdif + - fsl,imx8mm-lcdif + - fsl,imx8mn-lcdif + - fsl,imx8mp-lcdif + then: + required: + - power-domains
Now that this is required for i.MX6sx LCDIF, the examples needs to be updated to add the property for i.MX6sx LCDIF node. Otherwise, 'make dt_binding_check' would report error I think.
Regards,
Liu Ying
Quoted 3 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +0
-0examples: - |