Fixed pcnet io_base
PATCH 1/1 Fixed pcnet io_base
Bus and phys address are not always the same
--- drivers/pcnet.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/pcnet.c +1 -0
@@ -196,6 +196,7 @@ int pcnet_initialize(bd_t *bis)* Setup the PCI device. */ pci_read_config_dword (devbusfn,PCI_BASE_ADDRESS_0 , (unsigned int *)&dev->iobase); + dev->iobase=pci_io_to_phys (devbusfn,dev->iobase); dev->iobase &= ~0xf ; PCNET_DEBUG1("%s: devbusfn=0x%x iobase=0x%x: ",
Signature · 1 line
1.5.2.2
PATCH 1/1 Fixed pcnet io_base
Dear Ben,
this patch is still on my "open" list. Can you please review and apply if it makes sense to you? Thanks.
------- Forwarded Message
Date: Wed, 10 Oct 2007 23:02:09 +0300 From: Vlad Lungu <[email protected]> To: u-boot-users at lists.sourceforge.net, wd at denx.de Subject: [PATCH] Fixed pcnet io_base
Bus and phys address are not always the same
--- drivers/pcnet.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/pcnet.c +0 -0
@@ -196,6 +196,7 @@ int pcnet_initialize(bd_t *bis)* Setup the PCI device. */ pci_read_config_dword(devbusfn, PCI_BASE_ADDRESS_0, (unsigned int *)&de
v->iobase);
+ dev->iobase=pci_io_to_phys(devbusfn,dev->iobase);
dev->iobase &= ~0xf;
PCNET_DEBUG1("%s: devbusfn=0x%x iobase=0x%x: ",
Signature · 16 lines
1.5.2.2 ------- End of Forwarded Message Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Where a calculator on the ENIAC is equipped with 18,000 vacuum tubes and weighs 30 tons, computers in the future may have only 1,000 vacuum tubes and weigh only 1/2 tons. - Popular Mechanics, March 1949
PATCH 1/1 Fixed pcnet io_base
Hi Wolfgang,
Quoted 6 lines · Wolfgang Denk
Dear Ben,
this patch is still on my "open" list. Can you please review and apply if it makes sense to you? Thanks.
This looks OK to me. Assuming that pci_io_to_phys() is defined on all relevant architectures, I have no objections. Unfortunately I can't run MAKEALL right now, so if it's not too much of a bother please pull directly. We can always pull it out if there's a problem, I guess.
regards,
Ben
Quoted 45 lines
------- Forwarded Message
Date: Wed, 10 Oct 2007 23:02:09 +0300 From: Vlad Lungu <[email protected]> To: u-boot-users at lists.sourceforge.net, wd at denx.deSubject: [PATCH] Fixed pcnet
io_baseBus and phys address are not always the same
Signed-off-by Vlad Lungu <[email protected]>---
drivers/pcnet.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)diff --git
a/drivers/pcnet.cb/drivers/pcnet.c
index 2af0e8f..22edb48 100644
---a/drivers/pcnet.c
+++b/drivers/pcnet.c
@@ -196,6 +196,7 @@ intpcnet_initialize(bd_t *bis)
* Setup the PCI device.
*/
pci_read_config_dword(devbusfn,PCI_BASE_ADDRESS_0, (unsigned int *)&de
v->iobase);+ dev->iobase=pci_io_to_phys(devbusfn,dev->iobase); dev->iobase &= ~0xf; PCNET_DEBUG1("%s: devbusfn=0x%x iobase=0x%x: ",--
1.5.2.2------- End of Forwarded Message
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Where a calculator on the ENIAC is equipped with 18,000 vacuum tubes and weighs 30 tons, computers in the future may have only 1,000 vacuum tubes and weigh only 1/2 tons. - Popular Mechanics, March 1949
Wolfgang Denk
AppliedPATCH 1/1 Fixed pcnet io_base
Quoted 8 lines · In message <[email protected]> you…
Quoted 3 lines
this patch is still on my "open" list. Can you please review and apply if it makes sense to you? Thanks.
This looks OK to me. Assuming that
pci_io_to_phys()is defined on all relevant architectures, I have no objections. Unfortunately I can't run MAKEALL right now, so if it's not too much of a bother please pull directly. We can always pull it out if there's a problem, I guess.
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Any sufficiently advanced technology is indistinguishable from magic.
Clarke's Third Law - _Profiles of the Future_ (1962; rev. 1973)
``Hazards of Prophecy: The Failure of Imagination''Wolfgang Denk
AppliedPATCH 1/1 Fixed pcnet io_base
In reply to Vlad LunguQuoted 6 lines · In message <[email protected]> you wrote:
Bus and phys address are not always the same
Signed-off-by Vlad Lungu <[email protected]>--- drivers/pcnet.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Data is a lot like humans: It is born. Matures. Gets married to other data, divorced. Gets old. One thing that it doesn't do is die. It has to be killed." - Arthur Miller