Skip to contentSkip to conversation

linux/i386: Use symbolic constants in dump_fault_path()

PATCH New Jan Beulich 1 participant 1 message Dec 6, 2007

lore
Share & tools
lore

Jan Beulich

author
#0 lore raw

PATCH 1/1 linux/i386: Use symbolic constants in dump_fault_path()

As usual, written and tested against 2.6.24-rc3 and made apply against 2.6.18 without further testing.

Signed-off-by Jan Beulich <[email protected]>
arch/i386/mm/fault-xen.c +2 -2
Index: head-2007-11-30/arch/i386/mm/fault-xen.c
===================================================================
@@ -231,7 +226,7 @@ static void dump_fault_path(unsigned lon
 	p  = (unsigned long *)__va(page);
 	p += (address >> 30) * 2;
 	printk(KERN_ALERT "%08lx -> *pde = %08lx:%08lx\n", page, p[1], p[0]);
-	if (p[0] & 1) {
+	if (p[0] & _PAGE_PRESENT) {
 		mfn  = (p[0] >> PAGE_SHIFT) | (p[1] << 20);
 		page = mfn_to_pfn(mfn) << PAGE_SHIFT; 
 		p  = (unsigned long *)__va(page);

@@ -244,7 +239,7 @@ static void dump_fault_path(unsigned lon
 		if (mfn_to_pfn(mfn) >= highstart_pfn)
 			return;
 #endif
-		if (p[0] & 1) {
+		if (p[0] & _PAGE_PRESENT) {
 			page = mfn_to_pfn(mfn) << PAGE_SHIFT; 
 			p  = (unsigned long *) __va(page);
 			address &= 0x001fffff;