Skip to contentSkip to conversation

xen: fiddle_vdso() must be __init

PATCH In review Adrian Bunk 2 participants 2 messages Dec 11, 2007

Subsystems (2)
x86 Xen hypervisor x86
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 xen: fiddle_vdso() must be __init

This patch fixes the following section mismatch:

<-- snip -->

...
WARNING: vmlinux.o(.text+0x2589): Section mismatch: reference to .init.data:vsyscall_int80_start (between 'fiddle_vdso' and 'xen_setup_features')
...

<-- snip -->

Signed-off-by Adrian Bunk <[email protected]>

---
bd7d683674d639a57c73b316972a28df43690a17

arch/x86/xen/setup.c +1 -1
index f84e772..5e24f67 100644
@@ -59,7 +59,7 @@ static void xen_idle(void)
 /*
  * Set the bit indicating "nosegneg" library variants should be used.
  */
-static void fiddle_vdso(void)
+static void __init fiddle_vdso(void)
 {
 	extern u32 VDSO_NOTE_MASK; /* See ../kernel/vsyscall-note.S.  */
 	extern char vsyscall_int80_start;
#1 lore raw
Quoted 7 lines · Adrian Bunk

This patch fixes the following section mismatch:

<-- snip -->

...
WARNING: vmlinux.o(.text+0x2589): Section mismatch: reference to .init.data:vsyscall_int80_start (between 'fiddle_vdso' and 'xen_setup_features')

Jan Beulich just posted a patch to do this, which I acked.

J

Quoted 23 lines

...

<-- snip -->

Signed-off-by Adrian Bunk <[email protected]>

---
bd7d683674d639a57c73b316972a28df43690a17

arch/x86/xen/setup.c +1 -1
index f84e772..5e24f67 100644
@@ -59,7 +59,7 @@ static void xen_idle(void)
 /*
  * Set the bit indicating "nosegneg" library variants should be used.
  */
-static void fiddle_vdso(void)
+static void __init fiddle_vdso(void)
 {
 	extern u32 VDSO_NOTE_MASK; /* See ../kernel/vsyscall-note.S.  */
 	extern char vsyscall_int80_start;