Skip to contentSkip to conversation

add SMSC LAN9x1x Network driver

PATCH New Guennadi Liakhovetski 7 participants 14 messages Mar 26, 2008 – Apr 14, 2008 Network drivers

lore
Share & tools
lore

Guennadi Liakhovetski

author
#0 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

From: Sascha Hauer <[email protected]>

This patch adds a driver for the following smsc network controllers:
LAN9115
LAN9116
LAN9117
LAN9215
LAN9216
LAN9217

Signed-off-by Sascha Hauer <[email protected]>
Signed-off-by Guennadi Liakhovetski <[email protected]>

---

Changes since v1: Removed C++ style comments

 drivers/net/Makefile  |    1 +
 drivers/net/smc911x.c |  668 +++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 669 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/smc911x.c
drivers/net/Makefile +1 -0
index 320dc3e..9482398 100644
@@ -54,6 +54,7 @@ COBJS-y += rtl8139.o
 COBJS-y += rtl8169.o
 COBJS-y += s3c4510b_eth.o
 COBJS-y += smc91111.o
+COBJS-y += smc911x.o
 COBJS-y += tigon3.o
 COBJS-y += tsec.o
 COBJS-y += tsi108_eth.o
drivers/net/smc911x.c new file +667 -0

667 lines not on this page · raw message

Signature · 1 line
1.5.4
#1 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

Hi Guennadi,

Quoted 11 lines · Guennadi Liakhovetski

From: Sascha Hauer <[email protected]>

This patch adds a driver for the following smsc network controllers:
LAN9115
LAN9116
LAN9117
LAN9215
LAN9216
LAN9217

How many of these have been tested, and on what platforms. I'm asking because the code seems to assume a 32-bit interface and these aren't all 32-bit chips.

Quoted 49 lines
Signed-off-by Sascha Hauer <[email protected]>
Signed-off-by Guennadi Liakhovetski <[email protected]>

---

Changes since v1: Removed C++ style comments

 drivers/net/Makefile  |    1 +
 drivers/net/smc911x.c |  668 +++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 669 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/smc911x.c
drivers/net/Makefile +1 -0
index 320dc3e..9482398 100644
@@ -54,6 +54,7 @@ COBJS-y += rtl8139.o
 COBJS-y += rtl8169.o
 COBJS-y += s3c4510b_eth.o
 COBJS-y += smc91111.o
+COBJS-y += smc911x.o
 COBJS-y += tigon3.o
 COBJS-y += tsec.o
 COBJS-y += tsi108_eth.o
drivers/net/smc911x.c new file +18 -0
new file mode 100644
index 0000000..5830368
@@ -0,0 +1,667 @@
+/*
+ * SMSC LAN9[12]1[567] Network driver
+ *
+ * (c) 2007 Pengutronix, Sascha Hauer <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *

drivers/net/smc911x.c line 28

Quoted 10 lines
drivers/net/smc911x.c new file +10 -0
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+
+#ifdef CONFIG_DRIVER_SMC911X
+

This should be moved to the Makefile. Looks like I beat J-C to this one...

drivers/net/smc911x.c line 36

Quoted 9 lines
drivers/net/smc911x.c new file +8 -0
+#include <command.h>
+#include <net.h>
+#include <miiphy.h>
+
+#define mdelay(n)       udelay((n)*1000)
+
+#define __REG(x)     (*((volatile u32 *)(x)))
+

See, you're assuming 32-bit accesses. That should be configurable, I think

Quoted 11 lines
drivers/net/smc911x.c new file +10 -0
+/* Below are the register offsets and bit definitions
+ * of the Lan911x memory space
+ */
+#define RX_DATA_FIFO		 __REG(CONFIG_DRIVER_SMC911X_BASE + 0x00)
+
+#define TX_DATA_FIFO		 __REG(CONFIG_DRIVER_SMC911X_BASE + 0x20)
+#define	TX_CMD_A_INT_ON_COMP			(0x80000000)
+#define	TX_CMD_A_INT_BUF_END_ALGN		(0x03000000)
+#define	TX_CMD_A_INT_4_BYTE_ALGN		(0x00000000)
+#define	TX_CMD_A_INT_16_BYTE_ALGN		(0x01000000)

drivers/net/smc911x.c line 56

Quoted 10 lines
drivers/net/smc911x.c new file +10 -0
+#define	TX_CMD_A_INT_32_BYTE_ALGN		(0x02000000)
+#define	TX_CMD_A_INT_DATA_OFFSET		(0x001F0000)
+#define	TX_CMD_A_INT_FIRST_SEG			(0x00002000)
+#define	TX_CMD_A_INT_LAST_SEG			(0x00001000)
+#define	TX_CMD_A_BUF_SIZE			(0x000007FF)
+#define	TX_CMD_B_PKT_TAG			(0xFFFF0000)
+#define	TX_CMD_B_ADD_CRC_DISABLE		(0x00002000)
+#define	TX_CMD_B_DISABLE_PADDING		(0x00001000)
+#define	TX_CMD_B_PKT_BYTE_LENGTH		(0x000007FF)
+

Register and bitfield definitions should be in a header file. More generally, only register addresses and bitfields should be defined. Using macros to encapsulate both address and function is bad form, IMHO. More on that later.
<snip>

drivers/net/smc911x.c line 380

Quoted 7 lines
drivers/net/smc911x.c new file +6 -0
+
+#define DRIVERNAME "smc911x"
+
+u32 smc911x_get_mac_csr(u8 reg)
+{
+	while (MAC_CSR_CMD & MAC_CSR_CMD_CSR_BUSY);

Using macros like this is both unreadable and hard to debug. Instead, consider something like:

    while (reg_read(MAC_CSR) & MAC_CSR_BUSY));

IMHO, one-liner while loops are bad too, but that's debatable.

I haven't even gotten into the functionality, because I think there's a lot of work to be done just in coding style before we look at substance.

regards,
Ben

author
#2 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

Hi Ben,

Quoted 14 lines · Ben Warren

Hi Guennadi,

Quoted 11 lines · Guennadi Liakhovetski

From: Sascha Hauer <[email protected]>

This patch adds a driver for the following smsc network controllers:
LAN9115
LAN9116
LAN9117
LAN9215
LAN9216
LAN9217

Quoted 2 lines

How many of these have been tested, and on what platforms. I'm asking because the code seems to assume a 32-bit interface and these aren't all 32-bit chips.

I'll let the author reply to all your question / take care of all your suggestions, apart, maybe from just one:

Quoted 9 lines

drivers/net/smc911x.c line 56

Quoted 8 lines
drivers/net/smc911x.c new file +7 -0
+#define	TX_CMD_A_INT_LAST_SEG			(0x00001000)
+#define	TX_CMD_A_BUF_SIZE			(0x000007FF)
+#define	TX_CMD_B_PKT_TAG			(0xFFFF0000)
+#define	TX_CMD_B_ADD_CRC_DISABLE		(0x00002000)
+#define	TX_CMD_B_DISABLE_PADDING		(0x00001000)
+#define	TX_CMD_B_PKT_BYTE_LENGTH		(0x000007FF)
+

Register and bitfield definitions should be in a header file. More generally,

I disagree with this. If only one .c file uses registers and bitfields and whatever other macros, I think, they better be defined in the .c file directly.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de

#3 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

In reply to Ben Warren
Quoted 22 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: 26 March 2008 20:08
To: Guennadi Liakhovetski
Cc: u-boot-users at lists.sourceforge.net; Wolfgang Denk; Peter Pearse
Subject: Re: [U-Boot-Users] [PATCH v2 4/7] add SMSC LAN9x1x Network driver

Hi Guennadi,

Quoted 11 lines · Guennadi Liakhovetski

From: Sascha Hauer <[email protected]>

This patch adds a driver for the following smsc network controllers:
LAN9115
LAN9116
LAN9117
LAN9215
LAN9216
LAN9217

Quoted 3 lines

How many of these have been tested, and on what platforms. I'm asking because the code seems to assume a 32-bit interface and these aren't all 32-bit chips.

Comments please Sascha.

---snip---

Quoted 4 lines

drivers/net/smc911x.c

Quoted 4 lines
drivers/net/smc911x.c new file renamed from drivers/net/smc911x.c +0 -0

mode 100644 index 0000000..5830368

drivers/net/smc911x.c new file +0 -0

---snip---

Quoted 5 lines

drivers/net/smc911x.c line 28

Quoted 4 lines
drivers/net/smc911x.c new file +3 -0
+
+#ifdef CONFIG_DRIVER_SMC911X
+

This should be moved to the Makefile.

Agreed

---snip---

Quoted 2 lines
Quoted 1 line

Register and bitfield definitions should be in a header file.

Not these file specific ones.
Ben - where else would they be applicable?

Quoted 2 lines

More generally, only register addresses and bitfields should
be defined.

Using macros to encapsulate both address and

Quoted 1 line

function is bad form, IMHO.

Agreed

Quoted 3 lines

I haven't even gotten into the functionality, because I think there's a lot of work to be done just in coding style

Ben - perhaps you could help by pointing out some more examples

Quoted 2 lines

before
we look at substance.

Regards

Peter

#4 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

Hi Peter,

Quoted 59 lines · Peter Pearse
Quoted 24 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: 26 March 2008 20:08
To: Guennadi Liakhovetski
Cc: u-boot-users at lists.sourceforge.net; Wolfgang Denk; Peter Pearse
Subject: Re: [U-Boot-Users] [PATCH v2 4/7] add SMSC LAN9x1x Network driver

Hi Guennadi,

Quoted 12 lines · Guennadi Liakhovetski

From: Sascha Hauer <[email protected]>

This patch adds a driver for the following smsc network controllers:
LAN9115
LAN9116
LAN9117
LAN9215
LAN9216
LAN9217

Quoted 4 lines

How many of these have been tested, and on what platforms. I'm asking because the code seems to assume a 32-bit interface and these aren't all 32-bit chips.

Comments please Sascha.

---snip---

Quoted 5 lines

drivers/net/smc911x.c

Quoted 5 lines
drivers/net/smc911x.c new file renamed from drivers/net/smc911x.c +0 -0

mode 100644 index 0000000..5830368

drivers/net/smc911x.c new file +0 -0

---snip---

Quoted 7 lines

drivers/net/smc911x.c line 28

Quoted 5 lines
drivers/net/smc911x.c new file +3 -0
+
+#ifdef CONFIG_DRIVER_SMC911X
+

This should be moved to the Makefile.

Agreed

---snip---

Quoted 2 lines
Quoted 2 lines
Quoted 7 lines
Quoted 2 lines

Register and bitfield definitions should be in a header file.

Not these file specific ones.
Ben - where else would they be applicable?

Well, I can't come up with a better answer than 'precedent', so I guess it's OK to keep the #defines in the C code.

Quoted 9 lines
Quoted 3 lines

More generally, only register addresses and bitfields should
be defined.

Using macros to encapsulate both address and

Quoted 2 lines

function is bad form, IMHO.

Quoted 10 lines

Agreed

Quoted 3 lines

I haven't even gotten into the functionality, because I think there's a lot of work to be done just in coding style

Ben - perhaps you could help by pointing out some more examples

By coding style I mean the nasty macros, not stuff like brackets and whitespace. If the code was more readable and addressed the bus width differences between chips, this would probably go in quickly. I'll have another look to see if I can be more helpful rather than curmudgeonly.

regards,
Ben

#5 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

Quoted 13 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: 27 March 2008 13:57
To: Peter Pearse
Cc: s.hauer at pengutronix.de; lg at denx.de; u-boot-users at lists.sourceforge.net
Subject: Re: [U-Boot-Users] [PATCH v2 4/7] add SMSC LAN9x1x Network driver

Hi Peter,

Quoted 9 lines
Quoted 6 lines · Peter Pearse
Quoted 6 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: 26 March 2008 20:08
To: Guennadi Liakhovetski
Cc: u-boot-users at lists.sourceforge.net; Wolfgang Denk; Peter Pearse
Subject: Re: [U-Boot-Users] [PATCH v2 4/7] add SMSC

LAN9x1x Network

Quoted 1 line
Quoted 1 line

driver

Thanks Ben

Hopefully we can make this window....

Regards

Peter

Quoted 4 lines

regards,
Ben

#6 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

In reply to Peter Pearse
Quoted 22 lines · Peter Pearse
Quoted 22 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: 26 March 2008 20:08
To: Guennadi Liakhovetski
Cc: u-boot-users at lists.sourceforge.net; Wolfgang Denk; Peter Pearse
Subject: Re: [U-Boot-Users] [PATCH v2 4/7] add SMSC LAN9x1x Network driver

Hi Guennadi,

Quoted 11 lines · Guennadi Liakhovetski

From: Sascha Hauer <[email protected]>

This patch adds a driver for the following smsc network controllers:
LAN9115
LAN9116
LAN9117
LAN9215
LAN9216
LAN9217

Quoted 5 lines
Quoted 3 lines

How many of these have been tested, and on what platforms. I'm asking because the code seems to assume a 32-bit interface and these aren't all 32-bit chips.

Comments please Sascha.

It's tested on the LAN9217 but I remember using it on one of the 16bit controllers as well, maybe with some register access adjustments. Maybe it's best to abstract the register accesses because I already had a board which had the address lines shifted (somehow SMSC seems to provoke this)

Sascha

Signature · 4 lines
Pengutronix e.K. - Linux Solutions for Science and Industry
-----------------------------------------------------------
Kontakt-Informationen finden Sie im Header dieser Mail oder
auf der Webseite -> http://www.pengutronix.de/impressum/ <-
#7 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

Thanks Sascha,

Quoted 33 lines · Sascha Hauer
Quoted 24 lines · Peter Pearse
Quoted 24 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: 26 March 2008 20:08
To: Guennadi Liakhovetski
Cc: u-boot-users at lists.sourceforge.net; Wolfgang Denk; Peter Pearse
Subject: Re: [U-Boot-Users] [PATCH v2 4/7] add SMSC LAN9x1x Network driver

Hi Guennadi,

Quoted 12 lines · Guennadi Liakhovetski

From: Sascha Hauer <[email protected]>

This patch adds a driver for the following smsc network controllers:
LAN9115
LAN9116
LAN9117
LAN9215
LAN9216
LAN9217

Quoted 6 lines
Quoted 4 lines

How many of these have been tested, and on what platforms. I'm asking because the code seems to assume a 32-bit interface and these aren't all 32-bit chips.

Comments please Sascha.

Quoted 9 lines

It's tested on the LAN9217 but I remember using it on one of the 16bit controllers as well, maybe with some register access adjustments. Maybe it's best to abstract the register accesses because I already had a board which had the address lines shifted (somehow SMSC seems to provoke this)

Sascha

I have no issue with bringing this in as a 32-bit only driver, leaving 16-bit implementation as a future exercise. We really should do this right, and the amount of code in the driver is small, so hopefully it can be fixed up for this merge window. If either you or Guennadi can do the following, I'll try my best to keep up:

1. Change all register definitions as following:

    #define RX_DATA_FIFO   __REG(CONFIG_DRIVER_SMC911X_BASE + 0x00)
       to
    #define RX_DATA_FIFO   CONFIG_DRIVER_SMC911X_BASE + 0x00

2. Implement read/write methods
#ifdef CONFIG_DRIVER_SMC911X_32_BIT
static inline u32 reg_read(u32 addr) ... static inline void reg_write(u32 addr, u32 val) ... #else
#error "SMC911X: Only 32-bit bus is supported" #endif

or use macros if you insist. I won't get religious on this, just
make it readable and debuggable.

thanks,
Ben

#8 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

Hi Everyone,

Would this driver work with the LAN9218 chip as well?

Nick

Quoted 77 lines · Ben Warren

Thanks Sascha,

Quoted 37 lines · Sascha Hauer
Quoted 26 lines · Peter Pearse
Quoted 26 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: 26 March 2008 20:08
To: Guennadi Liakhovetski
Cc: u-boot-users at lists.sourceforge.net; Wolfgang Denk; Peter Pearse
Subject: Re: [U-Boot-Users] [PATCH v2 4/7] add SMSC LAN9x1x Network driver

Hi Guennadi,

Quoted 13 lines · Guennadi Liakhovetski

From: Sascha Hauer <[email protected]>

This patch adds a driver for the following smsc network controllers:
LAN9115
LAN9116
LAN9117
LAN9215
LAN9216
LAN9217

Quoted 8 lines
Quoted 5 lines

How many of these have been tested, and on what platforms. I'm asking because the code seems to assume a 32-bit interface and these aren't all 32-bit chips.

Comments please Sascha.

Quoted 10 lines

It's tested on the LAN9217 but I remember using it on one of the 16bit controllers as well, maybe with some register access adjustments. Maybe it's best to abstract the register accesses because I already had a board which had the address lines shifted (somehow SMSC seems to provoke this)

Sascha

I have no issue with bringing this in as a 32-bit only driver, leaving 16-bit implementation as a future exercise. We really should do this right, and the amount of code in the driver is small, so hopefully it can be fixed up for this merge window. If either you or Guennadi can do the following, I'll try my best to keep up:

1. Change all register definitions as following:

    #define RX_DATA_FIFO   __REG(CONFIG_DRIVER_SMC911X_BASE + 0x00)
       to
    #define RX_DATA_FIFO   CONFIG_DRIVER_SMC911X_BASE + 0x00

2. Implement read/write methods
#ifdef CONFIG_DRIVER_SMC911X_32_BIT
static inline u32 reg_read(u32 addr) ... static inline void reg_write(u32 addr, u32 val) ... #else
#error "SMC911X: Only 32-bit bus is supported" #endif

or use macros if you insist. I won't get religious on this, just
make it readable and debuggable.

thanks,
Ben

Quoted 11 lines

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ndroogh.vcf
Type: text/x-vcard
Size: 220 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080327/41e2aa2f/attachment.vcf

#9 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

Quoted 3 lines · Nick Droogh

Hi Everyone,

Would this driver work with the LAN9218 chip as well?

The chips in this family differ in that some of them have an integrated phy and others not. Some have a 16bit bus interface and others have a 32bit bus interface.
So yes, the driver should work with the 9218.

Sascha

Quoted 98 lines

Nick

Quoted 70 lines · Ben Warren

Thanks Sascha,

Quoted 31 lines · Sascha Hauer
Quoted 23 lines · Peter Pearse
Quoted 23 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com] Sent: 26 March 2008 20:08
To: Guennadi Liakhovetski
Cc: u-boot-users at lists.sourceforge.net; Wolfgang Denk; Peter Pearse
Subject: Re: [U-Boot-Users] [PATCH v2 4/7] add SMSC LAN9x1x Network driver

Hi Guennadi,

Quoted 11 lines · Guennadi Liakhovetski

From: Sascha Hauer <[email protected]>

This patch adds a driver for the following smsc network controllers:
LAN9115
LAN9116
LAN9117
LAN9215
LAN9216
LAN9217

Quoted 6 lines
Quoted 4 lines

How many of these have been tested, and on what platforms. I'm asking because the code seems to assume a 32-bit interface and these aren't all 32-bit chips.

Comments please Sascha.

Quoted 9 lines

It's tested on the LAN9217 but I remember using it on one of the 16bit controllers as well, maybe with some register access adjustments. Maybe it's best to abstract the register accesses because I already had a board which had the address lines shifted (somehow SMSC seems to provoke this)

Sascha

I have no issue with bringing this in as a 32-bit only driver, leaving 16-bit implementation as a future exercise. We really should do this right, and the amount of code in the driver is small, so hopefully it can be fixed up for this merge window. If either you or Guennadi can do the following, I'll try my best to keep up:

1. Change all register definitions as following:

    #define RX_DATA_FIFO   __REG(CONFIG_DRIVER_SMC911X_BASE + 0x00)
       to
    #define RX_DATA_FIFO   CONFIG_DRIVER_SMC911X_BASE + 0x00

2. Implement read/write methods
#ifdef CONFIG_DRIVER_SMC911X_32_BIT
static inline u32 reg_read(u32 addr) ... static inline void reg_write(u32 addr, u32 val) ... #else
#error "SMC911X: Only 32-bit bus is supported" #endif

or use macros if you insist. I won't get religious on this, just
make it readable and debuggable.

thanks,
Ben

Quoted 11 lines

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

sh: vcard-filter: command not found

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Signature · 4 lines
Pengutronix e.K. - Linux Solutions for Science and Industry
-----------------------------------------------------------
Kontakt-Informationen finden Sie im Header dieser Mail oder
auf der Webseite -> http://www.pengutronix.de/impressum/ <-
#10 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 3 lines · Nick Droogh

Hi Everyone,

Would this driver work with the LAN9218 chip as well?

The chips in this family differ in that some of them have an integrated phy and others not. Some have a 16bit bus interface and others have a 32bit bus interface.
So yes, the driver should work with the 9218.

Ben, it seems discussion stopped here without a decision or so. What's the state of this driver, then?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If A equals success, then the formula is A = X + Y + Z. X is work.  Y
is play. Z is keep your mouth shut.                 - Albert Einstein
#11 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

Quoted 6 lines · Wolfgang Denk
Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 3 lines · Nick Droogh

Hi Everyone,

Would this driver work with the LAN9218 chip as well?

Quoted 8 lines
Quoted 4 lines

The chips in this family differ in that some of them have an integrated phy and others not. Some have a 16bit bus interface and others have a 32bit bus interface.
So yes, the driver should work with the 9218.

Ben, it seems discussion stopped here without a decision or so. What's the state of this driver, then?

I'm so sorry for non-responsiveness on this. I hate to make excuses but I'm in the midst of moving my family across the country and um, some things have slipped through the cracks.

I've pulled Guennadi's latest submission for this driver into my local copy, but haven't pushed it to the net repo yet. I have a few hours available tomorrow where I'll finish this up and also look more closely into JCPV's regression fix for the ne2000-related build failure.

regards,
Ben

#12 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

Quoted 19 lines · Ben Warren
Quoted 6 lines · Wolfgang Denk
Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 3 lines · Nick Droogh

Hi Everyone,

Would this driver work with the LAN9218 chip as well?

Quoted 7 lines
Quoted 4 lines

The chips in this family differ in that some of them have an integrated phy and others not. Some have a 16bit bus interface and others have a 32bit bus interface.
So yes, the driver should work with the 9218.

Ben, it seems discussion stopped here without a decision or so. What's the state of this driver, then?

I'm so sorry for non-responsiveness on this. I hate to make excuses but I'm in the midst of moving my family across the country and um, some things have slipped through the cracks.

Quoted 5 lines

I've pulled Guennadi's latest submission for this driver into my local copy, but haven't pushed it to the net repo yet. I have a few hours available tomorrow where I'll finish this up and also look more closely into JCPV's regression fix for the ne2000-related build failure.

i'm guessing the eeprom programmer i posted wont be part of this. should i just wait for everything to hit mainline and then post a patch to add it then ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080413/c677299a/attachment.pgp

#13 lore raw

PATCH v2 4/7 add SMSC LAN9x1x Network driver

Quoted 27 lines · Mike Frysinger
Quoted 19 lines · Ben Warren
Quoted 6 lines · Wolfgang Denk
Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 3 lines · Nick Droogh

Hi Everyone,

Would this driver work with the LAN9218 chip as well?

Quoted 7 lines
Quoted 4 lines

The chips in this family differ in that some of them have an integrated phy and others not. Some have a 16bit bus interface and others have a 32bit bus interface.
So yes, the driver should work with the 9218.

Ben, it seems discussion stopped here without a decision or so. What's the state of this driver, then?

I'm so sorry for non-responsiveness on this. I hate to make excuses but I'm in the midst of moving my family across the country and um, some things have slipped through the cracks.

Quoted 5 lines

I've pulled Guennadi's latest submission for this driver into my local copy, but haven't pushed it to the net repo yet. I have a few hours available tomorrow where I'll finish this up and also look more closely into JCPV's regression fix for the ne2000-related build failure.

Quoted 5 lines

i'm guessing the eeprom programmer i posted wont be part of this. should i just wait for everything to hit mainline and then post a patch to add it then ?
-mike

Right - this particular one has been given the OK as a bug fix for 1.3.3. The EEPROM programmer will make it into the next release.

regards,
Ben