Skip to contentSkip to conversation

ath5k: Fix a compilation error after reg list update

PATCH In review Nick Kossifidis 4 participants 6 messages Jul 20, 2008 – Jul 28, 2008 Networking drivers (wireless)

lore
Share & tools
lore

Nick Kossifidis

author
#0 lore raw

PATCH 12/12 ath5k: Fix a compilation error after reg list update

Last minute fix...

AR5K_CPCORN is changed to AR5K_CPCOVF in reg list update so we have to update debug.c in order to compile

Changes-licensed-under: ISC

Signed-off-by Nick Kossifidis <[email protected]>

---

drivers/net/wireless/ath5k/debug.c +1 -1
index 41d5fa3..6fa6c8e 100644
@@ -129,7 +129,7 @@ static struct reg regs[] = {
 	REG_STRUCT_INIT(AR5K_CPC1),
 	REG_STRUCT_INIT(AR5K_CPC2),
 	REG_STRUCT_INIT(AR5K_CPC3),
-	REG_STRUCT_INIT(AR5K_CPCORN),
+	REG_STRUCT_INIT(AR5K_CPCOVF),
 	REG_STRUCT_INIT(AR5K_RESET_CTL),
 	REG_STRUCT_INIT(AR5K_SLEEP_CTL),
 	REG_STRUCT_INIT(AR5K_INTPEND),
#1 lore raw
Quoted 13 lines · Nick Kossifidis

Last minute fix...

AR5K_CPCORN is changed to AR5K_CPCOVF in reg list update so we have to update debug.c in order to compile

Changes-licensed-under: ISC

Signed-off-by Nick Kossifidis <[email protected]>

---

drivers/net/wireless/ath5k/debug.c +0 -0
index 41d5fa3..6fa6c8e 100644

drivers/net/wireless/ath5k/debug.c static struct reg regs[] = { · line 135

Quoted 8 lines
drivers/net/wireless/ath5k/debug.c +1 -1
@@ -129,7 +129,7 @@ static struct reg regs[] = {
 	REG_STRUCT_INIT(AR5K_CPC1),
 	REG_STRUCT_INIT(AR5K_CPC2),
 	REG_STRUCT_INIT(AR5K_CPC3),
-	REG_STRUCT_INIT(AR5K_CPCORN),
+	REG_STRUCT_INIT(AR5K_CPCOVF),
 	REG_STRUCT_INIT(AR5K_RESET_CTL),
 	REG_STRUCT_INIT(AR5K_SLEEP_CTL),
 	REG_STRUCT_INIT(AR5K_INTPEND),

Please amend this to the patch 1 to not break bisectability.

#2 lore raw

2008/7/22 Jiri Slaby <[email protected]>:

Quoted 8 lines · Nick Kossifidis
Quoted 7 lines

Last minute fix...

AR5K_CPCORN is changed to AR5K_CPCOVF in reg list update so we have to update debug.c in order to compile

Changes-licensed-under: ISC

Signed-off-by Nick Kossifidis <[email protected]>
Quoted 16 lines
Quoted 6 lines

---

drivers/net/wireless/ath5k/debug.c +0 -0
index 41d5fa3..6fa6c8e 100644

drivers/net/wireless/ath5k/debug.c static struct reg regs[] = { · line 135

Quoted 8 lines
drivers/net/wireless/ath5k/debug.c +1 -1
@@ -129,7 +129,7 @@ static struct reg regs[] = {
      REG_STRUCT_INIT(AR5K_CPC1),
      REG_STRUCT_INIT(AR5K_CPC2),
      REG_STRUCT_INIT(AR5K_CPC3),
-     REG_STRUCT_INIT(AR5K_CPCORN),
+     REG_STRUCT_INIT(AR5K_CPCOVF),
      REG_STRUCT_INIT(AR5K_RESET_CTL),
      REG_STRUCT_INIT(AR5K_SLEEP_CTL),
      REG_STRUCT_INIT(AR5K_INTPEND),

Please amend this to the patch 1 to not break bisectability.

I see your point but this series is meant to be applied as a whole, i didn't notice this bug until i tested the code with debugging enabled (which is off by default), that's why it's "last minute fix". Is it really that much needed to repost the first patch ? I mean the patch series works and doesn't introduce any problems...

Signature · 3 lines
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
#3 lore raw
Quoted 7 lines · Nick Kossifidis
Quoted 1 line

Please amend this to the patch 1 to not break bisectability.

I see your point but this series is meant to be applied as a whole, i didn't notice this bug until i tested the code with debugging enabled (which is off by default), that's why it's "last minute fix". Is it really that much needed to repost the first patch ? I mean the patch series works and doesn't introduce any problems...

The reason is that git-bisect divides the number of commits in half and checks out the middle commit. That commit make be a broken one. Hitting one bug while hunting another is not nice.

Besides, nobody wants to apply a known bad patch.

It would be great if you repost fixed patches. If you are not using stgit, please try it. I would make it easy to return to older patches and change them. "stg edit -d" even allows editing the patch.

Signature · 2 lines
Regards,
Pavel Roskin
#4 lore raw

2008/7/28 Pavel Roskin <[email protected]>:

Quoted 16 lines · Nick Kossifidis
Quoted 8 lines
Quoted 2 lines

Please amend this to the patch 1 to not break bisectability.

I see your point but this series is meant to be applied as a whole, i didn't notice this bug until i tested the code with debugging enabled (which is off by default), that's why it's "last minute fix". Is it really that much needed to repost the first patch ? I mean the patch series works and doesn't introduce any problems...

The reason is that git-bisect divides the number of commits in half and checks out the middle commit. That commit make be a broken one. Hitting one bug while hunting another is not nice.

Besides, nobody wants to apply a known bad patch.

Quoted 8 lines

It would be great if you repost fixed patches. If you are not using stgit, please try it. I would make it easy to return to older patches and change them. "stg edit -d" even allows editing the patch.

--
Regards,
Pavel Roskin

O.K. then i'll repost the first patch asap (i'm still in Ottawa :P)...

Signature · 3 lines
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
#5 lore raw
In reply to Nick Kossifidis

Why the hell the mailer cropped Nick's address away...

Quoted 13 lines · Nick Kossifidis

Last minute fix...

AR5K_CPCORN is changed to AR5K_CPCOVF in reg list update so we have to update debug.c in order to compile

Changes-licensed-under: ISC

Signed-off-by Nick Kossifidis <[email protected]>

---

drivers/net/wireless/ath5k/debug.c +0 -0
index 41d5fa3..6fa6c8e 100644

drivers/net/wireless/ath5k/debug.c static struct reg regs[] = { · line 135

Quoted 8 lines
drivers/net/wireless/ath5k/debug.c +1 -1
@@ -129,7 +129,7 @@ static struct reg regs[] = {
 	REG_STRUCT_INIT(AR5K_CPC1),
 	REG_STRUCT_INIT(AR5K_CPC2),
 	REG_STRUCT_INIT(AR5K_CPC3),
-	REG_STRUCT_INIT(AR5K_CPCORN),
+	REG_STRUCT_INIT(AR5K_CPCOVF),
 	REG_STRUCT_INIT(AR5K_RESET_CTL),
 	REG_STRUCT_INIT(AR5K_SLEEP_CTL),
 	REG_STRUCT_INIT(AR5K_INTPEND),

Please amend this to the patch 1 to not break bisectability.