Skip to contentSkip to conversation

xtables-addons: Missing reference operator in xt_ECHO.c (for Jan Engelhardt)

PATCH In review Jiri Moravec 2 participants 2 messages Sep 19, 2008 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xtables-addons: Missing reference operator in xt_ECHO.c (for Jan Engelhardt)

Jan,
when you prepared commit ab27472eb44b0690f74d542ddb9a972460eceb9a, you probably overlooked some piece of code, because my gcc objects:
"2.6.26.5-t4/net/netfilter/xtables-addons/xt_ECHO.c:90: warning: passing argument 1 of ‘xtnu_ip_route_me_harder’ from incompatible pointer type"

extensions/xt_ECHO.c +1 -1
diff -Nupr old/extensions/xt_ECHO.c new/extensions/xt_ECHO.c
@@ -87,7 +87,7 @@ static unsigned int echo_tg4(struct sk_b
 	dst_hold(oldskb->dst);
 	newskb->dst = oldskb->dst;
 
-	if (ip_route_me_harder(newskb, addr_type) < 0)
+	if (ip_route_me_harder(&newskb, addr_type) < 0)
 		goto free_nskb;
 
 	newip->ttl        = dst_metric(newskb->dst, RTAX_HOPLIMIT);

--

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#1 lore raw
Quoted 3 lines · Jiri Moravec

Jan,
when you prepared commit ab27472eb44b0690f74d542ddb9a972460eceb9a, you probably overlooked some piece of code, because my gcc objects:
"2.6.26.5-t4/net/netfilter/xtables-addons/xt_ECHO.c:90: warning: passing argument 1 of ‘xtnu_ip_route_me_harder’ from incompatible pointer type"

There is more than just that one.
I fixed it up, thanks for reporting!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html